[
https://issues.apache.org/jira/browse/YARN-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145864#comment-17145864
]
Eric Payne edited comment on YARN-10251 at 6/26/20, 3:37 PM:
-
Thanks very much for the review, [~Jim_Brennan]. I attached patch 006 for
trunk. I'll work on getting the backport patches up later.
{quote}AppInfo
- (nit) move the initialization of usageReport before the if statement so you
can use it throughout that condition. Makes the diff a little bigger, but I
think it’s worth it in this case.{quote}
For the sake of sparing the reviewers, I don't generally like to make changes
that refactor the code if they are not directly related to the bug fix/feature.
But since you suggested it and are on board, I did so in this case.
{quote}NodesPage
- The new entries for GPUs Used and GPUs Avail are still using ".vcores” for
the set selector. Is this correct? Shouldn't we use ".gpus"?
{code:java}
.th(".vcores", "GPUs Used")
.th(".vcores", "GPUs Avail");
{code}
{quote}
OOPS! Good catch.
{quote}RmAppsBlock
- I'm not sure I understand this logic:{quote}
In the AppsBlock on the RM UI, the Allocated and Reserved columns contain a
number if the app is not completed and "N/A" if the app is completed.
When {{AppInfo}} retrieves the {{ApplicationResourceUsageReport}}, this
behavior is handle automatically because the memory and vcores field is -1 if
the app is completed and has a number otherwise. However, the extended
resources can be 0 if there are no resources of that type used, or it will be 0
if the app has completed, not -1. I felt that it is less risky to put the
additional check for completed app in RMAppsBlock rather than try to change the
behavior in the retrieval of {{ApplicationResourceUsageReport}}.
was (Author: eepayne):
Thanks very much for the review, [~Jim_Brennan]. I attached patch 006 for
trunk. I'll work on getting the backport patches up later.
{quote}AppInfo
- (nit) move the initialization of usageReport before the if statement so you
can use it throughout that condition. Makes the diff a little bigger, but I
think it’s worth it in this case.{quote}
For the sake of sparing the reviewers, I don't generally like to make changes
that refactor the code if they are not directly related to the bug fix/feature.
But since you suggested it and are on board, I did so in this case.
{quote}NodesPage
- The new entries for GPUs Used and GPUs Avail are still using ".vcores” for
the set selector. Is this correct? Shouldn't we use ".gpus"?
{code:java}
.th(".vcores", "GPUs Used")
.th(".vcores", "GPUs Avail");
{code}
{quote}
OOPS! Good catch.
{quote}RmAppsBlock
- I'm not sure I understand this logic:{quote}
In the AppsBlock on the RM UI, the Allocated and Reserved columns contain a
number if the app is not completed and "N/A" if the app is completed.
!Screen Shot 2020-06-25 at 3.40.06 PM.png!
When {{AppInfo}} retrieves the {{ApplicationResourceUsageReport}}, this
behavior is handle automatically because the memory and vcores field is -1 if
the app is completed and has a number otherwise. However, the extended
resources can be 0 if there are no resources of that type used, or it will be 0
if the app has completed, not -1. I felt that it is less risky to put the
additional check for completed app in RMAppsBlock rather than try to change the
behavior in the retrieval of {{ApplicationResourceUsageReport}}.
> Show extended resources on legacy RM UI.
>
>
> Key: YARN-10251
> URL: https://issues.apache.org/jira/browse/YARN-10251
> Project: Hadoop YARN
> Issue Type: Improvement
>Reporter: Eric Payne
>Assignee: Eric Payne
>Priority: Major
> Attachments: Legacy RM UI With Not All Resources Shown.png, Updated
> NodesPage UI With GPU columns.png, Updated RM UI With All Resources
> Shown.png.png, YARN-10251.003.patch, YARN-10251.004.patch,
> YARN-10251.005.patch, YARN-10251.006.patch, YARN-10251.branch-2.10.001.patch,
> YARN-10251.branch-2.10.002.patch, YARN-10251.branch-2.10.003.patch,
> YARN-10251.branch-2.10.005.patch, YARN-10251.branch-3.2.004.patch,
> YARN-10251.branch-3.2.005.patch
>
>
> It would be great to update the legacy RM UI to include GPU resources in the
> overview and in the per-app sections.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
