[jira] [Comment Edited] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
[ https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987149#comment-15987149 ] Junping Du edited comment on YARN-5007 at 4/27/17 5:53 PM: --- bq. If 3.0 is not a good time to remove deprecated method, when is a good time? Deprecated means this method is not recommended to use, and no promise of supporting well in following releases. That doesn't mean we have to remove/break these methods. For the safest time of removing, I would suggest to wait for another major release. Otherwise, case here will happen again and again. bq. -1 on reverting YARN-3573. Technically, in apache way, -1 doesn't work for any reverting work - no matter binding or non-binding. However, after thinking again, I would agree keeping YARN-3573 there is better. Thanks [~ajisakaa] for the revert work. Let's resolve this JIRA as won't fix or later. was (Author: djp): bq. If 3.0 is not a good time to remove deprecated method, when is a good time? Deprecated means this method is not recommended to use, and no promise of supporting well in following releases. That doesn't mean we have to remove/break these methods. For the safest time of removing, I would suggest to wait for another major release. Otherwise, case here will happen again and again. bq. -1 on reverting YARN-3573. Technically, in apache way, -1 doesn't work for any reverting work - no matter binding or non-binding. However, after thinking again, I would agree keeping YARN-3573 there is better. Thanks [~ajisakaa] for the revert work. Let's resolve this JIRA as won't fix or after. > Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster > --- > > Key: YARN-5007 > URL: https://issues.apache.org/jira/browse/YARN-5007 > Project: Hadoop YARN > Issue Type: Test >Reporter: Andras Bokor >Assignee: Andras Bokor > Labels: oct16-easy > Attachments: YARN-5007.01.patch, YARN-5007.02.patch, > YARN-5007.03.patch > > > MiniYarnCluster has a deprecated constructor which is called by the other > constructors and it causes javac warnings during the build. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
[ https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982066#comment-15982066 ] Zhiyuan Yang edited comment on YARN-5007 at 4/24/17 10:58 PM: -- This change breaks Tez and possibly many other downstream projects. In 2.7.0, the only way to enable ATS is through ctor parameters; now the only way is configuration. How do you expect downstream projects to support both 2.7.0 and 3.0.0? was (Author: aplusplus): This change breaks Tez and possibly many other downstream projects. In 2.7.0, the only way to enable ATS is through ctor parameters; now the only way is configuration. How do you expect downstream projects to support both support both 2.7.0 and 3.0.0? > Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster > --- > > Key: YARN-5007 > URL: https://issues.apache.org/jira/browse/YARN-5007 > Project: Hadoop YARN > Issue Type: Test >Reporter: Andras Bokor >Assignee: Andras Bokor > Labels: oct16-easy > Fix For: 3.0.0-alpha3 > > Attachments: YARN-5007.01.patch, YARN-5007.02.patch, > YARN-5007.03.patch > > > MiniYarnCluster has a deprecated constructor which is called by the other > constructors and it causes javac warnings during the build. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
[ https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982066#comment-15982066 ] Zhiyuan Yang edited comment on YARN-5007 at 4/24/17 10:58 PM: -- This change breaks Tez and possibly many other downstream projects. In 2.7.0, the only way to enable ATS is through ctor parameters; now the only way is configuration. How do you expect downstream projects to support both 2.7.0 and 3.0.0? Even a hadoop shim layer cannot fix the problem. was (Author: aplusplus): This change breaks Tez and possibly many other downstream projects. In 2.7.0, the only way to enable ATS is through ctor parameters; now the only way is configuration. How do you expect downstream projects to support both 2.7.0 and 3.0.0? > Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster > --- > > Key: YARN-5007 > URL: https://issues.apache.org/jira/browse/YARN-5007 > Project: Hadoop YARN > Issue Type: Test >Reporter: Andras Bokor >Assignee: Andras Bokor > Labels: oct16-easy > Fix For: 3.0.0-alpha3 > > Attachments: YARN-5007.01.patch, YARN-5007.02.patch, > YARN-5007.03.patch > > > MiniYarnCluster has a deprecated constructor which is called by the other > constructors and it causes javac warnings during the build. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
[ https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587900#comment-15587900 ] Akira Ajisaka edited comment on YARN-5007 at 10/19/16 7:17 AM: --- +1 for this patch but not committing for now. YARN-3573 deprecated the constructors but the fix version (2.8.0) is not released. We need to wait for 2.8.0 release before committing this to trunk. This is the same as the reason why HADOOP-13705 reverted HADOOP-13534. was (Author: ajisakaa): +1 for this patch but not committing for now. YARN-3573 deprecated the constructors but the fix version (2.8.0) is not released. We need to wait for 2.8.0 release before committing this. This is the same as the reason why HADOOP-13705 reverted HADOOP-13534. > Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster > --- > > Key: YARN-5007 > URL: https://issues.apache.org/jira/browse/YARN-5007 > Project: Hadoop YARN > Issue Type: Test >Reporter: Andras Bokor >Assignee: Andras Bokor > Attachments: YARN-5007.01.patch, YARN-5007.02.patch > > > MiniYarnCluster has a deprecated constructor which is called by the other > constructors and it causes javac warnings during the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
