[jira] [Comment Edited] (YARN-5411) Create a proxy chain for ApplicationClientProtocol in the Router
[ https://issues.apache.org/jira/browse/YARN-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995511#comment-15995511 ] Giovanni Matteo Fumarola edited comment on YARN-5411 at 5/3/17 7:44 PM: Thanks [~botong], I added log4j and removed TestRouter. The Findbugs and javac errors are not related to the patch. was (Author: giovanni.fumarola): Thanks [~botong], I added log4j and remove TestRouter. The Findbugs and javac errors are not related to the patch. > Create a proxy chain for ApplicationClientProtocol in the Router > > > Key: YARN-5411 > URL: https://issues.apache.org/jira/browse/YARN-5411 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager, resourcemanager >Reporter: Subru Krishnan >Assignee: Giovanni Matteo Fumarola > Attachments: YARN-5411-YARN-2915.v1.patch, > YARN-5411-YARN-2915.v2.patch, YARN-5411-YARN-2915.v3.patch, > YARN-5411-YARN-2915.v4.patch, YARN-5411-YARN-2915.v5.patch, > YARN-5411-YARN-2915.v6.patch > > > As detailed in the proposal in the umbrella JIRA, we are introducing a new > component that routes client request to appropriate ResourceManager(s). This > JIRA tracks the creation of a proxy for ApplicationClientProtocol in the > Router. This provides a placeholder for: > 1) throttling mis-behaving clients (YARN-1546) > 3) mask the access to multiple RMs (YARN-3659) > We are planning to follow the interceptor pattern like we did in YARN-2884 to > generalize the approach and have only dynamically coupling for Federation. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-5411) Create a proxy chain for ApplicationClientProtocol in the Router
[
https://issues.apache.org/jira/browse/YARN-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995281#comment-15995281
]
Subru Krishnan edited comment on YARN-5411 at 5/3/17 6:13 PM:
--
Thanks [~giovanni.fumarola] for addressing my comments. I have manually kicked
Yetus as it didn't pick up the latest patch.
Regarding the version in pom.xml, you should add the test-jar in the hadoop
main pom
[here|https://github.com/apache/hadoop/blob/trunk/hadoop-project/pom.xml] and
then the version gets automatically inherited.
You seemed to have missed this suggestion:
bq. MockClientRequestInterceptor should extend DefaultClientRequestInterceptor
and only override init.
A clarification regarding {{MockResourceManagerFacade}} - why do we need it as
there's {{MockRM}} already which is widely used in tests. IF we do need it,
call out in the class Javadocs that it's used by {{AMRMProxy/Router}} tests.
was (Author: subru):
Thanks [~giovanni.fumarola] for addressing my comments. I have manually kicked
Yetus as it didn't pick up the latest patch.
Regarding the version in pom.xml, you should add the test-jar in the hadoop
main pom
[here|https://github.com/apache/hadoop/blob/trunk/hadoop-project/pom.xml] and
then the version gets automatically inherited.
You seemed to have missed this suggestion:
bq. MockClientRequestInterceptor should extend DefaultClientRequestInterceptor
and only override init.
> Create a proxy chain for ApplicationClientProtocol in the Router
>
>
> Key: YARN-5411
> URL: https://issues.apache.org/jira/browse/YARN-5411
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
>Reporter: Subru Krishnan
>Assignee: Giovanni Matteo Fumarola
> Attachments: YARN-5411-YARN-2915.v1.patch,
> YARN-5411-YARN-2915.v2.patch, YARN-5411-YARN-2915.v3.patch,
> YARN-5411-YARN-2915.v4.patch
>
>
> As detailed in the proposal in the umbrella JIRA, we are introducing a new
> component that routes client request to appropriate ResourceManager(s). This
> JIRA tracks the creation of a proxy for ApplicationClientProtocol in the
> Router. This provides a placeholder for:
> 1) throttling mis-behaving clients (YARN-1546)
> 3) mask the access to multiple RMs (YARN-3659)
> We are planning to follow the interceptor pattern like we did in YARN-2884 to
> generalize the approach and have only dynamically coupling for Federation.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-5411) Create a proxy chain for ApplicationClientProtocol in the Router
[ https://issues.apache.org/jira/browse/YARN-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15991308#comment-15991308 ] Giovanni Matteo Fumarola edited comment on YARN-5411 at 5/1/17 6:59 PM: Thanks [~subru] for the feedbacks. * Done. * I opened YARN-6539, I will update in the next patch. * Done. * Done. * Done. * Done. * The 2 chains have different objects. Refactoring and Reusing will add additional complexity to the code and it may reduce the stability. I tested this code for long time. * Done. * There is no a double translation. * Done. * I opened YARN-6537 to track this. * Moved to a yarn-server-common. I add in the pom.xml in nodemanager and router the test-dependency on it. Right now it has the version dependency, I did not find a way to avoid it. * Done. * I added comments to avoid confusions. * test1, test2 are the names of UGIs. was (Author: giovanni.fumarola): Thanks [~subru] for the feedbacks. * Done. * I opened YARN-6539, I will update in the next patch. * Done. * Done. * Done. * Done. * The 2 chains have different objects. Refactoring and Reusing will add additional complexity to the code and it may reduce the stability. I tested this code for long time. * Done. * There is no a double translating. * Done. * I opened YARN-6537 to track this. * Moved to a yarn-server-common. I add in the pom.xml in nodemanager and router the test-dependency on it. Right now it has the version dependency, I did not find a way to avoid it. * Done. * I added comments to avoid confusions. * test1, test2 are the names of UGIs. > Create a proxy chain for ApplicationClientProtocol in the Router > > > Key: YARN-5411 > URL: https://issues.apache.org/jira/browse/YARN-5411 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager, resourcemanager >Reporter: Subru Krishnan >Assignee: Giovanni Matteo Fumarola > Attachments: YARN-5411-YARN-2915.v1.patch, > YARN-5411-YARN-2915.v2.patch > > > As detailed in the proposal in the umbrella JIRA, we are introducing a new > component that routes client request to appropriate ResourceManager(s). This > JIRA tracks the creation of a proxy for ApplicationClientProtocol in the > Router. This provides a placeholder for: > 1) throttling mis-behaving clients (YARN-1546) > 3) mask the access to multiple RMs (YARN-3659) > We are planning to follow the interceptor pattern like we did in YARN-2884 to > generalize the approach and have only dynamically coupling for Federation. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-5411) Create a proxy chain for ApplicationClientProtocol in the Router
[ https://issues.apache.org/jira/browse/YARN-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764796#comment-15764796 ] luhuichun edited comment on YARN-5411 at 12/21/16 10:14 AM: [~giovanni.fumarola] Hi Giovanni, I'd like to contribute and work on this, if you haven't started working on it yet. Thank you. was (Author: luhuichun): [~giovanni.fumarola] hi, Giovanni we recently focus on yarn federation, can we take some patch to work on, we are really interested in this feature. > Create a proxy chain for ApplicationClientProtocol in the Router > > > Key: YARN-5411 > URL: https://issues.apache.org/jira/browse/YARN-5411 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager, resourcemanager >Reporter: Subru Krishnan >Assignee: Giovanni Matteo Fumarola > > As detailed in the proposal in the umbrella JIRA, we are introducing a new > component that routes client request to appropriate ResourceManager(s). This > JIRA tracks the creation of a proxy for ApplicationClientProtocol in the > Router. This provides a placeholder for: > 1) throttling mis-behaving clients (YARN-1546) > 3) mask the access to multiple RMs (YARN-3659) > We are planning to follow the interceptor pattern like we did in YARN-2884 to > generalize the approach and have only dynamically coupling for Federation. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
