[jira] [Comment Edited] (YARN-5899) A small fix for printing debug info inside function canAssignToThisQueue()
[ https://issues.apache.org/jira/browse/YARN-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797093#comment-15797093 ] Ying Zhang edited comment on YARN-5899 at 1/4/17 4:04 AM: -- This patch only introduces some modification to debug information. No test case is needed. I've enabled DEBUG mode and test it manually. Failed test case TestRMRestart.testFinishedAppRemovalAfterRMRestart is known and tracked by YARN-5548. was (Author: ying zhang): Failed test case TestRMRestart.testFinishedAppRemovalAfterRMRestart is known and tracked by YARN-5548. > A small fix for printing debug info inside function canAssignToThisQueue() > -- > > Key: YARN-5899 > URL: https://issues.apache.org/jira/browse/YARN-5899 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler >Affects Versions: 3.0.0-alpha1 >Reporter: Ying Zhang >Assignee: Ying Zhang >Priority: Trivial > Attachments: YARN-5899.001.patch, YARN-5899.002.patch > > > A small fix inside function canAssignToThisQueue() for printing DEBUG info. > Please see patch attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-5899) A small fix for printing debug info inside function canAssignToThisQueue()
[ https://issues.apache.org/jira/browse/YARN-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796889#comment-15796889 ] Ying Zhang edited comment on YARN-5899 at 1/4/17 2:07 AM: -- Not sure why there wasn't Jenkins result. Delete and re-attach YARN-5899.002.patch to try to start Jenkins again. was (Author: ying zhang): Not sure why there wasn't Jenkins results. Delete and re-attach YARN-5899.002.patch to try to start Jenkins again. > A small fix for printing debug info inside function canAssignToThisQueue() > -- > > Key: YARN-5899 > URL: https://issues.apache.org/jira/browse/YARN-5899 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler >Affects Versions: 3.0.0-alpha1 >Reporter: Ying Zhang >Assignee: Ying Zhang >Priority: Trivial > Attachments: YARN-5899.001.patch, YARN-5899.002.patch > > > A small fix inside function canAssignToThisQueue() for printing DEBUG info. > Please see patch attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-5899) A small fix for printing debug info inside function canAssignToThisQueue()
[ https://issues.apache.org/jira/browse/YARN-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794349#comment-15794349 ] Ying Zhang edited comment on YARN-5899 at 1/3/17 7:13 AM: -- Hi [~sunilg], thanks for the review. Agree. I've updated the patch, please take a look. Besides those you've listed here, I'm thinking "resourceCouldBeUnreserved" would also be useful. was (Author: ying zhang): Hi [~sunilg], thanks for the review. Agree. I've updated the patch. Please take a look. > A small fix for printing debug info inside function canAssignToThisQueue() > -- > > Key: YARN-5899 > URL: https://issues.apache.org/jira/browse/YARN-5899 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler >Affects Versions: 3.0.0-alpha1 >Reporter: Ying Zhang >Assignee: Ying Zhang >Priority: Trivial > Attachments: YARN-5899.001.patch, YARN-5899.002.patch > > > A small fix inside function canAssignToThisQueue() for printing DEBUG info. > Please see patch attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-5899) A small fix for printing debug info inside function canAssignToThisQueue()
[
https://issues.apache.org/jira/browse/YARN-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15792372#comment-15792372
]
Sunil G edited comment on YARN-5899 at 1/2/17 7:11 AM:
---
Hi [~Ying Zhang]
Your observation is correct. We are using that debug log to get some more
information when assign to queue is passed. So your patch is correct. I think
we can also add one more debug info in case when we return false case also
(wherever we have current debug log). We could print
{noformat}
LOG.debug("Failed to assignToQueue: " + getQueueName() + " usedResources: " +
queueUsage.getUsed() + ", clusterResources: " + clusterResource + ",
maxLimitCapacity: " + currentLimitResource + ", currTotalUsed:" +
usedExceptKillable);
{noformat}
Thoughts?
was (Author: sunilg):
Hi [~Ying Zhang]
Your observation is correct. We are using that debug log to get some more
information when assign to queue is passed. So your patch is correct. I think
we can also add one more debug info in case when we return false case also
(wherever we have current debug log). We could print
{noformat}
LOG.debug("try to use reserved: " + getQueueName() + " usedResources: " +
queueUsage.getUsed() + ", clusterResources: " + clusterResource + ",
maxLimitCapacity: " + currentLimitResource + ", currTotalUsed:" +
usedExceptKillable);
{noformat}
Thoughts?
> A small fix for printing debug info inside function canAssignToThisQueue()
> --
>
> Key: YARN-5899
> URL: https://issues.apache.org/jira/browse/YARN-5899
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler
>Affects Versions: 3.0.0-alpha1
>Reporter: Ying Zhang
>Assignee: Ying Zhang
>Priority: Trivial
> Attachments: YARN-5899.001.patch
>
>
> A small fix inside function canAssignToThisQueue() for printing DEBUG info.
> Please see patch attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
