[jira] [Comment Edited] (YARN-6634) [API] Define an API for ResourceManager WebServices

2017-05-31 Thread Subru Krishnan (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-6634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032053#comment-16032053
 ] 

Subru Krishnan edited comment on YARN-6634 at 5/31/17 9:55 PM:
---

[~giovanni.fumarola], I know it's a nit but you can try abbreviating 
{{RMWebServiceProtocolConstants}} and a suppress for the arg numbers for 
_getApps_ as that should address the checkstyle warnings. The Javadoc fix looks 
trivial.


was (Author: subru):
[~giovanni.fumarola], I know it's a nit but you can try abbreviating 
{{RMWebServiceProtocolConstants}} and a suppress for the arg numbers for 
_getApps_ as that should address the line length warnings.

> [API] Define an API for ResourceManager WebServices
> ---
>
> Key: YARN-6634
> URL: https://issues.apache.org/jira/browse/YARN-6634
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: resourcemanager
>Affects Versions: 2.8.0
>Reporter: Subru Krishnan
>Assignee: Giovanni Matteo Fumarola
>Priority: Critical
> Attachments: YARN-6634.proto.patch, YARN-6634.v1.patch, 
> YARN-6634.v2.patch, YARN-6634.v3.patch, YARN-6634.v4.patch
>
>
> The RM exposes few REST queries but there's no clear API interface defined. 
> This makes it painful to build either clients or extension components like 
> Router (YARN-5412) that expose REST interfaces themselves. This jira proposes 
> adding a RM WebServices protocol similar to the one we have for RPC, i.e. 
> {{ApplicationClientProtocol}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Comment Edited] (YARN-6634) [API] Define an API for ResourceManager WebServices

2017-05-23 Thread Giovanni Matteo Fumarola (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-6634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021851#comment-16021851
 ] 

Giovanni Matteo Fumarola edited comment on YARN-6634 at 5/23/17 9:00 PM:
-

Thanks [~subru] for creating this JIRA. I attached a prototype of the possible 
solution. I have to add some missing javadocs in the protocol class and check 
all the jUnits to decrease the amount of hard code strings. By using 
hadoop-format.xml the RMWebServices.java changed a bit.


was (Author: giovanni.fumarola):
Thanks [~subru] for creating this JIRA. I attached a prototype of the possible 
solution. I have to add some missing javadocs in the protocol class and check 
all the jUnits to decrease the amount of hard code strings.  

> [API] Define an API for ResourceManager WebServices
> ---
>
> Key: YARN-6634
> URL: https://issues.apache.org/jira/browse/YARN-6634
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: resourcemanager
>Affects Versions: 2.8.0
>Reporter: Subru Krishnan
>Assignee: Giovanni Matteo Fumarola
>Priority: Critical
> Attachments: YARN-6634.proto.patch
>
>
> The RM exposes few REST queries but there's no clear API interface defined. 
> This makes it painful to build either clients or extension components like 
> Router (YARN-5412) that expose REST interfaces themselves. This jira proposes 
> adding a RM WebServices protocol similar to the one we have for RPC, i.e. 
> {{ApplicationClientProtocol}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org