[jira] [Commented] (YARN-10490) "yarn top" command not quitting completely with ctrl+c

2021-01-21 Thread Szilard Nemeth (Jira) 


[ 
https://issues.apache.org/jira/browse/YARN-10490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269568#comment-17269568
 ] 

Szilard Nemeth commented on YARN-10490:
---

Thanks [~akshink] for working on this.

Latest patch LGTM, committed to trunk.

Thanks [~gandras] for the review.

> "yarn top" command not quitting completely with ctrl+c
> --
>
> Key: YARN-10490
> URL: https://issues.apache.org/jira/browse/YARN-10490
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: yarn
>Reporter: Agshin Kazimli
>Assignee: Agshin Kazimli
>Priority: Minor
> Fix For: 3.4.0
>
> Attachments: YARN-10490-001.patch, YARN-10490-001.patch, 
> YARN-10490-002.patch, YARN-10490-003.patch
>
>
> When we quit "yarn top" command using ctrl+c, even though the command prompt 
> returns, the old statistics info is still visible below the prompt.
> And we need to manually type clear command or multiple return keys to get 
> around it. It is reported as a inconvenience for the customer from a 
> usability perspective.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-10490) "yarn top" command not quitting completely with ctrl+c

2021-01-19 Thread Hadoop QA (Jira) 


[ 
https://issues.apache.org/jira/browse/YARN-10490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267867#comment-17267867
 ] 

Hadoop QA commented on YARN-10490:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime ||  Logfile || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 
27s{color} | {color:blue}{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} || ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green}{color} | {color:green} No case conflicting files 
found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green}{color} | {color:green} The patch does not contain any 
@author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red}{color} | {color:red} The patch doesn't appear to 
include any new or modified tests. Please justify why no new tests are needed 
for this patch. Also please list what manual steps were performed to verify 
this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} || ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 24m 
 9s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
32s{color} | {color:green}{color} | {color:green} trunk passed with JDK 
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
29s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private 
Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
22s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
30s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
17m 33s{color} | {color:green}{color} | {color:green} branch has no errors when 
building and testing our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
24s{color} | {color:green}{color} | {color:green} trunk passed with JDK 
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
23s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private 
Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  0m 
49s{color} | {color:blue}{color} | {color:blue} Used deprecated FindBugs 
config; considering switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
48s{color} | {color:green}{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} || ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
28s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
29s{color} | {color:green}{color} | {color:green} the patch passed with JDK 
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
29s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
24s{color} | {color:green}{color} | {color:green} the patch passed with JDK 
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
24s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
19s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
26s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green}{color} | {color:green} The patch has no whitespace 
issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
16m 28s{color} | {color:green}{color} | {color:green} patch has no errors when 
building and testing our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
22s{color} | {color:green}{color} | {color:green} the patch passed with JDK 
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 {color} |
|

[jira] [Commented] (YARN-10490) "yarn top" command not quitting completely with ctrl+c

2021-01-19 Thread Agshin Kazimli (Jira) 


[ 
https://issues.apache.org/jira/browse/YARN-10490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267835#comment-17267835
 ] 

Agshin Kazimli commented on YARN-10490:
---

[~snemeth] Thanks for the idea. I've uploaded a new patch.

> "yarn top" command not quitting completely with ctrl+c
> --
>
> Key: YARN-10490
> URL: https://issues.apache.org/jira/browse/YARN-10490
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: yarn
>Reporter: Agshin Kazimli
>Assignee: Agshin Kazimli
>Priority: Minor
> Attachments: YARN-10490-001.patch, YARN-10490-001.patch, 
> YARN-10490-002.patch, YARN-10490-003.patch
>
>
> When we quit "yarn top" command using ctrl+c, even though the command prompt 
> returns, the old statistics info is still visible below the prompt.
> And we need to manually type clear command or multiple return keys to get 
> around it. It is reported as a inconvenience for the customer from a 
> usability perspective.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-10490) "yarn top" command not quitting completely with ctrl+c

2021-01-15 Thread Szilard Nemeth (Jira) 


[ 
https://issues.apache.org/jira/browse/YARN-10490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266356#comment-17266356
 ] 

Szilard Nemeth commented on YARN-10490:
---

Hi [~akshink],
Thanks for working on this.

I'm a bit confused.
Looking at the source code of TopCLI, there's a method named "clearScreen": 
https://github.com/apache/hadoop/blob/630f8ddd2c72c27b02032ed3cf9dde15745ed605/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/TopCLI.java#L473

It's implementation prints the CLEAR string from this class to the System.out 
stream.
You introduced a string called CLEAR_SCREEN.
So the namings are quite confusing.
Did you test to call the clearScreen method from the shutdown hook?
If not, please test it and you don't need the new constant.

Thanks.

> "yarn top" command not quitting completely with ctrl+c
> --
>
> Key: YARN-10490
> URL: https://issues.apache.org/jira/browse/YARN-10490
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: yarn
>Reporter: Agshin Kazimli
>Assignee: Agshin Kazimli
>Priority: Minor
> Attachments: YARN-10490-001.patch, YARN-10490-001.patch, 
> YARN-10490-002.patch
>
>
> When we quit "yarn top" command using ctrl+c, even though the command prompt 
> returns, the old statistics info is still visible below the prompt.
> And we need to manually type clear command or multiple return keys to get 
> around it. It is reported as a inconvenience for the customer from a 
> usability perspective.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-10490) "yarn top" command not quitting completely with ctrl+c

2021-01-15 Thread Andras Gyori (Jira) 


[ 
https://issues.apache.org/jira/browse/YARN-10490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265890#comment-17265890
 ] 

Andras Gyori commented on YARN-10490:
-

Thank you [~akshink], the patch looks good to me +1.

> "yarn top" command not quitting completely with ctrl+c
> --
>
> Key: YARN-10490
> URL: https://issues.apache.org/jira/browse/YARN-10490
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: yarn
>Reporter: Agshin Kazimli
>Assignee: Agshin Kazimli
>Priority: Minor
> Attachments: YARN-10490-001.patch, YARN-10490-001.patch, 
> YARN-10490-002.patch
>
>
> When we quit "yarn top" command using ctrl+c, even though the command prompt 
> returns, the old statistics info is still visible below the prompt.
> And we need to manually type clear command or multiple return keys to get 
> around it. It is reported as a inconvenience for the customer from a 
> usability perspective.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org