[jira] [Commented] (YARN-10978) yarn.nodemanager.aux-services.%s.classpath configuration fails to reflect on Windows Path

2022-12-06 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/YARN-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643800#comment-17643800
 ] 

ASF GitHub Bot commented on YARN-10978:
---

GauthamBanasandra merged PR #3558:
URL: https://github.com/apache/hadoop/pull/3558




> yarn.nodemanager.aux-services.%s.classpath configuration fails to reflect on 
> Windows Path
> -
>
> Key: YARN-10978
> URL: https://issues.apache.org/jira/browse/YARN-10978
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Akshat Bordia
>Assignee: Akshat Bordia
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Steps to Reproduce:
> 1. Add auxillary service configuration such as spark_shuffle.
> 2. Add following configuration to provide custom classpath for the auxillary 
> service:
> yarn.nodemanager.aux-services.spark_shuffle.classpath=D:\Spark\yarn\*
> 3. Start NM
> Expected Behavior:
> 1. NM should start along with the auxillary service.
> Actual Behavior:
> 1. NM keeps crashing due to auxillary service not being able to start as it 
> is not able to find required classes.
> java.lang.ClassNotFoundException: 
> org.apache.spark.network.yarn.YarnShuffleService
> Potential Fix:
> Using File.separator instead of "\" to make glob expansion OS agnostic.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-10978) yarn.nodemanager.aux-services.%s.classpath configuration fails to reflect on Windows Path

2022-12-06 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/YARN-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643799#comment-17643799
 ] 

ASF GitHub Bot commented on YARN-10978:
---

GauthamBanasandra commented on PR #3558:
URL: https://github.com/apache/hadoop/pull/3558#issuecomment-1339156347

   LGTM as well.




> yarn.nodemanager.aux-services.%s.classpath configuration fails to reflect on 
> Windows Path
> -
>
> Key: YARN-10978
> URL: https://issues.apache.org/jira/browse/YARN-10978
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Akshat Bordia
>Assignee: Akshat Bordia
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Steps to Reproduce:
> 1. Add auxillary service configuration such as spark_shuffle.
> 2. Add following configuration to provide custom classpath for the auxillary 
> service:
> yarn.nodemanager.aux-services.spark_shuffle.classpath=D:\Spark\yarn\*
> 3. Start NM
> Expected Behavior:
> 1. NM should start along with the auxillary service.
> Actual Behavior:
> 1. NM keeps crashing due to auxillary service not being able to start as it 
> is not able to find required classes.
> java.lang.ClassNotFoundException: 
> org.apache.spark.network.yarn.YarnShuffleService
> Potential Fix:
> Using File.separator instead of "\" to make glob expansion OS agnostic.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-10978) yarn.nodemanager.aux-services.%s.classpath configuration fails to reflect on Windows Path

2022-12-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/YARN-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643377#comment-17643377
 ] 

ASF GitHub Bot commented on YARN-10978:
---

goiri commented on PR #3558:
URL: https://github.com/apache/hadoop/pull/3558#issuecomment-1337501374

   @GauthamBanasandra this is in the direction of your current effort.
   It looks good to me though.




> yarn.nodemanager.aux-services.%s.classpath configuration fails to reflect on 
> Windows Path
> -
>
> Key: YARN-10978
> URL: https://issues.apache.org/jira/browse/YARN-10978
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Akshat Bordia
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Steps to Reproduce:
> 1. Add auxillary service configuration such as spark_shuffle.
> 2. Add following configuration to provide custom classpath for the auxillary 
> service:
> yarn.nodemanager.aux-services.spark_shuffle.classpath=D:\Spark\yarn\*
> 3. Start NM
> Expected Behavior:
> 1. NM should start along with the auxillary service.
> Actual Behavior:
> 1. NM keeps crashing due to auxillary service not being able to start as it 
> is not able to find required classes.
> java.lang.ClassNotFoundException: 
> org.apache.spark.network.yarn.YarnShuffleService
> Potential Fix:
> Using File.separator instead of "\" to make glob expansion OS agnostic.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-10978) yarn.nodemanager.aux-services.%s.classpath configuration fails to reflect on Windows Path

2022-12-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/YARN-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643334#comment-17643334
 ] 

ASF GitHub Bot commented on YARN-10978:
---

hadoop-yetus commented on PR #3558:
URL: https://github.com/apache/hadoop/pull/3558#issuecomment-1337295644

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 54s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  39m  4s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  23m 18s |  |  trunk passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |  20m 58s |  |  trunk passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  checkstyle  |   1m 28s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  3s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   1m 37s |  |  trunk passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   1m  5s |  |  trunk passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  spotbugs  |   2m 53s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  23m 22s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   1m  1s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  22m 38s |  |  the patch passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |  22m 38s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  20m 53s |  |  the patch passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  javac  |  20m 53s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   1m 27s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   1m 54s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   1m 16s |  |  the patch passed with JDK 
Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   1m 15s |  |  the patch passed with JDK 
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  spotbugs  |   2m 59s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  23m 14s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |  18m 57s |  |  hadoop-common in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   1m 13s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 215m  4s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3558/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/3558 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux a79130b3a38b 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 
01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 11fbd9d454e8a11f94cc9b6cb8ebdda3776ef4e9 |
   | Default Java | Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3558/2/testReport/ |
   | Max. process+thread count | 1263 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-common U: 
hadoop-common-project/hadoop-common |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3558/2/console |
   | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.14.0