[jira] [Commented] (YARN-11006) Allow overriding user limit factor and maxAMResourcePercent with AQCv2 templates

2021-12-08 Thread Benjamin Teke (Jira)


[ 
https://issues.apache.org/jira/browse/YARN-11006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17455914#comment-17455914
 ] 

Benjamin Teke commented on YARN-11006:
--

Thanks [~snemeth]. No need to backport it, this only impacts AQCv2, which will 
be part of 3.4.

> Allow overriding user limit factor and maxAMResourcePercent with AQCv2 
> templates
> 
>
> Key: YARN-11006
> URL: https://issues.apache.org/jira/browse/YARN-11006
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Benjamin Teke
>Assignee: Benjamin Teke
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.4.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> [YARN-10801|https://issues.apache.org/jira/browse/YARN-10801] fixed the 
> template configurations for every queue property, but it introduced a strange 
> behaviour as well. When setting the template configurations 
> LeafQueue.setDynamicQueueProperties is called:
> {code:java}
>   @Override
>   protected void setDynamicQueueProperties(
>   CapacitySchedulerConfiguration configuration) {
> super.setDynamicQueueProperties(configuration);
> // set to -1, to disable it
> configuration.setUserLimitFactor(getQueuePath(), -1);
> // Set Max AM percentage to a higher value
> configuration.setMaximumApplicationMasterResourcePerQueuePercent(
> getQueuePath(), 1f);
>   }
> {code}
> This sets the configured template properties in the configuration object and 
> then it overwrites the user limit factor and the maximum AM resource percent 
> values with the hardcoded ones. The order should be reversed.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-11006) Allow overriding user limit factor and maxAMResourcePercent with AQCv2 templates

2021-12-07 Thread Szilard Nemeth (Jira)


[ 
https://issues.apache.org/jira/browse/YARN-11006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17454688#comment-17454688
 ] 

Szilard Nemeth commented on YARN-11006:
---

Hi [~bteke],
Just committed your patch to trunk.
Could you please check whether it's required to backport this to branch-3.3 / 
branch-3.2?
Thanks.

> Allow overriding user limit factor and maxAMResourcePercent with AQCv2 
> templates
> 
>
> Key: YARN-11006
> URL: https://issues.apache.org/jira/browse/YARN-11006
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Benjamin Teke
>Assignee: Benjamin Teke
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.4.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> [YARN-10801|https://issues.apache.org/jira/browse/YARN-10801] fixed the 
> template configurations for every queue property, but it introduced a strange 
> behaviour as well. When setting the template configurations 
> LeafQueue.setDynamicQueueProperties is called:
> {code:java}
>   @Override
>   protected void setDynamicQueueProperties(
>   CapacitySchedulerConfiguration configuration) {
> super.setDynamicQueueProperties(configuration);
> // set to -1, to disable it
> configuration.setUserLimitFactor(getQueuePath(), -1);
> // Set Max AM percentage to a higher value
> configuration.setMaximumApplicationMasterResourcePerQueuePercent(
> getQueuePath(), 1f);
>   }
> {code}
> This sets the configured template properties in the configuration object and 
> then it overwrites the user limit factor and the maximum AM resource percent 
> values with the hardcoded ones. The order should be reversed.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org