[jira] [Commented] (YARN-1299) Improve 'checking for deactivate...' log message by adding app id
[ https://issues.apache.org/jira/browse/YARN-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322973#comment-14322973 ] Tsuyoshi OZAWA commented on YARN-1299: -- Findbugs is not related to the patch. We don't need tests since this is an improvement for log message. Committing this shortly. > Improve 'checking for deactivate...' log message by adding app id > - > > Key: YARN-1299 > URL: https://issues.apache.org/jira/browse/YARN-1299 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.1.1-beta >Reporter: Devaraj K > Fix For: 2.7.0 > > Attachments: YARN-1299.patch, yarn-1299.patch > > > {code:xml} > 2013-10-07 19:28:35,365 INFO > org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo: > checking for deactivate... > 2013-10-07 19:28:35,365 INFO > org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo: > checking for deactivate... > {code} > In RM log, it gives message saying 'checking for deactivate...'. It would > give better meaning if this log message contains app id. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-1299) Improve 'checking for deactivate...' log message by adding app id
[ https://issues.apache.org/jira/browse/YARN-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322970#comment-14322970 ] Hadoop QA commented on YARN-1299: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12699109/YARN-1299.patch against trunk revision 447bd7b. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:red}-1 findbugs{color}. The patch appears to introduce 5 new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6644//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6644//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6644//console This message is automatically generated. > Improve 'checking for deactivate...' log message by adding app id > - > > Key: YARN-1299 > URL: https://issues.apache.org/jira/browse/YARN-1299 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.1.1-beta >Reporter: Devaraj K > Attachments: YARN-1299.patch, yarn-1299.patch > > > {code:xml} > 2013-10-07 19:28:35,365 INFO > org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo: > checking for deactivate... > 2013-10-07 19:28:35,365 INFO > org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo: > checking for deactivate... > {code} > In RM log, it gives message saying 'checking for deactivate...'. It would > give better meaning if this log message contains app id. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-1299) Improve 'checking for deactivate...' log message by adding app id
[ https://issues.apache.org/jira/browse/YARN-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322923#comment-14322923 ] Devaraj K commented on YARN-1299: - Thanks [~ozawa] for review. > Improve 'checking for deactivate...' log message by adding app id > - > > Key: YARN-1299 > URL: https://issues.apache.org/jira/browse/YARN-1299 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.1.1-beta >Reporter: Devaraj K > Attachments: YARN-1299.patch, yarn-1299.patch > > > {code:xml} > 2013-10-07 19:28:35,365 INFO > org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo: > checking for deactivate... > 2013-10-07 19:28:35,365 INFO > org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo: > checking for deactivate... > {code} > In RM log, it gives message saying 'checking for deactivate...'. It would > give better meaning if this log message contains app id. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-1299) Improve 'checking for deactivate...' log message by adding app id
[ https://issues.apache.org/jira/browse/YARN-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322823#comment-14322823 ] Tsuyoshi OZAWA commented on YARN-1299: -- +1, pending for Jenkins. > Improve 'checking for deactivate...' log message by adding app id > - > > Key: YARN-1299 > URL: https://issues.apache.org/jira/browse/YARN-1299 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.1.1-beta >Reporter: Devaraj K > Attachments: YARN-1299.patch, yarn-1299.patch > > > {code:xml} > 2013-10-07 19:28:35,365 INFO > org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo: > checking for deactivate... > 2013-10-07 19:28:35,365 INFO > org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo: > checking for deactivate... > {code} > In RM log, it gives message saying 'checking for deactivate...'. It would > give better meaning if this log message contains app id. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-1299) Improve 'checking for deactivate...' log message by adding app id
[ https://issues.apache.org/jira/browse/YARN-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794942#comment-13794942 ] Devaraj K commented on YARN-1299: - can you also take care of avoiding lines longer than 80 characters guide line for the changes. > Improve 'checking for deactivate...' log message by adding app id > - > > Key: YARN-1299 > URL: https://issues.apache.org/jira/browse/YARN-1299 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.1.1-beta >Reporter: Devaraj K > Attachments: yarn-1299.patch > > > {code:xml} > 2013-10-07 19:28:35,365 INFO > org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo: > checking for deactivate... > 2013-10-07 19:28:35,365 INFO > org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo: > checking for deactivate... > {code} > In RM log, it gives message saying 'checking for deactivate...'. It would > give better meaning if this log message contains app id. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (YARN-1299) Improve 'checking for deactivate...' log message by adding app id
[ https://issues.apache.org/jira/browse/YARN-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13792783#comment-13792783 ] Zhijie Shen commented on YARN-1299: --- Probably, you want to add the appId for the following log as well {code} LOG.debug("allocate: user: " + user + ", memory: " + request.getCapability()); {code} > Improve 'checking for deactivate...' log message by adding app id > - > > Key: YARN-1299 > URL: https://issues.apache.org/jira/browse/YARN-1299 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.1.1-beta >Reporter: Devaraj K > Attachments: yarn-1299.patch > > > {code:xml} > 2013-10-07 19:28:35,365 INFO > org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo: > checking for deactivate... > 2013-10-07 19:28:35,365 INFO > org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo: > checking for deactivate... > {code} > In RM log, it gives message saying 'checking for deactivate...'. It would > give better meaning if this log message contains app id. -- This message was sent by Atlassian JIRA (v6.1#6144)