[jira] [Commented] (YARN-1448) Protocol changes in RM side to support change container resources

2013-12-09 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842969#comment-13842969
 ] 

Hadoop QA commented on YARN-1448:
-

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12617640/yarn-1448.3.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/2626//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2626//console

This message is automatically generated.

 Protocol changes in RM side to support change container resources
 -

 Key: YARN-1448
 URL: https://issues.apache.org/jira/browse/YARN-1448
 Project: Hadoop YARN
  Issue Type: Sub-task
  Components: api, resourcemanager
Affects Versions: 2.2.0
Reporter: Wangda Tan
Assignee: Wangda Tan
 Attachments: yarn-1448.1.patch, yarn-1448.2.patch, yarn-1448.3.patch


 As described in YARN-1197, we need add API in RM to support
 1) Add increase request in AllocateRequest
 2) Can get successfully increased/decreased containers from RM in 
 AllocateResponse



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Commented] (YARN-1448) Protocol changes in RM side to support change container resources

2013-12-09 Thread Sandy Ryza (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842975#comment-13842975
 ] 

Sandy Ryza commented on YARN-1448:
--

+1

 Protocol changes in RM side to support change container resources
 -

 Key: YARN-1448
 URL: https://issues.apache.org/jira/browse/YARN-1448
 Project: Hadoop YARN
  Issue Type: Sub-task
  Components: api, resourcemanager
Affects Versions: 2.2.0
Reporter: Wangda Tan
Assignee: Wangda Tan
 Attachments: yarn-1448.1.patch, yarn-1448.2.patch, yarn-1448.3.patch


 As described in YARN-1197, we need add API in RM to support
 1) Add increase request in AllocateRequest
 2) Can get successfully increased/decreased containers from RM in 
 AllocateResponse



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Commented] (YARN-1448) Protocol changes in RM side to support change container resources

2013-12-09 Thread Wangda Tan (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842984#comment-13842984
 ] 

Wangda Tan commented on YARN-1448:
--

Thanks :)

 Protocol changes in RM side to support change container resources
 -

 Key: YARN-1448
 URL: https://issues.apache.org/jira/browse/YARN-1448
 Project: Hadoop YARN
  Issue Type: Sub-task
  Components: api, resourcemanager
Affects Versions: 2.2.0
Reporter: Wangda Tan
Assignee: Wangda Tan
 Attachments: yarn-1448.1.patch, yarn-1448.2.patch, yarn-1448.3.patch


 As described in YARN-1197, we need add API in RM to support
 1) Add increase request in AllocateRequest
 2) Can get successfully increased/decreased containers from RM in 
 AllocateResponse



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Commented] (YARN-1448) Protocol changes in RM side to support change container resources

2013-12-07 Thread Sandy Ryza (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842382#comment-13842382
 ] 

Sandy Ryza commented on YARN-1448:
--

The patch overall looks good to me, just a few nits:

{code}
+if (increaseRequests == null)
+  return;
{code}
{code}
+if (increasedContainers == null)
+  return;
{code}
Should use curly braces in these places.

{code}
+throw new UnsupportedOperationException();
+
{code}
Blank line not necessary.

Method annotations should follow similar methods in the same class. I.e. 
getters should be Public and Stable and setters should be Private and Unstable.

 Protocol changes in RM side to support change container resources
 -

 Key: YARN-1448
 URL: https://issues.apache.org/jira/browse/YARN-1448
 Project: Hadoop YARN
  Issue Type: Sub-task
  Components: api, resourcemanager
Affects Versions: 2.2.0
Reporter: Wangda Tan
Assignee: Wangda Tan
 Attachments: yarn-1448.1.patch, yarn-1448.2.patch


 As described in YARN-1197, we need add API in RM to support
 1) Add increase request in AllocateRequest
 2) Can get successfully increased/decreased containers from RM in 
 AllocateResponse



--
This message was sent by Atlassian JIRA
(v6.1#6144)