[jira] [Commented] (YARN-1768) yarn kill non-existent application is too verbose
[ https://issues.apache.org/jira/browse/YARN-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13920667#comment-13920667 ] Tsuyoshi OZAWA commented on YARN-1768: -- Thank you for the review, [~raviprak]! I ran TestNMClient with the modification and confirmed to pass the test locally. yarn kill non-existent application is too verbose - Key: YARN-1768 URL: https://issues.apache.org/jira/browse/YARN-1768 Project: Hadoop YARN Issue Type: Bug Components: client Affects Versions: 2.2.0 Reporter: Hitesh Shah Assignee: Tsuyoshi OZAWA Priority: Minor Attachments: YARN-1768.1.patch, YARN-1768.2.patch, YARN-1768.3.patch, YARN-1768.3.patch Instead of catching ApplicationNotFound and logging a simple app not found message, the whole stack trace is logged. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1768) yarn kill non-existent application is too verbose
[ https://issues.apache.org/jira/browse/YARN-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13920699#comment-13920699 ] Hudson commented on YARN-1768: -- SUCCESS: Integrated in Hadoop-trunk-Commit #5265 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5265/]) YARN-1768. Fixed error message being too verbose when killing a non-existent application (raviprak: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1574401) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java yarn kill non-existent application is too verbose - Key: YARN-1768 URL: https://issues.apache.org/jira/browse/YARN-1768 Project: Hadoop YARN Issue Type: Bug Components: client Affects Versions: 2.2.0 Reporter: Hitesh Shah Assignee: Tsuyoshi OZAWA Priority: Minor Attachments: YARN-1768.1.patch, YARN-1768.2.patch, YARN-1768.3.patch, YARN-1768.3.patch Instead of catching ApplicationNotFound and logging a simple app not found message, the whole stack trace is logged. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1768) yarn kill non-existent application is too verbose
[ https://issues.apache.org/jira/browse/YARN-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13920703#comment-13920703 ] Ravi Prakash commented on YARN-1768: https://issues.apache.org/jira/browse/YARN-1657 is open to investigate the timeout of TestNMClient . This patch is unrelated to the test failure. Committed to trunk, branch-2 and branch-2.4. Thanks a lot Tsuyoshi and Hitesh! yarn kill non-existent application is too verbose - Key: YARN-1768 URL: https://issues.apache.org/jira/browse/YARN-1768 Project: Hadoop YARN Issue Type: Bug Components: client Affects Versions: 2.2.0 Reporter: Hitesh Shah Assignee: Tsuyoshi OZAWA Priority: Minor Attachments: YARN-1768.1.patch, YARN-1768.2.patch, YARN-1768.3.patch, YARN-1768.3.patch Instead of catching ApplicationNotFound and logging a simple app not found message, the whole stack trace is logged. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1768) yarn kill non-existent application is too verbose
[ https://issues.apache.org/jira/browse/YARN-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13920847#comment-13920847 ] Hudson commented on YARN-1768: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1692 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1692/]) YARN-1768. Fixed error message being too verbose when killing a non-existent application. Contributed by Tsuyoshi Ozawa (raviprak: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1574401) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java yarn kill non-existent application is too verbose - Key: YARN-1768 URL: https://issues.apache.org/jira/browse/YARN-1768 Project: Hadoop YARN Issue Type: Bug Components: client Affects Versions: 2.2.0 Reporter: Hitesh Shah Assignee: Tsuyoshi OZAWA Priority: Minor Fix For: 2.4.0 Attachments: YARN-1768.1.patch, YARN-1768.2.patch, YARN-1768.3.patch, YARN-1768.3.patch Instead of catching ApplicationNotFound and logging a simple app not found message, the whole stack trace is logged. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1768) yarn kill non-existent application is too verbose
[ https://issues.apache.org/jira/browse/YARN-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13920920#comment-13920920 ] Hudson commented on YARN-1768: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1717 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1717/]) YARN-1768. Fixed error message being too verbose when killing a non-existent application. Contributed by Tsuyoshi Ozawa (raviprak: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1574401) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java yarn kill non-existent application is too verbose - Key: YARN-1768 URL: https://issues.apache.org/jira/browse/YARN-1768 Project: Hadoop YARN Issue Type: Bug Components: client Affects Versions: 2.2.0 Reporter: Hitesh Shah Assignee: Tsuyoshi OZAWA Priority: Minor Fix For: 2.4.0 Attachments: YARN-1768.1.patch, YARN-1768.2.patch, YARN-1768.3.patch, YARN-1768.3.patch Instead of catching ApplicationNotFound and logging a simple app not found message, the whole stack trace is logged. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1768) yarn kill non-existent application is too verbose
[ https://issues.apache.org/jira/browse/YARN-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919157#comment-13919157 ] Ravi Prakash commented on YARN-1768: Thanks Tsuyoshi! Patch lgtm. +1. I'll commit it tomorrow in trunk and branch-2 unless any one has a comment. yarn kill non-existent application is too verbose - Key: YARN-1768 URL: https://issues.apache.org/jira/browse/YARN-1768 Project: Hadoop YARN Issue Type: Bug Components: client Affects Versions: 2.2.0 Reporter: Hitesh Shah Assignee: Tsuyoshi OZAWA Priority: Minor Attachments: YARN-1768.1.patch, YARN-1768.2.patch, YARN-1768.3.patch Instead of catching ApplicationNotFound and logging a simple app not found message, the whole stack trace is logged. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1768) yarn kill non-existent application is too verbose
[ https://issues.apache.org/jira/browse/YARN-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13920528#comment-13920528 ] Hadoop QA commented on YARN-1768: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12632771/YARN-1768.3.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The following test timeouts occurred in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: org.apache.hadoop.yarn.client.api.impl.TestNMClient {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/3257//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3257//console This message is automatically generated. yarn kill non-existent application is too verbose - Key: YARN-1768 URL: https://issues.apache.org/jira/browse/YARN-1768 Project: Hadoop YARN Issue Type: Bug Components: client Affects Versions: 2.2.0 Reporter: Hitesh Shah Assignee: Tsuyoshi OZAWA Priority: Minor Attachments: YARN-1768.1.patch, YARN-1768.2.patch, YARN-1768.3.patch, YARN-1768.3.patch Instead of catching ApplicationNotFound and logging a simple app not found message, the whole stack trace is logged. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1768) yarn kill non-existent application is too verbose
[ https://issues.apache.org/jira/browse/YARN-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918381#comment-13918381 ] Ravi Prakash commented on YARN-1768: With this patch the return code is wrong (0). Earlier it was returning a non-zero error code. Please also consider adding that check to the test yarn kill non-existent application is too verbose - Key: YARN-1768 URL: https://issues.apache.org/jira/browse/YARN-1768 Project: Hadoop YARN Issue Type: Bug Components: client Affects Versions: 2.2.0 Reporter: Hitesh Shah Assignee: Tsuyoshi OZAWA Priority: Minor Attachments: YARN-1768.1.patch, YARN-1768.2.patch Instead of catching ApplicationNotFound and logging a simple app not found message, the whole stack trace is logged. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1768) yarn kill non-existent application is too verbose
[ https://issues.apache.org/jira/browse/YARN-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13916701#comment-13916701 ] Tsuyoshi OZAWA commented on YARN-1768: -- [~hitesh], could you review patch? yarn kill non-existent application is too verbose - Key: YARN-1768 URL: https://issues.apache.org/jira/browse/YARN-1768 Project: Hadoop YARN Issue Type: Bug Components: client Affects Versions: 2.2.0 Reporter: Hitesh Shah Assignee: Tsuyoshi OZAWA Priority: Minor Attachments: YARN-1768.1.patch Instead of catching ApplicationNotFound and logging a simple app not found message, the whole stack trace is logged. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1768) yarn kill non-existent application is too verbose
[ https://issues.apache.org/jira/browse/YARN-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13916705#comment-13916705 ] Hitesh Shah commented on YARN-1768: --- Looks good for the most part. {code} +import org.apache.hadoop.ipc.RpcException; {code} - Unused import added by mistake? yarn kill non-existent application is too verbose - Key: YARN-1768 URL: https://issues.apache.org/jira/browse/YARN-1768 Project: Hadoop YARN Issue Type: Bug Components: client Affects Versions: 2.2.0 Reporter: Hitesh Shah Assignee: Tsuyoshi OZAWA Priority: Minor Attachments: YARN-1768.1.patch Instead of catching ApplicationNotFound and logging a simple app not found message, the whole stack trace is logged. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1768) yarn kill non-existent application is too verbose
[ https://issues.apache.org/jira/browse/YARN-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13916732#comment-13916732 ] Hadoop QA commented on YARN-1768: - {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12631893/YARN-1768.1.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/3221//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3221//console This message is automatically generated. yarn kill non-existent application is too verbose - Key: YARN-1768 URL: https://issues.apache.org/jira/browse/YARN-1768 Project: Hadoop YARN Issue Type: Bug Components: client Affects Versions: 2.2.0 Reporter: Hitesh Shah Assignee: Tsuyoshi OZAWA Priority: Minor Attachments: YARN-1768.1.patch, YARN-1768.2.patch Instead of catching ApplicationNotFound and logging a simple app not found message, the whole stack trace is logged. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1768) yarn kill non-existent application is too verbose
[ https://issues.apache.org/jira/browse/YARN-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13916739#comment-13916739 ] Hadoop QA commented on YARN-1768: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12631902/YARN-1768.2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The following test timeouts occurred in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: org.apache.hadoop.yarn.client.api.impl.TestNMClient {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/3223//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3223//console This message is automatically generated. yarn kill non-existent application is too verbose - Key: YARN-1768 URL: https://issues.apache.org/jira/browse/YARN-1768 Project: Hadoop YARN Issue Type: Bug Components: client Affects Versions: 2.2.0 Reporter: Hitesh Shah Assignee: Tsuyoshi OZAWA Priority: Minor Attachments: YARN-1768.1.patch, YARN-1768.2.patch Instead of catching ApplicationNotFound and logging a simple app not found message, the whole stack trace is logged. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1768) yarn kill non-existent application is too verbose
[ https://issues.apache.org/jira/browse/YARN-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13916761#comment-13916761 ] Tsuyoshi OZAWA commented on YARN-1768: -- The test failure is not related to the patch - just timeout. We can fix it on another JIRA. yarn kill non-existent application is too verbose - Key: YARN-1768 URL: https://issues.apache.org/jira/browse/YARN-1768 Project: Hadoop YARN Issue Type: Bug Components: client Affects Versions: 2.2.0 Reporter: Hitesh Shah Assignee: Tsuyoshi OZAWA Priority: Minor Attachments: YARN-1768.1.patch, YARN-1768.2.patch Instead of catching ApplicationNotFound and logging a simple app not found message, the whole stack trace is logged. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1768) yarn kill non-existent application is too verbose
[ https://issues.apache.org/jira/browse/YARN-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915130#comment-13915130 ] Hitesh Shah commented on YARN-1768: --- hadoop-yarn-2.2.0/bin/yarn application -kill application_1393537192691_0006 WARNING: org.apache.hadoop.metrics.jvm.EventCounter is deprecated. Please use org.apache.hadoop.log.metrics.EventCounter in all the log4j.properties files. 14/02/27 14:29:32:822 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable 14/02/27 14:29:33:281 INFO client.RMProxy: Connecting to ResourceManager at localhost/127.0.0.1:8020 Exception in thread main org.apache.hadoop.yarn.exceptions.ApplicationNotFoundException: Application with id 'application_1393537192691_0006' doesn't exist in RM. at org.apache.hadoop.yarn.server.resourcemanager.ClientRMService.getApplicationReport(ClientRMService.java:247) at org.apache.hadoop.yarn.api.impl.pb.service.ApplicationClientProtocolPBServiceImpl.getApplicationReport(ApplicationClientProtocolPBServiceImpl.java:120) at org.apache.hadoop.yarn.proto.ApplicationClientProtocol$ApplicationClientProtocolService$2.callBlockingMethod(ApplicationClientProtocol.java:241) at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:585) at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:928) at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2048) at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2044) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:394) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1491) at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2042) yarn kill non-existent application is too verbose - Key: YARN-1768 URL: https://issues.apache.org/jira/browse/YARN-1768 Project: Hadoop YARN Issue Type: Bug Reporter: Hitesh Shah Instead of catching ApplicationNotFound and logging a simple app not found message, the whole stack trace is logged. -- This message was sent by Atlassian JIRA (v6.1.5#6160)