[jira] [Commented] (YARN-1793) yarn application -kill doesn't kill UnmanagedAMs
[ https://issues.apache.org/jira/browse/YARN-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930228#comment-13930228 ] Hudson commented on YARN-1793: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #506 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/506/]) YARN-1793. Fixed ClientRMService#forceKillApplication not killing unmanaged application. Contributed by Karthik Kambatla (jianhe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1576023) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ApplicationMasterService.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMApp.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestKillApplicationWithRMHA.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/applicationsmanager/MockAsm.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/MockRMApp.java yarn application -kill doesn't kill UnmanagedAMs Key: YARN-1793 URL: https://issues.apache.org/jira/browse/YARN-1793 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Affects Versions: 2.3.0 Reporter: Karthik Kambatla Assignee: Karthik Kambatla Priority: Critical Fix For: 2.4.0 Attachments: yarn-1793-0.patch, yarn-1793-1.patch, yarn-1793-2.patch, yarn-1793-3.patch Trying to kill an Unmanaged AM though CLI (yarn application -kill id) logs a success, but doesn't actually kill the AM or reclaim the containers allocated to it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1793) yarn application -kill doesn't kill UnmanagedAMs
[ https://issues.apache.org/jira/browse/YARN-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930352#comment-13930352 ] Hudson commented on YARN-1793: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1698 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1698/]) YARN-1793. Fixed ClientRMService#forceKillApplication not killing unmanaged application. Contributed by Karthik Kambatla (jianhe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1576023) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ApplicationMasterService.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMApp.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestKillApplicationWithRMHA.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/applicationsmanager/MockAsm.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/MockRMApp.java yarn application -kill doesn't kill UnmanagedAMs Key: YARN-1793 URL: https://issues.apache.org/jira/browse/YARN-1793 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Affects Versions: 2.3.0 Reporter: Karthik Kambatla Assignee: Karthik Kambatla Priority: Critical Fix For: 2.4.0 Attachments: yarn-1793-0.patch, yarn-1793-1.patch, yarn-1793-2.patch, yarn-1793-3.patch Trying to kill an Unmanaged AM though CLI (yarn application -kill id) logs a success, but doesn't actually kill the AM or reclaim the containers allocated to it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1793) yarn application -kill doesn't kill UnmanagedAMs
[ https://issues.apache.org/jira/browse/YARN-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930422#comment-13930422 ] Hudson commented on YARN-1793: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1723 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1723/]) YARN-1793. Fixed ClientRMService#forceKillApplication not killing unmanaged application. Contributed by Karthik Kambatla (jianhe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1576023) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ApplicationMasterService.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMApp.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestKillApplicationWithRMHA.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/applicationsmanager/MockAsm.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/MockRMApp.java yarn application -kill doesn't kill UnmanagedAMs Key: YARN-1793 URL: https://issues.apache.org/jira/browse/YARN-1793 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Affects Versions: 2.3.0 Reporter: Karthik Kambatla Assignee: Karthik Kambatla Priority: Critical Fix For: 2.4.0 Attachments: yarn-1793-0.patch, yarn-1793-1.patch, yarn-1793-2.patch, yarn-1793-3.patch Trying to kill an Unmanaged AM though CLI (yarn application -kill id) logs a success, but doesn't actually kill the AM or reclaim the containers allocated to it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1793) yarn application -kill doesn't kill UnmanagedAMs
[ https://issues.apache.org/jira/browse/YARN-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925944#comment-13925944 ] Jian He commented on YARN-1793: --- LGTM, + 1 yarn application -kill doesn't kill UnmanagedAMs Key: YARN-1793 URL: https://issues.apache.org/jira/browse/YARN-1793 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Affects Versions: 2.3.0 Reporter: Karthik Kambatla Assignee: Karthik Kambatla Priority: Critical Attachments: yarn-1793-0.patch, yarn-1793-1.patch, yarn-1793-2.patch, yarn-1793-3.patch Trying to kill an Unmanaged AM though CLI (yarn application -kill id) logs a success, but doesn't actually kill the AM or reclaim the containers allocated to it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1793) yarn application -kill doesn't kill UnmanagedAMs
[ https://issues.apache.org/jira/browse/YARN-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925974#comment-13925974 ] Jian He commented on YARN-1793: --- Committed to trunk, branch-2, branch-2.4 , thanks Karthik ! yarn application -kill doesn't kill UnmanagedAMs Key: YARN-1793 URL: https://issues.apache.org/jira/browse/YARN-1793 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Affects Versions: 2.3.0 Reporter: Karthik Kambatla Assignee: Karthik Kambatla Priority: Critical Fix For: 2.4.0 Attachments: yarn-1793-0.patch, yarn-1793-1.patch, yarn-1793-2.patch, yarn-1793-3.patch Trying to kill an Unmanaged AM though CLI (yarn application -kill id) logs a success, but doesn't actually kill the AM or reclaim the containers allocated to it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1793) yarn application -kill doesn't kill UnmanagedAMs
[ https://issues.apache.org/jira/browse/YARN-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925975#comment-13925975 ] Hudson commented on YARN-1793: -- SUCCESS: Integrated in Hadoop-trunk-Commit #5295 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5295/]) YARN-1793. Fixed ClientRMService#forceKillApplication not killing unmanaged application. Contributed by Karthik Kambatla (jianhe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1576023) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ApplicationMasterService.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMApp.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestKillApplicationWithRMHA.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/applicationsmanager/MockAsm.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/MockRMApp.java yarn application -kill doesn't kill UnmanagedAMs Key: YARN-1793 URL: https://issues.apache.org/jira/browse/YARN-1793 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Affects Versions: 2.3.0 Reporter: Karthik Kambatla Assignee: Karthik Kambatla Priority: Critical Fix For: 2.4.0 Attachments: yarn-1793-0.patch, yarn-1793-1.patch, yarn-1793-2.patch, yarn-1793-3.patch Trying to kill an Unmanaged AM though CLI (yarn application -kill id) logs a success, but doesn't actually kill the AM or reclaim the containers allocated to it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1793) yarn application -kill doesn't kill UnmanagedAMs
[ https://issues.apache.org/jira/browse/YARN-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13926401#comment-13926401 ] Karthik Kambatla commented on YARN-1793: Thanks for your prompt reviews, Jian and Bikas. yarn application -kill doesn't kill UnmanagedAMs Key: YARN-1793 URL: https://issues.apache.org/jira/browse/YARN-1793 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Affects Versions: 2.3.0 Reporter: Karthik Kambatla Assignee: Karthik Kambatla Priority: Critical Fix For: 2.4.0 Attachments: yarn-1793-0.patch, yarn-1793-1.patch, yarn-1793-2.patch, yarn-1793-3.patch Trying to kill an Unmanaged AM though CLI (yarn application -kill id) logs a success, but doesn't actually kill the AM or reclaim the containers allocated to it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1793) yarn application -kill doesn't kill UnmanagedAMs
[
https://issues.apache.org/jira/browse/YARN-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925349#comment-13925349
]
Hadoop QA commented on YARN-1793:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12633609/yarn-1793-3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3306//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3306//console
This message is automatically generated.
yarn application -kill doesn't kill UnmanagedAMs
Key: YARN-1793
URL: https://issues.apache.org/jira/browse/YARN-1793
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Affects Versions: 2.3.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Critical
Attachments: yarn-1793-0.patch, yarn-1793-1.patch, yarn-1793-2.patch,
yarn-1793-3.patch
Trying to kill an Unmanaged AM though CLI (yarn application -kill id) logs
a success, but doesn't actually kill the AM or reclaim the containers
allocated to it.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1793) yarn application -kill doesn't kill UnmanagedAMs
[
https://issues.apache.org/jira/browse/YARN-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13924641#comment-13924641
]
Jian He commented on YARN-1793:
---
Patch looks good, some comments:
Test case: the assert message seems wrong as it's asserting for normal app.
{code}
KillApplicationResponse killResponse1 =
rmService.forceKillApplication(killRequest1);
assertFalse(Killing UnmanagedAM should falsely acknowledge true,
killResponse1.getIsKillCompleted());
{code}
I think we can also have a test that use MockRM to submit an UnmanagedApp and
kill that app, and assert the app to be killed state in the end. That'll be
more end-to-end.
yarn application -kill doesn't kill UnmanagedAMs
Key: YARN-1793
URL: https://issues.apache.org/jira/browse/YARN-1793
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Affects Versions: 2.3.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Critical
Attachments: yarn-1793-0.patch, yarn-1793-1.patch, yarn-1793-2.patch
Trying to kill an Unmanaged AM though CLI (yarn application -kill id) logs
a success, but doesn't actually kill the AM or reclaim the containers
allocated to it.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1793) yarn application -kill doesn't kill UnmanagedAMs
[
https://issues.apache.org/jira/browse/YARN-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13924670#comment-13924670
]
Hadoop QA commented on YARN-1793:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12633509/yarn-1793-2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 1
release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3305//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/3305//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3305//console
This message is automatically generated.
yarn application -kill doesn't kill UnmanagedAMs
Key: YARN-1793
URL: https://issues.apache.org/jira/browse/YARN-1793
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Affects Versions: 2.3.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Critical
Attachments: yarn-1793-0.patch, yarn-1793-1.patch, yarn-1793-2.patch
Trying to kill an Unmanaged AM though CLI (yarn application -kill id) logs
a success, but doesn't actually kill the AM or reclaim the containers
allocated to it.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1793) yarn application -kill doesn't kill UnmanagedAMs
[ https://issues.apache.org/jira/browse/YARN-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13924763#comment-13924763 ] Bikas Saha commented on YARN-1793: -- isAppStateStored() - isAppFinalStateStored() ? yarn application -kill doesn't kill UnmanagedAMs Key: YARN-1793 URL: https://issues.apache.org/jira/browse/YARN-1793 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Affects Versions: 2.3.0 Reporter: Karthik Kambatla Assignee: Karthik Kambatla Priority: Critical Attachments: yarn-1793-0.patch, yarn-1793-1.patch, yarn-1793-2.patch Trying to kill an Unmanaged AM though CLI (yarn application -kill id) logs a success, but doesn't actually kill the AM or reclaim the containers allocated to it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1793) yarn application -kill doesn't kill UnmanagedAMs
[
https://issues.apache.org/jira/browse/YARN-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13922989#comment-13922989
]
Karthik Kambatla commented on YARN-1793:
{code}
if (application.isAppSafeToTerminate()) {
RMAuditLogger.logSuccess(callerUGI.getShortUserName(),
AuditConstants.KILL_APP_REQUEST, ClientRMService, applicationId);
return KillApplicationResponse.newInstance(true);
} else {
this.rmContext.getDispatcher().getEventHandler()
.handle(new RMAppEvent(applicationId, RMAppEventType.KILL));
return KillApplicationResponse.newInstance(false);
}
{code}
Looks like we don't do anything bug log and return if the app is unmanaged. If
the AM continues to run, it continues to hold onto all the containers that were
allocated to it.
[~jianhe], [~vinodkv], [~bikassaha] - any thoughts off the top of your head?
yarn application -kill doesn't kill UnmanagedAMs
Key: YARN-1793
URL: https://issues.apache.org/jira/browse/YARN-1793
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Affects Versions: 2.3.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Critical
Trying to kill an Unmanaged AM though CLI (yarn application -kill id) logs
a success, but doesn't actually kill the AM or reclaim the containers
allocated to it.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1793) yarn application -kill doesn't kill UnmanagedAMs
[ https://issues.apache.org/jira/browse/YARN-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923099#comment-13923099 ] Karthik Kambatla commented on YARN-1793: What do you think about getting rid of this if-else altogether and create the new RMAppEvent for kill in both cases? yarn application -kill doesn't kill UnmanagedAMs Key: YARN-1793 URL: https://issues.apache.org/jira/browse/YARN-1793 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Affects Versions: 2.3.0 Reporter: Karthik Kambatla Assignee: Karthik Kambatla Priority: Critical Trying to kill an Unmanaged AM though CLI (yarn application -kill id) logs a success, but doesn't actually kill the AM or reclaim the containers allocated to it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1793) yarn application -kill doesn't kill UnmanagedAMs
[ https://issues.apache.org/jira/browse/YARN-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923491#comment-13923491 ] Jian He commented on YARN-1793: --- Took a quick look at the patch, if I remember correctly, the special check in isAppSafeToTerminate for unmanaged AM is for this reason https://issues.apache.org/jira/browse/YARN-540?focusedCommentId=13762533page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13762533 yarn application -kill doesn't kill UnmanagedAMs Key: YARN-1793 URL: https://issues.apache.org/jira/browse/YARN-1793 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Affects Versions: 2.3.0 Reporter: Karthik Kambatla Assignee: Karthik Kambatla Priority: Critical Attachments: yarn-1793-0.patch Trying to kill an Unmanaged AM though CLI (yarn application -kill id) logs a success, but doesn't actually kill the AM or reclaim the containers allocated to it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1793) yarn application -kill doesn't kill UnmanagedAMs
[ https://issues.apache.org/jira/browse/YARN-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923568#comment-13923568 ] Karthik Kambatla commented on YARN-1793: Thanks for digging up the reason, [~jianhe]. Can you take a look at the updated patch. Looked into this more carefully. Updated patch changes both ClientRMService and ApplicationMasterService. I believe we have three cases based on the state and kind of application. * Applications that have already reached a final state - do nothing, trivially log success. * Applications that aren't in a final state yet - kill / unregister the application ** UnmanagedAM - falsely acknowledge kill/ unregister so they don't retry ** ManagedAM - return false, so they keep retrying Submitted the patch to see what Jenkins has to say. Still need to add unit tests. yarn application -kill doesn't kill UnmanagedAMs Key: YARN-1793 URL: https://issues.apache.org/jira/browse/YARN-1793 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Affects Versions: 2.3.0 Reporter: Karthik Kambatla Assignee: Karthik Kambatla Priority: Critical Attachments: yarn-1793-0.patch, yarn-1793-1.patch Trying to kill an Unmanaged AM though CLI (yarn application -kill id) logs a success, but doesn't actually kill the AM or reclaim the containers allocated to it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1793) yarn application -kill doesn't kill UnmanagedAMs
[
https://issues.apache.org/jira/browse/YARN-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923591#comment-13923591
]
Hadoop QA commented on YARN-1793:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12633315/yarn-1793-1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3293//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3293//console
This message is automatically generated.
yarn application -kill doesn't kill UnmanagedAMs
Key: YARN-1793
URL: https://issues.apache.org/jira/browse/YARN-1793
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Affects Versions: 2.3.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Critical
Attachments: yarn-1793-0.patch, yarn-1793-1.patch
Trying to kill an Unmanaged AM though CLI (yarn application -kill id) logs
a success, but doesn't actually kill the AM or reclaim the containers
allocated to it.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
