[jira] [Commented] (YARN-2337) remove duplication function call (setClientRMService) in resource manage class

2014-07-23 Thread Tsuyoshi OZAWA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071496#comment-14071496
 ] 

Tsuyoshi OZAWA commented on YARN-2337:
--

+1 (non-binding), let's waiting for the result of Jenkins CI.

 remove duplication function call (setClientRMService) in resource manage class
 --

 Key: YARN-2337
 URL: https://issues.apache.org/jira/browse/YARN-2337
 Project: Hadoop YARN
  Issue Type: Improvement
  Components: resourcemanager
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
 Attachments: YARN-2337.000.patch


 remove duplication function call (setClientRMService) in resource manage 
 class.
 rmContext.setClientRMService(clientRM); is duplicate in serviceInit of 
 ResourceManager. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (YARN-2337) remove duplication function call (setClientRMService) in resource manage class

2014-07-23 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071566#comment-14071566
 ] 

Hadoop QA commented on YARN-2337:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12657305/YARN-2337.000.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/4401//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4401//console

This message is automatically generated.

 remove duplication function call (setClientRMService) in resource manage class
 --

 Key: YARN-2337
 URL: https://issues.apache.org/jira/browse/YARN-2337
 Project: Hadoop YARN
  Issue Type: Improvement
  Components: resourcemanager
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
 Attachments: YARN-2337.000.patch


 remove duplication function call (setClientRMService) in resource manage 
 class.
 rmContext.setClientRMService(clientRM); is duplicate in serviceInit of 
 ResourceManager. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (YARN-2337) remove duplication function call (setClientRMService) in resource manage class

2014-07-23 Thread zhihai xu (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071999#comment-14071999
 ] 

zhihai xu commented on YARN-2337:
-

[~ozawa] thanks for your quick response.

 remove duplication function call (setClientRMService) in resource manage class
 --

 Key: YARN-2337
 URL: https://issues.apache.org/jira/browse/YARN-2337
 Project: Hadoop YARN
  Issue Type: Improvement
  Components: resourcemanager
Reporter: zhihai xu
Assignee: zhihai xu
Priority: Minor
 Attachments: YARN-2337.000.patch


 remove duplication function call (setClientRMService) in resource manage 
 class.
 rmContext.setClientRMService(clientRM); is duplicate in serviceInit of 
 ResourceManager. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)