[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[
https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116294#comment-14116294
]
Hadoop QA commented on YARN-2395:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12665549/YARN-2395-5.patch
against trunk revision 5c14bc4.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/4785//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4785//console
This message is automatically generated.
FairScheduler: Preemption timeout should be configurable per queue
--
Key: YARN-2395
URL: https://issues.apache.org/jira/browse/YARN-2395
Project: Hadoop YARN
Issue Type: New Feature
Components: fairscheduler
Reporter: Ashwin Shankar
Assignee: Wei Yan
Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch,
YARN-2395-3.patch, YARN-2395-4.patch, YARN-2395-5.patch, YARN-2395-5.patch,
YARN-2395-5.patch
Currently in fair scheduler, the preemption logic considers fair share
starvation only at leaf queue level. This jira is created to implement it at
the parent queue as well.
It involves :
1. Making check for fair share starvation and amount of resource to
preempt recursive such that they traverse the queue hierarchy from root to
leaf.
2. Currently fairSharePreemptionTimeout is a global config. We could make it
configurable on a per queue basis,so that we can specify different timeouts
for parent queues.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[ https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116297#comment-14116297 ] Karthik Kambatla commented on YARN-2395: +1. FairScheduler: Preemption timeout should be configurable per queue -- Key: YARN-2395 URL: https://issues.apache.org/jira/browse/YARN-2395 Project: Hadoop YARN Issue Type: New Feature Components: fairscheduler Reporter: Ashwin Shankar Assignee: Wei Yan Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch, YARN-2395-3.patch, YARN-2395-4.patch, YARN-2395-5.patch, YARN-2395-5.patch, YARN-2395-5.patch Currently in fair scheduler, the preemption logic considers fair share starvation only at leaf queue level. This jira is created to implement it at the parent queue as well. It involves : 1. Making check for fair share starvation and amount of resource to preempt recursive such that they traverse the queue hierarchy from root to leaf. 2. Currently fairSharePreemptionTimeout is a global config. We could make it configurable on a per queue basis,so that we can specify different timeouts for parent queues. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[ https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116303#comment-14116303 ] Karthik Kambatla commented on YARN-2395: Just committed this to trunk and branch-2. FairScheduler: Preemption timeout should be configurable per queue -- Key: YARN-2395 URL: https://issues.apache.org/jira/browse/YARN-2395 Project: Hadoop YARN Issue Type: New Feature Components: fairscheduler Reporter: Ashwin Shankar Assignee: Wei Yan Fix For: 2.6.0 Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch, YARN-2395-3.patch, YARN-2395-4.patch, YARN-2395-5.patch, YARN-2395-5.patch, YARN-2395-5.patch Currently in fair scheduler, the preemption logic considers fair share starvation only at leaf queue level. This jira is created to implement it at the parent queue as well. It involves : 1. Making check for fair share starvation and amount of resource to preempt recursive such that they traverse the queue hierarchy from root to leaf. 2. Currently fairSharePreemptionTimeout is a global config. We could make it configurable on a per queue basis,so that we can specify different timeouts for parent queues. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[ https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116352#comment-14116352 ] Hudson commented on YARN-2395: -- FAILURE: Integrated in Hadoop-Yarn-trunk #664 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/664/]) YARN-2395. FairScheduler: Preemption timeout should be configurable per queue. (Wei Yan via kasha) (kasha: rev 0f34e6f3873aee0f4932740ca790c6dd2a13b5d9) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSQueue.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/FairScheduler.apt.vm * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestAllocationFileLoaderService.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationConfiguration.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestFairScheduler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSParentQueue.java FairScheduler: Preemption timeout should be configurable per queue -- Key: YARN-2395 URL: https://issues.apache.org/jira/browse/YARN-2395 Project: Hadoop YARN Issue Type: New Feature Components: fairscheduler Reporter: Ashwin Shankar Assignee: Wei Yan Fix For: 2.6.0 Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch, YARN-2395-3.patch, YARN-2395-4.patch, YARN-2395-5.patch, YARN-2395-5.patch, YARN-2395-5.patch Currently in fair scheduler, the preemption logic considers fair share starvation only at leaf queue level. This jira is created to implement it at the parent queue as well. It involves : 1. Making check for fair share starvation and amount of resource to preempt recursive such that they traverse the queue hierarchy from root to leaf. 2. Currently fairSharePreemptionTimeout is a global config. We could make it configurable on a per queue basis,so that we can specify different timeouts for parent queues. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[ https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116419#comment-14116419 ] Wei Yan commented on YARN-2395: --- Thanks for the review, [~kasha], [~ashwinshankar77]. FairScheduler: Preemption timeout should be configurable per queue -- Key: YARN-2395 URL: https://issues.apache.org/jira/browse/YARN-2395 Project: Hadoop YARN Issue Type: New Feature Components: fairscheduler Reporter: Ashwin Shankar Assignee: Wei Yan Fix For: 2.6.0 Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch, YARN-2395-3.patch, YARN-2395-4.patch, YARN-2395-5.patch, YARN-2395-5.patch, YARN-2395-5.patch Currently in fair scheduler, the preemption logic considers fair share starvation only at leaf queue level. This jira is created to implement it at the parent queue as well. It involves : 1. Making check for fair share starvation and amount of resource to preempt recursive such that they traverse the queue hierarchy from root to leaf. 2. Currently fairSharePreemptionTimeout is a global config. We could make it configurable on a per queue basis,so that we can specify different timeouts for parent queues. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[
https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14115797#comment-14115797
]
Hadoop QA commented on YARN-2395:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12665397/YARN-2395-4.patch
against trunk revision b1dce2a.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/4774//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4774//console
This message is automatically generated.
FairScheduler: Preemption timeout should be configurable per queue
--
Key: YARN-2395
URL: https://issues.apache.org/jira/browse/YARN-2395
Project: Hadoop YARN
Issue Type: New Feature
Components: fairscheduler
Reporter: Ashwin Shankar
Assignee: Wei Yan
Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch,
YARN-2395-3.patch, YARN-2395-4.patch
Currently in fair scheduler, the preemption logic considers fair share
starvation only at leaf queue level. This jira is created to implement it at
the parent queue as well.
It involves :
1. Making check for fair share starvation and amount of resource to
preempt recursive such that they traverse the queue hierarchy from root to
leaf.
2. Currently fairSharePreemptionTimeout is a global config. We could make it
configurable on a per queue basis,so that we can specify different timeouts
for parent queues.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[ https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14115826#comment-14115826 ] Karthik Kambatla commented on YARN-2395: Good catch, Ashwin. I missed the backward incompatibility issue. FairScheduler: Preemption timeout should be configurable per queue -- Key: YARN-2395 URL: https://issues.apache.org/jira/browse/YARN-2395 Project: Hadoop YARN Issue Type: New Feature Components: fairscheduler Reporter: Ashwin Shankar Assignee: Wei Yan Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch, YARN-2395-3.patch, YARN-2395-4.patch Currently in fair scheduler, the preemption logic considers fair share starvation only at leaf queue level. This jira is created to implement it at the parent queue as well. It involves : 1. Making check for fair share starvation and amount of resource to preempt recursive such that they traverse the queue hierarchy from root to leaf. 2. Currently fairSharePreemptionTimeout is a global config. We could make it configurable on a per queue basis,so that we can specify different timeouts for parent queues. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[ https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14115854#comment-14115854 ] Karthik Kambatla commented on YARN-2395: Thanks for quickly updating the patch, Wei. The patch looks mostly good, a couple of minor comments (sorry, I should have done a more thorough review earlier): # Instead of calling updatePreemptionTimeouts() in FairScheduler multiple times, we should probably call it in QueueManager#updateAllocationConfiguration once where we call recomputeSteadyShares(). # Can we augment the test (or add a new one) to verify we are not breaking backward compatibility with the preemptionTimeout defaults? FairScheduler: Preemption timeout should be configurable per queue -- Key: YARN-2395 URL: https://issues.apache.org/jira/browse/YARN-2395 Project: Hadoop YARN Issue Type: New Feature Components: fairscheduler Reporter: Ashwin Shankar Assignee: Wei Yan Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch, YARN-2395-3.patch, YARN-2395-4.patch Currently in fair scheduler, the preemption logic considers fair share starvation only at leaf queue level. This jira is created to implement it at the parent queue as well. It involves : 1. Making check for fair share starvation and amount of resource to preempt recursive such that they traverse the queue hierarchy from root to leaf. 2. Currently fairSharePreemptionTimeout is a global config. We could make it configurable on a per queue basis,so that we can specify different timeouts for parent queues. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[
https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14115969#comment-14115969
]
Hadoop QA commented on YARN-2395:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12665433/YARN-2395-5.patch
against trunk revision c60da4d.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService
org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore
org.apache.hadoop.yarn.server.resourcemanager.recovery.TestFSRMStateStore
The following test timeouts occurred in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.server.resourcemanager.TestClientRMTokens
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/4778//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4778//console
This message is automatically generated.
FairScheduler: Preemption timeout should be configurable per queue
--
Key: YARN-2395
URL: https://issues.apache.org/jira/browse/YARN-2395
Project: Hadoop YARN
Issue Type: New Feature
Components: fairscheduler
Reporter: Ashwin Shankar
Assignee: Wei Yan
Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch,
YARN-2395-3.patch, YARN-2395-4.patch, YARN-2395-5.patch
Currently in fair scheduler, the preemption logic considers fair share
starvation only at leaf queue level. This jira is created to implement it at
the parent queue as well.
It involves :
1. Making check for fair share starvation and amount of resource to
preempt recursive such that they traverse the queue hierarchy from root to
leaf.
2. Currently fairSharePreemptionTimeout is a global config. We could make it
configurable on a per queue basis,so that we can specify different timeouts
for parent queues.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[
https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116039#comment-14116039
]
Hadoop QA commented on YARN-2395:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12665475/YARN-2395-5.patch
against trunk revision 9ad413b.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:red}-1 javac{color:red}. The patch appears to cause the build to
fail.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4779//console
This message is automatically generated.
FairScheduler: Preemption timeout should be configurable per queue
--
Key: YARN-2395
URL: https://issues.apache.org/jira/browse/YARN-2395
Project: Hadoop YARN
Issue Type: New Feature
Components: fairscheduler
Reporter: Ashwin Shankar
Assignee: Wei Yan
Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch,
YARN-2395-3.patch, YARN-2395-4.patch, YARN-2395-5.patch, YARN-2395-5.patch
Currently in fair scheduler, the preemption logic considers fair share
starvation only at leaf queue level. This jira is created to implement it at
the parent queue as well.
It involves :
1. Making check for fair share starvation and amount of resource to
preempt recursive such that they traverse the queue hierarchy from root to
leaf.
2. Currently fairSharePreemptionTimeout is a global config. We could make it
configurable on a per queue basis,so that we can specify different timeouts
for parent queues.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[ https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114688#comment-14114688 ] Wei Yan commented on YARN-2395: --- bq. Do we want to introduce backward incompatible change by removing the existing global fairSharePreemptionTimeout config ? Backward incompatible happens. Here the problem is, if we introduce per-queue preemption timeout, the old fairSharePreemptionTimeout always be incompatible. To solve this problem, we can check whether the old fairSharePreemptionTimeout exist in the alloc file; if existing and without defaultFairSharePreemptionTimeout config, we can treat the fairSharePreemptionTimeout as the default one. bq. Just curious as to why we decided to inherit timeouts ? Consider a scenario where we have one high priority parent queue and low priority parent queue, and each parent queue will create multiple user queues runtime. The high priority queues want to take the resource back as soon as possible, using a small preemption timeout; while the low priority queues are ok for a larger timeout. This cannot be achieved if we only have one default preemption timeout config. FairScheduler: Preemption timeout should be configurable per queue -- Key: YARN-2395 URL: https://issues.apache.org/jira/browse/YARN-2395 Project: Hadoop YARN Issue Type: New Feature Components: fairscheduler Reporter: Ashwin Shankar Assignee: Wei Yan Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch, YARN-2395-3.patch Currently in fair scheduler, the preemption logic considers fair share starvation only at leaf queue level. This jira is created to implement it at the parent queue as well. It involves : 1. Making check for fair share starvation and amount of resource to preempt recursive such that they traverse the queue hierarchy from root to leaf. 2. Currently fairSharePreemptionTimeout is a global config. We could make it configurable on a per queue basis,so that we can specify different timeouts for parent queues. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[ https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114730#comment-14114730 ] Ashwin Shankar commented on YARN-2395: -- [~ywskycn], Sure, I'm fine with this, I just wanted to call it out. FairScheduler: Preemption timeout should be configurable per queue -- Key: YARN-2395 URL: https://issues.apache.org/jira/browse/YARN-2395 Project: Hadoop YARN Issue Type: New Feature Components: fairscheduler Reporter: Ashwin Shankar Assignee: Wei Yan Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch, YARN-2395-3.patch Currently in fair scheduler, the preemption logic considers fair share starvation only at leaf queue level. This jira is created to implement it at the parent queue as well. It involves : 1. Making check for fair share starvation and amount of resource to preempt recursive such that they traverse the queue hierarchy from root to leaf. 2. Currently fairSharePreemptionTimeout is a global config. We could make it configurable on a per queue basis,so that we can specify different timeouts for parent queues. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[ https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14112772#comment-14112772 ] Karthik Kambatla commented on YARN-2395: I ll commit this later today if no one has any comments. FairScheduler: Preemption timeout should be configurable per queue -- Key: YARN-2395 URL: https://issues.apache.org/jira/browse/YARN-2395 Project: Hadoop YARN Issue Type: New Feature Components: fairscheduler Reporter: Ashwin Shankar Assignee: Wei Yan Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch, YARN-2395-3.patch Currently in fair scheduler, the preemption logic considers fair share starvation only at leaf queue level. This jira is created to implement it at the parent queue as well. It involves : 1. Making check for fair share starvation and amount of resource to preempt recursive such that they traverse the queue hierarchy from root to leaf. 2. Currently fairSharePreemptionTimeout is a global config. We could make it configurable on a per queue basis,so that we can specify different timeouts for parent queues. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[
https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113290#comment-14113290
]
Ashwin Shankar commented on YARN-2395:
--
[~kasha], I'm fine with the plan. However I'm not very clear on what you plan
to do in YARN-2457. I'll ping you later to discuss this.
Patch looks mostly good.
Couple of questions :
Do we want to introduce backward incompatible change by removing the existing
global fairSharePreemptionTimeout config ?
Just curious as to why we decided to inherit timeouts ?
One nit :
{code}
// For max share
{code}
This should be fair share.
FairScheduler: Preemption timeout should be configurable per queue
--
Key: YARN-2395
URL: https://issues.apache.org/jira/browse/YARN-2395
Project: Hadoop YARN
Issue Type: New Feature
Components: fairscheduler
Reporter: Ashwin Shankar
Assignee: Wei Yan
Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch,
YARN-2395-3.patch
Currently in fair scheduler, the preemption logic considers fair share
starvation only at leaf queue level. This jira is created to implement it at
the parent queue as well.
It involves :
1. Making check for fair share starvation and amount of resource to
preempt recursive such that they traverse the queue hierarchy from root to
leaf.
2. Currently fairSharePreemptionTimeout is a global config. We could make it
configurable on a per queue basis,so that we can specify different timeouts
for parent queues.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[ https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111090#comment-14111090 ] Karthik Kambatla commented on YARN-2395: bq. Which means starvation at parent queues would not be detected and preemption at parent will not happen. Am I missing something ? If a parent queue is starved, wouldn't at least one of the child queues starve? Is there a counter example? FairScheduler: Preemption timeout should be configurable per queue -- Key: YARN-2395 URL: https://issues.apache.org/jira/browse/YARN-2395 Project: Hadoop YARN Issue Type: New Feature Components: fairscheduler Reporter: Ashwin Shankar Assignee: Wei Yan Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch, YARN-2395-3.patch Currently in fair scheduler, the preemption logic considers fair share starvation only at leaf queue level. This jira is created to implement it at the parent queue as well. It involves : 1. Making check for fair share starvation and amount of resource to preempt recursive such that they traverse the queue hierarchy from root to leaf. 2. Currently fairSharePreemptionTimeout is a global config. We could make it configurable on a per queue basis,so that we can specify different timeouts for parent queues. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[ https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1431#comment-1431 ] Karthik Kambatla commented on YARN-2395: I think I now get Ashwin's point. Ashwin - please correct me if I am wrong. If the parent queue has a timeout of 5 seconds and all the child queues have a timeout of 30 seconds, any preemption under the parent queue kicks in only after 30 seconds and not 5 seconds. I am not sure we can really do much in this case. It can be a case of misconfiguration that we might want to warn. But again, if a leaf queue were to be created under, that would inherit these timeouts. FairScheduler: Preemption timeout should be configurable per queue -- Key: YARN-2395 URL: https://issues.apache.org/jira/browse/YARN-2395 Project: Hadoop YARN Issue Type: New Feature Components: fairscheduler Reporter: Ashwin Shankar Assignee: Wei Yan Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch, YARN-2395-3.patch Currently in fair scheduler, the preemption logic considers fair share starvation only at leaf queue level. This jira is created to implement it at the parent queue as well. It involves : 1. Making check for fair share starvation and amount of resource to preempt recursive such that they traverse the queue hierarchy from root to leaf. 2. Currently fairSharePreemptionTimeout is a global config. We could make it configurable on a per queue basis,so that we can specify different timeouts for parent queues. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[ https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1448#comment-1448 ] Ashwin Shankar commented on YARN-2395: -- [~kasha], bq. If a parent queue is starved, wouldn't at least one of the child queues starve? Not always. Here is an example : Queue hierarchy : root.lowPriorityLeaf - fair share = 10% root.HighPriorityParent - fair share = 90% fairSharePreemptionThreshold=1 root.HighPriorityParent.child(1-10) Scenario : Apps running in root.lowPriorityLeaf, root.HighPriorityParent.child1, root.HighPriorityParent.child2(Remember we now have fair share for active queues) Following situation is possible : root.lowPriorityLeaf : *usage = 55% demand = 55% fair share = 10%* root.HighPriorityParent.child1: *usage = 45% demand = 85% fair share = 45%* root.HighPriorityParent.child2 : usage = 5% demand = 5% fair share = 45% In above example, low priority queue with fair share 10% is taking up 55% of the cluster, while HighPriorityParent.child1 needs 85%, but can get only 45% through preemption since thats its fair share. Another point is HighPriorityParent.child2 has a fair share of 45%, but needs only 5%. *Note that both child1,child2 are NOT starved, but HighPriorityParent is starved.* Use case is basically this : We want ALL 90% of the cluster resources to go to HighPriorityParent whenever its needed by ANY of its children. We can do that by detecting starvation at parent HighPriorityParent and preempt from lowPriorityLeaf. FairScheduler: Preemption timeout should be configurable per queue -- Key: YARN-2395 URL: https://issues.apache.org/jira/browse/YARN-2395 Project: Hadoop YARN Issue Type: New Feature Components: fairscheduler Reporter: Ashwin Shankar Assignee: Wei Yan Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch, YARN-2395-3.patch Currently in fair scheduler, the preemption logic considers fair share starvation only at leaf queue level. This jira is created to implement it at the parent queue as well. It involves : 1. Making check for fair share starvation and amount of resource to preempt recursive such that they traverse the queue hierarchy from root to leaf. 2. Currently fairSharePreemptionTimeout is a global config. We could make it configurable on a per queue basis,so that we can specify different timeouts for parent queues. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[ https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111722#comment-14111722 ] Karthik Kambatla commented on YARN-2395: I see the issue now. Thanks for catching it, Ashwin. Wei and I discussed this offline to see what might be the best way to handle this, and here is what I think might work: # Starved leaf queues will continue to be handled the way they are in the latest patch. # YARN-2154 changes the behavior for leaf queues to look at actual ResourceRequests and preempt only matching containers. # YARN-2457: For each starved parent queue, pick an application with positive demand and the least disadvantaged in terms of allocation and preempt containers that match that. I propose we get this in and follow up on other items in respective JIRAs. FairScheduler: Preemption timeout should be configurable per queue -- Key: YARN-2395 URL: https://issues.apache.org/jira/browse/YARN-2395 Project: Hadoop YARN Issue Type: New Feature Components: fairscheduler Reporter: Ashwin Shankar Assignee: Wei Yan Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch, YARN-2395-3.patch Currently in fair scheduler, the preemption logic considers fair share starvation only at leaf queue level. This jira is created to implement it at the parent queue as well. It involves : 1. Making check for fair share starvation and amount of resource to preempt recursive such that they traverse the queue hierarchy from root to leaf. 2. Currently fairSharePreemptionTimeout is a global config. We could make it configurable on a per queue basis,so that we can specify different timeouts for parent queues. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[ https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111747#comment-14111747 ] Karthik Kambatla commented on YARN-2395: Latest patch looks good to me. +1 [~ashwinshankar77] - does the plan and the current patch look alright to you? FairScheduler: Preemption timeout should be configurable per queue -- Key: YARN-2395 URL: https://issues.apache.org/jira/browse/YARN-2395 Project: Hadoop YARN Issue Type: New Feature Components: fairscheduler Reporter: Ashwin Shankar Assignee: Wei Yan Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch, YARN-2395-3.patch Currently in fair scheduler, the preemption logic considers fair share starvation only at leaf queue level. This jira is created to implement it at the parent queue as well. It involves : 1. Making check for fair share starvation and amount of resource to preempt recursive such that they traverse the queue hierarchy from root to leaf. 2. Currently fairSharePreemptionTimeout is a global config. We could make it configurable on a per queue basis,so that we can specify different timeouts for parent queues. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[
https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110007#comment-14110007
]
Karthik Kambatla commented on YARN-2395:
Comments on the latest patch:
# Typo - should be If and not In
{code}
// Fair share preemption timeout for each queue in seconds. In a job in the
{code}
# Documentation typos - s/will inherits/will inherit in two places.
# In TestAllocationFileLoaderService, can we make some changes to minShare as
well and verify them.
FairScheduler: Preemption timeout should be configurable per queue
--
Key: YARN-2395
URL: https://issues.apache.org/jira/browse/YARN-2395
Project: Hadoop YARN
Issue Type: New Feature
Components: fairscheduler
Reporter: Ashwin Shankar
Assignee: Wei Yan
Attachments: YARN-2395-1.patch, YARN-2395-2.patch
Currently in fair scheduler, the preemption logic considers fair share
starvation only at leaf queue level. This jira is created to implement it at
the parent queue as well.
It involves :
1. Making check for fair share starvation and amount of resource to
preempt recursive such that they traverse the queue hierarchy from root to
leaf.
2. Currently fairSharePreemptionTimeout is a global config. We could make it
configurable on a per queue basis,so that we can specify different timeouts
for parent queues.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[ https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110059#comment-14110059 ] Ashwin Shankar commented on YARN-2395: -- [~ywskycn], I'll post my comments soon. But quick comment on skimming through the patch - I see you have NOT made FairScheduler#isStarvedForMinShare and isStarvedForFairShare recursive. Which means starvation at parent queues would not be detected and preemption at parent will not happen. Am I missing something ? FairScheduler: Preemption timeout should be configurable per queue -- Key: YARN-2395 URL: https://issues.apache.org/jira/browse/YARN-2395 Project: Hadoop YARN Issue Type: New Feature Components: fairscheduler Reporter: Ashwin Shankar Assignee: Wei Yan Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch Currently in fair scheduler, the preemption logic considers fair share starvation only at leaf queue level. This jira is created to implement it at the parent queue as well. It involves : 1. Making check for fair share starvation and amount of resource to preempt recursive such that they traverse the queue hierarchy from root to leaf. 2. Currently fairSharePreemptionTimeout is a global config. We could make it configurable on a per queue basis,so that we can specify different timeouts for parent queues. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[
https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110191#comment-14110191
]
Hadoop QA commented on YARN-2395:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12664263/YARN-2395-3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The test build failed in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/4724//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4724//console
This message is automatically generated.
FairScheduler: Preemption timeout should be configurable per queue
--
Key: YARN-2395
URL: https://issues.apache.org/jira/browse/YARN-2395
Project: Hadoop YARN
Issue Type: New Feature
Components: fairscheduler
Reporter: Ashwin Shankar
Assignee: Wei Yan
Attachments: YARN-2395-1.patch, YARN-2395-2.patch, YARN-2395-3.patch
Currently in fair scheduler, the preemption logic considers fair share
starvation only at leaf queue level. This jira is created to implement it at
the parent queue as well.
It involves :
1. Making check for fair share starvation and amount of resource to
preempt recursive such that they traverse the queue hierarchy from root to
leaf.
2. Currently fairSharePreemptionTimeout is a global config. We could make it
configurable on a per queue basis,so that we can specify different timeouts
for parent queues.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2395) FairScheduler: Preemption timeout should be configurable per queue
[
https://issues.apache.org/jira/browse/YARN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14107785#comment-14107785
]
Hadoop QA commented on YARN-2395:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12663799/YARN-2395-2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/4700//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4700//console
This message is automatically generated.
FairScheduler: Preemption timeout should be configurable per queue
--
Key: YARN-2395
URL: https://issues.apache.org/jira/browse/YARN-2395
Project: Hadoop YARN
Issue Type: New Feature
Components: fairscheduler
Reporter: Ashwin Shankar
Assignee: Wei Yan
Attachments: YARN-2395-1.patch, YARN-2395-2.patch
Currently in fair scheduler, the preemption logic considers fair share
starvation only at leaf queue level. This jira is created to implement it at
the parent queue as well.
It involves :
1. Making check for fair share starvation and amount of resource to
preempt recursive such that they traverse the queue hierarchy from root to
leaf.
2. Currently fairSharePreemptionTimeout is a global config. We could make it
configurable on a per queue basis,so that we can specify different timeouts
for parent queues.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
