[jira] [Commented] (YARN-2847) Linux native container executor segfaults if default banned user detected
[ https://issues.apache.org/jira/browse/YARN-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323834#comment-14323834 ] Hudson commented on YARN-2847: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #97 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/97/]) YARN-2847. Linux native container executor segfaults if default banned user detected. Contributed by Olaf Flebbe (jlowe: rev 1a0f508b6386b1c26ec606f6d73afddaa191b7d8) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c * hadoop-yarn-project/CHANGES.txt Linux native container executor segfaults if default banned user detected - Key: YARN-2847 URL: https://issues.apache.org/jira/browse/YARN-2847 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Affects Versions: 2.5.0, 2.4.1, 2.6.0 Reporter: Jason Lowe Assignee: Olaf Flebbe Fix For: 2.7.0 Attachments: YARN-2487.04.trunk.patch, YARN-2487.05.trunk.patch, YARN-2487.06.trunk.patch, yarn2847.patch, yarn2847.patch, yarn2847notest.patch The check_user function in container-executor.c can cause a segmentation fault if banned.users is not provided but the user is detected as one of the default users. In that scenario it will call free_values on a NULL pointer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2847) Linux native container executor segfaults if default banned user detected
[ https://issues.apache.org/jira/browse/YARN-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321347#comment-14321347 ] Hudson commented on YARN-2847: -- FAILURE: Integrated in Hadoop-Yarn-trunk #838 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/838/]) YARN-2847. Linux native container executor segfaults if default banned user detected. Contributed by Olaf Flebbe (jlowe: rev 1a0f508b6386b1c26ec606f6d73afddaa191b7d8) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c Linux native container executor segfaults if default banned user detected - Key: YARN-2847 URL: https://issues.apache.org/jira/browse/YARN-2847 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Affects Versions: 2.5.0, 2.4.1, 2.6.0 Reporter: Jason Lowe Assignee: Olaf Flebbe Fix For: 2.7.0 Attachments: YARN-2487.04.trunk.patch, YARN-2487.05.trunk.patch, YARN-2487.06.trunk.patch, yarn2847.patch, yarn2847.patch, yarn2847notest.patch The check_user function in container-executor.c can cause a segmentation fault if banned.users is not provided but the user is detected as one of the default users. In that scenario it will call free_values on a NULL pointer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2847) Linux native container executor segfaults if default banned user detected
[ https://issues.apache.org/jira/browse/YARN-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321336#comment-14321336 ] Hudson commented on YARN-2847: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #104 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/104/]) YARN-2847. Linux native container executor segfaults if default banned user detected. Contributed by Olaf Flebbe (jlowe: rev 1a0f508b6386b1c26ec606f6d73afddaa191b7d8) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c * hadoop-yarn-project/CHANGES.txt Linux native container executor segfaults if default banned user detected - Key: YARN-2847 URL: https://issues.apache.org/jira/browse/YARN-2847 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Affects Versions: 2.5.0, 2.4.1, 2.6.0 Reporter: Jason Lowe Assignee: Olaf Flebbe Fix For: 2.7.0 Attachments: YARN-2487.04.trunk.patch, YARN-2487.05.trunk.patch, YARN-2487.06.trunk.patch, yarn2847.patch, yarn2847.patch, yarn2847notest.patch The check_user function in container-executor.c can cause a segmentation fault if banned.users is not provided but the user is detected as one of the default users. In that scenario it will call free_values on a NULL pointer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2847) Linux native container executor segfaults if default banned user detected
[ https://issues.apache.org/jira/browse/YARN-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321432#comment-14321432 ] Hudson commented on YARN-2847: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2036 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2036/]) YARN-2847. Linux native container executor segfaults if default banned user detected. Contributed by Olaf Flebbe (jlowe: rev 1a0f508b6386b1c26ec606f6d73afddaa191b7d8) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c Linux native container executor segfaults if default banned user detected - Key: YARN-2847 URL: https://issues.apache.org/jira/browse/YARN-2847 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Affects Versions: 2.5.0, 2.4.1, 2.6.0 Reporter: Jason Lowe Assignee: Olaf Flebbe Fix For: 2.7.0 Attachments: YARN-2487.04.trunk.patch, YARN-2487.05.trunk.patch, YARN-2487.06.trunk.patch, yarn2847.patch, yarn2847.patch, yarn2847notest.patch The check_user function in container-executor.c can cause a segmentation fault if banned.users is not provided but the user is detected as one of the default users. In that scenario it will call free_values on a NULL pointer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2847) Linux native container executor segfaults if default banned user detected
[ https://issues.apache.org/jira/browse/YARN-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321477#comment-14321477 ] Hudson commented on YARN-2847: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #105 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/105/]) YARN-2847. Linux native container executor segfaults if default banned user detected. Contributed by Olaf Flebbe (jlowe: rev 1a0f508b6386b1c26ec606f6d73afddaa191b7d8) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c Linux native container executor segfaults if default banned user detected - Key: YARN-2847 URL: https://issues.apache.org/jira/browse/YARN-2847 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Affects Versions: 2.5.0, 2.4.1, 2.6.0 Reporter: Jason Lowe Assignee: Olaf Flebbe Fix For: 2.7.0 Attachments: YARN-2487.04.trunk.patch, YARN-2487.05.trunk.patch, YARN-2487.06.trunk.patch, yarn2847.patch, yarn2847.patch, yarn2847notest.patch The check_user function in container-executor.c can cause a segmentation fault if banned.users is not provided but the user is detected as one of the default users. In that scenario it will call free_values on a NULL pointer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2847) Linux native container executor segfaults if default banned user detected
[ https://issues.apache.org/jira/browse/YARN-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14321501#comment-14321501 ] Hudson commented on YARN-2847: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2055 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2055/]) YARN-2847. Linux native container executor segfaults if default banned user detected. Contributed by Olaf Flebbe (jlowe: rev 1a0f508b6386b1c26ec606f6d73afddaa191b7d8) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c Linux native container executor segfaults if default banned user detected - Key: YARN-2847 URL: https://issues.apache.org/jira/browse/YARN-2847 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Affects Versions: 2.5.0, 2.4.1, 2.6.0 Reporter: Jason Lowe Assignee: Olaf Flebbe Fix For: 2.7.0 Attachments: YARN-2487.04.trunk.patch, YARN-2487.05.trunk.patch, YARN-2487.06.trunk.patch, yarn2847.patch, yarn2847.patch, yarn2847notest.patch The check_user function in container-executor.c can cause a segmentation fault if banned.users is not provided but the user is detected as one of the default users. In that scenario it will call free_values on a NULL pointer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2847) Linux native container executor segfaults if default banned user detected
[ https://issues.apache.org/jira/browse/YARN-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319951#comment-14319951 ] Olaf Flebbe commented on YARN-2847: --- The eclipse:eclipse test trips over the Test from [~Chang Li] . The required user mapred does not exit. Do we need this test anyway? I added a test in the C Part of the patch. Linux native container executor segfaults if default banned user detected - Key: YARN-2847 URL: https://issues.apache.org/jira/browse/YARN-2847 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Affects Versions: 2.5.0, 2.4.1, 2.6.0 Reporter: Jason Lowe Assignee: Chang Li Attachments: YARN-2487.04.trunk.patch, YARN-2487.05.trunk.patch, yarn2847.patch, yarn2847.patch, yarn2847notest.patch The check_user function in container-executor.c can cause a segmentation fault if banned.users is not provided but the user is detected as one of the default users. In that scenario it will call free_values on a NULL pointer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2847) Linux native container executor segfaults if default banned user detected
[
https://issues.apache.org/jira/browse/YARN-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14320541#comment-14320541
]
Hadoop QA commented on YARN-2847:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12698773/YARN-2487.06.trunk.patch
against trunk revision ba3c80a.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6636//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6636//console
This message is automatically generated.
Linux native container executor segfaults if default banned user detected
-
Key: YARN-2847
URL: https://issues.apache.org/jira/browse/YARN-2847
Project: Hadoop YARN
Issue Type: Bug
Components: nodemanager
Affects Versions: 2.5.0, 2.4.1, 2.6.0
Reporter: Jason Lowe
Assignee: Olaf Flebbe
Attachments: YARN-2487.04.trunk.patch, YARN-2487.05.trunk.patch,
YARN-2487.06.trunk.patch, yarn2847.patch, yarn2847.patch, yarn2847notest.patch
The check_user function in container-executor.c can cause a segmentation
fault if banned.users is not provided but the user is detected as one of the
default users. In that scenario it will call free_values on a NULL pointer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2847) Linux native container executor segfaults if default banned user detected
[ https://issues.apache.org/jira/browse/YARN-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14320686#comment-14320686 ] Jason Lowe commented on YARN-2847: -- +1 lgtm. Committing this. Linux native container executor segfaults if default banned user detected - Key: YARN-2847 URL: https://issues.apache.org/jira/browse/YARN-2847 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Affects Versions: 2.5.0, 2.4.1, 2.6.0 Reporter: Jason Lowe Assignee: Olaf Flebbe Attachments: YARN-2487.04.trunk.patch, YARN-2487.05.trunk.patch, YARN-2487.06.trunk.patch, yarn2847.patch, yarn2847.patch, yarn2847notest.patch The check_user function in container-executor.c can cause a segmentation fault if banned.users is not provided but the user is detected as one of the default users. In that scenario it will call free_values on a NULL pointer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2847) Linux native container executor segfaults if default banned user detected
[ https://issues.apache.org/jira/browse/YARN-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14320708#comment-14320708 ] Hudson commented on YARN-2847: -- FAILURE: Integrated in Hadoop-trunk-Commit #7106 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7106/]) YARN-2847. Linux native container executor segfaults if default banned user detected. Contributed by Olaf Flebbe (jlowe: rev 1a0f508b6386b1c26ec606f6d73afddaa191b7d8) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c * hadoop-yarn-project/CHANGES.txt Linux native container executor segfaults if default banned user detected - Key: YARN-2847 URL: https://issues.apache.org/jira/browse/YARN-2847 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Affects Versions: 2.5.0, 2.4.1, 2.6.0 Reporter: Jason Lowe Assignee: Olaf Flebbe Fix For: 2.7.0 Attachments: YARN-2487.04.trunk.patch, YARN-2487.05.trunk.patch, YARN-2487.06.trunk.patch, yarn2847.patch, yarn2847.patch, yarn2847notest.patch The check_user function in container-executor.c can cause a segmentation fault if banned.users is not provided but the user is detected as one of the default users. In that scenario it will call free_values on a NULL pointer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2847) Linux native container executor segfaults if default banned user detected
[ https://issues.apache.org/jira/browse/YARN-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14318885#comment-14318885 ] Olaf Flebbe commented on YARN-2847: --- Oops fix not correct Linux native container executor segfaults if default banned user detected - Key: YARN-2847 URL: https://issues.apache.org/jira/browse/YARN-2847 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Affects Versions: 2.5.0, 2.4.1, 2.6.0 Reporter: Jason Lowe Assignee: Chang Li Attachments: YARN-2487.04.trunk.patch, yarn2847.patch, yarn2847.patch, yarn2847notest.patch The check_user function in container-executor.c can cause a segmentation fault if banned.users is not provided but the user is detected as one of the default users. In that scenario it will call free_values on a NULL pointer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2847) Linux native container executor segfaults if default banned user detected
[
https://issues.apache.org/jira/browse/YARN-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319027#comment-14319027
]
Hadoop QA commented on YARN-2847:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12698521/YARN-2487.05.trunk.patch
against trunk revision 58cb9f5.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:red}-1 eclipse:eclipse{color}. The patch failed to build with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6623//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6623//console
This message is automatically generated.
Linux native container executor segfaults if default banned user detected
-
Key: YARN-2847
URL: https://issues.apache.org/jira/browse/YARN-2847
Project: Hadoop YARN
Issue Type: Bug
Components: nodemanager
Affects Versions: 2.5.0, 2.4.1, 2.6.0
Reporter: Jason Lowe
Assignee: Chang Li
Attachments: YARN-2487.04.trunk.patch, YARN-2487.05.trunk.patch,
yarn2847.patch, yarn2847.patch, yarn2847notest.patch
The check_user function in container-executor.c can cause a segmentation
fault if banned.users is not provided but the user is detected as one of the
default users. In that scenario it will call free_values on a NULL pointer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2847) Linux native container executor segfaults if default banned user detected
[ https://issues.apache.org/jira/browse/YARN-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14233615#comment-14233615 ] Wei Yan commented on YARN-2847: --- Thanks for the fix, [~lichangleo]. There are some unnecessary changes in the latest patch, the blanks. And for the testcase, do we really need the testcase for this fix, given that the testcase requires mapred user. Linux native container executor segfaults if default banned user detected - Key: YARN-2847 URL: https://issues.apache.org/jira/browse/YARN-2847 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Affects Versions: 2.5.0 Reporter: Jason Lowe Assignee: chang li Attachments: yarn2847.patch, yarn2847.patch, yarn2847notest.patch The check_user function in container-executor.c can cause a segmentation fault if banned.users is not provided but the user is detected as one of the default users. In that scenario it will call free_values on a NULL pointer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2847) Linux native container executor segfaults if default banned user detected
[ https://issues.apache.org/jira/browse/YARN-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224245#comment-14224245 ] zhihai xu commented on YARN-2847: - Will the second solution(set it to DEFAULT_BANNED_USERS if get_values returns NULL) be better? With second solution, we needn't check null and we only need check DEFAULT_BANNED_USERS before calling free_values. Linux native container executor segfaults if default banned user detected - Key: YARN-2847 URL: https://issues.apache.org/jira/browse/YARN-2847 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Affects Versions: 2.5.0 Reporter: Jason Lowe Assignee: chang li Attachments: yarn2847notest.patch The check_user function in container-executor.c can cause a segmentation fault if banned.users is not provided but the user is detected as one of the default users. In that scenario it will call free_values on a NULL pointer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2847) Linux native container executor segfaults if default banned user detected
[
https://issues.apache.org/jira/browse/YARN-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14206801#comment-14206801
]
Jason Lowe commented on YARN-2847:
--
The problem is in this code:
{code}
char **banned_users = get_values(BANNED_USERS_KEY);
char **banned_user = (banned_users == NULL) ?
(char**) DEFAULT_BANNED_USERS : banned_users;
for(; *banned_user; ++banned_user) {
if (strcmp(*banned_user, user) == 0) {
free(user_info);
if (banned_users != (char**)DEFAULT_BANNED_USERS) {
free_values(banned_users);
}
fprintf(LOGFILE, Requested user %s is banned\n, user);
return NULL;
}
}
if (banned_users != NULL banned_users != (char**)DEFAULT_BANNED_USERS) {
free_values(banned_users);
}
{code}
Note that in one case we check for banned_users != NULL and !=
DEFAULT_BANNED_USERS but in another case we're missing the NULL check.
Lots of ways to fix it:
- free_values could check for NULL
- banned_users could always be non-NULL (i.e.: set it to DEFAULT_BANNED_USERS
if get_values returns NULL)
- add check for != NULL before calling free_values
Linux native container executor segfaults if default banned user detected
-
Key: YARN-2847
URL: https://issues.apache.org/jira/browse/YARN-2847
Project: Hadoop YARN
Issue Type: Bug
Components: nodemanager
Affects Versions: 2.5.0
Reporter: Jason Lowe
The check_user function in container-executor.c can cause a segmentation
fault if banned.users is not provided but the user is detected as one of the
default users. In that scenario it will call free_values on a NULL pointer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
