[jira] [Commented] (YARN-2945) FSLeafQueue#assignContainer - document the reason for using both write and read locks

2015-08-31 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723053#comment-14723053
 ] 

Hudson commented on YARN-2945:
--

FAILURE: Integrated in Hadoop-Hdfs-trunk #2252 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2252/])
YARN-2945. Fixing the CHANGES.txt to have the right JIRA number. (vinodkv: rev 
cf831565e8344523e1bd0eaf686ed56a2b48b920)
* hadoop-yarn-project/CHANGES.txt


> FSLeafQueue#assignContainer - document the reason for using both write and 
> read locks
> -
>
> Key: YARN-2945
> URL: https://issues.apache.org/jira/browse/YARN-2945
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Tsuyoshi Ozawa
>Assignee: Tsuyoshi Ozawa
> Fix For: 2.7.0
>
> Attachments: YARN-2945.001.patch, YARN-2945.002.patch
>
>
> After YARN-2910, assignContainer hold WriteLock while sorting and ReadLock 
> while referencing runnableApps. This can cause interrupted assignment of 
> containers regardless of the policy.
> {code}
> writeLock.lock();
> try {
>   Collections.sort(runnableApps, comparator);
> } finally {
>   writeLock.unlock();
> }
> readLock.lock();
> try {
>   for (FSAppAttempt sched : runnableApps) {
> if (SchedulerAppUtils.isBlacklisted(sched, node, LOG)) {
>   continue;
> }
> assigned = sched.assignContainer(node);
> if (!assigned.equals(Resources.none())) {
>   break;
> }
>}
> } finally {
>   readLock.unlock();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-2945) FSLeafQueue#assignContainer - document the reason for using both write and read locks

2015-08-30 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14721915#comment-14721915
 ] 

Hudson commented on YARN-2945:
--

FAILURE: Integrated in Hadoop-trunk-Commit #8371 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/8371/])
YARN-2945. Fixing the CHANGES.txt to have the right JIRA number. (vinodkv: rev 
cf831565e8344523e1bd0eaf686ed56a2b48b920)
* hadoop-yarn-project/CHANGES.txt


 FSLeafQueue#assignContainer - document the reason for using both write and 
 read locks
 -

 Key: YARN-2945
 URL: https://issues.apache.org/jira/browse/YARN-2945
 Project: Hadoop YARN
  Issue Type: Bug
Reporter: Tsuyoshi Ozawa
Assignee: Tsuyoshi Ozawa
 Fix For: 2.7.0

 Attachments: YARN-2945.001.patch, YARN-2945.002.patch


 After YARN-2910, assignContainer hold WriteLock while sorting and ReadLock 
 while referencing runnableApps. This can cause interrupted assignment of 
 containers regardless of the policy.
 {code}
 writeLock.lock();
 try {
   Collections.sort(runnableApps, comparator);
 } finally {
   writeLock.unlock();
 }
 readLock.lock();
 try {
   for (FSAppAttempt sched : runnableApps) {
 if (SchedulerAppUtils.isBlacklisted(sched, node, LOG)) {
   continue;
 }
 assigned = sched.assignContainer(node);
 if (!assigned.equals(Resources.none())) {
   break;
 }
}
 } finally {
   readLock.unlock();
 }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-2945) FSLeafQueue#assignContainer - document the reason for using both write and read locks

2015-08-30 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14722709#comment-14722709
 ] 

Hudson commented on YARN-2945:
--

FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #313 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/313/])
YARN-2945. Fixing the CHANGES.txt to have the right JIRA number. (vinodkv: rev 
cf831565e8344523e1bd0eaf686ed56a2b48b920)
* hadoop-yarn-project/CHANGES.txt


 FSLeafQueue#assignContainer - document the reason for using both write and 
 read locks
 -

 Key: YARN-2945
 URL: https://issues.apache.org/jira/browse/YARN-2945
 Project: Hadoop YARN
  Issue Type: Bug
Reporter: Tsuyoshi Ozawa
Assignee: Tsuyoshi Ozawa
 Fix For: 2.7.0

 Attachments: YARN-2945.001.patch, YARN-2945.002.patch


 After YARN-2910, assignContainer hold WriteLock while sorting and ReadLock 
 while referencing runnableApps. This can cause interrupted assignment of 
 containers regardless of the policy.
 {code}
 writeLock.lock();
 try {
   Collections.sort(runnableApps, comparator);
 } finally {
   writeLock.unlock();
 }
 readLock.lock();
 try {
   for (FSAppAttempt sched : runnableApps) {
 if (SchedulerAppUtils.isBlacklisted(sched, node, LOG)) {
   continue;
 }
 assigned = sched.assignContainer(node);
 if (!assigned.equals(Resources.none())) {
   break;
 }
}
 } finally {
   readLock.unlock();
 }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-2945) FSLeafQueue#assignContainer - document the reason for using both write and read locks

2015-08-30 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14722841#comment-14722841
 ] 

Hudson commented on YARN-2945:
--

SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #322 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/322/])
YARN-2945. Fixing the CHANGES.txt to have the right JIRA number. (vinodkv: rev 
cf831565e8344523e1bd0eaf686ed56a2b48b920)
* hadoop-yarn-project/CHANGES.txt


 FSLeafQueue#assignContainer - document the reason for using both write and 
 read locks
 -

 Key: YARN-2945
 URL: https://issues.apache.org/jira/browse/YARN-2945
 Project: Hadoop YARN
  Issue Type: Bug
Reporter: Tsuyoshi Ozawa
Assignee: Tsuyoshi Ozawa
 Fix For: 2.7.0

 Attachments: YARN-2945.001.patch, YARN-2945.002.patch


 After YARN-2910, assignContainer hold WriteLock while sorting and ReadLock 
 while referencing runnableApps. This can cause interrupted assignment of 
 containers regardless of the policy.
 {code}
 writeLock.lock();
 try {
   Collections.sort(runnableApps, comparator);
 } finally {
   writeLock.unlock();
 }
 readLock.lock();
 try {
   for (FSAppAttempt sched : runnableApps) {
 if (SchedulerAppUtils.isBlacklisted(sched, node, LOG)) {
   continue;
 }
 assigned = sched.assignContainer(node);
 if (!assigned.equals(Resources.none())) {
   break;
 }
}
 } finally {
   readLock.unlock();
 }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-2945) FSLeafQueue#assignContainer - document the reason for using both write and read locks

2015-08-30 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14722839#comment-14722839
 ] 

Hudson commented on YARN-2945:
--

SUCCESS: Integrated in Hadoop-Yarn-trunk #1055 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/1055/])
YARN-2945. Fixing the CHANGES.txt to have the right JIRA number. (vinodkv: rev 
cf831565e8344523e1bd0eaf686ed56a2b48b920)
* hadoop-yarn-project/CHANGES.txt


 FSLeafQueue#assignContainer - document the reason for using both write and 
 read locks
 -

 Key: YARN-2945
 URL: https://issues.apache.org/jira/browse/YARN-2945
 Project: Hadoop YARN
  Issue Type: Bug
Reporter: Tsuyoshi Ozawa
Assignee: Tsuyoshi Ozawa
 Fix For: 2.7.0

 Attachments: YARN-2945.001.patch, YARN-2945.002.patch


 After YARN-2910, assignContainer hold WriteLock while sorting and ReadLock 
 while referencing runnableApps. This can cause interrupted assignment of 
 containers regardless of the policy.
 {code}
 writeLock.lock();
 try {
   Collections.sort(runnableApps, comparator);
 } finally {
   writeLock.unlock();
 }
 readLock.lock();
 try {
   for (FSAppAttempt sched : runnableApps) {
 if (SchedulerAppUtils.isBlacklisted(sched, node, LOG)) {
   continue;
 }
 assigned = sched.assignContainer(node);
 if (!assigned.equals(Resources.none())) {
   break;
 }
}
 } finally {
   readLock.unlock();
 }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-2945) FSLeafQueue#assignContainer - document the reason for using both write and read locks

2015-08-30 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14722303#comment-14722303
 ] 

Hudson commented on YARN-2945:
--

FAILURE: Integrated in Hadoop-Mapreduce-trunk #2271 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2271/])
YARN-2945. Fixing the CHANGES.txt to have the right JIRA number. (vinodkv: rev 
cf831565e8344523e1bd0eaf686ed56a2b48b920)
* hadoop-yarn-project/CHANGES.txt


 FSLeafQueue#assignContainer - document the reason for using both write and 
 read locks
 -

 Key: YARN-2945
 URL: https://issues.apache.org/jira/browse/YARN-2945
 Project: Hadoop YARN
  Issue Type: Bug
Reporter: Tsuyoshi Ozawa
Assignee: Tsuyoshi Ozawa
 Fix For: 2.7.0

 Attachments: YARN-2945.001.patch, YARN-2945.002.patch


 After YARN-2910, assignContainer hold WriteLock while sorting and ReadLock 
 while referencing runnableApps. This can cause interrupted assignment of 
 containers regardless of the policy.
 {code}
 writeLock.lock();
 try {
   Collections.sort(runnableApps, comparator);
 } finally {
   writeLock.unlock();
 }
 readLock.lock();
 try {
   for (FSAppAttempt sched : runnableApps) {
 if (SchedulerAppUtils.isBlacklisted(sched, node, LOG)) {
   continue;
 }
 assigned = sched.assignContainer(node);
 if (!assigned.equals(Resources.none())) {
   break;
 }
}
 } finally {
   readLock.unlock();
 }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-2945) FSLeafQueue#assignContainer - document the reason for using both write and read locks

2015-08-30 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14722713#comment-14722713
 ] 

Hudson commented on YARN-2945:
--

SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #328 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/328/])
YARN-2945. Fixing the CHANGES.txt to have the right JIRA number. (vinodkv: rev 
cf831565e8344523e1bd0eaf686ed56a2b48b920)
* hadoop-yarn-project/CHANGES.txt


 FSLeafQueue#assignContainer - document the reason for using both write and 
 read locks
 -

 Key: YARN-2945
 URL: https://issues.apache.org/jira/browse/YARN-2945
 Project: Hadoop YARN
  Issue Type: Bug
Reporter: Tsuyoshi Ozawa
Assignee: Tsuyoshi Ozawa
 Fix For: 2.7.0

 Attachments: YARN-2945.001.patch, YARN-2945.002.patch


 After YARN-2910, assignContainer hold WriteLock while sorting and ReadLock 
 while referencing runnableApps. This can cause interrupted assignment of 
 containers regardless of the policy.
 {code}
 writeLock.lock();
 try {
   Collections.sort(runnableApps, comparator);
 } finally {
   writeLock.unlock();
 }
 readLock.lock();
 try {
   for (FSAppAttempt sched : runnableApps) {
 if (SchedulerAppUtils.isBlacklisted(sched, node, LOG)) {
   continue;
 }
 assigned = sched.assignContainer(node);
 if (!assigned.equals(Resources.none())) {
   break;
 }
}
 } finally {
   readLock.unlock();
 }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)