[jira] [Commented] (YARN-3204) Fix new findbug warnings in hadoop-yarn-server-resourcemanager(resourcemanager.scheduler.fair)

2015-03-25 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380304#comment-14380304
 ] 

Hadoop QA commented on YARN-3204:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12702024/YARN-3204-003.patch
  against trunk revision c906a1d.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:red}-1 findbugs{color}.  The patch appears to introduce 1 new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/7104//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-YARN-Build/7104//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7104//console

This message is automatically generated.

 Fix new findbug warnings in 
 hadoop-yarn-server-resourcemanager(resourcemanager.scheduler.fair)
 --

 Key: YARN-3204
 URL: https://issues.apache.org/jira/browse/YARN-3204
 Project: Hadoop YARN
  Issue Type: Bug
Reporter: Brahma Reddy Battula
Assignee: Brahma Reddy Battula
Priority: Blocker
 Attachments: YARN-3204-001.patch, YARN-3204-002.patch, 
 YARN-3204-003.patch


 Please check following findbug report..
 https://builds.apache.org/job/PreCommit-YARN-Build/6644//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-3204) Fix new findbug warnings in hadoop-yarn-server-resourcemanager(resourcemanager.scheduler.fair)

2015-03-17 Thread zhihai xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14365821#comment-14365821
 ] 

zhihai xu commented on YARN-3204:
-

Some comments:
1. about the comment for Inconsistent sync warning fsOpDurations
{code}
Inconsistent sync warning - callDurationMetrics is only initialized once and 
never changed
{code}
It looks like not accurate. Each method from fsOpDurations is only called in 
one thread, all these methods access different fields and are independent.

2.Can we define reloadListener as volatile?
since reloadListener is accessed by two threads, it will be safer to use 
volatile.

3.Can we move the check to the beginning of the functions of reserveResource?
It will be better to check error earlier than later to avoid unnecessary 
operations.
{code}
if (!(application instanceof FSAppAttempt)) {
{code}
Can we use YarnRuntimeException instead of IllegalArgumentException?
This looks like an unexpected runtime exception.

4.adding lock for getAllocationConfiguration is dangerous.
A lot of codes(Queue, FairReservationSystem... ) are calling 
getAllocationConfiguration, which can introduce potential deadlock situation 
and performance issue.
For example, QueueManager#getQueue lock queues then call 
QueueManager#createQueue then call scheduler.getAllocationConfiguration.
This will have two layer locks if we add lock in getAllocationConfiguration.
Can we define allocConf as volatile?  since allocConf will only be updated by 
AllocationReloadListener.onReload which is called from 
AllocationFileLoaderService#reloadThread after initialization. 


 Fix new findbug warnings in 
 hadoop-yarn-server-resourcemanager(resourcemanager.scheduler.fair)
 --

 Key: YARN-3204
 URL: https://issues.apache.org/jira/browse/YARN-3204
 Project: Hadoop YARN
  Issue Type: Bug
Reporter: Brahma Reddy Battula
Assignee: Brahma Reddy Battula
Priority: Blocker
 Attachments: YARN-3204-001.patch, YARN-3204-002.patch, 
 YARN-3204-003.patch


 Please check following findbug report..
 https://builds.apache.org/job/PreCommit-YARN-Build/6644//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-3204) Fix new findbug warnings in hadoop-yarn-server-resourcemanager(resourcemanager.scheduler.fair)

2015-03-11 Thread Brahma Reddy Battula (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357353#comment-14357353
 ] 

Brahma Reddy Battula commented on YARN-3204:


Kindly  review if you find time ..thanks..

 Fix new findbug warnings in 
 hadoop-yarn-server-resourcemanager(resourcemanager.scheduler.fair)
 --

 Key: YARN-3204
 URL: https://issues.apache.org/jira/browse/YARN-3204
 Project: Hadoop YARN
  Issue Type: Bug
Reporter: Brahma Reddy Battula
Assignee: Brahma Reddy Battula
Priority: Blocker
 Attachments: YARN-3204-001.patch, YARN-3204-002.patch, 
 YARN-3204-003.patch


 Please check following findbug report..
 https://builds.apache.org/job/PreCommit-YARN-Build/6644//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-3204) Fix new findbug warnings in hadoop-yarn-server-resourcemanager(resourcemanager.scheduler.fair)

2015-03-02 Thread Brahma Reddy Battula (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344114#comment-14344114
 ] 

Brahma Reddy Battula commented on YARN-3204:


[~chengbing.liu] Thanks a lot for review..Addressed your comments and updated 
the patch..

 Fix new findbug warnings in 
 hadoop-yarn-server-resourcemanager(resourcemanager.scheduler.fair)
 --

 Key: YARN-3204
 URL: https://issues.apache.org/jira/browse/YARN-3204
 Project: Hadoop YARN
  Issue Type: Bug
Reporter: Brahma Reddy Battula
Assignee: Brahma Reddy Battula
 Attachments: YARN-3204-001.patch, YARN-3204-002.patch, 
 YARN-3204-003.patch


 Please check following findbug report..
 https://builds.apache.org/job/PreCommit-YARN-Build/6644//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-3204) Fix new findbug warnings in hadoop-yarn-server-resourcemanager(resourcemanager.scheduler.fair)

2015-03-02 Thread Karthik Kambatla (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344151#comment-14344151
 ] 

Karthik Kambatla commented on YARN-3204:


Thanks for working on this, [~brahmareddy]

I am surprised Jenkins didn't catch this on YARN-3181. We should be able to 
avoid the findbugs failures on FairScheduler through some code changes. 
findbugs-exclusions are easy to add, but very had to maintain. I would like to 
take a closer look at the list and see what is going on. Unfortunately, I am 
very caught up for the next couple of days. I hope it is okay if I get to this 
towards the end of the week. 

 Fix new findbug warnings in 
 hadoop-yarn-server-resourcemanager(resourcemanager.scheduler.fair)
 --

 Key: YARN-3204
 URL: https://issues.apache.org/jira/browse/YARN-3204
 Project: Hadoop YARN
  Issue Type: Bug
Reporter: Brahma Reddy Battula
Assignee: Brahma Reddy Battula
 Attachments: YARN-3204-001.patch, YARN-3204-002.patch, 
 YARN-3204-003.patch


 Please check following findbug report..
 https://builds.apache.org/job/PreCommit-YARN-Build/6644//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-3204) Fix new findbug warnings in hadoop-yarn-server-resourcemanager(resourcemanager.scheduler.fair)

2015-03-02 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344299#comment-14344299
 ] 

Hadoop QA commented on YARN-3204:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12702024/YARN-3204-003.patch
  against trunk revision c5eac9c.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

  org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/6811//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6811//console

This message is automatically generated.

 Fix new findbug warnings in 
 hadoop-yarn-server-resourcemanager(resourcemanager.scheduler.fair)
 --

 Key: YARN-3204
 URL: https://issues.apache.org/jira/browse/YARN-3204
 Project: Hadoop YARN
  Issue Type: Bug
Reporter: Brahma Reddy Battula
Assignee: Brahma Reddy Battula
 Attachments: YARN-3204-001.patch, YARN-3204-002.patch, 
 YARN-3204-003.patch


 Please check following findbug report..
 https://builds.apache.org/job/PreCommit-YARN-Build/6644//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-3204) Fix new findbug warnings in hadoop-yarn-server-resourcemanager(resourcemanager.scheduler.fair)

2015-02-26 Thread Chengbing Liu (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339811#comment-14339811
 ] 

Chengbing Liu commented on YARN-3204:
-

{code}
-this.reservedAppSchedulable = (FSAppAttempt) application;
+ if(application instanceof FSAppAttempt){
+   this.reservedAppSchedulable = (FSAppAttempt) application;
+}
{code}
Would it be better if we throw an exception if the condition is not met?

{code}
 SetString planQueues = new HashSetString();
 for (FSQueue fsQueue : queueMgr.getQueues()) {
   String queueName = fsQueue.getName();
-  if (allocConf.isReservable(queueName)) {
+  boolean isReservable = false;
+  synchronized(this){
+ isReservable = allocConf.isReservable(queueName);
+  }
+  if (isReservable) {
 planQueues.add(queueName);
   }
 }
{code}
I think we should synchronize the whole function, since {{allocConf}} may be 
reloaded during this loop. A dedicated lock is better than 
{{FairScheduler.this}} to me.

 Fix new findbug warnings in 
 hadoop-yarn-server-resourcemanager(resourcemanager.scheduler.fair)
 --

 Key: YARN-3204
 URL: https://issues.apache.org/jira/browse/YARN-3204
 Project: Hadoop YARN
  Issue Type: Bug
Reporter: Brahma Reddy Battula
Assignee: Brahma Reddy Battula
 Attachments: YARN-3204-001.patch, YARN-3204-002.patch


 Please check following findbug report..
 https://builds.apache.org/job/PreCommit-YARN-Build/6644//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)