[jira] [Commented] (YARN-3345) Add non-exclusive node label RMAdmin CLI/API
[ https://issues.apache.org/jira/browse/YARN-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372165#comment-14372165 ] Wangda Tan commented on YARN-3345: -- Failed tests are not related to this patch. > Add non-exclusive node label RMAdmin CLI/API > > > Key: YARN-3345 > URL: https://issues.apache.org/jira/browse/YARN-3345 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, client, resourcemanager >Reporter: Wangda Tan >Assignee: Wangda Tan > Attachments: YARN-3345.1.patch, YARN-3345.2.patch, YARN-3345.3.patch, > YARN-3345.4.patch, YARN-3345.5.patch, YARN-3345.6.patch > > > As described in YARN-3214 (see design doc attached to that JIRA), we need add > non-exclusive node label RMAdmin API and CLI implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3345) Add non-exclusive node label RMAdmin CLI/API
[ https://issues.apache.org/jira/browse/YARN-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14371835#comment-14371835 ] Hadoop QA commented on YARN-3345: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12705976/YARN-3345.6.patch against trunk revision 1561231. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 6 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.server.resourcemanager.TestRM org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7046//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7046//console This message is automatically generated. > Add non-exclusive node label RMAdmin CLI/API > > > Key: YARN-3345 > URL: https://issues.apache.org/jira/browse/YARN-3345 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, client, resourcemanager >Reporter: Wangda Tan >Assignee: Wangda Tan > Attachments: YARN-3345.1.patch, YARN-3345.2.patch, YARN-3345.3.patch, > YARN-3345.4.patch, YARN-3345.5.patch, YARN-3345.6.patch > > > As described in YARN-3214 (see design doc attached to that JIRA), we need add > non-exclusive node label RMAdmin API and CLI implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3345) Add non-exclusive node label RMAdmin CLI/API
[ https://issues.apache.org/jira/browse/YARN-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14371444#comment-14371444 ] Hadoop QA commented on YARN-3345: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12705763/YARN-3345.5.patch against trunk revision 8041267. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 6 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.api.TestPBImplRecords Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7041//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7041//console This message is automatically generated. > Add non-exclusive node label RMAdmin CLI/API > > > Key: YARN-3345 > URL: https://issues.apache.org/jira/browse/YARN-3345 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, client, resourcemanager >Reporter: Wangda Tan >Assignee: Wangda Tan > Attachments: YARN-3345.1.patch, YARN-3345.2.patch, YARN-3345.3.patch, > YARN-3345.4.patch, YARN-3345.5.patch > > > As described in YARN-3214 (see design doc attached to that JIRA), we need add > non-exclusive node label RMAdmin API and CLI implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3345) Add non-exclusive node label RMAdmin CLI/API
[ https://issues.apache.org/jira/browse/YARN-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370549#comment-14370549 ] Hadoop QA commented on YARN-3345: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12705763/YARN-3345.5.patch against trunk revision 91baca1. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 6 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 9 warning messages. See https://builds.apache.org/job/PreCommit-YARN-Build/7034//artifact/patchprocess/diffJavadocWarnings.txt for details. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.api.TestPBImplRecords Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7034//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7034//console This message is automatically generated. > Add non-exclusive node label RMAdmin CLI/API > > > Key: YARN-3345 > URL: https://issues.apache.org/jira/browse/YARN-3345 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, client, resourcemanager >Reporter: Wangda Tan >Assignee: Wangda Tan > Attachments: YARN-3345.1.patch, YARN-3345.2.patch, YARN-3345.3.patch, > YARN-3345.4.patch, YARN-3345.5.patch > > > As described in YARN-3214 (see design doc attached to that JIRA), we need add > non-exclusive node label RMAdmin API and CLI implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3345) Add non-exclusive node label RMAdmin CLI/API
[ https://issues.apache.org/jira/browse/YARN-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368089#comment-14368089 ] Jian He commented on YARN-3345: --- - public/unstable annotations for the newly added records, e.g. SetNodeLabelsAttributesRequest, NodeLabelAttributes#getAttributes,getNodeLabel - NodeLabelAttributes -> NodeLabel, so that AddToClusterNodeLabelsRequest can later on use the same data structure. - for node exclusiveness - I think we may use NodeLabel#(get/set)IsExclusive - “ an un existed node-label=%s” - “non-existing node-label” - throw YarnException instead of IOException - below code, how about user wants to set the attributes to be empty {code} if (attr.getAttributes().isEmpty()) { // simply ignore continue; } {code} - add a newInstance method in SetNodeLabelsAttributesResponse and use that {code} SetNodeLabelsAttributesResponse response = recordFactory.newRecordInstance(SetNodeLabelsAttributesResponse.class); {code} - revert RMNodeLabelsManager change > Add non-exclusive node label RMAdmin CLI/API > > > Key: YARN-3345 > URL: https://issues.apache.org/jira/browse/YARN-3345 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, client, resourcemanager >Reporter: Wangda Tan >Assignee: Wangda Tan > Attachments: YARN-3345.1.patch, YARN-3345.2.patch, YARN-3345.3.patch, > YARN-3345.4.patch > > > As described in YARN-3214 (see design doc attached to that JIRA), we need add > non-exclusive node label RMAdmin API and CLI implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3345) Add non-exclusive node label RMAdmin CLI/API
[ https://issues.apache.org/jira/browse/YARN-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366119#comment-14366119 ] Hadoop QA commented on YARN-3345: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12705175/YARN-3345.4.patch against trunk revision 968425e. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 5 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:red}-1 eclipse:eclipse{color}. The patch failed to build with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7002//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7002//console This message is automatically generated. > Add non-exclusive node label RMAdmin CLI/API > > > Key: YARN-3345 > URL: https://issues.apache.org/jira/browse/YARN-3345 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, client, resourcemanager >Reporter: Wangda Tan >Assignee: Wangda Tan > Attachments: YARN-3345.1.patch, YARN-3345.2.patch, YARN-3345.3.patch, > YARN-3345.4.patch > > > As described in YARN-3214 (see design doc attached to that JIRA), we need add > non-exclusive node label RMAdmin API and CLI implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3345) Add non-exclusive node label RMAdmin CLI/API
[ https://issues.apache.org/jira/browse/YARN-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14364076#comment-14364076 ] Hadoop QA commented on YARN-3345: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704866/YARN-3345.3.patch against trunk revision ce5de93. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 5 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:red}-1 findbugs{color}. The patch appears to introduce 5 new Findbugs (version 2.0.3) warnings. {color:red}-1 release audit{color}. The applied patch generated 1 release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.api.TestPBImplRecords Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6982//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6982//artifact/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6982//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6982//console This message is automatically generated. > Add non-exclusive node label RMAdmin CLI/API > > > Key: YARN-3345 > URL: https://issues.apache.org/jira/browse/YARN-3345 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, client, resourcemanager >Reporter: Wangda Tan >Assignee: Wangda Tan > Attachments: YARN-3345.1.patch, YARN-3345.2.patch, YARN-3345.3.patch > > > As described in YARN-3214 (see design doc attached to that JIRA), we need add > non-exclusive node label RMAdmin API and CLI implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3345) Add non-exclusive node label RMAdmin CLI/API
[ https://issues.apache.org/jira/browse/YARN-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363850#comment-14363850 ] Hadoop QA commented on YARN-3345: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704847/YARN-3345.2.patch against trunk revision ed4e72a. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 5 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:red}-1 findbugs{color}. The patch appears to introduce 5 new Findbugs (version 2.0.3) warnings. {color:red}-1 release audit{color}. The applied patch generated 1 release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.api.TestPBImplRecords Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6980//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6980//artifact/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6980//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6980//console This message is automatically generated. > Add non-exclusive node label RMAdmin CLI/API > > > Key: YARN-3345 > URL: https://issues.apache.org/jira/browse/YARN-3345 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, client, resourcemanager >Reporter: Wangda Tan >Assignee: Wangda Tan > Attachments: YARN-3345.1.patch, YARN-3345.2.patch > > > As described in YARN-3214 (see design doc attached to that JIRA), we need add > non-exclusive node label RMAdmin API and CLI implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3345) Add non-exclusive node label RMAdmin CLI/API
[ https://issues.apache.org/jira/browse/YARN-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361397#comment-14361397 ] Hadoop QA commented on YARN-3345: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704531/YARN-3345.1.patch against trunk revision 6fdef76. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 5 new or modified test files. {color:red}-1 javac{color}. The applied patch generated 1153 javac compiler warnings (more than the trunk's current 1152 warnings). {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:red}-1 findbugs{color}. The patch appears to introduce 8 new Findbugs (version 2.0.3) warnings. {color:red}-1 release audit{color}. The applied patch generated 1 release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.nodelabels.TestFileSystemNodeLabelsStore Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6959//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6959//artifact/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6959//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6959//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html Javac warnings: https://builds.apache.org/job/PreCommit-YARN-Build/6959//artifact/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6959//console This message is automatically generated. > Add non-exclusive node label RMAdmin CLI/API > > > Key: YARN-3345 > URL: https://issues.apache.org/jira/browse/YARN-3345 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, client, resourcemanager >Reporter: Wangda Tan >Assignee: Wangda Tan > Attachments: YARN-3345.1.patch > > > As described in YARN-3214 (see design doc attached to that JIRA), we need add > non-exclusive node label RMAdmin API and CLI implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)