[jira] [Commented] (YARN-3552) RMServerUtils#DUMMY_APPLICATION_RESOURCE_USAGE_REPORT has negative numbers

2015-04-29 Thread Rohith (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519096#comment-14519096
 ] 

Rohith commented on YARN-3552:
--

I think for UI dispaly 'N/A' is resonable, and REST we should keep existing 
behavior since it affect compatibility.

> RMServerUtils#DUMMY_APPLICATION_RESOURCE_USAGE_REPORT  has negative numbers
> ---
>
> Key: YARN-3552
> URL: https://issues.apache.org/jira/browse/YARN-3552
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: webapp
>Reporter: Rohith
>Assignee: Rohith
>Priority: Trivial
> Attachments: 0001-YARN-3552.patch, yarn-3352.PNG
>
>
> In the RMServerUtils, the default values are negative number which results in 
> the displayiing the RM web UI also negative number. 
> {code}
>   public static final ApplicationResourceUsageReport
> DUMMY_APPLICATION_RESOURCE_USAGE_REPORT =
>   BuilderUtils.newApplicationResourceUsageReport(-1, -1,
>   Resources.createResource(-1, -1), Resources.createResource(-1, -1),
>   Resources.createResource(-1, -1), 0, 0);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3552) RMServerUtils#DUMMY_APPLICATION_RESOURCE_USAGE_REPORT has negative numbers

2015-04-28 Thread Jason Lowe (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517146#comment-14517146
 ] 

Jason Lowe commented on YARN-3552:
--

This also appears in the REST service, so this is an API not just what humans 
see (and possibly screen-scraped by those that should have been using the REST 
API).  We could always translate the -1's into 'N/A' or "Unavailable' on the 
web UI, but changing the REST API is going to be trickier from a compatibility 
point of view.

> RMServerUtils#DUMMY_APPLICATION_RESOURCE_USAGE_REPORT  has negative numbers
> ---
>
> Key: YARN-3552
> URL: https://issues.apache.org/jira/browse/YARN-3552
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: webapp
>Reporter: Rohith
>Assignee: Rohith
>Priority: Trivial
> Attachments: 0001-YARN-3552.patch, yarn-3352.PNG
>
>
> In the RMServerUtils, the default values are negative number which results in 
> the displayiing the RM web UI also negative number. 
> {code}
>   public static final ApplicationResourceUsageReport
> DUMMY_APPLICATION_RESOURCE_USAGE_REPORT =
>   BuilderUtils.newApplicationResourceUsageReport(-1, -1,
>   Resources.createResource(-1, -1), Resources.createResource(-1, -1),
>   Resources.createResource(-1, -1), 0, 0);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3552) RMServerUtils#DUMMY_APPLICATION_RESOURCE_USAGE_REPORT has negative numbers

2015-04-28 Thread Rohith (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517094#comment-14517094
 ] 

Rohith commented on YARN-3552:
--

I agree to the internal logic, but concern is when the Application is finished 
the WebUI displays as -1 which I  feel this can be improved.

> RMServerUtils#DUMMY_APPLICATION_RESOURCE_USAGE_REPORT  has negative numbers
> ---
>
> Key: YARN-3552
> URL: https://issues.apache.org/jira/browse/YARN-3552
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: webapp
>Reporter: Rohith
>Assignee: Rohith
>Priority: Trivial
> Attachments: 0001-YARN-3552.patch, yarn-3352.PNG
>
>
> In the RMServerUtils, the default values are negative number which results in 
> the displayiing the RM web UI also negative number. 
> {code}
>   public static final ApplicationResourceUsageReport
> DUMMY_APPLICATION_RESOURCE_USAGE_REPORT =
>   BuilderUtils.newApplicationResourceUsageReport(-1, -1,
>   Resources.createResource(-1, -1), Resources.createResource(-1, -1),
>   Resources.createResource(-1, -1), 0, 0);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YARN-3552) RMServerUtils#DUMMY_APPLICATION_RESOURCE_USAGE_REPORT has negative numbers

2015-04-28 Thread Jason Lowe (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517030#comment-14517030
 ] 

Jason Lowe commented on YARN-3552:
--

I believe the negative numbers were to indicate that the value is not available 
or cannot be reported due to lack of authorization.  Changing these to zero 
changes the API and breaks anyone depending upon that behavior.

> RMServerUtils#DUMMY_APPLICATION_RESOURCE_USAGE_REPORT  has negative numbers
> ---
>
> Key: YARN-3552
> URL: https://issues.apache.org/jira/browse/YARN-3552
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: webapp
>Reporter: Rohith
>Assignee: Rohith
>Priority: Trivial
> Attachments: 0001-YARN-3552.patch, yarn-3352.PNG
>
>
> In the RMServerUtils, the default values are negative number which results in 
> the displayiing the RM web UI also negative number. 
> {code}
>   public static final ApplicationResourceUsageReport
> DUMMY_APPLICATION_RESOURCE_USAGE_REPORT =
>   BuilderUtils.newApplicationResourceUsageReport(-1, -1,
>   Resources.createResource(-1, -1), Resources.createResource(-1, -1),
>   Resources.createResource(-1, -1), 0, 0);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)