[jira] [Commented] (YARN-359) NodeManager container-related tests fail on branch-trunk-win
[
https://issues.apache.org/jira/browse/YARN-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13573116#comment-13573116
]
Bikas Saha commented on YARN-359:
-
The main reason for moving these to Shell was to reduce the number of places
where OS specific forks happen in code and limit all such behavior to the Shell
object that mainly performs OS dependent tasks that cannot be done in Java.
NodeManager container-related tests fail on branch-trunk-win
Key: YARN-359
URL: https://issues.apache.org/jira/browse/YARN-359
Project: Hadoop YARN
Issue Type: Bug
Components: nodemanager
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Attachments: YARN-359-branch-trunk-win.1.patch,
YARN-359-branch-trunk-win.2.patch
On branch-trunk-win, there are test failures in {{TestContainerManager}},
{{TestNodeManagerShutdown}}, {{TestContainerLaunch}}, and
{{TestContainersMonitor}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-359) NodeManager container-related tests fail on branch-trunk-win
[
https://issues.apache.org/jira/browse/YARN-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13573166#comment-13573166
]
Vinod Kumar Vavilapalli commented on YARN-359:
--
bq. The main reason for moving these to Shell was to reduce the number of
places where OS specific forks happen in code and limit all such behavior to
the Shell object that mainly performs OS dependent tasks that cannot be done in
Java.
Sure, I found only one usage and didn't see this arguments otherwise, so
suggested moving it out. As I mentioned, if we already have other uses, we can
promote it.
NodeManager container-related tests fail on branch-trunk-win
Key: YARN-359
URL: https://issues.apache.org/jira/browse/YARN-359
Project: Hadoop YARN
Issue Type: Bug
Components: nodemanager
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Attachments: YARN-359-branch-trunk-win.1.patch,
YARN-359-branch-trunk-win.2.patch
On branch-trunk-win, there are test failures in {{TestContainerManager}},
{{TestNodeManagerShutdown}}, {{TestContainerLaunch}}, and
{{TestContainersMonitor}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-359) NodeManager container-related tests fail on branch-trunk-win
[
https://issues.apache.org/jira/browse/YARN-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13573183#comment-13573183
]
Chris Nauroth commented on YARN-359:
Thanks for the commit.
Sorry, Bikas. I had forgotten the earlier discussion on YARN-233 when we chose
to place these methods in Shell, so I forgot to point this out to Vinod during
his review of this patch. We don't currently have other uses for these
methods. However, a potential argument for moving them back to Shell is that
if a need arises, then developers are far more likely to look in Shell for a
utility method than to remember to promote something out of the nodemanager
codebase.
I'd be happy to do more refactoring if you want to discuss further.
NodeManager container-related tests fail on branch-trunk-win
Key: YARN-359
URL: https://issues.apache.org/jira/browse/YARN-359
Project: Hadoop YARN
Issue Type: Bug
Components: nodemanager
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Attachments: YARN-359-branch-trunk-win.1.patch,
YARN-359-branch-trunk-win.2.patch
On branch-trunk-win, there are test failures in {{TestContainerManager}},
{{TestNodeManagerShutdown}}, {{TestContainerLaunch}}, and
{{TestContainersMonitor}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-359) NodeManager container-related tests fail on branch-trunk-win
[
https://issues.apache.org/jira/browse/YARN-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13571615#comment-13571615
]
Vinod Kumar Vavilapalli commented on YARN-359:
--
The logic for the patch is good.
If I follow correctly, YARN-233 moved {{isSetsidSupported()}} from
ContainerExecutor to shell and now this patch moves it back. I think we should
move the newly added methods in shell - {{getRunCommand()}},
{{getCheckProcessIsAliveCommand()}} and {{getSignalKillCommand()}} - into
ContainerExecutor. We can promote them later into common shell when need arises
- reduces affecting the public shell API.
NodeManager container-related tests fail on branch-trunk-win
Key: YARN-359
URL: https://issues.apache.org/jira/browse/YARN-359
Project: Hadoop YARN
Issue Type: Bug
Components: nodemanager
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Attachments: YARN-359-branch-trunk-win.1.patch
On branch-trunk-win, there are test failures in {{TestContainerManager}},
{{TestNodeManagerShutdown}}, {{TestContainerLaunch}}, and
{{TestContainersMonitor}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-359) NodeManager container-related tests fail on branch-trunk-win
[
https://issues.apache.org/jira/browse/YARN-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562914#comment-13562914
]
Chris Nauroth commented on YARN-359:
These test failures were found by a pre-commit build for HADOOP-8562. See
https://builds.apache.org/job/PreCommit-HADOOP-Build/2088//testReport/ . It
appears that something related to container launch and process management has a
problem on branch-trunk-win. I could not repro the test failures on Mac, but I
could repro them on Ubuntu.
NodeManager container-related tests fail on branch-trunk-win
Key: YARN-359
URL: https://issues.apache.org/jira/browse/YARN-359
Project: Hadoop YARN
Issue Type: Bug
Components: nodemanager
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
On branch-trunk-win, there are test failures in {{TestContainerManager}},
{{TestNodeManagerShutdown}}, {{TestContainerLaunch}}, and
{{TestContainersMonitor}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
