[jira] [Commented] (YARN-3609) Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case.
[ https://issues.apache.org/jira/browse/YARN-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554237#comment-14554237 ] Hudson commented on YARN-3609: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2132 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2132/]) YARN-3609. Load node labels from storage inside RM serviceStart. Contributed by Wangda Tan (jianhe: rev 8966d4217969eb71767ba83a3ff2b5bb38189b19) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/RMHATestBase.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMHAForNodeLabels.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case. Key: YARN-3609 URL: https://issues.apache.org/jira/browse/YARN-3609 Project: Hadoop YARN Issue Type: Sub-task Components: resourcemanager Reporter: Wangda Tan Assignee: Wangda Tan Fix For: 2.7.1 Attachments: YARN-3609.1.preliminary.patch, YARN-3609.2.patch, YARN-3609.3.branch-2.7.patch, YARN-3609.3.patch Now RMNodeLabelsManager loads label when serviceInit, but RMActiveService.start() is called when RM HA transition happens. We haven't done this before because queue's initialization happens in serviceInit as well, we need make sure labels added to system before init queue, after YARN-2918, we should be able to do this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3609) Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case.
[ https://issues.apache.org/jira/browse/YARN-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554154#comment-14554154 ] Hudson commented on YARN-3609: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #203 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/203/]) YARN-3609. Load node labels from storage inside RM serviceStart. Contributed by Wangda Tan (jianhe: rev 8966d4217969eb71767ba83a3ff2b5bb38189b19) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/RMHATestBase.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMHAForNodeLabels.java Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case. Key: YARN-3609 URL: https://issues.apache.org/jira/browse/YARN-3609 Project: Hadoop YARN Issue Type: Sub-task Components: resourcemanager Reporter: Wangda Tan Assignee: Wangda Tan Fix For: 2.7.1 Attachments: YARN-3609.1.preliminary.patch, YARN-3609.2.patch, YARN-3609.3.branch-2.7.patch, YARN-3609.3.patch Now RMNodeLabelsManager loads label when serviceInit, but RMActiveService.start() is called when RM HA transition happens. We haven't done this before because queue's initialization happens in serviceInit as well, we need make sure labels added to system before init queue, after YARN-2918, we should be able to do this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3609) Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case.
[ https://issues.apache.org/jira/browse/YARN-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554095#comment-14554095 ] Hudson commented on YARN-3609: -- FAILURE: Integrated in Hadoop-Yarn-trunk #934 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/934/]) YARN-3609. Load node labels from storage inside RM serviceStart. Contributed by Wangda Tan (jianhe: rev 8966d4217969eb71767ba83a3ff2b5bb38189b19) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/RMHATestBase.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMHAForNodeLabels.java * hadoop-yarn-project/CHANGES.txt Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case. Key: YARN-3609 URL: https://issues.apache.org/jira/browse/YARN-3609 Project: Hadoop YARN Issue Type: Sub-task Components: resourcemanager Reporter: Wangda Tan Assignee: Wangda Tan Fix For: 2.7.1 Attachments: YARN-3609.1.preliminary.patch, YARN-3609.2.patch, YARN-3609.3.branch-2.7.patch, YARN-3609.3.patch Now RMNodeLabelsManager loads label when serviceInit, but RMActiveService.start() is called when RM HA transition happens. We haven't done this before because queue's initialization happens in serviceInit as well, we need make sure labels added to system before init queue, after YARN-2918, we should be able to do this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3609) Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case.
[ https://issues.apache.org/jira/browse/YARN-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554356#comment-14554356 ] Hudson commented on YARN-3609: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #192 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/192/]) YARN-3609. Load node labels from storage inside RM serviceStart. Contributed by Wangda Tan (jianhe: rev 8966d4217969eb71767ba83a3ff2b5bb38189b19) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMHAForNodeLabels.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/RMHATestBase.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case. Key: YARN-3609 URL: https://issues.apache.org/jira/browse/YARN-3609 Project: Hadoop YARN Issue Type: Sub-task Components: resourcemanager Reporter: Wangda Tan Assignee: Wangda Tan Fix For: 2.7.1 Attachments: YARN-3609.1.preliminary.patch, YARN-3609.2.patch, YARN-3609.3.branch-2.7.patch, YARN-3609.3.patch Now RMNodeLabelsManager loads label when serviceInit, but RMActiveService.start() is called when RM HA transition happens. We haven't done this before because queue's initialization happens in serviceInit as well, we need make sure labels added to system before init queue, after YARN-2918, we should be able to do this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3609) Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case.
[ https://issues.apache.org/jira/browse/YARN-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554304#comment-14554304 ] Hudson commented on YARN-3609: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #202 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/202/]) YARN-3609. Load node labels from storage inside RM serviceStart. Contributed by Wangda Tan (jianhe: rev 8966d4217969eb71767ba83a3ff2b5bb38189b19) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/RMHATestBase.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMHAForNodeLabels.java Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case. Key: YARN-3609 URL: https://issues.apache.org/jira/browse/YARN-3609 Project: Hadoop YARN Issue Type: Sub-task Components: resourcemanager Reporter: Wangda Tan Assignee: Wangda Tan Fix For: 2.7.1 Attachments: YARN-3609.1.preliminary.patch, YARN-3609.2.patch, YARN-3609.3.branch-2.7.patch, YARN-3609.3.patch Now RMNodeLabelsManager loads label when serviceInit, but RMActiveService.start() is called when RM HA transition happens. We haven't done this before because queue's initialization happens in serviceInit as well, we need make sure labels added to system before init queue, after YARN-2918, we should be able to do this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3609) Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case.
[ https://issues.apache.org/jira/browse/YARN-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554558#comment-14554558 ] Hudson commented on YARN-3609: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2150 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2150/]) YARN-3609. Load node labels from storage inside RM serviceStart. Contributed by Wangda Tan (jianhe: rev 8966d4217969eb71767ba83a3ff2b5bb38189b19) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/RMHATestBase.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMHAForNodeLabels.java Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case. Key: YARN-3609 URL: https://issues.apache.org/jira/browse/YARN-3609 Project: Hadoop YARN Issue Type: Sub-task Components: resourcemanager Reporter: Wangda Tan Assignee: Wangda Tan Fix For: 2.7.1 Attachments: YARN-3609.1.preliminary.patch, YARN-3609.2.patch, YARN-3609.3.branch-2.7.patch, YARN-3609.3.patch Now RMNodeLabelsManager loads label when serviceInit, but RMActiveService.start() is called when RM HA transition happens. We haven't done this before because queue's initialization happens in serviceInit as well, we need make sure labels added to system before init queue, after YARN-2918, we should be able to do this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3609) Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case.
[ https://issues.apache.org/jira/browse/YARN-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553377#comment-14553377 ] Hadoop QA commented on YARN-3609: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | patch | 0m 0s | The patch command could not apply the patch during dryrun. | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12734279/YARN-3609.3.branch-2.7.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 8966d42 | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8035/console | This message was automatically generated. Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case. Key: YARN-3609 URL: https://issues.apache.org/jira/browse/YARN-3609 Project: Hadoop YARN Issue Type: Sub-task Components: resourcemanager Reporter: Wangda Tan Assignee: Wangda Tan Attachments: YARN-3609.1.preliminary.patch, YARN-3609.2.patch, YARN-3609.3.branch-2.7.patch, YARN-3609.3.patch Now RMNodeLabelsManager loads label when serviceInit, but RMActiveService.start() is called when RM HA transition happens. We haven't done this before because queue's initialization happens in serviceInit as well, we need make sure labels added to system before init queue, after YARN-2918, we should be able to do this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3609) Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case.
[ https://issues.apache.org/jira/browse/YARN-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553359#comment-14553359 ] Hudson commented on YARN-3609: -- FAILURE: Integrated in Hadoop-trunk-Commit #7876 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7876/]) YARN-3609. Load node labels from storage inside RM serviceStart. Contributed by Wangda Tan (jianhe: rev 8966d4217969eb71767ba83a3ff2b5bb38189b19) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestFileSystemNodeLabelsStore.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/RMHATestBase.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMHAForNodeLabels.java Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case. Key: YARN-3609 URL: https://issues.apache.org/jira/browse/YARN-3609 Project: Hadoop YARN Issue Type: Sub-task Components: resourcemanager Reporter: Wangda Tan Assignee: Wangda Tan Attachments: YARN-3609.1.preliminary.patch, YARN-3609.2.patch, YARN-3609.3.patch Now RMNodeLabelsManager loads label when serviceInit, but RMActiveService.start() is called when RM HA transition happens. We haven't done this before because queue's initialization happens in serviceInit as well, we need make sure labels added to system before init queue, after YARN-2918, we should be able to do this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3609) Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case.
[ https://issues.apache.org/jira/browse/YARN-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14551428#comment-14551428 ] Wangda Tan commented on YARN-3609: -- Findbugs warning is tracked by: https://issues.apache.org/jira/browse/YARN-3667 Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case. Key: YARN-3609 URL: https://issues.apache.org/jira/browse/YARN-3609 Project: Hadoop YARN Issue Type: Sub-task Components: resourcemanager Reporter: Wangda Tan Assignee: Wangda Tan Attachments: YARN-3609.1.preliminary.patch, YARN-3609.2.patch, YARN-3609.3.patch Now RMNodeLabelsManager loads label when serviceInit, but RMActiveService.start() is called when RM HA transition happens. We haven't done this before because queue's initialization happens in serviceInit as well, we need make sure labels added to system before init queue, after YARN-2918, we should be able to do this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3609) Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case.
[ https://issues.apache.org/jira/browse/YARN-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14546262#comment-14546262 ] Hadoop QA commented on YARN-3609: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 14m 58s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 4 new or modified test files. | | {color:green}+1{color} | javac | 7m 42s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 45s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 1m 38s | There were no new checkstyle issues. | | {color:red}-1{color} | whitespace | 0m 0s | The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. | | {color:green}+1{color} | install | 1m 35s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with eclipse:eclipse. | | {color:red}-1{color} | findbugs | 2m 44s | The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. | | {color:green}+1{color} | yarn tests | 1m 58s | Tests passed in hadoop-yarn-common. | | {color:green}+1{color} | yarn tests | 50m 25s | Tests passed in hadoop-yarn-server-resourcemanager. | | | | 91m 45s | | \\ \\ || Reason || Tests || | FindBugs | module:hadoop-yarn-server-resourcemanager | | | Inconsistent synchronization of org.apache.hadoop.yarn.server.resourcemanager.recovery.FileSystemRMStateStore.isHDFS; locked 66% of time Unsynchronized access at FileSystemRMStateStore.java:66% of time Unsynchronized access at FileSystemRMStateStore.java:[line 156] | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12733214/YARN-3609.3.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 03a293a | | whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/7951/artifact/patchprocess/whitespace.txt | | Findbugs warnings | https://builds.apache.org/job/PreCommit-YARN-Build/7951/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html | | hadoop-yarn-common test log | https://builds.apache.org/job/PreCommit-YARN-Build/7951/artifact/patchprocess/testrun_hadoop-yarn-common.txt | | hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/7951/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/7951/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/7951/console | This message was automatically generated. Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case. Key: YARN-3609 URL: https://issues.apache.org/jira/browse/YARN-3609 Project: Hadoop YARN Issue Type: Sub-task Components: resourcemanager Reporter: Wangda Tan Assignee: Wangda Tan Attachments: YARN-3609.1.preliminary.patch, YARN-3609.2.patch, YARN-3609.3.patch Now RMNodeLabelsManager loads label when serviceInit, but RMActiveService.start() is called when RM HA transition happens. We haven't done this before because queue's initialization happens in serviceInit as well, we need make sure labels added to system before init queue, after YARN-2918, we should be able to do this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3609) Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case.
[ https://issues.apache.org/jira/browse/YARN-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14546132#comment-14546132 ] Hadoop QA commented on YARN-3609: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 15m 5s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 4 new or modified test files. | | {color:green}+1{color} | javac | 7m 33s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 32s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 1m 36s | There were no new checkstyle issues. | | {color:red}-1{color} | whitespace | 0m 0s | The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. | | {color:green}+1{color} | install | 1m 34s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:red}-1{color} | findbugs | 2m 47s | The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. | | {color:green}+1{color} | yarn tests | 1m 58s | Tests passed in hadoop-yarn-common. | | {color:red}-1{color} | yarn tests | 46m 34s | Tests failed in hadoop-yarn-server-resourcemanager. | | | | 87m 40s | | \\ \\ || Reason || Tests || | FindBugs | module:hadoop-yarn-server-resourcemanager | | | Inconsistent synchronization of org.apache.hadoop.yarn.server.resourcemanager.recovery.FileSystemRMStateStore.isHDFS; locked 66% of time Unsynchronized access at FileSystemRMStateStore.java:66% of time Unsynchronized access at FileSystemRMStateStore.java:[line 156] | | Failed unit tests | hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices | | | hadoop.yarn.server.resourcemanager.TestRMRestart | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12733214/YARN-3609.3.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 03a293a | | whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/7950/artifact/patchprocess/whitespace.txt | | Findbugs warnings | https://builds.apache.org/job/PreCommit-YARN-Build/7950/artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html | | hadoop-yarn-common test log | https://builds.apache.org/job/PreCommit-YARN-Build/7950/artifact/patchprocess/testrun_hadoop-yarn-common.txt | | hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/7950/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/7950/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/7950/console | This message was automatically generated. Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case. Key: YARN-3609 URL: https://issues.apache.org/jira/browse/YARN-3609 Project: Hadoop YARN Issue Type: Sub-task Components: resourcemanager Reporter: Wangda Tan Assignee: Wangda Tan Attachments: YARN-3609.1.preliminary.patch, YARN-3609.2.patch, YARN-3609.3.patch Now RMNodeLabelsManager loads label when serviceInit, but RMActiveService.start() is called when RM HA transition happens. We haven't done this before because queue's initialization happens in serviceInit as well, we need make sure labels added to system before init queue, after YARN-2918, we should be able to do this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3609) Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case.
[ https://issues.apache.org/jira/browse/YARN-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14544224#comment-14544224 ] Hadoop QA commented on YARN-3609: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 14m 39s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 4 new or modified test files. | | {color:green}+1{color} | javac | 7m 33s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 35s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 1m 40s | There were no new checkstyle issues. | | {color:red}-1{color} | whitespace | 0m 0s | The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix. | | {color:green}+1{color} | install | 1m 32s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 2m 38s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. | | {color:green}+1{color} | yarn tests | 1m 58s | Tests passed in hadoop-yarn-common. | | {color:red}-1{color} | yarn tests | 49m 52s | Tests failed in hadoop-yarn-server-resourcemanager. | | | | 90m 27s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.yarn.server.resourcemanager.TestClientRMService | | | hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesNodeLabels | | | hadoop.yarn.server.resourcemanager.TestRMAdminService | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12732908/YARN-3609.2.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 15ccd96 | | whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/7937/artifact/patchprocess/whitespace.txt | | hadoop-yarn-common test log | https://builds.apache.org/job/PreCommit-YARN-Build/7937/artifact/patchprocess/testrun_hadoop-yarn-common.txt | | hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/7937/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/7937/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/7937/console | This message was automatically generated. Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case. Key: YARN-3609 URL: https://issues.apache.org/jira/browse/YARN-3609 Project: Hadoop YARN Issue Type: Sub-task Components: resourcemanager Reporter: Wangda Tan Assignee: Wangda Tan Attachments: YARN-3609.1.preliminary.patch, YARN-3609.2.patch Now RMNodeLabelsManager loads label when serviceInit, but RMActiveService.start() is called when RM HA transition happens. We haven't done this before because queue's initialization happens in serviceInit as well, we need make sure labels added to system before init queue, after YARN-2918, we should be able to do this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3609) Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case.
[ https://issues.apache.org/jira/browse/YARN-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543047#comment-14543047 ] Hadoop QA commented on YARN-3609: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 14m 41s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | | {color:green}+1{color} | javac | 7m 33s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 36s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 0m 56s | There were no new checkstyle issues. | | {color:red}-1{color} | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. | | {color:green}+1{color} | install | 1m 34s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 24s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. | | {color:red}-1{color} | yarn tests | 1m 55s | Tests failed in hadoop-yarn-common. | | | | 38m 39s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.yarn.nodelabels.TestFileSystemNodeLabelsStore | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12732729/YARN-3609.1.preliminary.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 0e85044 | | whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/7930/artifact/patchprocess/whitespace.txt | | hadoop-yarn-common test log | https://builds.apache.org/job/PreCommit-YARN-Build/7930/artifact/patchprocess/testrun_hadoop-yarn-common.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/7930/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/7930/console | This message was automatically generated. Move load labels from storage from serviceInit to serviceStart to make it works with RM HA case. Key: YARN-3609 URL: https://issues.apache.org/jira/browse/YARN-3609 Project: Hadoop YARN Issue Type: Sub-task Components: resourcemanager Reporter: Wangda Tan Assignee: Wangda Tan Attachments: YARN-3609.1.preliminary.patch Now RMNodeLabelsManager loads label when serviceInit, but RMActiveService.start() is called when RM HA transition happens. We haven't done this before because queue's initialization happens in serviceInit as well, we need make sure labels added to system before init queue, after YARN-2918, we should be able to do this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)