[jira] [Commented] (YARN-3629) NodeID is always printed as null in node manager initialization log.
[ https://issues.apache.org/jira/browse/YARN-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541802#comment-14541802 ] Hudson commented on YARN-3629: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #926 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/926/]) YARN-3629. NodeID is always printed as null in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java NodeID is always printed as null in node manager initialization log. -- Key: YARN-3629 URL: https://issues.apache.org/jira/browse/YARN-3629 Project: Hadoop YARN Issue Type: Bug Reporter: nijel Assignee: nijel Fix For: 2.8.0 Attachments: YARN-3629-1.patch In Node manager log during startup the following logs is printed 2015-05-12 11:20:02,347 INFO org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl: Initialized nodemanager for *null* : physical-memory=4096 virtual-memory=8602 virtual-cores=8 This line is printed from NodeStatusUpdaterImpl.serviceInit. But the nodeid assignment is happening only in NodeStatusUpdaterImpl.serviceStart {code} protected void serviceStart() throws Exception { // NodeManager is the last service to start, so NodeId is available. this.nodeId = this.context.getNodeId(); {code} Assigning the node id in serviceinit is not feasible since it is generated by ContainerManagerImpl.serviceStart. The log can be moved to service start to give right information to user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3629) NodeID is always printed as null in node manager initialization log.
[ https://issues.apache.org/jira/browse/YARN-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541780#comment-14541780 ] Hudson commented on YARN-3629: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #195 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/195/]) YARN-3629. NodeID is always printed as null in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java NodeID is always printed as null in node manager initialization log. -- Key: YARN-3629 URL: https://issues.apache.org/jira/browse/YARN-3629 Project: Hadoop YARN Issue Type: Bug Reporter: nijel Assignee: nijel Fix For: 2.8.0 Attachments: YARN-3629-1.patch In Node manager log during startup the following logs is printed 2015-05-12 11:20:02,347 INFO org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl: Initialized nodemanager for *null* : physical-memory=4096 virtual-memory=8602 virtual-cores=8 This line is printed from NodeStatusUpdaterImpl.serviceInit. But the nodeid assignment is happening only in NodeStatusUpdaterImpl.serviceStart {code} protected void serviceStart() throws Exception { // NodeManager is the last service to start, so NodeId is available. this.nodeId = this.context.getNodeId(); {code} Assigning the node id in serviceinit is not feasible since it is generated by ContainerManagerImpl.serviceStart. The log can be moved to service start to give right information to user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3629) NodeID is always printed as null in node manager initialization log.
[ https://issues.apache.org/jira/browse/YARN-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541980#comment-14541980 ] Hudson commented on YARN-3629: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2124 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2124/]) YARN-3629. NodeID is always printed as null in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java * hadoop-yarn-project/CHANGES.txt NodeID is always printed as null in node manager initialization log. -- Key: YARN-3629 URL: https://issues.apache.org/jira/browse/YARN-3629 Project: Hadoop YARN Issue Type: Bug Reporter: nijel Assignee: nijel Fix For: 2.8.0 Attachments: YARN-3629-1.patch In Node manager log during startup the following logs is printed 2015-05-12 11:20:02,347 INFO org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl: Initialized nodemanager for *null* : physical-memory=4096 virtual-memory=8602 virtual-cores=8 This line is printed from NodeStatusUpdaterImpl.serviceInit. But the nodeid assignment is happening only in NodeStatusUpdaterImpl.serviceStart {code} protected void serviceStart() throws Exception { // NodeManager is the last service to start, so NodeId is available. this.nodeId = this.context.getNodeId(); {code} Assigning the node id in serviceinit is not feasible since it is generated by ContainerManagerImpl.serviceStart. The log can be moved to service start to give right information to user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3629) NodeID is always printed as null in node manager initialization log.
[ https://issues.apache.org/jira/browse/YARN-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541999#comment-14541999 ] Hudson commented on YARN-3629: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #184 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/184/]) YARN-3629. NodeID is always printed as null in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java * hadoop-yarn-project/CHANGES.txt NodeID is always printed as null in node manager initialization log. -- Key: YARN-3629 URL: https://issues.apache.org/jira/browse/YARN-3629 Project: Hadoop YARN Issue Type: Bug Reporter: nijel Assignee: nijel Fix For: 2.8.0 Attachments: YARN-3629-1.patch In Node manager log during startup the following logs is printed 2015-05-12 11:20:02,347 INFO org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl: Initialized nodemanager for *null* : physical-memory=4096 virtual-memory=8602 virtual-cores=8 This line is printed from NodeStatusUpdaterImpl.serviceInit. But the nodeid assignment is happening only in NodeStatusUpdaterImpl.serviceStart {code} protected void serviceStart() throws Exception { // NodeManager is the last service to start, so NodeId is available. this.nodeId = this.context.getNodeId(); {code} Assigning the node id in serviceinit is not feasible since it is generated by ContainerManagerImpl.serviceStart. The log can be moved to service start to give right information to user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3629) NodeID is always printed as null in node manager initialization log.
[ https://issues.apache.org/jira/browse/YARN-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542164#comment-14542164 ] Hudson commented on YARN-3629: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2142 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2142/]) YARN-3629. NodeID is always printed as null in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java * hadoop-yarn-project/CHANGES.txt NodeID is always printed as null in node manager initialization log. -- Key: YARN-3629 URL: https://issues.apache.org/jira/browse/YARN-3629 Project: Hadoop YARN Issue Type: Bug Reporter: nijel Assignee: nijel Fix For: 2.8.0 Attachments: YARN-3629-1.patch In Node manager log during startup the following logs is printed 2015-05-12 11:20:02,347 INFO org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl: Initialized nodemanager for *null* : physical-memory=4096 virtual-memory=8602 virtual-cores=8 This line is printed from NodeStatusUpdaterImpl.serviceInit. But the nodeid assignment is happening only in NodeStatusUpdaterImpl.serviceStart {code} protected void serviceStart() throws Exception { // NodeManager is the last service to start, so NodeId is available. this.nodeId = this.context.getNodeId(); {code} Assigning the node id in serviceinit is not feasible since it is generated by ContainerManagerImpl.serviceStart. The log can be moved to service start to give right information to user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3629) NodeID is always printed as null in node manager initialization log.
[ https://issues.apache.org/jira/browse/YARN-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542119#comment-14542119 ] Hudson commented on YARN-3629: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #194 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/194/]) YARN-3629. NodeID is always printed as null in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java NodeID is always printed as null in node manager initialization log. -- Key: YARN-3629 URL: https://issues.apache.org/jira/browse/YARN-3629 Project: Hadoop YARN Issue Type: Bug Reporter: nijel Assignee: nijel Fix For: 2.8.0 Attachments: YARN-3629-1.patch In Node manager log during startup the following logs is printed 2015-05-12 11:20:02,347 INFO org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl: Initialized nodemanager for *null* : physical-memory=4096 virtual-memory=8602 virtual-cores=8 This line is printed from NodeStatusUpdaterImpl.serviceInit. But the nodeid assignment is happening only in NodeStatusUpdaterImpl.serviceStart {code} protected void serviceStart() throws Exception { // NodeManager is the last service to start, so NodeId is available. this.nodeId = this.context.getNodeId(); {code} Assigning the node id in serviceinit is not feasible since it is generated by ContainerManagerImpl.serviceStart. The log can be moved to service start to give right information to user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3629) NodeID is always printed as null in node manager initialization log.
[ https://issues.apache.org/jira/browse/YARN-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539495#comment-14539495 ] nijel commented on YARN-3629: - Moving the logs message is bit tricky since it logs some parameters which is not available in serviceStart. So keeping this log as it is Adding a new log message to print the nodeid for information purpose Any different thought ? NodeID is always printed as null in node manager initialization log. -- Key: YARN-3629 URL: https://issues.apache.org/jira/browse/YARN-3629 Project: Hadoop YARN Issue Type: Bug Reporter: nijel Assignee: nijel Attachments: YARN-3629-1.patch In Node manager log during startup the following logs is printed 2015-05-12 11:20:02,347 INFO org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl: Initialized nodemanager for *null* : physical-memory=4096 virtual-memory=8602 virtual-cores=8 This line is printed from NodeStatusUpdaterImpl.serviceInit. But the nodeid assignment is happening only in NodeStatusUpdaterImpl.serviceStart {code} protected void serviceStart() throws Exception { // NodeManager is the last service to start, so NodeId is available. this.nodeId = this.context.getNodeId(); {code} Assigning the node id in serviceinit is not feasible since it is generated by ContainerManagerImpl.serviceStart. The log can be moved to service start to give right information to user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3629) NodeID is always printed as null in node manager initialization log.
[ https://issues.apache.org/jira/browse/YARN-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14540225#comment-14540225 ] Hudson commented on YARN-3629: -- FAILURE: Integrated in Hadoop-trunk-Commit #7807 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7807/]) YARN-3629. NodeID is always printed as null in node manager (devaraj: rev 5c2f05cd9bad9bf9beb0f4ca18f4ae1bc3e84499) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java NodeID is always printed as null in node manager initialization log. -- Key: YARN-3629 URL: https://issues.apache.org/jira/browse/YARN-3629 Project: Hadoop YARN Issue Type: Bug Reporter: nijel Assignee: nijel Fix For: 2.8.0 Attachments: YARN-3629-1.patch In Node manager log during startup the following logs is printed 2015-05-12 11:20:02,347 INFO org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl: Initialized nodemanager for *null* : physical-memory=4096 virtual-memory=8602 virtual-cores=8 This line is printed from NodeStatusUpdaterImpl.serviceInit. But the nodeid assignment is happening only in NodeStatusUpdaterImpl.serviceStart {code} protected void serviceStart() throws Exception { // NodeManager is the last service to start, so NodeId is available. this.nodeId = this.context.getNodeId(); {code} Assigning the node id in serviceinit is not feasible since it is generated by ContainerManagerImpl.serviceStart. The log can be moved to service start to give right information to user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3629) NodeID is always printed as null in node manager initialization log.
[ https://issues.apache.org/jira/browse/YARN-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541225#comment-14541225 ] nijel commented on YARN-3629: - Thanks [~devaraj.k] for the reviewing and committing the patch NodeID is always printed as null in node manager initialization log. -- Key: YARN-3629 URL: https://issues.apache.org/jira/browse/YARN-3629 Project: Hadoop YARN Issue Type: Bug Reporter: nijel Assignee: nijel Fix For: 2.8.0 Attachments: YARN-3629-1.patch In Node manager log during startup the following logs is printed 2015-05-12 11:20:02,347 INFO org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl: Initialized nodemanager for *null* : physical-memory=4096 virtual-memory=8602 virtual-cores=8 This line is printed from NodeStatusUpdaterImpl.serviceInit. But the nodeid assignment is happening only in NodeStatusUpdaterImpl.serviceStart {code} protected void serviceStart() throws Exception { // NodeManager is the last service to start, so NodeId is available. this.nodeId = this.context.getNodeId(); {code} Assigning the node id in serviceinit is not feasible since it is generated by ContainerManagerImpl.serviceStart. The log can be moved to service start to give right information to user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3629) NodeID is always printed as null in node manager initialization log.
[ https://issues.apache.org/jira/browse/YARN-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539566#comment-14539566 ] Hadoop QA commented on YARN-3629: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 14m 43s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | | {color:green}+1{color} | javac | 7m 34s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 40s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 0m 38s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 33s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 2s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. | | {color:green}+1{color} | yarn tests | 6m 0s | Tests passed in hadoop-yarn-server-nodemanager. | | | | 42m 9s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12732192/YARN-3629-1.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 360dff5 | | hadoop-yarn-server-nodemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/7881/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/7881/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/7881/console | This message was automatically generated. NodeID is always printed as null in node manager initialization log. -- Key: YARN-3629 URL: https://issues.apache.org/jira/browse/YARN-3629 Project: Hadoop YARN Issue Type: Bug Reporter: nijel Assignee: nijel Attachments: YARN-3629-1.patch In Node manager log during startup the following logs is printed 2015-05-12 11:20:02,347 INFO org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl: Initialized nodemanager for *null* : physical-memory=4096 virtual-memory=8602 virtual-cores=8 This line is printed from NodeStatusUpdaterImpl.serviceInit. But the nodeid assignment is happening only in NodeStatusUpdaterImpl.serviceStart {code} protected void serviceStart() throws Exception { // NodeManager is the last service to start, so NodeId is available. this.nodeId = this.context.getNodeId(); {code} Assigning the node id in serviceinit is not feasible since it is generated by ContainerManagerImpl.serviceStart. The log can be moved to service start to give right information to user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3629) NodeID is always printed as null in node manager initialization log.
[ https://issues.apache.org/jira/browse/YARN-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539788#comment-14539788 ] nijel commented on YARN-3629: - bq.-1 tests included This is a log message change. So tests are not required NodeID is always printed as null in node manager initialization log. -- Key: YARN-3629 URL: https://issues.apache.org/jira/browse/YARN-3629 Project: Hadoop YARN Issue Type: Bug Reporter: nijel Assignee: nijel Attachments: YARN-3629-1.patch In Node manager log during startup the following logs is printed 2015-05-12 11:20:02,347 INFO org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl: Initialized nodemanager for *null* : physical-memory=4096 virtual-memory=8602 virtual-cores=8 This line is printed from NodeStatusUpdaterImpl.serviceInit. But the nodeid assignment is happening only in NodeStatusUpdaterImpl.serviceStart {code} protected void serviceStart() throws Exception { // NodeManager is the last service to start, so NodeId is available. this.nodeId = this.context.getNodeId(); {code} Assigning the node id in serviceinit is not feasible since it is generated by ContainerManagerImpl.serviceStart. The log can be moved to service start to give right information to user. -- This message was sent by Atlassian JIRA (v6.3.4#6332)