[jira] [Commented] (YARN-3987) am container complete msg ack to NM once RM receive it
[ https://issues.apache.org/jira/browse/YARN-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697063#comment-14697063 ] Hudson commented on YARN-3987: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2233 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2233/]) YARN-3987. Send AM container completed msg to NM once AM finishes. Contributed by sandflee (jianhe: rev 0a030546e24c55662a603bb63c9029ad0ccf43fc) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java am container complete msg ack to NM once RM receive it -- Key: YARN-3987 URL: https://issues.apache.org/jira/browse/YARN-3987 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Reporter: sandflee Assignee: sandflee Fix For: 2.8.0 Attachments: YARN-3987.001.patch, YARN-3987.002.patch In our cluster we set max-am-attempts to a very very large num, and unfortunately our am crash after launched, leaving too many completed container(AM container) in NM. completed container is removed from NM and NMStateStore only if container complete is passed to AM, but if AM couldn't be launched, the completed AM container couldn't be cleaned, and may eat up NM heap memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3987) am container complete msg ack to NM once RM receive it
[ https://issues.apache.org/jira/browse/YARN-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697040#comment-14697040 ] Hudson commented on YARN-3987: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #284 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/284/]) YARN-3987. Send AM container completed msg to NM once AM finishes. Contributed by sandflee (jianhe: rev 0a030546e24c55662a603bb63c9029ad0ccf43fc) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java am container complete msg ack to NM once RM receive it -- Key: YARN-3987 URL: https://issues.apache.org/jira/browse/YARN-3987 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Reporter: sandflee Assignee: sandflee Fix For: 2.8.0 Attachments: YARN-3987.001.patch, YARN-3987.002.patch In our cluster we set max-am-attempts to a very very large num, and unfortunately our am crash after launched, leaving too many completed container(AM container) in NM. completed container is removed from NM and NMStateStore only if container complete is passed to AM, but if AM couldn't be launched, the completed AM container couldn't be cleaned, and may eat up NM heap memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3987) am container complete msg ack to NM once RM receive it
[ https://issues.apache.org/jira/browse/YARN-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697120#comment-14697120 ] Hudson commented on YARN-3987: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2214 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2214/]) YARN-3987. Send AM container completed msg to NM once AM finishes. Contributed by sandflee (jianhe: rev 0a030546e24c55662a603bb63c9029ad0ccf43fc) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java am container complete msg ack to NM once RM receive it -- Key: YARN-3987 URL: https://issues.apache.org/jira/browse/YARN-3987 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Reporter: sandflee Assignee: sandflee Fix For: 2.8.0 Attachments: YARN-3987.001.patch, YARN-3987.002.patch In our cluster we set max-am-attempts to a very very large num, and unfortunately our am crash after launched, leaving too many completed container(AM container) in NM. completed container is removed from NM and NMStateStore only if container complete is passed to AM, but if AM couldn't be launched, the completed AM container couldn't be cleaned, and may eat up NM heap memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3987) am container complete msg ack to NM once RM receive it
[ https://issues.apache.org/jira/browse/YARN-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697142#comment-14697142 ] Hudson commented on YARN-3987: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #276 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/276/]) YARN-3987. Send AM container completed msg to NM once AM finishes. Contributed by sandflee (jianhe: rev 0a030546e24c55662a603bb63c9029ad0ccf43fc) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java * hadoop-yarn-project/CHANGES.txt am container complete msg ack to NM once RM receive it -- Key: YARN-3987 URL: https://issues.apache.org/jira/browse/YARN-3987 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Reporter: sandflee Assignee: sandflee Fix For: 2.8.0 Attachments: YARN-3987.001.patch, YARN-3987.002.patch In our cluster we set max-am-attempts to a very very large num, and unfortunately our am crash after launched, leaving too many completed container(AM container) in NM. completed container is removed from NM and NMStateStore only if container complete is passed to AM, but if AM couldn't be launched, the completed AM container couldn't be cleaned, and may eat up NM heap memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3987) am container complete msg ack to NM once RM receive it
[ https://issues.apache.org/jira/browse/YARN-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696825#comment-14696825 ] Hudson commented on YARN-3987: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #287 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/287/]) YARN-3987. Send AM container completed msg to NM once AM finishes. Contributed by sandflee (jianhe: rev 0a030546e24c55662a603bb63c9029ad0ccf43fc) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java * hadoop-yarn-project/CHANGES.txt am container complete msg ack to NM once RM receive it -- Key: YARN-3987 URL: https://issues.apache.org/jira/browse/YARN-3987 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Reporter: sandflee Assignee: sandflee Fix For: 2.8.0 Attachments: YARN-3987.001.patch, YARN-3987.002.patch In our cluster we set max-am-attempts to a very very large num, and unfortunately our am crash after launched, leaving too many completed container(AM container) in NM. completed container is removed from NM and NMStateStore only if container complete is passed to AM, but if AM couldn't be launched, the completed AM container couldn't be cleaned, and may eat up NM heap memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3987) am container complete msg ack to NM once RM receive it
[ https://issues.apache.org/jira/browse/YARN-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696839#comment-14696839 ] Hudson commented on YARN-3987: -- FAILURE: Integrated in Hadoop-Yarn-trunk #1017 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1017/]) YARN-3987. Send AM container completed msg to NM once AM finishes. Contributed by sandflee (jianhe: rev 0a030546e24c55662a603bb63c9029ad0ccf43fc) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java * hadoop-yarn-project/CHANGES.txt am container complete msg ack to NM once RM receive it -- Key: YARN-3987 URL: https://issues.apache.org/jira/browse/YARN-3987 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Reporter: sandflee Assignee: sandflee Fix For: 2.8.0 Attachments: YARN-3987.001.patch, YARN-3987.002.patch In our cluster we set max-am-attempts to a very very large num, and unfortunately our am crash after launched, leaving too many completed container(AM container) in NM. completed container is removed from NM and NMStateStore only if container complete is passed to AM, but if AM couldn't be launched, the completed AM container couldn't be cleaned, and may eat up NM heap memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3987) am container complete msg ack to NM once RM receive it
[ https://issues.apache.org/jira/browse/YARN-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696244#comment-14696244 ] Hudson commented on YARN-3987: -- FAILURE: Integrated in Hadoop-trunk-Commit #8296 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8296/]) YARN-3987. Send AM container completed msg to NM once AM finishes. Contributed by sandflee (jianhe: rev 0a030546e24c55662a603bb63c9029ad0ccf43fc) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java * hadoop-yarn-project/CHANGES.txt am container complete msg ack to NM once RM receive it -- Key: YARN-3987 URL: https://issues.apache.org/jira/browse/YARN-3987 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Reporter: sandflee Assignee: sandflee Fix For: 2.8.0 Attachments: YARN-3987.001.patch, YARN-3987.002.patch In our cluster we set max-am-attempts to a very very large num, and unfortunately our am crash after launched, leaving too many completed container(AM container) in NM. completed container is removed from NM and NMStateStore only if container complete is passed to AM, but if AM couldn't be launched, the completed AM container couldn't be cleaned, and may eat up NM heap memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3987) am container complete msg ack to NM once RM receive it
[ https://issues.apache.org/jira/browse/YARN-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696433#comment-14696433 ] sandflee commented on YARN-3987: Thanks [~jianhe]! am container complete msg ack to NM once RM receive it -- Key: YARN-3987 URL: https://issues.apache.org/jira/browse/YARN-3987 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Reporter: sandflee Assignee: sandflee Fix For: 2.8.0 Attachments: YARN-3987.001.patch, YARN-3987.002.patch In our cluster we set max-am-attempts to a very very large num, and unfortunately our am crash after launched, leaving too many completed container(AM container) in NM. completed container is removed from NM and NMStateStore only if container complete is passed to AM, but if AM couldn't be launched, the completed AM container couldn't be cleaned, and may eat up NM heap memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3987) am container complete msg ack to NM once RM receive it
[ https://issues.apache.org/jira/browse/YARN-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645136#comment-14645136 ] sandflee commented on YARN-3987: yes, we set getKeepContainersAcrossApplicationAttempts true, thanks for your review. am container complete msg ack to NM once RM receive it -- Key: YARN-3987 URL: https://issues.apache.org/jira/browse/YARN-3987 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Reporter: sandflee Assignee: sandflee Attachments: YARN-3987.001.patch In our cluster we set max-am-attempts to a very very large num, and unfortunately our am crash after launched, leaving too many completed container(AM container) in NM. completed container is removed from NM and NMStateStore only if container complete is passed to AM, but if AM couldn't be launched, the completed AM container couldn't be cleaned, and may eat up NM heap memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3987) am container complete msg ack to NM once RM receive it
[ https://issues.apache.org/jira/browse/YARN-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645341#comment-14645341 ] sandflee commented on YARN-3987: AM crashes before it register to RM am container complete msg ack to NM once RM receive it -- Key: YARN-3987 URL: https://issues.apache.org/jira/browse/YARN-3987 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Reporter: sandflee Assignee: sandflee Attachments: YARN-3987.001.patch, YARN-3987.002.patch In our cluster we set max-am-attempts to a very very large num, and unfortunately our am crash after launched, leaving too many completed container(AM container) in NM. completed container is removed from NM and NMStateStore only if container complete is passed to AM, but if AM couldn't be launched, the completed AM container couldn't be cleaned, and may eat up NM heap memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3987) am container complete msg ack to NM once RM receive it
[ https://issues.apache.org/jira/browse/YARN-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645181#comment-14645181 ] Jian He commented on YARN-3987: --- bq. leaving too many completed container(AM container) in NM. At a single point of time,there should be only one AM instance in NM. Do you mean the old AM containers are not cleaned up ? If AM cannot be launched, the AM will expire in 10 mins, in which case the containers should also be cleanedup. am container complete msg ack to NM once RM receive it -- Key: YARN-3987 URL: https://issues.apache.org/jira/browse/YARN-3987 Project: Hadoop YARN Issue Type: Bug Components: resourcemanager Reporter: sandflee Assignee: sandflee Attachments: YARN-3987.001.patch, YARN-3987.002.patch In our cluster we set max-am-attempts to a very very large num, and unfortunately our am crash after launched, leaving too many completed container(AM container) in NM. completed container is removed from NM and NMStateStore only if container complete is passed to AM, but if AM couldn't be launched, the completed AM container couldn't be cleaned, and may eat up NM heap memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3987) am container complete msg ack to NM once RM receive it
[
https://issues.apache.org/jira/browse/YARN-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644709#comment-14644709
]
Hadoop QA commented on YARN-3987:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 16m 34s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 45s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 40s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 0m 46s | The applied patch generated 4
new checkstyle issues (total was 123, now 127). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 22s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 25s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 52m 20s | Tests passed in
hadoop-yarn-server-resourcemanager. |
| | | 90m 51s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12747573/YARN-3987.001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / f170934 |
| checkstyle |
https://builds.apache.org/job/PreCommit-YARN-Build/8692/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
|
| hadoop-yarn-server-resourcemanager test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8692/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8692/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8692/console |
This message was automatically generated.
am container complete msg ack to NM once RM receive it
--
Key: YARN-3987
URL: https://issues.apache.org/jira/browse/YARN-3987
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Reporter: sandflee
Assignee: sandflee
Attachments: YARN-3987.001.patch
In our cluster we set max-am-attempts to a very very large num, and
unfortunately our am crash after launched, leaving too many completed
container(AM container) in NM. completed container is removed from NM and
NMStateStore only if container complete is passed to AM, but if AM couldn't
be launched, the completed AM container couldn't be cleaned, and may eat up
NM heap memory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3987) am container complete msg ack to NM once RM receive it
[
https://issues.apache.org/jira/browse/YARN-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645114#comment-14645114
]
Jian He commented on YARN-3987:
---
Hi, [~sandflee], below code in the sendAMContainerToNM method should send the
container complete msg over. Is getKeepContainersAcrossApplicationAttempts
true in your case?
{code}
if (!appAttempt.getSubmissionContext()
.getKeepContainersAcrossApplicationAttempts()) {
appAttempt.sendFinishedContainersToNM();
}
}
{code}
am container complete msg ack to NM once RM receive it
--
Key: YARN-3987
URL: https://issues.apache.org/jira/browse/YARN-3987
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Reporter: sandflee
Assignee: sandflee
Attachments: YARN-3987.001.patch
In our cluster we set max-am-attempts to a very very large num, and
unfortunately our am crash after launched, leaving too many completed
container(AM container) in NM. completed container is removed from NM and
NMStateStore only if container complete is passed to AM, but if AM couldn't
be launched, the completed AM container couldn't be cleaned, and may eat up
NM heap memory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
