[jira] [Commented] (YARN-4255) container-executor does not clean up docker operation command files.
[ https://issues.apache.org/jira/browse/YARN-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14956627#comment-14956627 ] Hudson commented on YARN-4255: -- FAILURE: Integrated in Hadoop-trunk-Commit #8630 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8630/]) YARN-4255. container-executor does not clean up docker operation command (vvasudev: rev da1ee078f9d3c2c25c51d0b392b0925821c42ad3) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c * hadoop-yarn-project/CHANGES.txt > container-executor does not clean up docker operation command files. > - > > Key: YARN-4255 > URL: https://issues.apache.org/jira/browse/YARN-4255 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Sidharta Seethana >Assignee: Sidharta Seethana >Priority: Minor > Fix For: 2.8.0 > > Attachments: YARN-4255.001.patch > > > container-executor leaves behind docker command files that are used to run > docker commands. These need to be cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4255) container-executor does not clean up docker operation command files.
[ https://issues.apache.org/jira/browse/YARN-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14956745#comment-14956745 ] Hudson commented on YARN-4255: -- FAILURE: Integrated in Hadoop-Yarn-trunk #1263 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1263/]) YARN-4255. container-executor does not clean up docker operation command (vvasudev: rev da1ee078f9d3c2c25c51d0b392b0925821c42ad3) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c * hadoop-yarn-project/CHANGES.txt > container-executor does not clean up docker operation command files. > - > > Key: YARN-4255 > URL: https://issues.apache.org/jira/browse/YARN-4255 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Sidharta Seethana >Assignee: Sidharta Seethana >Priority: Minor > Fix For: 2.8.0 > > Attachments: YARN-4255.001.patch > > > container-executor leaves behind docker command files that are used to run > docker commands. These need to be cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4255) container-executor does not clean up docker operation command files.
[ https://issues.apache.org/jira/browse/YARN-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14956674#comment-14956674 ] Hudson commented on YARN-4255: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #539 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/539/]) YARN-4255. container-executor does not clean up docker operation command (vvasudev: rev da1ee078f9d3c2c25c51d0b392b0925821c42ad3) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c * hadoop-yarn-project/CHANGES.txt > container-executor does not clean up docker operation command files. > - > > Key: YARN-4255 > URL: https://issues.apache.org/jira/browse/YARN-4255 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Sidharta Seethana >Assignee: Sidharta Seethana >Priority: Minor > Fix For: 2.8.0 > > Attachments: YARN-4255.001.patch > > > container-executor leaves behind docker command files that are used to run > docker commands. These need to be cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4255) container-executor does not clean up docker operation command files.
[ https://issues.apache.org/jira/browse/YARN-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14956691#comment-14956691 ] Sidharta Seethana commented on YARN-4255: - Thanks! > container-executor does not clean up docker operation command files. > - > > Key: YARN-4255 > URL: https://issues.apache.org/jira/browse/YARN-4255 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Sidharta Seethana >Assignee: Sidharta Seethana >Priority: Minor > Fix For: 2.8.0 > > Attachments: YARN-4255.001.patch > > > container-executor leaves behind docker command files that are used to run > docker commands. These need to be cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4255) container-executor does not clean up docker operation command files.
[ https://issues.apache.org/jira/browse/YARN-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14956727#comment-14956727 ] Hudson commented on YARN-4255: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2475 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2475/]) YARN-4255. container-executor does not clean up docker operation command (vvasudev: rev da1ee078f9d3c2c25c51d0b392b0925821c42ad3) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c > container-executor does not clean up docker operation command files. > - > > Key: YARN-4255 > URL: https://issues.apache.org/jira/browse/YARN-4255 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Sidharta Seethana >Assignee: Sidharta Seethana >Priority: Minor > Fix For: 2.8.0 > > Attachments: YARN-4255.001.patch > > > container-executor leaves behind docker command files that are used to run > docker commands. These need to be cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4255) container-executor does not clean up docker operation command files.
[ https://issues.apache.org/jira/browse/YARN-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14956957#comment-14956957 ] Hudson commented on YARN-4255: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #494 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/494/]) YARN-4255. container-executor does not clean up docker operation command (vvasudev: rev da1ee078f9d3c2c25c51d0b392b0925821c42ad3) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c * hadoop-yarn-project/CHANGES.txt > container-executor does not clean up docker operation command files. > - > > Key: YARN-4255 > URL: https://issues.apache.org/jira/browse/YARN-4255 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Sidharta Seethana >Assignee: Sidharta Seethana >Priority: Minor > Fix For: 2.8.0 > > Attachments: YARN-4255.001.patch > > > container-executor leaves behind docker command files that are used to run > docker commands. These need to be cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4255) container-executor does not clean up docker operation command files.
[ https://issues.apache.org/jira/browse/YARN-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14956661#comment-14956661 ] Hudson commented on YARN-4255: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #527 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/527/]) YARN-4255. container-executor does not clean up docker operation command (vvasudev: rev da1ee078f9d3c2c25c51d0b392b0925821c42ad3) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c > container-executor does not clean up docker operation command files. > - > > Key: YARN-4255 > URL: https://issues.apache.org/jira/browse/YARN-4255 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Sidharta Seethana >Assignee: Sidharta Seethana >Priority: Minor > Fix For: 2.8.0 > > Attachments: YARN-4255.001.patch > > > container-executor leaves behind docker command files that are used to run > docker commands. These need to be cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4255) container-executor does not clean up docker operation command files.
[ https://issues.apache.org/jira/browse/YARN-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957000#comment-14957000 ] Hudson commented on YARN-4255: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2432 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2432/]) YARN-4255. container-executor does not clean up docker operation command (vvasudev: rev da1ee078f9d3c2c25c51d0b392b0925821c42ad3) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c > container-executor does not clean up docker operation command files. > - > > Key: YARN-4255 > URL: https://issues.apache.org/jira/browse/YARN-4255 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Sidharta Seethana >Assignee: Sidharta Seethana >Priority: Minor > Fix For: 2.8.0 > > Attachments: YARN-4255.001.patch > > > container-executor leaves behind docker command files that are used to run > docker commands. These need to be cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4255) container-executor does not clean up docker operation command files.
[ https://issues.apache.org/jira/browse/YARN-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14954727#comment-14954727 ] Varun Vasudev commented on YARN-4255: - [~sidharta-s] - any reason this change is in container-executor and not in DockerRuntimeContainerExecutor? Also, moving this to be a sub-task of YARN-3611. > container-executor does not clean up docker operation command files. > - > > Key: YARN-4255 > URL: https://issues.apache.org/jira/browse/YARN-4255 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sidharta Seethana >Assignee: Sidharta Seethana >Priority: Minor > Attachments: YARN-4255.001.patch > > > container-executor leaves behind docker command files that are used to run > docker commands. These need to be cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4255) container-executor does not clean up docker operation command files.
[ https://issues.apache.org/jira/browse/YARN-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14954733#comment-14954733 ] Sidharta Seethana commented on YARN-4255: - [~vvasudev] , I am assuming you mean DockerLinuxContainerRuntime ? The reason for doing this in the container-executor is that the filename has a randomly generated component. We would have to save the filename in the NM state store (to persist across restarts) in order to clean this up effectively in java code. A similar pattern of cleaning up command files is already in place in container-executor (traffic shaping/tc command files are cleaned up in container-executor as well). > container-executor does not clean up docker operation command files. > - > > Key: YARN-4255 > URL: https://issues.apache.org/jira/browse/YARN-4255 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Sidharta Seethana >Assignee: Sidharta Seethana >Priority: Minor > Attachments: YARN-4255.001.patch > > > container-executor leaves behind docker command files that are used to run > docker commands. These need to be cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4255) container-executor does not clean up docker operation command files.
[ https://issues.apache.org/jira/browse/YARN-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14954804#comment-14954804 ] Varun Vasudev commented on YARN-4255: - Makes sense. +1 to the patch. I'll commit tomorrow if no one objects. > container-executor does not clean up docker operation command files. > - > > Key: YARN-4255 > URL: https://issues.apache.org/jira/browse/YARN-4255 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Sidharta Seethana >Assignee: Sidharta Seethana >Priority: Minor > Attachments: YARN-4255.001.patch > > > container-executor leaves behind docker command files that are used to run > docker commands. These need to be cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4255) container-executor does not clean up docker operation command files.
[ https://issues.apache.org/jira/browse/YARN-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953087#comment-14953087 ] Sidharta Seethana commented on YARN-4255: - Tests : The patch is trivial - manually tested with test applications that the command files are being deleted. YARN test failure is unrelated to this patch. Release audit check failure is unrelated to this patch. > container-executor does not clean up docker operation command files. > - > > Key: YARN-4255 > URL: https://issues.apache.org/jira/browse/YARN-4255 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sidharta Seethana >Assignee: Sidharta Seethana >Priority: Minor > Attachments: YARN-4255.001.patch > > > container-executor leaves behind docker command files that are used to run > docker commands. These need to be cleaned up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4255) container-executor does not clean up docker operation command files.
[
https://issues.apache.org/jira/browse/YARN-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953080#comment-14953080
]
Hadoop QA commented on YARN-4255:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 5m 48s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 8m 5s | There were no new javac warning
messages. |
| {color:red}-1{color} | release audit | 0m 18s | The applied patch generated
1 release audit warnings. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 30s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | yarn tests | 8m 47s | Tests failed in
hadoop-yarn-server-nodemanager. |
| | | 25m 4s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests |
hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12766110/YARN-4255.001.patch |
| Optional Tests | javac unit |
| git revision | trunk / e617cf6 |
| Release Audit |
https://builds.apache.org/job/PreCommit-YARN-Build/9409/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| hadoop-yarn-server-nodemanager test log |
https://builds.apache.org/job/PreCommit-YARN-Build/9409/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/9409/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/9409/console |
This message was automatically generated.
> container-executor does not clean up docker operation command files.
> -
>
> Key: YARN-4255
> URL: https://issues.apache.org/jira/browse/YARN-4255
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Sidharta Seethana
>Assignee: Sidharta Seethana
>Priority: Minor
> Attachments: YARN-4255.001.patch
>
>
> container-executor leaves behind docker command files that are used to run
> docker commands. These need to be cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
