[jira] [Commented] (YARN-4313) Race condition in MiniMRYarnCluster when getting history server address
[ https://issues.apache.org/jira/browse/YARN-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982154#comment-14982154 ] Hudson commented on YARN-4313: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2491 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2491/]) YARN-4313. Race condition in MiniMRYarnCluster when getting history (xgong: rev 7412ff48eeb967c972c19c1370c77a41c5b3b81f) * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java * hadoop-yarn-project/CHANGES.txt > Race condition in MiniMRYarnCluster when getting history server address > --- > > Key: YARN-4313 > URL: https://issues.apache.org/jira/browse/YARN-4313 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Jian He > Fix For: 2.8.0, 2.7.2 > > Attachments: YARN-4313.1.patch, YARN-4313.2.patch > > > Problem in this place when waiting for JHS to be started > {code} > new Thread() { > public void run() { > historyServer.start(); > }; > }.start(); > while (historyServer.getServiceState() == STATE.INITED) { > LOG.info("Waiting for HistoryServer to start..."); > Thread.sleep(1500); > } > {code} > The service state is updated before the service is actually started. See > AbstractServic#start. So it's possible that when the while loop breaks, the > service is not yet started. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4313) Race condition in MiniMRYarnCluster when getting history server address
[ https://issues.apache.org/jira/browse/YARN-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981994#comment-14981994 ] Hudson commented on YARN-4313: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #553 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/553/]) YARN-4313. Race condition in MiniMRYarnCluster when getting history (xgong: rev 7412ff48eeb967c972c19c1370c77a41c5b3b81f) * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java * hadoop-yarn-project/CHANGES.txt > Race condition in MiniMRYarnCluster when getting history server address > --- > > Key: YARN-4313 > URL: https://issues.apache.org/jira/browse/YARN-4313 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Jian He > Fix For: 2.8.0, 2.7.2 > > Attachments: YARN-4313.1.patch, YARN-4313.2.patch > > > Problem in this place when waiting for JHS to be started > {code} > new Thread() { > public void run() { > historyServer.start(); > }; > }.start(); > while (historyServer.getServiceState() == STATE.INITED) { > LOG.info("Waiting for HistoryServer to start..."); > Thread.sleep(1500); > } > {code} > The service state is updated before the service is actually started. See > AbstractServic#start. So it's possible that when the while loop breaks, the > service is not yet started. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4313) Race condition in MiniMRYarnCluster when getting history server address
[ https://issues.apache.org/jira/browse/YARN-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981857#comment-14981857 ] Hudson commented on YARN-4313: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #616 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/616/]) YARN-4313. Race condition in MiniMRYarnCluster when getting history (xgong: rev 7412ff48eeb967c972c19c1370c77a41c5b3b81f) * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java * hadoop-yarn-project/CHANGES.txt > Race condition in MiniMRYarnCluster when getting history server address > --- > > Key: YARN-4313 > URL: https://issues.apache.org/jira/browse/YARN-4313 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Jian He > Fix For: 2.8.0, 2.7.2 > > Attachments: YARN-4313.1.patch, YARN-4313.2.patch > > > Problem in this place when waiting for JHS to be started > {code} > new Thread() { > public void run() { > historyServer.start(); > }; > }.start(); > while (historyServer.getServiceState() == STATE.INITED) { > LOG.info("Waiting for HistoryServer to start..."); > Thread.sleep(1500); > } > {code} > The service state is updated before the service is actually started. See > AbstractServic#start. So it's possible that when the while loop breaks, the > service is not yet started. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4313) Race condition in MiniMRYarnCluster when getting history server address
[ https://issues.apache.org/jira/browse/YARN-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981736#comment-14981736 ] Hudson commented on YARN-4313: -- FAILURE: Integrated in Hadoop-Yarn-trunk #1339 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1339/]) YARN-4313. Race condition in MiniMRYarnCluster when getting history (xgong: rev 7412ff48eeb967c972c19c1370c77a41c5b3b81f) * hadoop-yarn-project/CHANGES.txt * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java > Race condition in MiniMRYarnCluster when getting history server address > --- > > Key: YARN-4313 > URL: https://issues.apache.org/jira/browse/YARN-4313 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Jian He > Fix For: 2.8.0, 2.7.2 > > Attachments: YARN-4313.1.patch, YARN-4313.2.patch > > > Problem in this place when waiting for JHS to be started > {code} > new Thread() { > public void run() { > historyServer.start(); > }; > }.start(); > while (historyServer.getServiceState() == STATE.INITED) { > LOG.info("Waiting for HistoryServer to start..."); > Thread.sleep(1500); > } > {code} > The service state is updated before the service is actually started. See > AbstractServic#start. So it's possible that when the while loop breaks, the > service is not yet started. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4313) Race condition in MiniMRYarnCluster when getting history server address
[ https://issues.apache.org/jira/browse/YARN-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981700#comment-14981700 ] Hudson commented on YARN-4313: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2546 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2546/]) YARN-4313. Race condition in MiniMRYarnCluster when getting history (xgong: rev 7412ff48eeb967c972c19c1370c77a41c5b3b81f) * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java * hadoop-yarn-project/CHANGES.txt > Race condition in MiniMRYarnCluster when getting history server address > --- > > Key: YARN-4313 > URL: https://issues.apache.org/jira/browse/YARN-4313 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Jian He > Fix For: 2.8.0, 2.7.2 > > Attachments: YARN-4313.1.patch, YARN-4313.2.patch > > > Problem in this place when waiting for JHS to be started > {code} > new Thread() { > public void run() { > historyServer.start(); > }; > }.start(); > while (historyServer.getServiceState() == STATE.INITED) { > LOG.info("Waiting for HistoryServer to start..."); > Thread.sleep(1500); > } > {code} > The service state is updated before the service is actually started. See > AbstractServic#start. So it's possible that when the while loop breaks, the > service is not yet started. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4313) Race condition in MiniMRYarnCluster when getting history server address
[ https://issues.apache.org/jira/browse/YARN-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981683#comment-14981683 ] Hudson commented on YARN-4313: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #604 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/604/]) YARN-4313. Race condition in MiniMRYarnCluster when getting history (xgong: rev 7412ff48eeb967c972c19c1370c77a41c5b3b81f) * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java * hadoop-yarn-project/CHANGES.txt > Race condition in MiniMRYarnCluster when getting history server address > --- > > Key: YARN-4313 > URL: https://issues.apache.org/jira/browse/YARN-4313 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Jian He > Fix For: 2.8.0, 2.7.2 > > Attachments: YARN-4313.1.patch, YARN-4313.2.patch > > > Problem in this place when waiting for JHS to be started > {code} > new Thread() { > public void run() { > historyServer.start(); > }; > }.start(); > while (historyServer.getServiceState() == STATE.INITED) { > LOG.info("Waiting for HistoryServer to start..."); > Thread.sleep(1500); > } > {code} > The service state is updated before the service is actually started. See > AbstractServic#start. So it's possible that when the while loop breaks, the > service is not yet started. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4313) Race condition in MiniMRYarnCluster when getting history server address
[ https://issues.apache.org/jira/browse/YARN-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981657#comment-14981657 ] Hudson commented on YARN-4313: -- FAILURE: Integrated in Hadoop-trunk-Commit #8727 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8727/]) YARN-4313. Race condition in MiniMRYarnCluster when getting history (xgong: rev 7412ff48eeb967c972c19c1370c77a41c5b3b81f) * hadoop-yarn-project/CHANGES.txt * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java > Race condition in MiniMRYarnCluster when getting history server address > --- > > Key: YARN-4313 > URL: https://issues.apache.org/jira/browse/YARN-4313 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Jian He > Fix For: 2.8.0, 2.7.2 > > Attachments: YARN-4313.1.patch, YARN-4313.2.patch > > > Problem in this place when waiting for JHS to be started > {code} > new Thread() { > public void run() { > historyServer.start(); > }; > }.start(); > while (historyServer.getServiceState() == STATE.INITED) { > LOG.info("Waiting for HistoryServer to start..."); > Thread.sleep(1500); > } > {code} > The service state is updated before the service is actually started. See > AbstractServic#start. So it's possible that when the while loop breaks, the > service is not yet started. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4313) Race condition in MiniMRYarnCluster when getting history server address
[ https://issues.apache.org/jira/browse/YARN-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981651#comment-14981651 ] Xuan Gong commented on YARN-4313: - Committed into trunk/branch-2/branch-2.7. Thanks, Jian ! > Race condition in MiniMRYarnCluster when getting history server address > --- > > Key: YARN-4313 > URL: https://issues.apache.org/jira/browse/YARN-4313 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Jian He > Fix For: 2.8.0, 2.7.2 > > Attachments: YARN-4313.1.patch, YARN-4313.2.patch > > > Problem in this place when waiting for JHS to be started > {code} > new Thread() { > public void run() { > historyServer.start(); > }; > }.start(); > while (historyServer.getServiceState() == STATE.INITED) { > LOG.info("Waiting for HistoryServer to start..."); > Thread.sleep(1500); > } > {code} > The service state is updated before the service is actually started. See > AbstractServic#start. So it's possible that when the while loop breaks, the > service is not yet started. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4313) Race condition in MiniMRYarnCluster when getting history server address
[ https://issues.apache.org/jira/browse/YARN-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981647#comment-14981647 ] Xuan Gong commented on YARN-4313: - Thanks, [~jianhe] for the verification. Checking this in > Race condition in MiniMRYarnCluster when getting history server address > --- > > Key: YARN-4313 > URL: https://issues.apache.org/jira/browse/YARN-4313 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Jian He > Attachments: YARN-4313.1.patch, YARN-4313.2.patch > > > Problem in this place when waiting for JHS to be started > {code} > new Thread() { > public void run() { > historyServer.start(); > }; > }.start(); > while (historyServer.getServiceState() == STATE.INITED) { > LOG.info("Waiting for HistoryServer to start..."); > Thread.sleep(1500); > } > {code} > The service state is updated before the service is actually started. See > AbstractServic#start. So it's possible that when the while loop breaks, the > service is not yet started. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4313) Race condition in MiniMRYarnCluster when getting history server address
[ https://issues.apache.org/jira/browse/YARN-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981535#comment-14981535 ] Jian He commented on YARN-4313: --- TestMRTimelineEventHandling failed without the patch, other tests pass locally with or without the patch > Race condition in MiniMRYarnCluster when getting history server address > --- > > Key: YARN-4313 > URL: https://issues.apache.org/jira/browse/YARN-4313 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Jian He > Attachments: YARN-4313.1.patch, YARN-4313.2.patch > > > Problem in this place when waiting for JHS to be started > {code} > new Thread() { > public void run() { > historyServer.start(); > }; > }.start(); > while (historyServer.getServiceState() == STATE.INITED) { > LOG.info("Waiting for HistoryServer to start..."); > Thread.sleep(1500); > } > {code} > The service state is updated before the service is actually started. See > AbstractServic#start. So it's possible that when the while loop breaks, the > service is not yet started. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4313) Race condition in MiniMRYarnCluster when getting history server address
[ https://issues.apache.org/jira/browse/YARN-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981387#comment-14981387 ] Hadoop QA commented on YARN-4313: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 11s {color} | {color:blue} docker + precommit patch detected. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 9s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 18s {color} | {color:green} trunk passed with JDK v1.8.0_60 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s {color} | {color:green} trunk passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 9s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 14s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 29s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 12s {color} | {color:green} trunk passed with JDK v1.8.0_60 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 15s {color} | {color:green} trunk passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 23s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 18s {color} | {color:green} the patch passed with JDK v1.8.0_60 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 18s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s {color} | {color:green} the patch passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 20s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 8s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 14s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 36s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 13s {color} | {color:green} the patch passed with JDK v1.8.0_60 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 13s {color} | {color:green} the patch passed with JDK v1.7.0_79 {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 98m 10s {color} | {color:red} hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_60. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 116m 4s {color} | {color:red} hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_79. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 29s {color} | {color:red} Patch generated 15 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 223m 26s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | JDK v1.7.0_79 Failed junit tests | hadoop.mapreduce.v2.TestMRJobsWithProfiler | | | hadoop.mapreduce.lib.output.TestJobOutputCommitter | | | hadoop.mapred.TestMRTimelineEventHandling | | | hadoop.mapred.TestLocalMRNotification | | | hadoop.mapred.TestMRTimelineEventHandling | | JDK v1.7.0_79 Timed out junit tests | org.apache.hadoop.mapreduce.lib.jobcontrol.TestMapReduceJobControl | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-29 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12769577/YARN-4313.2.patch | | JIRA Issue | YARN-4313 | | Optional Tests | asflicense javac javadoc mvninstall unit findbugs checkstyle compile | | uname | Linux b50179539cb7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | |
[jira] [Commented] (YARN-4313) Race condition in MiniMRYarnCluster when getting history server address
[ https://issues.apache.org/jira/browse/YARN-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14980915#comment-14980915 ] Xuan Gong commented on YARN-4313: - +1 lgtm. Will commit the patch after Jenkins says OK > Race condition in MiniMRYarnCluster when getting history server address > --- > > Key: YARN-4313 > URL: https://issues.apache.org/jira/browse/YARN-4313 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Jian He > Attachments: YARN-4313.1.patch, YARN-4313.2.patch > > > Problem in this place when waiting for JHS to be started > {code} > new Thread() { > public void run() { > historyServer.start(); > }; > }.start(); > while (historyServer.getServiceState() == STATE.INITED) { > LOG.info("Waiting for HistoryServer to start..."); > Thread.sleep(1500); > } > {code} > The service state is updated before the service is actually started. See > AbstractServic#start. So it's possible that when the while loop breaks, the > service is not yet started. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4313) Race condition in MiniMRYarnCluster when getting history server address
[ https://issues.apache.org/jira/browse/YARN-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14980875#comment-14980875 ] Li Lu commented on YARN-4313: - Latest change LGTM. Could any committers please review this change? Thanks! > Race condition in MiniMRYarnCluster when getting history server address > --- > > Key: YARN-4313 > URL: https://issues.apache.org/jira/browse/YARN-4313 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Jian He > Attachments: YARN-4313.1.patch, YARN-4313.2.patch > > > Problem in this place when waiting for JHS to be started > {code} > new Thread() { > public void run() { > historyServer.start(); > }; > }.start(); > while (historyServer.getServiceState() == STATE.INITED) { > LOG.info("Waiting for HistoryServer to start..."); > Thread.sleep(1500); > } > {code} > The service state is updated before the service is actually started. See > AbstractServic#start. So it's possible that when the while loop breaks, the > service is not yet started. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4313) Race condition in MiniMRYarnCluster when getting history server address
[ https://issues.apache.org/jira/browse/YARN-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14980727#comment-14980727 ] Li Lu commented on YARN-4313: - Well wait, quick question---why do we need to initialize a customized job history server here? I think we can directly set the flag in the thread's run() method, after the historyServer.start() is done? Then we can wait on the flag afterwards? > Race condition in MiniMRYarnCluster when getting history server address > --- > > Key: YARN-4313 > URL: https://issues.apache.org/jira/browse/YARN-4313 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Jian He > Attachments: YARN-4313.1.patch > > > Problem in this place when waiting for JHS to be started > {code} > new Thread() { > public void run() { > historyServer.start(); > }; > }.start(); > while (historyServer.getServiceState() == STATE.INITED) { > LOG.info("Waiting for HistoryServer to start..."); > Thread.sleep(1500); > } > {code} > The service state is updated before the service is actually started. See > AbstractServic#start. So it's possible that when the while loop breaks, the > service is not yet started. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4313) Race condition in MiniMRYarnCluster when getting history server address
[ https://issues.apache.org/jira/browse/YARN-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14980720#comment-14980720 ] Li Lu commented on YARN-4313: - Oh I overlooked that. Yes in this case we can use an atomic boolean. +1 for the patch. > Race condition in MiniMRYarnCluster when getting history server address > --- > > Key: YARN-4313 > URL: https://issues.apache.org/jira/browse/YARN-4313 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Jian He > Attachments: YARN-4313.1.patch > > > Problem in this place when waiting for JHS to be started > {code} > new Thread() { > public void run() { > historyServer.start(); > }; > }.start(); > while (historyServer.getServiceState() == STATE.INITED) { > LOG.info("Waiting for HistoryServer to start..."); > Thread.sleep(1500); > } > {code} > The service state is updated before the service is actually started. See > AbstractServic#start. So it's possible that when the while loop breaks, the > service is not yet started. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4313) Race condition in MiniMRYarnCluster when getting history server address
[ https://issues.apache.org/jira/browse/YARN-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979956#comment-14979956 ] Jian He commented on YARN-4313: --- [~gtCarrera9], thanks for taking a look at this. This variable needs to be declared as final since it's accessed from within an inner class. So a boolean flag may not work as it cannot be reset ? > Race condition in MiniMRYarnCluster when getting history server address > --- > > Key: YARN-4313 > URL: https://issues.apache.org/jira/browse/YARN-4313 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Jian He > Attachments: YARN-4313.1.patch > > > Problem in this place when waiting for JHS to be started > {code} > new Thread() { > public void run() { > historyServer.start(); > }; > }.start(); > while (historyServer.getServiceState() == STATE.INITED) { > LOG.info("Waiting for HistoryServer to start..."); > Thread.sleep(1500); > } > {code} > The service state is updated before the service is actually started. See > AbstractServic#start. So it's possible that when the while loop breaks, the > service is not yet started. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4313) Race condition in MiniMRYarnCluster when getting history server address
[ https://issues.apache.org/jira/browse/YARN-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979919#comment-14979919 ] Hadoop QA commented on YARN-4313: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 7s {color} | {color:blue} docker + precommit patch detected. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 27s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 23s {color} | {color:green} trunk passed with JDK v1.8.0_60 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 22s {color} | {color:green} trunk passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 10s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 15s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 33s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 15s {color} | {color:green} trunk passed with JDK v1.8.0_60 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 15s {color} | {color:green} trunk passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 25s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s {color} | {color:green} the patch passed with JDK v1.8.0_60 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 20s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 22s {color} | {color:green} the patch passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 22s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 9s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 15s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 41s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 14s {color} | {color:green} the patch passed with JDK v1.8.0_60 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s {color} | {color:green} the patch passed with JDK v1.7.0_79 {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 110m 49s {color} | {color:red} hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_60. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 126m 35s {color} | {color:red} hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_79. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 48s {color} | {color:red} Patch generated 17 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 247m 55s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | JDK v1.7.0_79 Failed junit tests | hadoop.mapred.TestLocalMRNotification | | | hadoop.mapreduce.v2.TestMRJobsWithProfiler | | | hadoop.mapred.TestMRTimelineEventHandling | | | hadoop.mapred.TestLocalMRNotification | | | hadoop.mapred.TestMRTimelineEventHandling | | JDK v1.7.0_79 Timed out junit tests | org.apache.hadoop.mapred.TestReduceFetchFromPartialMem | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-29 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12769448/YARN-4313.1.patch | | JIRA Issue | YARN-4313 | | Optional Tests | asflicense javac javadoc mvninstall unit findbugs checkstyle compile | | uname | Linux 667b0268a7fe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | |
[jira] [Commented] (YARN-4313) Race condition in MiniMRYarnCluster when getting history server address
[ https://issues.apache.org/jira/browse/YARN-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979640#comment-14979640 ] Li Lu commented on YARN-4313: - Thanks [~jianhe] for the work. I have one quick w.r.t the atomic boolean in the patch. If we're just using atomic read/write for the boolean flag, I think a volatile boolean would suffice. We're not actually using the "fancy" features of atomic boolean in this fix. The other part of the patch LGTM. > Race condition in MiniMRYarnCluster when getting history server address > --- > > Key: YARN-4313 > URL: https://issues.apache.org/jira/browse/YARN-4313 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jian He >Assignee: Jian He > Attachments: YARN-4313.1.patch > > > Problem in this place when waiting for JHS to be started > {code} > new Thread() { > public void run() { > historyServer.start(); > }; > }.start(); > while (historyServer.getServiceState() == STATE.INITED) { > LOG.info("Waiting for HistoryServer to start..."); > Thread.sleep(1500); > } > {code} > The service state is updated before the service is actually started. See > AbstractServic#start. So it's possible that when the while loop breaks, the > service is not yet started. -- This message was sent by Atlassian JIRA (v6.3.4#6332)