[jira] [Commented] (YARN-447) applicationComparator improvement for CS
[ https://issues.apache.org/jira/browse/YARN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619824#comment-13619824 ] Hudson commented on YARN-447: - Integrated in Hadoop-Mapreduce-trunk #1389 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1389/]) YARN-447. Move ApplicationComparator in CapacityScheduler to use comparator in ApplicationId. Contributed by Nemon Lou. (Revision 1463405) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1463405 Files : * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestUtils.java > applicationComparator improvement for CS > > > Key: YARN-447 > URL: https://issues.apache.org/jira/browse/YARN-447 > Project: Hadoop YARN > Issue Type: Improvement > Components: scheduler >Affects Versions: 2.0.3-alpha >Reporter: nemon lou >Assignee: nemon lou >Priority: Minor > Fix For: 2.0.5-beta > > Attachments: YARN-447-trunk.patch, YARN-447-trunk.patch, > YARN-447-trunk.patch, YARN-447-trunk.patch, YARN-447-trunk.patch > > > Now the compare code is : > return a1.getApplicationId().getId() - a2.getApplicationId().getId(); > Will be replaced with : > return a1.getApplicationId().compareTo(a2.getApplicationId()); > This will bring some benefits: > 1,leave applicationId compare logic to ApplicationId class; > 2,In future's HA mode,cluster time stamp may change,ApplicationId class > already takes care of this condition. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-447) applicationComparator improvement for CS
[ https://issues.apache.org/jira/browse/YARN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619768#comment-13619768 ] Hudson commented on YARN-447: - Integrated in Hadoop-Hdfs-trunk #1362 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1362/]) YARN-447. Move ApplicationComparator in CapacityScheduler to use comparator in ApplicationId. Contributed by Nemon Lou. (Revision 1463405) Result = FAILURE vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1463405 Files : * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestUtils.java > applicationComparator improvement for CS > > > Key: YARN-447 > URL: https://issues.apache.org/jira/browse/YARN-447 > Project: Hadoop YARN > Issue Type: Improvement > Components: scheduler >Affects Versions: 2.0.3-alpha >Reporter: nemon lou >Assignee: nemon lou >Priority: Minor > Fix For: 2.0.5-beta > > Attachments: YARN-447-trunk.patch, YARN-447-trunk.patch, > YARN-447-trunk.patch, YARN-447-trunk.patch, YARN-447-trunk.patch > > > Now the compare code is : > return a1.getApplicationId().getId() - a2.getApplicationId().getId(); > Will be replaced with : > return a1.getApplicationId().compareTo(a2.getApplicationId()); > This will bring some benefits: > 1,leave applicationId compare logic to ApplicationId class; > 2,In future's HA mode,cluster time stamp may change,ApplicationId class > already takes care of this condition. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-447) applicationComparator improvement for CS
[ https://issues.apache.org/jira/browse/YARN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619697#comment-13619697 ] Hudson commented on YARN-447: - Integrated in Hadoop-Yarn-trunk #173 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/173/]) YARN-447. Move ApplicationComparator in CapacityScheduler to use comparator in ApplicationId. Contributed by Nemon Lou. (Revision 1463405) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1463405 Files : * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestUtils.java > applicationComparator improvement for CS > > > Key: YARN-447 > URL: https://issues.apache.org/jira/browse/YARN-447 > Project: Hadoop YARN > Issue Type: Improvement > Components: scheduler >Affects Versions: 2.0.3-alpha >Reporter: nemon lou >Assignee: nemon lou >Priority: Minor > Fix For: 2.0.5-beta > > Attachments: YARN-447-trunk.patch, YARN-447-trunk.patch, > YARN-447-trunk.patch, YARN-447-trunk.patch, YARN-447-trunk.patch > > > Now the compare code is : > return a1.getApplicationId().getId() - a2.getApplicationId().getId(); > Will be replaced with : > return a1.getApplicationId().compareTo(a2.getApplicationId()); > This will bring some benefits: > 1,leave applicationId compare logic to ApplicationId class; > 2,In future's HA mode,cluster time stamp may change,ApplicationId class > already takes care of this condition. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-447) applicationComparator improvement for CS
[ https://issues.apache.org/jira/browse/YARN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619581#comment-13619581 ] Hudson commented on YARN-447: - Integrated in Hadoop-trunk-Commit #3547 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3547/]) YARN-447. Move ApplicationComparator in CapacityScheduler to use comparator in ApplicationId. Contributed by Nemon Lou. (Revision 1463405) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1463405 Files : * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapacityScheduler.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestUtils.java > applicationComparator improvement for CS > > > Key: YARN-447 > URL: https://issues.apache.org/jira/browse/YARN-447 > Project: Hadoop YARN > Issue Type: Improvement > Components: scheduler >Affects Versions: 2.0.3-alpha >Reporter: nemon lou >Assignee: nemon lou >Priority: Minor > Fix For: 2.0.5-beta > > Attachments: YARN-447-trunk.patch, YARN-447-trunk.patch, > YARN-447-trunk.patch, YARN-447-trunk.patch, YARN-447-trunk.patch > > > Now the compare code is : > return a1.getApplicationId().getId() - a2.getApplicationId().getId(); > Will be replaced with : > return a1.getApplicationId().compareTo(a2.getApplicationId()); > This will bring some benefits: > 1,leave applicationId compare logic to ApplicationId class; > 2,In future's HA mode,cluster time stamp may change,ApplicationId class > already takes care of this condition. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-447) applicationComparator improvement for CS
[ https://issues.apache.org/jira/browse/YARN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619573#comment-13619573 ] Vinod Kumar Vavilapalli commented on YARN-447: -- Latest patch looks good. +1. Checking this in. > applicationComparator improvement for CS > > > Key: YARN-447 > URL: https://issues.apache.org/jira/browse/YARN-447 > Project: Hadoop YARN > Issue Type: Improvement > Components: scheduler >Affects Versions: 2.0.3-alpha >Reporter: nemon lou >Assignee: nemon lou >Priority: Minor > Attachments: YARN-447-trunk.patch, YARN-447-trunk.patch, > YARN-447-trunk.patch, YARN-447-trunk.patch, YARN-447-trunk.patch > > > Now the compare code is : > return a1.getApplicationId().getId() - a2.getApplicationId().getId(); > Will be replaced with : > return a1.getApplicationId().compareTo(a2.getApplicationId()); > This will bring some benefits: > 1,leave applicationId compare logic to ApplicationId class; > 2,In future's HA mode,cluster time stamp may change,ApplicationId class > already takes care of this condition. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-447) applicationComparator improvement for CS
[ https://issues.apache.org/jira/browse/YARN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619551#comment-13619551 ] Hadoop QA commented on YARN-447: {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12576484/YARN-447-trunk.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/644//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/644//console This message is automatically generated. > applicationComparator improvement for CS > > > Key: YARN-447 > URL: https://issues.apache.org/jira/browse/YARN-447 > Project: Hadoop YARN > Issue Type: Improvement > Components: scheduler >Affects Versions: 2.0.3-alpha >Reporter: nemon lou >Assignee: nemon lou >Priority: Minor > Attachments: YARN-447-trunk.patch, YARN-447-trunk.patch, > YARN-447-trunk.patch, YARN-447-trunk.patch, YARN-447-trunk.patch > > > Now the compare code is : > return a1.getApplicationId().getId() - a2.getApplicationId().getId(); > Will be replaced with : > return a1.getApplicationId().compareTo(a2.getApplicationId()); > This will bring some benefits: > 1,leave applicationId compare logic to ApplicationId class; > 2,In future's HA mode,cluster time stamp may change,ApplicationId class > already takes care of this condition. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-447) applicationComparator improvement for CS
[ https://issues.apache.org/jira/browse/YARN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618701#comment-13618701 ] Hadoop QA commented on YARN-447: {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12576347/YARN-447-trunk.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/635//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/635//console This message is automatically generated. > applicationComparator improvement for CS > > > Key: YARN-447 > URL: https://issues.apache.org/jira/browse/YARN-447 > Project: Hadoop YARN > Issue Type: Improvement > Components: scheduler >Affects Versions: 2.0.3-alpha >Reporter: nemon lou >Assignee: nemon lou >Priority: Minor > Attachments: YARN-447-trunk.patch, YARN-447-trunk.patch, > YARN-447-trunk.patch, YARN-447-trunk.patch > > > Now the compare code is : > return a1.getApplicationId().getId() - a2.getApplicationId().getId(); > Will be replaced with : > return a1.getApplicationId().compareTo(a2.getApplicationId()); > This will bring some benefits: > 1,leave applicationId compare logic to ApplicationId class; > 2,In future's HA mode,cluster time stamp may change,ApplicationId class > already takes care of this condition. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-447) applicationComparator improvement for CS
[ https://issues.apache.org/jira/browse/YARN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618447#comment-13618447 ] Arun C Murthy commented on YARN-447: +1, lgtm! > applicationComparator improvement for CS > > > Key: YARN-447 > URL: https://issues.apache.org/jira/browse/YARN-447 > Project: Hadoop YARN > Issue Type: Improvement > Components: scheduler >Affects Versions: 2.0.3-alpha >Reporter: nemon lou >Assignee: nemon lou >Priority: Minor > Attachments: YARN-447-trunk.patch, YARN-447-trunk.patch, > YARN-447-trunk.patch > > > Now the compare code is : > return a1.getApplicationId().getId() - a2.getApplicationId().getId(); > Will be replaced with : > return a1.getApplicationId().compareTo(a2.getApplicationId()); > This will bring some benefits: > 1,leave applicationId compare logic to ApplicationId class; > 2,In future's HA mode,cluster time stamp may change,ApplicationId class > already takes care of this condition. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-447) applicationComparator improvement for CS
[ https://issues.apache.org/jira/browse/YARN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13593135#comment-13593135 ] nemon lou commented on YARN-447: This patch is ready for review now. Thank you. > applicationComparator improvement for CS > > > Key: YARN-447 > URL: https://issues.apache.org/jira/browse/YARN-447 > Project: Hadoop YARN > Issue Type: Improvement > Components: scheduler >Affects Versions: 2.0.3-alpha >Reporter: nemon lou >Priority: Minor > Attachments: YARN-447-trunk.patch, YARN-447-trunk.patch, > YARN-447-trunk.patch > > > Now the compare code is : > return a1.getApplicationId().getId() - a2.getApplicationId().getId(); > Will be replaced with : > return a1.getApplicationId().compareTo(a2.getApplicationId()); > This will bring some benefits: > 1,leave applicationId compare logic to ApplicationId class; > 2,In future's HA mode,cluster time stamp may change,ApplicationId class > already takes care of this condition. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-447) applicationComparator improvement for CS
[ https://issues.apache.org/jira/browse/YARN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13593133#comment-13593133 ] Hadoop QA commented on YARN-447: {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12572040/YARN-447-trunk.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:green}+1 tests included appear to have a timeout.{color} {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/468//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/468//console This message is automatically generated. > applicationComparator improvement for CS > > > Key: YARN-447 > URL: https://issues.apache.org/jira/browse/YARN-447 > Project: Hadoop YARN > Issue Type: Improvement > Components: scheduler >Affects Versions: 2.0.3-alpha >Reporter: nemon lou >Priority: Minor > Attachments: YARN-447-trunk.patch, YARN-447-trunk.patch, > YARN-447-trunk.patch > > > Now the compare code is : > return a1.getApplicationId().getId() - a2.getApplicationId().getId(); > Will be replaced with : > return a1.getApplicationId().compareTo(a2.getApplicationId()); > This will bring some benefits: > 1,leave applicationId compare logic to ApplicationId class; > 2,In future's HA mode,cluster time stamp may change,ApplicationId class > already takes care of this condition. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-447) applicationComparator improvement for CS
[ https://issues.apache.org/jira/browse/YARN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592167#comment-13592167 ] Hadoop QA commented on YARN-447: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12571874/YARN-447-trunk.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:red}-1 one of tests included doesn't have a timeout.{color} {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestApplicationLimits org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/457//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/457//console This message is automatically generated. > applicationComparator improvement for CS > > > Key: YARN-447 > URL: https://issues.apache.org/jira/browse/YARN-447 > Project: Hadoop YARN > Issue Type: Improvement > Components: scheduler >Affects Versions: 2.0.3-alpha >Reporter: nemon lou >Priority: Minor > Attachments: YARN-447-trunk.patch > > > Now the compare code is : > return a1.getApplicationId().getId() - a2.getApplicationId().getId(); > Will be replaced with : > return a1.getApplicationId().compareTo(a2.getApplicationId()); > This will bring some benefits: > 1,leave applicationId compare logic to ApplicationId class; > 2,In future's HA mode,cluster time stamp may change,ApplicationId class > already takes care of this condition. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira