[jira] [Commented] (YARN-4596) SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
[ https://issues.apache.org/jira/browse/YARN-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106055#comment-15106055 ] Hudson commented on YARN-4596: -- FAILURE: Integrated in Hadoop-trunk-Commit #9133 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/9133/]) YARN-4596. SystemMetricPublisher should not swallow error messages from (jianhe: rev f385851141522633184ce394899c659af5ace92a) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/metrics/SystemMetricsPublisher.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java * hadoop-yarn-project/CHANGES.txt > SystemMetricPublisher should not swallow error messages from > TimelineClient#putEntities > --- > > Key: YARN-4596 > URL: https://issues.apache.org/jira/browse/YARN-4596 > Project: Hadoop YARN > Issue Type: Bug > Components: timelineserver >Reporter: Li Lu >Assignee: Li Lu > Fix For: 2.8.0 > > Attachments: YARN-4596-trunk.001.patch, YARN-4596-trunk.002.patch > > > We should report error messages from the returned TimelineResponse when > posting timeline entities through system metric publisher. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4596) SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
[ https://issues.apache.org/jira/browse/YARN-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106248#comment-15106248 ] Naganarasimha G R commented on YARN-4596: - Thanks [~gtCarrera] for considering them ! > SystemMetricPublisher should not swallow error messages from > TimelineClient#putEntities > --- > > Key: YARN-4596 > URL: https://issues.apache.org/jira/browse/YARN-4596 > Project: Hadoop YARN > Issue Type: Bug > Components: timelineserver >Reporter: Li Lu >Assignee: Li Lu > Fix For: 2.8.0 > > Attachments: YARN-4596-trunk.001.patch, YARN-4596-trunk.002.patch > > > We should report error messages from the returned TimelineResponse when > posting timeline entities through system metric publisher. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4596) SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
[ https://issues.apache.org/jira/browse/YARN-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106240#comment-15106240 ] Li Lu commented on YARN-4596: - I've created YARN-4604 and MAPREDUCE-6610 to trace the two problems raised in the discussion of this issue. Thanks [~Naganarasimha]! > SystemMetricPublisher should not swallow error messages from > TimelineClient#putEntities > --- > > Key: YARN-4596 > URL: https://issues.apache.org/jira/browse/YARN-4596 > Project: Hadoop YARN > Issue Type: Bug > Components: timelineserver >Reporter: Li Lu >Assignee: Li Lu > Fix For: 2.8.0 > > Attachments: YARN-4596-trunk.001.patch, YARN-4596-trunk.002.patch > > > We should report error messages from the returned TimelineResponse when > posting timeline entities through system metric publisher. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4596) SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
[
https://issues.apache.org/jira/browse/YARN-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106332#comment-15106332
]
Varun Saxena commented on YARN-4596:
[~Naganarasimha], [~gtCarrera9],
Regarding below comment,
bq. but if some one uses rest directly then some entities will get posted and
some will not, hence wanted to know whether its right to break in the middle ?
Not really.
*None of the entities will get posted to backend store.*
*BadRequestException* is thrown during entity preprocessing phase. Not during
store put. We first collect all the applicable entities which can be posted and
then only call {{TimelineStore#put}}. We are not calling put from within the
loop. Refer to {{TimelineDataManager#doPostEntities}}.
It can although be argued that we can post entities which can be and send a put
error(new error type) for the entity which has no entity id or entity type. But
if we do not have entity id or type, how will client recognize which specific
entity has failed from put error ? Maybe they can cache entities which they
have sent and then re-look at entities they attempted to post and find out
which ones had entity id and entity type missing. But will client be doing so ?
Current clients would be looking at entity id and type to find out which
entities failed and why.
Entity ID and type are key pieces of information in ATSv1. If client is not
sending them, it indicates some problem in the client side code. I think
current code can be kept as it is because this will be consistent with
{{TimelineClient}} side code too where none of the entities will be posted if
entity id or type is missing in even one of them.
Thoughts ?
> SystemMetricPublisher should not swallow error messages from
> TimelineClient#putEntities
> ---
>
> Key: YARN-4596
> URL: https://issues.apache.org/jira/browse/YARN-4596
> Project: Hadoop YARN
> Issue Type: Bug
> Components: timelineserver
>Reporter: Li Lu
>Assignee: Li Lu
> Fix For: 2.8.0
>
> Attachments: YARN-4596-trunk.001.patch, YARN-4596-trunk.002.patch
>
>
> We should report error messages from the returned TimelineResponse when
> posting timeline entities through system metric publisher.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-4596) SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
[ https://issues.apache.org/jira/browse/YARN-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105838#comment-15105838 ] Li Lu commented on YARN-4596: - Ah I've got your point. Yes we can definitely improve the logic here. Please feel free to raise a JIRA about it. > SystemMetricPublisher should not swallow error messages from > TimelineClient#putEntities > --- > > Key: YARN-4596 > URL: https://issues.apache.org/jira/browse/YARN-4596 > Project: Hadoop YARN > Issue Type: Bug > Components: timelineserver >Reporter: Li Lu >Assignee: Li Lu > Attachments: YARN-4596-trunk.001.patch, YARN-4596-trunk.002.patch > > > We should report error messages from the returned TimelineResponse when > posting timeline entities through system metric publisher. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4596) SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
[ https://issues.apache.org/jira/browse/YARN-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15103147#comment-15103147 ] Naganarasimha G R commented on YARN-4596: - Thanks for the comments [~gtCarrera], MR side fix is a small one, if possible to include in this jira then fine if not can raise and fix in another jira. for the second point actually in timeline client side its not a problem as there is similar check before posting but if some one uses rest directly then some entities will get posted and some will not, hence wanted to know whether its right to break in the middle ? > SystemMetricPublisher should not swallow error messages from > TimelineClient#putEntities > --- > > Key: YARN-4596 > URL: https://issues.apache.org/jira/browse/YARN-4596 > Project: Hadoop YARN > Issue Type: Bug > Components: timelineserver >Reporter: Li Lu >Assignee: Li Lu > Attachments: YARN-4596-trunk.001.patch, YARN-4596-trunk.002.patch > > > We should report error messages from the returned TimelineResponse when > posting timeline entities through system metric publisher. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4596) SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
[
https://issues.apache.org/jira/browse/YARN-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101657#comment-15101657
]
Naganarasimha G R commented on YARN-4596:
-
Hi [~gtCarrera] IIUC you are referring to
{{org.apache.hadoop.yarn.client.api.impl.TimelineWriter.doPosting(Object,
String)}}
{code}
if (resp == null ||
resp.getClientResponseStatus() != ClientResponse.Status.OK){
...
}
{code}
we need to check if resp Obj is available (not null) and if so then we need to
try to get {{resp.getEntity(TimelinePutResponse.class)}} and may be have a
proper *toString* overrides to log the errors rights?
> SystemMetricPublisher should not swallow error messages from
> TimelineClient#putEntities
> ---
>
> Key: YARN-4596
> URL: https://issues.apache.org/jira/browse/YARN-4596
> Project: Hadoop YARN
> Issue Type: Bug
> Components: timelineserver
>Reporter: Li Lu
>Assignee: Li Lu
>
> We should report error messages from the returned TimelineResponse when
> posting timeline entities through system metric publisher.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-4596) SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
[
https://issues.apache.org/jira/browse/YARN-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102299#comment-15102299
]
Li Lu commented on YARN-4596:
-
Hi [~Naganarasimha] actually I was referring to the logic we have in the SMP
itself, where we simply do
{code}
client.putEntities(entity);
{code}
when we actually post entities. However, timeline stores may put error messages
in the response to indicate failures/errors when putting these entities. The
SMP needs to at least log down those problems. Otherwise it's hard to reason
about whether a putEntities call has actually landed onto the timeline storage.
The code you pointed out is on the client side, and is taking care of the case
when there is no (HTTP) response from the timeline server. If there are errors
happened in timeline store, the HTTP response should be fine but the actual
TimelinePutResponse will contain the error message.
> SystemMetricPublisher should not swallow error messages from
> TimelineClient#putEntities
> ---
>
> Key: YARN-4596
> URL: https://issues.apache.org/jira/browse/YARN-4596
> Project: Hadoop YARN
> Issue Type: Bug
> Components: timelineserver
>Reporter: Li Lu
>Assignee: Li Lu
>
> We should report error messages from the returned TimelineResponse when
> posting timeline entities through system metric publisher.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-4596) SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
[
https://issues.apache.org/jira/browse/YARN-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102531#comment-15102531
]
Hadoop QA commented on YARN-4596:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
4s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 29s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 38s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
17s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 23s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
33s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 28s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 28s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 30s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 36s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
22s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 61m 30s {color}
| {color:red} hadoop-yarn-server-resourcemanager in the patch failed with JDK
v1.8.0_66. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 62m 45s {color}
| {color:red} hadoop-yarn-server-resourcemanager in the patch failed with JDK
v1.7.0_91. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 142m 46s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_66 Failed junit tests |
hadoop.yarn.server.resourcemanager.TestAMAuthorization |
| | hadoop.yarn.server.resourcemanager.TestClientRMTokens |
| JDK v1.7.0_91 Failed junit tests |
hadoop.yarn.server.resourcemanager.TestAMAuthorization |
| | hadoop.yarn.server.resourcemanager.TestClientRMTokens |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:0ca8df7 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12782590/YARN-4596-trunk.001.patch
|
|
[jira] [Commented] (YARN-4596) SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
[
https://issues.apache.org/jira/browse/YARN-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102826#comment-15102826
]
Hadoop QA commented on YARN-4596:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 17s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
58s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 7s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 13s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 59s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
29s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
49s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 45s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 18s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
48s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 58s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 58s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 14s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 14s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 56s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
54s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 40s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 61m 32s {color}
| {color:red} hadoop-yarn-server-resourcemanager in the patch failed with JDK
v1.8.0_66. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 6m 55s
{color} | {color:green} hadoop-yarn-applications-distributedshell in the patch
passed with JDK v1.8.0_66. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 63m 29s {color}
| {color:red} hadoop-yarn-server-resourcemanager in the patch failed with JDK
v1.7.0_91. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m 7s
{color} | {color:green} hadoop-yarn-applications-distributedshell in the patch
passed with JDK v1.7.0_91. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s {color} | {color:green} Patch does not
[jira] [Commented] (YARN-4596) SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
[ https://issues.apache.org/jira/browse/YARN-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102900#comment-15102900 ] Naganarasimha G R commented on YARN-4596: - [~gtCarrera], Oops i understood it wrongly, got what you are trying to address ! > SystemMetricPublisher should not swallow error messages from > TimelineClient#putEntities > --- > > Key: YARN-4596 > URL: https://issues.apache.org/jira/browse/YARN-4596 > Project: Hadoop YARN > Issue Type: Bug > Components: timelineserver >Reporter: Li Lu >Assignee: Li Lu > Attachments: YARN-4596-trunk.001.patch, YARN-4596-trunk.002.patch > > > We should report error messages from the returned TimelineResponse when > posting timeline entities through system metric publisher. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4596) SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
[
https://issues.apache.org/jira/browse/YARN-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102909#comment-15102909
]
Naganarasimha G R commented on YARN-4596:
-
Hi [~gtCarrera],
Overall the patch looks fine but few issues (not exactly related to this patch
but just felt lil related)
* {{JobHistoryEventHandler.processEventForTimelineServer}} is also swallowing
the error message, so may be we can handle in another jira?
* In {{TimelineDataManager.doPostEntities(TimelineEntities,
UserGroupInformation)}} throws *BadRequestException* when
{{entity.getEntityId() == null || entity.getEntityType() == null}} should this
not be captured in {{TimelinePutResponse.TimelinePutError}} and continue with
next entity?
> SystemMetricPublisher should not swallow error messages from
> TimelineClient#putEntities
> ---
>
> Key: YARN-4596
> URL: https://issues.apache.org/jira/browse/YARN-4596
> Project: Hadoop YARN
> Issue Type: Bug
> Components: timelineserver
>Reporter: Li Lu
>Assignee: Li Lu
> Attachments: YARN-4596-trunk.001.patch, YARN-4596-trunk.002.patch
>
>
> We should report error messages from the returned TimelineResponse when
> posting timeline entities through system metric publisher.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-4596) SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
[ https://issues.apache.org/jira/browse/YARN-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102924#comment-15102924 ] Li Lu commented on YARN-4596: - [~Naganarasimha] Yes we can handle this in a separate JIRA (please feel free to work on this). TDM throws BadRequestException which represents a bad REST request. This is a connection level _exception_ rather than a semantic level _error_ (in using the timeline API). Therefore I prefer to leave it as the current behavior. > SystemMetricPublisher should not swallow error messages from > TimelineClient#putEntities > --- > > Key: YARN-4596 > URL: https://issues.apache.org/jira/browse/YARN-4596 > Project: Hadoop YARN > Issue Type: Bug > Components: timelineserver >Reporter: Li Lu >Assignee: Li Lu > Attachments: YARN-4596-trunk.001.patch, YARN-4596-trunk.002.patch > > > We should report error messages from the returned TimelineResponse when > posting timeline entities through system metric publisher. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4596) SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
[ https://issues.apache.org/jira/browse/YARN-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102612#comment-15102612 ] Jian He commented on YARN-4596: --- latest patch looks good to me. > SystemMetricPublisher should not swallow error messages from > TimelineClient#putEntities > --- > > Key: YARN-4596 > URL: https://issues.apache.org/jira/browse/YARN-4596 > Project: Hadoop YARN > Issue Type: Bug > Components: timelineserver >Reporter: Li Lu >Assignee: Li Lu > Attachments: YARN-4596-trunk.001.patch, YARN-4596-trunk.002.patch > > > We should report error messages from the returned TimelineResponse when > posting timeline entities through system metric publisher. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4596) SystemMetricPublisher should not swallow error messages from TimelineClient#putEntities
[ https://issues.apache.org/jira/browse/YARN-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102927#comment-15102927 ] Li Lu commented on YARN-4596: - BTW, the second point also appears to be orthogonal to the current problem. We can further decide (and hopefully streamline) the concrete post-effect of the putEntities() API. This will also assist us polish APIs for v2. > SystemMetricPublisher should not swallow error messages from > TimelineClient#putEntities > --- > > Key: YARN-4596 > URL: https://issues.apache.org/jira/browse/YARN-4596 > Project: Hadoop YARN > Issue Type: Bug > Components: timelineserver >Reporter: Li Lu >Assignee: Li Lu > Attachments: YARN-4596-trunk.001.patch, YARN-4596-trunk.002.patch > > > We should report error messages from the returned TimelineResponse when > posting timeline entities through system metric publisher. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
