[jira] [Commented] (YARN-475) Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in an AM's environment
[
https://issues.apache.org/jira/browse/YARN-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136201#comment-15136201
]
Johannes Zillmann commented on YARN-475:
Btw, the documentation
[http://hadoop.apache.org/docs/r2.7.2/hadoop-yarn/hadoop-yarn-site/WritingYarnApplications.html]
uses still the now non-existing
{{ApplicationConstants.AM_APP_ATTEMPT_ID_ENV.}}!
> Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in
> an AM's environment
> ---
>
> Key: YARN-475
> URL: https://issues.apache.org/jira/browse/YARN-475
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Hitesh Shah
>Assignee: Hitesh Shah
> Fix For: 2.1.0-beta
>
> Attachments: YARN-475.1.patch
>
>
> AMs are expected to use ApplicationConstants.AM_CONTAINER_ID_ENV and derive
> the application attempt id from the container id.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-475) Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in an AM's environment
[ https://issues.apache.org/jira/browse/YARN-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619825#comment-13619825 ] Hudson commented on YARN-475: - Integrated in Hadoop-Mapreduce-trunk #1389 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1389/]) YARN-475. Remove a unused constant in the public API - ApplicationConstants.AM_APP_ATTEMPT_ID_ENV. Contributed by Hitesh Shah. (Revision 1463033) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1463033 Files : * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationConstants.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher/src/main/java/org/apache/hadoop/yarn/applications/unmanagedamlauncher/UnmanagedAMLauncher.java > Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in > an AM's environment > --- > > Key: YARN-475 > URL: https://issues.apache.org/jira/browse/YARN-475 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Hitesh Shah >Assignee: Hitesh Shah > Fix For: 2.0.5-beta > > Attachments: YARN-475.1.patch > > > AMs are expected to use ApplicationConstants.AM_CONTAINER_ID_ENV and derive > the application attempt id from the container id. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-475) Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in an AM's environment
[ https://issues.apache.org/jira/browse/YARN-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618761#comment-13618761 ] Hudson commented on YARN-475: - Integrated in Hadoop-Hdfs-trunk #1361 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1361/]) YARN-475. Remove a unused constant in the public API - ApplicationConstants.AM_APP_ATTEMPT_ID_ENV. Contributed by Hitesh Shah. (Revision 1463033) Result = FAILURE vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1463033 Files : * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationConstants.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher/src/main/java/org/apache/hadoop/yarn/applications/unmanagedamlauncher/UnmanagedAMLauncher.java > Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in > an AM's environment > --- > > Key: YARN-475 > URL: https://issues.apache.org/jira/browse/YARN-475 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Hitesh Shah >Assignee: Hitesh Shah > Fix For: 2.0.5-beta > > Attachments: YARN-475.1.patch > > > AMs are expected to use ApplicationConstants.AM_CONTAINER_ID_ENV and derive > the application attempt id from the container id. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-475) Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in an AM's environment
[ https://issues.apache.org/jira/browse/YARN-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618735#comment-13618735 ] Hudson commented on YARN-475: - Integrated in Hadoop-Yarn-trunk #172 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/172/]) YARN-475. Remove a unused constant in the public API - ApplicationConstants.AM_APP_ATTEMPT_ID_ENV. Contributed by Hitesh Shah. (Revision 1463033) Result = FAILURE vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1463033 Files : * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationConstants.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher/src/main/java/org/apache/hadoop/yarn/applications/unmanagedamlauncher/UnmanagedAMLauncher.java > Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in > an AM's environment > --- > > Key: YARN-475 > URL: https://issues.apache.org/jira/browse/YARN-475 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Hitesh Shah >Assignee: Hitesh Shah > Fix For: 2.0.5-beta > > Attachments: YARN-475.1.patch > > > AMs are expected to use ApplicationConstants.AM_CONTAINER_ID_ENV and derive > the application attempt id from the container id. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-475) Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in an AM's environment
[ https://issues.apache.org/jira/browse/YARN-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618444#comment-13618444 ] Hudson commented on YARN-475: - Integrated in Hadoop-trunk-Commit #3541 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3541/]) YARN-475. Remove a unused constant in the public API - ApplicationConstants.AM_APP_ATTEMPT_ID_ENV. Contributed by Hitesh Shah. (Revision 1463033) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1463033 Files : * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationConstants.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher/src/main/java/org/apache/hadoop/yarn/applications/unmanagedamlauncher/UnmanagedAMLauncher.java > Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in > an AM's environment > --- > > Key: YARN-475 > URL: https://issues.apache.org/jira/browse/YARN-475 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Hitesh Shah >Assignee: Hitesh Shah > Fix For: 2.0.5-beta > > Attachments: YARN-475.1.patch > > > AMs are expected to use ApplicationConstants.AM_CONTAINER_ID_ENV and derive > the application attempt id from the container id. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-475) Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in an AM's environment
[ https://issues.apache.org/jira/browse/YARN-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618430#comment-13618430 ] Vinod Kumar Vavilapalli commented on YARN-475: -- +1 this looks good. No tests needed. Checking this in. > Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in > an AM's environment > --- > > Key: YARN-475 > URL: https://issues.apache.org/jira/browse/YARN-475 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Hitesh Shah >Assignee: Hitesh Shah > Attachments: YARN-475.1.patch > > > AMs are expected to use ApplicationConstants.AM_CONTAINER_ID_ENV and derive > the application attempt id from the container id. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-475) Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in an AM's environment
[
https://issues.apache.org/jira/browse/YARN-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616969#comment-13616969
]
Hadoop QA commented on YARN-475:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12575966/YARN-475.1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 eclipse:eclipse{color}. The patch failed to build with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/623//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/623//console
This message is automatically generated.
> Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in
> an AM's environment
> ---
>
> Key: YARN-475
> URL: https://issues.apache.org/jira/browse/YARN-475
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Hitesh Shah
>Assignee: Hitesh Shah
> Attachments: YARN-475.1.patch
>
>
> AMs are expected to use ApplicationConstants.AM_CONTAINER_ID_ENV and derive
> the application attempt id from the container id.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-475) Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in an AM's environment
[ https://issues.apache.org/jira/browse/YARN-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601905#comment-13601905 ] Hitesh Shah commented on YARN-475: -- Both DistributedShell and UnmanagedAM use it currently but we should remove its usage as it is definitely being set in the environment by the RM's AMLauncher. > Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in > an AM's environment > --- > > Key: YARN-475 > URL: https://issues.apache.org/jira/browse/YARN-475 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Hitesh Shah > > AMs are expected to use ApplicationConstants.AM_CONTAINER_ID_ENV and derive > the application attempt id from the container id. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-475) Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in an AM's environment
[ https://issues.apache.org/jira/browse/YARN-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601897#comment-13601897 ] Eli Reisman commented on YARN-475: -- Thanks, I was just going to ask this. So the containerId is the "right" place to get an app id from the AM's container environment? I think I'd doing this in my Giraph-YARN patch already but I will check. > Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in > an AM's environment > --- > > Key: YARN-475 > URL: https://issues.apache.org/jira/browse/YARN-475 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Hitesh Shah > > AMs are expected to use ApplicationConstants.AM_CONTAINER_ID_ENV and derive > the application attempt id from the container id. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-475) Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in an AM's environment
[
https://issues.apache.org/jira/browse/YARN-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601883#comment-13601883
]
Hitesh Shah commented on YARN-475:
--
{code}
// get containerIdStr from environment
ContainerId containerId = ConverterUtils.toContainerId(containerIdStr);
ApplicationAttemptId applicationAttemptId =
containerId.getApplicationAttemptId();
{code}
> Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in
> an AM's environment
> ---
>
> Key: YARN-475
> URL: https://issues.apache.org/jira/browse/YARN-475
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Hitesh Shah
>
> AMs are expected to use ApplicationConstants.AM_CONTAINER_ID_ENV and derive
> the application attempt id from the container id.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-475) Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in an AM's environment
[ https://issues.apache.org/jira/browse/YARN-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601838#comment-13601838 ] Bikas Saha commented on YARN-475: - Even when we remove it - is there some helper lib/api to help AM's derive appid, attempt number etc from the container_id? > Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in > an AM's environment > --- > > Key: YARN-475 > URL: https://issues.apache.org/jira/browse/YARN-475 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Hitesh Shah > > AMs are expected to use ApplicationConstants.AM_CONTAINER_ID_ENV and derive > the application attempt id from the container id. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-475) Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in an AM's environment
[
https://issues.apache.org/jira/browse/YARN-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601810#comment-13601810
]
Zhijie Shen commented on YARN-475:
--
ApplicationConstants.AM_APP_ATTEMPT_ID_ENV seems to be still used by unmanaged
AM. See the following code in UnmanagedAMLauncher.
{code}
if(!setClasspath && classpath!=null) {
envAMList.add("CLASSPATH="+classpath);
}
envAMList.add(ApplicationConstants.AM_APP_ATTEMPT_ID_ENV + "=" + attemptId);
String[] envAM = new String[envAMList.size()];
Process amProc = Runtime.getRuntime().exec(amCmd, envAMList.toArray(envAM));
{code}
Also, it is still checked in the AM of distributed shell.
{code}
if (envs.containsKey(ApplicationConstants.AM_APP_ATTEMPT_ID_ENV)) {
appAttemptID = ConverterUtils.toApplicationAttemptId(envs
.get(ApplicationConstants.AM_APP_ATTEMPT_ID_ENV));
}
{code}
> Remove ApplicationConstants.AM_APP_ATTEMPT_ID_ENV as it is no longer set in
> an AM's environment
> ---
>
> Key: YARN-475
> URL: https://issues.apache.org/jira/browse/YARN-475
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Hitesh Shah
>
> AMs are expected to use ApplicationConstants.AM_CONTAINER_ID_ENV and derive
> the application attempt id from the container id.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
