[jira] [Commented] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
[ https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987149#comment-15987149 ] Junping Du commented on YARN-5007: -- bq. If 3.0 is not a good time to remove deprecated method, when is a good time? Deprecated means this method is not recommended to use, and no promise of supporting well in following releases. That doesn't mean we have to remove/break these methods. For the safest time of removing, I would suggest to wait for another major release. Otherwise, case here will happen again and again. bq. -1 on reverting YARN-3573. Technically, in apache way, -1 doesn't work for any reverting work - no matter binding or non-binding. However, after thinking again, I would agree keeping YARN-3573 there is better. Thanks [~ajisakaa] for the revert work. Let's resolve this JIRA as won't fix or after. > Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster > --- > > Key: YARN-5007 > URL: https://issues.apache.org/jira/browse/YARN-5007 > Project: Hadoop YARN > Issue Type: Test >Reporter: Andras Bokor >Assignee: Andras Bokor > Labels: oct16-easy > Attachments: YARN-5007.01.patch, YARN-5007.02.patch, > YARN-5007.03.patch > > > MiniYarnCluster has a deprecated constructor which is called by the other > constructors and it causes javac warnings during the build. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
[ https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984333#comment-15984333 ] Hudson commented on YARN-5007: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11633 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/11633/]) Revert "YARN-5007. Remove deprecated constructors of MiniYARNCluster and (aajisaka: rev 8a99eba96d7db6031e0c4a6ae5d8f8a842572a8d) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/ProtocolHATestBase.java * (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestMRTimelineEventHandling.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java * (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestMiniYarnCluster.java > Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster > --- > > Key: YARN-5007 > URL: https://issues.apache.org/jira/browse/YARN-5007 > Project: Hadoop YARN > Issue Type: Test >Reporter: Andras Bokor >Assignee: Andras Bokor > Labels: oct16-easy > Attachments: YARN-5007.01.patch, YARN-5007.02.patch, > YARN-5007.03.patch > > > MiniYarnCluster has a deprecated constructor which is called by the other > constructors and it causes javac warnings during the build. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
[ https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982939#comment-15982939 ] John Zhuge commented on YARN-5007: -- +1 Thanks [~boky01] and [~ajisakaa] for the clarification. > Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster > --- > > Key: YARN-5007 > URL: https://issues.apache.org/jira/browse/YARN-5007 > Project: Hadoop YARN > Issue Type: Test >Reporter: Andras Bokor >Assignee: Andras Bokor > Labels: oct16-easy > Fix For: 3.0.0-alpha3 > > Attachments: YARN-5007.01.patch, YARN-5007.02.patch, > YARN-5007.03.patch > > > MiniYarnCluster has a deprecated constructor which is called by the other > constructors and it causes javac warnings during the build. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
[ https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982687#comment-15982687 ] Akira Ajisaka commented on YARN-5007: - Thank you for reporting [~aplusplus]. I'm +1 for reverting this now and -1 on reverting YARN-3573. bq. If 3.0 is not a good time to remove deprecated method, when is a good time? If there is a downstream project to support 2.7.x, we cannot remove it. branch-2.7 EoL seems to be a good time. > Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster > --- > > Key: YARN-5007 > URL: https://issues.apache.org/jira/browse/YARN-5007 > Project: Hadoop YARN > Issue Type: Test >Reporter: Andras Bokor >Assignee: Andras Bokor > Labels: oct16-easy > Fix For: 3.0.0-alpha3 > > Attachments: YARN-5007.01.patch, YARN-5007.02.patch, > YARN-5007.03.patch > > > MiniYarnCluster has a deprecated constructor which is called by the other > constructors and it causes javac warnings during the build. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
[
https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982680#comment-15982680
]
Andras Bokor commented on YARN-5007:
It should be marked as {{deprecated}}. Using config against constructor has
been being the preferred way for 2 years. {{Deprecated}} is a good sign for
developers to not to use that constructors.
-1 on reverting YARN-3573.
> Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
> ---
>
> Key: YARN-5007
> URL: https://issues.apache.org/jira/browse/YARN-5007
> Project: Hadoop YARN
> Issue Type: Test
>Reporter: Andras Bokor
>Assignee: Andras Bokor
> Labels: oct16-easy
> Fix For: 3.0.0-alpha3
>
> Attachments: YARN-5007.01.patch, YARN-5007.02.patch,
> YARN-5007.03.patch
>
>
> MiniYarnCluster has a deprecated constructor which is called by the other
> constructors and it causes javac warnings during the build.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
[
https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982364#comment-15982364
]
John Zhuge commented on YARN-5007:
--
If 3.0 is not a good time to remove deprecated method, when is a good time?
Maybe the method should not have been marked as {{deprecated}}?
> Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
> ---
>
> Key: YARN-5007
> URL: https://issues.apache.org/jira/browse/YARN-5007
> Project: Hadoop YARN
> Issue Type: Test
>Reporter: Andras Bokor
>Assignee: Andras Bokor
> Labels: oct16-easy
> Fix For: 3.0.0-alpha3
>
> Attachments: YARN-5007.01.patch, YARN-5007.02.patch,
> YARN-5007.03.patch
>
>
> MiniYarnCluster has a deprecated constructor which is called by the other
> constructors and it causes javac warnings during the build.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
[ https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982090#comment-15982090 ] Junping Du commented on YARN-5007: -- As [~aplusplus] said, this break Tez build against Hadoop 3 and some other downstream projects could also get affected seriously (in case it will use MiniYARNCluster). I am going to revert YARN-3573 (deprecated method) and this (completed removal). Let me know if you have some concerns. > Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster > --- > > Key: YARN-5007 > URL: https://issues.apache.org/jira/browse/YARN-5007 > Project: Hadoop YARN > Issue Type: Test >Reporter: Andras Bokor >Assignee: Andras Bokor > Labels: oct16-easy > Fix For: 3.0.0-alpha3 > > Attachments: YARN-5007.01.patch, YARN-5007.02.patch, > YARN-5007.03.patch > > > MiniYarnCluster has a deprecated constructor which is called by the other > constructors and it causes javac warnings during the build. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
[ https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982066#comment-15982066 ] Zhiyuan Yang commented on YARN-5007: This change breaks Tez and possibly many other downstream projects. In 2.7.0, the only way to enable ATS is through ctor parameters; now the only way is configuration. How do you expect downstream projects to support both support both 2.7.0 and 3.0.0? > Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster > --- > > Key: YARN-5007 > URL: https://issues.apache.org/jira/browse/YARN-5007 > Project: Hadoop YARN > Issue Type: Test >Reporter: Andras Bokor >Assignee: Andras Bokor > Labels: oct16-easy > Fix For: 3.0.0-alpha3 > > Attachments: YARN-5007.01.patch, YARN-5007.02.patch, > YARN-5007.03.patch > > > MiniYarnCluster has a deprecated constructor which is called by the other > constructors and it causes javac warnings during the build. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
[ https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971178#comment-15971178 ] Hudson commented on YARN-5007: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11591 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/11591/]) YARN-5007. Remove deprecated constructors of MiniYARNCluster and (aajisaka: rev 34ab8e73d48ea3c21c9e9571419b43b605de15c3) * (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestMRTimelineEventHandling.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/ProtocolHATestBase.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestMiniYarnCluster.java * (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java > Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster > --- > > Key: YARN-5007 > URL: https://issues.apache.org/jira/browse/YARN-5007 > Project: Hadoop YARN > Issue Type: Test >Reporter: Andras Bokor >Assignee: Andras Bokor > Labels: oct16-easy > Fix For: 3.0.0-alpha3 > > Attachments: YARN-5007.01.patch, YARN-5007.02.patch, > YARN-5007.03.patch > > > MiniYarnCluster has a deprecated constructor which is called by the other > constructors and it causes javac warnings during the build. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
[ https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962926#comment-15962926 ] Andras Bokor commented on YARN-5007: Thanks [~ajisakaa]! > Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster > --- > > Key: YARN-5007 > URL: https://issues.apache.org/jira/browse/YARN-5007 > Project: Hadoop YARN > Issue Type: Test >Reporter: Andras Bokor >Assignee: Andras Bokor > Labels: oct16-easy > Fix For: 3.0.0-alpha3 > > Attachments: YARN-5007.01.patch, YARN-5007.02.patch, > YARN-5007.03.patch > > > MiniYarnCluster has a deprecated constructor which is called by the other > constructors and it causes javac warnings during the build. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
[ https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956547#comment-15956547 ] Hudson commented on YARN-5007: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11529 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/11529/]) YARN-5007. Remove deprecated constructors of MiniYARNCluster and (aajisaka: rev 34ab8e73d48ea3c21c9e9571419b43b605de15c3) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/ProtocolHATestBase.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestMiniYarnCluster.java * (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java * (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestMRTimelineEventHandling.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java > Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster > --- > > Key: YARN-5007 > URL: https://issues.apache.org/jira/browse/YARN-5007 > Project: Hadoop YARN > Issue Type: Test >Reporter: Andras Bokor >Assignee: Andras Bokor > Labels: oct16-easy > Fix For: 3.0.0-alpha3 > > Attachments: YARN-5007.01.patch, YARN-5007.02.patch, > YARN-5007.03.patch > > > MiniYarnCluster has a deprecated constructor which is called by the other > constructors and it causes javac warnings during the build. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
[ https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956516#comment-15956516 ] Akira Ajisaka commented on YARN-5007: - +1 since 2.8.0 was released. Checking this in. > Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster > --- > > Key: YARN-5007 > URL: https://issues.apache.org/jira/browse/YARN-5007 > Project: Hadoop YARN > Issue Type: Test >Reporter: Andras Bokor >Assignee: Andras Bokor > Labels: oct16-easy > Attachments: YARN-5007.01.patch, YARN-5007.02.patch, > YARN-5007.03.patch > > > MiniYarnCluster has a deprecated constructor which is called by the other > constructors and it causes javac warnings during the build. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
[
https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830952#comment-15830952
]
Hadoop QA commented on YARN-5007:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} YARN-5007 does not apply to trunk. Rebase required? Wrong Branch?
See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | YARN-5007 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12817705/YARN-5007.02.patch |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/14715/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
> ---
>
> Key: YARN-5007
> URL: https://issues.apache.org/jira/browse/YARN-5007
> Project: Hadoop YARN
> Issue Type: Test
>Reporter: Andras Bokor
>Assignee: Andras Bokor
> Labels: oct16-easy
> Attachments: YARN-5007.01.patch, YARN-5007.02.patch
>
>
> MiniYarnCluster has a deprecated constructor which is called by the other
> constructors and it causes javac warnings during the build.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster
[ https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587900#comment-15587900 ] Akira Ajisaka commented on YARN-5007: - +1 for this patch but not committing for now. YARN-3573 deprecated the constructors but the fix version (2.8.0) is not released. We need to wait for 2.8.0 release before committing this. This is the same as the reason why HADOOP-13705 reverted HADOOP-13534. > Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster > --- > > Key: YARN-5007 > URL: https://issues.apache.org/jira/browse/YARN-5007 > Project: Hadoop YARN > Issue Type: Test >Reporter: Andras Bokor >Assignee: Andras Bokor > Attachments: YARN-5007.01.patch, YARN-5007.02.patch > > > MiniYarnCluster has a deprecated constructor which is called by the other > constructors and it causes javac warnings during the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
