[jira] [Commented] (YARN-5286) Add RPC port info in RM web service's response when getting app status
[ https://issues.apache.org/jira/browse/YARN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363730#comment-15363730 ] Varun Saxena commented on YARN-5286: Committed to branch-2.8 too > Add RPC port info in RM web service's response when getting app status > -- > > Key: YARN-5286 > URL: https://issues.apache.org/jira/browse/YARN-5286 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jun Gong >Assignee: Jun Gong > Fix For: 2.8.0 > > Attachments: YARN-5286.01.patch, YARN-5286.02.patch, > YARN-5286.03.patch, YARN-5286.04.patch, YARN-5286.05.patch > > > When getting app status by RM web service({{/ws/v1/cluster/apps/\{appid\}}}), > there is no RPC port info in the response. The port info is very important to > communicate with AM. > BTW: there is RPC port info when running {{bin/yarn application -status > appid}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5286) Add RPC port info in RM web service's response when getting app status
[ https://issues.apache.org/jira/browse/YARN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363590#comment-15363590 ] Jun Gong commented on YARN-5286: Thanks [~varun_saxena] for the review, suggestions and commit! I think it might be useful to be merged into branch-2.8. > Add RPC port info in RM web service's response when getting app status > -- > > Key: YARN-5286 > URL: https://issues.apache.org/jira/browse/YARN-5286 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jun Gong >Assignee: Jun Gong > Fix For: 2.9.0 > > Attachments: YARN-5286.01.patch, YARN-5286.02.patch, > YARN-5286.03.patch, YARN-5286.04.patch, YARN-5286.05.patch > > > When getting app status by RM web service({{/ws/v1/cluster/apps/\{appid\}}}), > there is no RPC port info in the response. The port info is very important to > communicate with AM. > BTW: there is RPC port info when running {{bin/yarn application -status > appid}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5286) Add RPC port info in RM web service's response when getting app status
[ https://issues.apache.org/jira/browse/YARN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362852#comment-15362852 ] Varun Saxena commented on YARN-5286: Committed this to trunk, branch-2. Thanks [~hex108] for your contribution. I have not committed it to branch-2.8 as target version wasnt specified. Is it required ? > Add RPC port info in RM web service's response when getting app status > -- > > Key: YARN-5286 > URL: https://issues.apache.org/jira/browse/YARN-5286 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jun Gong >Assignee: Jun Gong > Fix For: 2.9.0 > > Attachments: YARN-5286.01.patch, YARN-5286.02.patch, > YARN-5286.03.patch, YARN-5286.04.patch, YARN-5286.05.patch > > > When getting app status by RM web service({{/ws/v1/cluster/apps/\{appid\}}}), > there is no RPC port info in the response. The port info is very important to > communicate with AM. > BTW: there is RPC port info when running {{bin/yarn application -status > appid}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5286) Add RPC port info in RM web service's response when getting app status
[ https://issues.apache.org/jira/browse/YARN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362834#comment-15362834 ] Hudson commented on YARN-5286: -- SUCCESS: Integrated in Hadoop-trunk-Commit #10050 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10050/]) YARN-5286. Add RPC port info in RM web service's response when getting (varunsaxena: rev 8e672e3c717bb6f02ae9f93747f78ca3ab5d74a6) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AppInfo.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java > Add RPC port info in RM web service's response when getting app status > -- > > Key: YARN-5286 > URL: https://issues.apache.org/jira/browse/YARN-5286 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jun Gong >Assignee: Jun Gong > Attachments: YARN-5286.01.patch, YARN-5286.02.patch, > YARN-5286.03.patch, YARN-5286.04.patch, YARN-5286.05.patch > > > When getting app status by RM web service({{/ws/v1/cluster/apps/\{appid\}}}), > there is no RPC port info in the response. The port info is very important to > communicate with AM. > BTW: there is RPC port info when running {{bin/yarn application -status > appid}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5286) Add RPC port info in RM web service's response when getting app status
[ https://issues.apache.org/jira/browse/YARN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362822#comment-15362822 ] Varun Saxena commented on YARN-5286: +1 for the latest patch. Will commit it shortly. > Add RPC port info in RM web service's response when getting app status > -- > > Key: YARN-5286 > URL: https://issues.apache.org/jira/browse/YARN-5286 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jun Gong >Assignee: Jun Gong > Attachments: YARN-5286.01.patch, YARN-5286.02.patch, > YARN-5286.03.patch, YARN-5286.04.patch, YARN-5286.05.patch > > > When getting app status by RM web service({{/ws/v1/cluster/apps/\{appid\}}}), > there is no RPC port info in the response. The port info is very important to > communicate with AM. > BTW: there is RPC port info when running {{bin/yarn application -status > appid}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5286) Add RPC port info in RM web service's response when getting app status
[ https://issues.apache.org/jira/browse/YARN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361935#comment-15361935 ] Hadoop QA commented on YARN-5286: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 21s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 37s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 26s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 41s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 53s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 25s {color} | {color:green} trunk passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s {color} | {color:blue} Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 5s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s {color} | {color:green} trunk passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 41s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 12s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 12s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 33s {color} | {color:red} hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 57 unchanged - 1 fixed = 58 total (was 58) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 43s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 19s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s {color} | {color:blue} Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 0s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 24s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 35m 19s {color} | {color:green} hadoop-yarn-server-resourcemanager in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 7s {color} | {color:green} hadoop-yarn-site in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 17s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 56m 37s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:85209cc | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12816106/YARN-5286.05.patch | | JIRA Issue | YARN-5286 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 369faeb8c487 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 8b4b525 | | Default Java | 1.8.0_91 | | findbugs | v3.0.0 | | checkstyle |
[jira] [Commented] (YARN-5286) Add RPC port info in RM web service's response when getting app status
[ https://issues.apache.org/jira/browse/YARN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361896#comment-15361896 ] Jun Gong commented on YARN-5286: Thanks [~varun_saxena] for the review and comments. Attach a new patch to address your comments. I think there is no need to add extra interface to RMAppAttempt, so I store host and RPC port in a local variable according to your first suggestion. > Add RPC port info in RM web service's response when getting app status > -- > > Key: YARN-5286 > URL: https://issues.apache.org/jira/browse/YARN-5286 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jun Gong >Assignee: Jun Gong > Attachments: YARN-5286.01.patch, YARN-5286.02.patch, > YARN-5286.03.patch, YARN-5286.04.patch, YARN-5286.05.patch > > > When getting app status by RM web service({{/ws/v1/cluster/apps/\{appid\}}}), > there is no RPC port info in the response. The port info is very important to > communicate with AM. > BTW: there is RPC port info when running {{bin/yarn application -status > appid}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5286) Add RPC port info in RM web service's response when getting app status
[ https://issues.apache.org/jira/browse/YARN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361616#comment-15361616 ] Varun Saxena commented on YARN-5286: Thanks [~hex108] for the patch. I think we can reuse RMAppAttempt object used for getting master container in {{getAmRPCAddressFromRMApp}} instead of getting current attempt again. Moreover in getAmRPCAddressFromRMApp, we can store host and RPC port in a local variable or move this logic of generating AM RPC address to RMAppAttemptImpl and put it inside read lock. Reason being that in code below, host and rpc port may change between check for N/A and -1 and populating amRPCAddress if attempt fails in between. This may lead to an inconsistent response back to client. {code} if (attempt != null && !"N/A".equals(attempt.getHost()) && attempt.getRpcPort() != -1) { amRPCAddress = attempt.getHost() + ":" + attempt.getRpcPort(); } {code} > Add RPC port info in RM web service's response when getting app status > -- > > Key: YARN-5286 > URL: https://issues.apache.org/jira/browse/YARN-5286 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jun Gong >Assignee: Jun Gong > Attachments: YARN-5286.01.patch, YARN-5286.02.patch, > YARN-5286.03.patch, YARN-5286.04.patch > > > When getting app status by RM web service({{/ws/v1/cluster/apps/\{appid\}}}), > there is no RPC port info in the response. The port info is very important to > communicate with AM. > BTW: there is RPC port info when running {{bin/yarn application -status > appid}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5286) Add RPC port info in RM web service's response when getting app status
[ https://issues.apache.org/jira/browse/YARN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360899#comment-15360899 ] Jun Gong commented on YARN-5286: Test cases errors are not related. > Add RPC port info in RM web service's response when getting app status > -- > > Key: YARN-5286 > URL: https://issues.apache.org/jira/browse/YARN-5286 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jun Gong >Assignee: Jun Gong > Attachments: YARN-5286.01.patch, YARN-5286.02.patch, > YARN-5286.03.patch, YARN-5286.04.patch > > > When getting app status by RM web service({{/ws/v1/cluster/apps/\{appid\}}}), > there is no RPC port info in the response. The port info is very important to > communicate with AM. > BTW: there is RPC port info when running {{bin/yarn application -status > appid}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5286) Add RPC port info in RM web service's response when getting app status
[ https://issues.apache.org/jira/browse/YARN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360881#comment-15360881 ] Hadoop QA commented on YARN-5286: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 23s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 40s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 11s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 36s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 51s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 24s {color} | {color:green} trunk passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s {color} | {color:blue} Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 56s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s {color} | {color:green} trunk passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 37s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 7s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 7s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 35s {color} | {color:red} hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 57 unchanged - 1 fixed = 58 total (was 58) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 47s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 21s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s {color} | {color:blue} Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 2s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 37m 45s {color} | {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 8s {color} | {color:green} hadoop-yarn-site in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 57m 39s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.yarn.server.resourcemanager.TestRMRestart | | | hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:85209cc | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12815983/YARN-5286.04.patch | | JIRA Issue | YARN-5286 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux e924b01e7009 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality |
[jira] [Commented] (YARN-5286) Add RPC port info in RM web service's response when getting app status
[ https://issues.apache.org/jira/browse/YARN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360065#comment-15360065 ] Hadoop QA commented on YARN-5286: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 23s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 27s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 50s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 12s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 37s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 52s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 24s {color} | {color:green} trunk passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s {color} | {color:blue} Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 1s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s {color} | {color:green} trunk passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 39s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 23s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 23s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 37s {color} | {color:red} hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 57 unchanged - 1 fixed = 59 total (was 58) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 51s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 20s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s {color} | {color:blue} Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 9s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 30s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 36m 31s {color} | {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 8s {color} | {color:green} hadoop-yarn-site in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 17s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 57m 36s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.yarn.server.resourcemanager.TestRMAdminService | | | hadoop.yarn.server.resourcemanager.webapp.TestRMWebAppFairScheduler | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:85209cc | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12815873/YARN-5286.03.patch | | JIRA Issue | YARN-5286 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 103c63c7fab9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality |
[jira] [Commented] (YARN-5286) Add RPC port info in RM web service's response when getting app status
[ https://issues.apache.org/jira/browse/YARN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360042#comment-15360042 ] Jun Gong commented on YARN-5286: Thanks [~varun_saxena] for the review and comments! Attach a new patch to address above comments. > Add RPC port info in RM web service's response when getting app status > -- > > Key: YARN-5286 > URL: https://issues.apache.org/jira/browse/YARN-5286 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jun Gong >Assignee: Jun Gong > Attachments: YARN-5286.01.patch, YARN-5286.02.patch, > YARN-5286.03.patch > > > When getting app status by RM web service({{/ws/v1/cluster/apps/\{appid\}}}), > there is no RPC port info in the response. The port info is very important to > communicate with AM. > BTW: there is RPC port info when running {{bin/yarn application -status > appid}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5286) Add RPC port info in RM web service's response when getting app status
[ https://issues.apache.org/jira/browse/YARN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354717#comment-15354717 ] Varun Saxena commented on YARN-5286: [~hex108], thanks for the patch. A couple of comments : AM RPC address in AppInfo.java is being filled inside the check for master container not being null. But Master container is set when its allocated by scheduler, whereas AM host and RPC port is set when AM registers. There will be some time difference between both these events. I think we can explicitly check if host is not "N/A" and RPC port is not -1 to fill AM RPC address in response. Moreover, the additional field added can be added in documentation too in {{hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md}}. That is add the field in the response under the apps and app REST endpoint sections. > Add RPC port info in RM web service's response when getting app status > -- > > Key: YARN-5286 > URL: https://issues.apache.org/jira/browse/YARN-5286 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jun Gong >Assignee: Jun Gong > Attachments: YARN-5286.01.patch, YARN-5286.02.patch > > > When getting app status by RM web service({{/ws/v1/cluster/apps/\{appid\}}}), > there is no RPC port info in the response. The port info is very important to > communicate with AM. > BTW: there is RPC port info when running {{bin/yarn application -status > appid}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5286) Add RPC port info in RM web service's response when getting app status
[ https://issues.apache.org/jira/browse/YARN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354088#comment-15354088 ] Jun Gong commented on YARN-5286: Test case error is not related and addressed in YARN-5240. Checkstyle is an old problem. > Add RPC port info in RM web service's response when getting app status > -- > > Key: YARN-5286 > URL: https://issues.apache.org/jira/browse/YARN-5286 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jun Gong >Assignee: Jun Gong > Attachments: YARN-5286.01.patch, YARN-5286.02.patch > > > When getting app status by RM web service({{/ws/v1/cluster/apps/\{appid\}}}), > there is no RPC port info in the response. The port info is very important to > communicate with AM. > BTW: there is RPC port info when running {{bin/yarn application -status > appid}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5286) Add RPC port info in RM web service's response when getting app status
[ https://issues.apache.org/jira/browse/YARN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353237#comment-15353237 ] Hadoop QA commented on YARN-5286: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 23s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 1s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 21s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 36s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 3s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 31s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 31s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 20s {color} | {color:red} hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 57 unchanged - 1 fixed = 58 total (was 58) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 36s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 11s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 1s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 8s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 31m 55s {color} | {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 46m 52s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.yarn.server.resourcemanager.metrics.TestSystemMetricsPublisher | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:85209cc | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12814134/YARN-5286.02.patch | | JIRA Issue | YARN-5286 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux e75c8073b576 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / be38e53 | | Default Java | 1.8.0_91 | | findbugs | v3.0.0 | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/12157/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/12157/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt | | unit test logs | https://builds.apache.org/job/PreCommit-YARN-Build/12157/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/12157/testReport/ | | modules | C:
[jira] [Commented] (YARN-5286) Add RPC port info in RM web service's response when getting app status
[ https://issues.apache.org/jira/browse/YARN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353118#comment-15353118 ] Jun Gong commented on YARN-5286: Attach a new patch to fix test case error. > Add RPC port info in RM web service's response when getting app status > -- > > Key: YARN-5286 > URL: https://issues.apache.org/jira/browse/YARN-5286 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jun Gong >Assignee: Jun Gong > Attachments: YARN-5286.01.patch, YARN-5286.02.patch > > > When getting app status by RM web service({{/ws/v1/cluster/apps/\{appid\}}}), > there is no RPC port info in the response. The port info is very important to > communicate with AM. > BTW: there is RPC port info when running {{bin/yarn application -status > appid}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5286) Add RPC port info in RM web service's response when getting app status
[ https://issues.apache.org/jira/browse/YARN-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344418#comment-15344418 ] Hadoop QA commented on YARN-5286: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s {color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 10s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 19s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 33s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 53s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 27s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 26s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 26s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 17s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 31s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 11s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 57s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 31m 34s {color} | {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 44m 48s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:e2f6409 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12812474/YARN-5286.01.patch | | JIRA Issue | YARN-5286 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 4a69740b63eb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / d433b16 | | Default Java | 1.8.0_91 | | findbugs | v3.0.0 | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/12105/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt | | unit test logs | https://builds.apache.org/job/PreCommit-YARN-Build/12105/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/12105/testReport/ | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/12105/console