[jira] [Commented] (YARN-5394) Correct the wrong file name when mounting /etc/passwd to Docker Container
[ https://issues.apache.org/jira/browse/YARN-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395195#comment-15395195 ] Zhongyue Luo commented on YARN-5394: If we aren't going to mount /etc/passwd then I agree we should remove all attempts of mounting it and fix the user issue in 5360 > Correct the wrong file name when mounting /etc/passwd to Docker Container > - > > Key: YARN-5394 > URL: https://issues.apache.org/jira/browse/YARN-5394 > Project: Hadoop YARN > Issue Type: Sub-task > Components: yarn >Reporter: Zhankun Tang >Assignee: Zhankun Tang > Attachments: YARN-5394-branch-2.8.001.patch > > > Current LCE (DockerLinuxContainerRuntime) is mounting /etc/passwd to the > container. But it seems to use wrong file name "/etc/password" for container. > {panel} > .addMountLocation("/etc/passwd", "/etc/password:ro"); > {panel} > This causes LCE failed to launch the Docker container if the Docker images > don't create the same user name and UID in it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5394) Correct the wrong file name when mounting /etc/passwd to Docker Container
[ https://issues.apache.org/jira/browse/YARN-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392727#comment-15392727 ] Sidharta Seethana commented on YARN-5394: - Unfortunately, "correcting the typo" would change the current behavior and this could be disruptive. Removing the (bad) mount altogether and fixing it correctly in a different JIRA - that seems fine to me. Thoughts ? > Correct the wrong file name when mounting /etc/passwd to Docker Container > - > > Key: YARN-5394 > URL: https://issues.apache.org/jira/browse/YARN-5394 > Project: Hadoop YARN > Issue Type: Sub-task > Components: yarn >Reporter: Zhankun Tang >Assignee: Zhankun Tang > Attachments: YARN-5394-branch-2.8.001.patch > > > Current LCE (DockerLinuxContainerRuntime) is mounting /etc/passwd to the > container. But it seems to use wrong file name "/etc/password" for container. > {panel} > .addMountLocation("/etc/passwd", "/etc/password:ro"); > {panel} > This causes LCE failed to launch the Docker container if the Docker images > don't create the same user name and UID in it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5394) Correct the wrong file name when mounting /etc/passwd to Docker Container
[ https://issues.apache.org/jira/browse/YARN-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391332#comment-15391332 ] Zhankun Tang commented on YARN-5394: And I think the application can mount /etc/passwd thru the interface implemented in YARN-4595. So another choice is just remove this /etc/passwd bind-mount. > Correct the wrong file name when mounting /etc/passwd to Docker Container > - > > Key: YARN-5394 > URL: https://issues.apache.org/jira/browse/YARN-5394 > Project: Hadoop YARN > Issue Type: Sub-task > Components: yarn >Reporter: Zhankun Tang >Assignee: Zhankun Tang > Attachments: YARN-5394-branch-2.8.001.patch > > > Current LCE (DockerLinuxContainerRuntime) is mounting /etc/passwd to the > container. But it seems to use wrong file name "/etc/password" for container. > {panel} > .addMountLocation("/etc/passwd", "/etc/password:ro"); > {panel} > This causes LCE failed to launch the Docker container if the Docker images > don't create the same user name and UID in it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5394) Correct the wrong file name when mounting /etc/passwd to Docker Container
[ https://issues.apache.org/jira/browse/YARN-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391255#comment-15391255 ] Zhankun Tang commented on YARN-5394: [~sidharta-s], Yes. agree that there should be a way to disable it. But this JIRA is just for correting current typo issue. So I think we should close this JIRA and fill the improvement of this /etc/passwd mounting thing to a new JIRA. > Correct the wrong file name when mounting /etc/passwd to Docker Container > - > > Key: YARN-5394 > URL: https://issues.apache.org/jira/browse/YARN-5394 > Project: Hadoop YARN > Issue Type: Sub-task > Components: yarn >Reporter: Zhankun Tang >Assignee: Zhankun Tang > Attachments: YARN-5394-branch-2.8.001.patch > > > Current LCE (DockerLinuxContainerRuntime) is mounting /etc/passwd to the > container. But it seems to use wrong file name "/etc/password" for container. > {panel} > .addMountLocation("/etc/passwd", "/etc/password:ro"); > {panel} > This causes LCE failed to launch the Docker container if the Docker images > don't create the same user name and UID in it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5394) Correct the wrong file name when mounting /etc/passwd to Docker Container
[ https://issues.apache.org/jira/browse/YARN-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384999#comment-15384999 ] Sidharta Seethana commented on YARN-5394: - /cc [~zyluo], [~vvasudev] As discussed in YARN-5360, I don't think its a good idea to mount /etc/passwd into a container without any way to disable it. At a minimum, we should add a (cluster-wide?) mechanism to control this (and it should be disabled by default, IMO). > Correct the wrong file name when mounting /etc/passwd to Docker Container > - > > Key: YARN-5394 > URL: https://issues.apache.org/jira/browse/YARN-5394 > Project: Hadoop YARN > Issue Type: Sub-task > Components: yarn >Reporter: Zhankun Tang >Assignee: Zhankun Tang > Attachments: YARN-5394-branch-2.8.001.patch > > > Current LCE (DockerLinuxContainerRuntime) is mounting /etc/passwd to the > container. But it seems to use wrong file name "/etc/password" for container. > {panel} > .addMountLocation("/etc/passwd", "/etc/password:ro"); > {panel} > This causes LCE failed to launch the Docker container if the Docker images > don't create the same user name and UID in it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5394) Correct the wrong file name when mounting /etc/passwd to Docker Container
[ https://issues.apache.org/jira/browse/YARN-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382380#comment-15382380 ] Daniel Templeton commented on YARN-5394: Thanks for catching that, [~tangzhankun]! The patch itself looks fine, but I have some higher level concerns. Without also adding /etc/groups and maybe /etc/shadow, I don't think there's much value to mounting /etc/passwd. I'm also worried that the /etc/password mount point may have been intentional. [~vvasudev], any thoughts? > Correct the wrong file name when mounting /etc/passwd to Docker Container > - > > Key: YARN-5394 > URL: https://issues.apache.org/jira/browse/YARN-5394 > Project: Hadoop YARN > Issue Type: Sub-task > Components: yarn >Reporter: Zhankun Tang >Assignee: Zhankun Tang > Attachments: YARN-5394-branch-2.8.001.patch > > > Current LCE (DockerLinuxContainerRuntime) is mounting /etc/passwd to the > container. But it seems to use wrong file name "/etc/password" for container. > {panel} > .addMountLocation("/etc/passwd", "/etc/password:ro"); > {panel} > This causes LCE failed to launch the Docker container if the Docker images > don't create the same user name and UID in it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org