[jira] [Commented] (YARN-5440) Use AHSClient in YarnClient when TimelineServer is running
[ https://issues.apache.org/jira/browse/YARN-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397877#comment-15397877 ] Hudson commented on YARN-5440: -- SUCCESS: Integrated in Hadoop-trunk-Commit #10169 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10169/]) YARN-5440. Use AHSClient in YarnClient when TimelineServer is running. (gtcarrera9: rev 26de4f0de789f58736d1dc383125cffb54debdd0) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java > Use AHSClient in YarnClient when TimelineServer is running > -- > > Key: YARN-5440 > URL: https://issues.apache.org/jira/browse/YARN-5440 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: Xuan Gong >Assignee: Xuan Gong > Fix For: 2.9.0, 3.0.0-alpha2 > > Attachments: YARN-5440.1.patch > > > In YarnClient, depends on whether we enable > yarn.timeline-service.generic-application-history.enabled, the AHSClient will > be used or not. But the AHSClientService is enabled by default when we start > the TimelineServer which means we are able to get history information for > applications/applicationAttempts/containers by using ahsClient when the > TimelineServer is running. So, we do not have to rely on this deprecated > configuration to get history information by using YarnClient. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5440) Use AHSClient in YarnClient when TimelineServer is running
[ https://issues.apache.org/jira/browse/YARN-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397849#comment-15397849 ] Li Lu commented on YARN-5440: - Will commit shortly. > Use AHSClient in YarnClient when TimelineServer is running > -- > > Key: YARN-5440 > URL: https://issues.apache.org/jira/browse/YARN-5440 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: Xuan Gong >Assignee: Xuan Gong > Attachments: YARN-5440.1.patch > > > In YarnClient, depends on whether we enable > yarn.timeline-service.generic-application-history.enabled, the AHSClient will > be used or not. But the AHSClientService is enabled by default when we start > the TimelineServer which means we are able to get history information for > applications/applicationAttempts/containers by using ahsClient when the > TimelineServer is running. So, we do not have to rely on this deprecated > configuration to get history information by using YarnClient. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5440) Use AHSClient in YarnClient when TimelineServer is running
[ https://issues.apache.org/jira/browse/YARN-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396675#comment-15396675 ] Li Lu commented on YARN-5440: - Thanks [~xgong]! LGTM. +1 for commit. > Use AHSClient in YarnClient when TimelineServer is running > -- > > Key: YARN-5440 > URL: https://issues.apache.org/jira/browse/YARN-5440 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: Xuan Gong >Assignee: Xuan Gong > Attachments: YARN-5440.1.patch > > > In YarnClient, depends on whether we enable > yarn.timeline-service.generic-application-history.enabled, the AHSClient will > be used or not. But the AHSClientService is enabled by default when we start > the TimelineServer which means we are able to get history information for > applications/applicationAttempts/containers by using ahsClient when the > TimelineServer is running. So, we do not have to rely on this deprecated > configuration to get history information by using YarnClient. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5440) Use AHSClient in YarnClient when TimelineServer is running
[ https://issues.apache.org/jira/browse/YARN-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396656#comment-15396656 ] Xuan Gong commented on YARN-5440: - Thanks for the review. [~gtCarrera9] Created https://issues.apache.org/jira/browse/YARN-5442 to track the testcase failures. bq. if the user turn off timeline service but enable AHS in the config. So, the configuration: yarn.timeline-service.generic-application-history.enabled is deprecated configuration which means we could remove this configuration without any impact (If i understand the deprecate correctly). In current code base, this configuration controls whether we could get the full information (include current and history) for the apps/attempts/containers by using YarnClient. But the pre-requirement is that we have to run the TimelineServer. If we turn off the timeline server but enable AHS, it would give the connection exception because it tries to connect the ATS. > Use AHSClient in YarnClient when TimelineServer is running > -- > > Key: YARN-5440 > URL: https://issues.apache.org/jira/browse/YARN-5440 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: Xuan Gong >Assignee: Xuan Gong > Attachments: YARN-5440.1.patch > > > In YarnClient, depends on whether we enable > yarn.timeline-service.generic-application-history.enabled, the AHSClient will > be used or not. But the AHSClientService is enabled by default when we start > the TimelineServer which means we are able to get history information for > applications/applicationAttempts/containers by using ahsClient when the > TimelineServer is running. So, we do not have to rely on this deprecated > configuration to get history information by using YarnClient. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5440) Use AHSClient in YarnClient when TimelineServer is running
[ https://issues.apache.org/jira/browse/YARN-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396600#comment-15396600 ] Junping Du commented on YARN-5440: -- bq. if the user turn off timeline service but enable AHS in the config. In my understanding, if we enable AHS config but turn of timeline service, we will still create AHSClient to get finished application container information. The only different w/o the patch here is: this new added feature (log CLI enhancement) in 2.9 don't have to work by explicitly set a deprecated configuration of AHS. Instead, it also work with enabling ATS only. [~xgong], can you confirm this? > Use AHSClient in YarnClient when TimelineServer is running > -- > > Key: YARN-5440 > URL: https://issues.apache.org/jira/browse/YARN-5440 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: Xuan Gong >Assignee: Xuan Gong > Attachments: YARN-5440.1.patch > > > In YarnClient, depends on whether we enable > yarn.timeline-service.generic-application-history.enabled, the AHSClient will > be used or not. But the AHSClientService is enabled by default when we start > the TimelineServer which means we are able to get history information for > applications/applicationAttempts/containers by using ahsClient when the > TimelineServer is running. So, we do not have to rely on this deprecated > configuration to get history information by using YarnClient. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5440) Use AHSClient in YarnClient when TimelineServer is running
[ https://issues.apache.org/jira/browse/YARN-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396476#comment-15396476 ] Li Lu commented on YARN-5440: - I cannot reproduce the UT failure locally either. [~xgong] could you please open a separate JIRA to trace the UT failure? Patch generally LGTM. One question is that what will happen if the user turn off timeline service but enable AHS in the config? > Use AHSClient in YarnClient when TimelineServer is running > -- > > Key: YARN-5440 > URL: https://issues.apache.org/jira/browse/YARN-5440 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: Xuan Gong >Assignee: Xuan Gong > Attachments: YARN-5440.1.patch > > > In YarnClient, depends on whether we enable > yarn.timeline-service.generic-application-history.enabled, the AHSClient will > not be used. But the AHSClientService is enabled by default when we start the > TimelineServer which means we are able to get history information for > applications/applicationAttempts/containers by using ahsClient when the > TimelineServer is running. So, we do not have to reply on this deprecated > configuration to get history information by using YarnClient. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5440) Use AHSClient in YarnClient when TimelineServer is running
[ https://issues.apache.org/jira/browse/YARN-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396435#comment-15396435 ] Xuan Gong commented on YARN-5440: - The testcase failures are not related > Use AHSClient in YarnClient when TimelineServer is running > -- > > Key: YARN-5440 > URL: https://issues.apache.org/jira/browse/YARN-5440 > Project: Hadoop YARN > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: Xuan Gong >Assignee: Xuan Gong > Attachments: YARN-5440.1.patch > > > In YarnClient, depends on whether we enable > yarn.timeline-service.generic-application-history.enabled, the AHSClient will > not be used. But the AHSClientService is enabled by default when we start the > TimelineServer which means we are able to get history information for > applications/applicationAttempts/containers by using ahsClient when the > TimelineServer is running. So, we do not have to reply on this deprecated > configuration to get history information by using YarnClient. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5440) Use AHSClient in YarnClient when TimelineServer is running
[
https://issues.apache.org/jira/browse/YARN-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396395#comment-15396395
]
Hadoop QA commented on YARN-5440:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
17s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 23s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
17s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 28s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
32s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
20s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 20s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s {color} | {color:green} hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client:
The patch generated 0 new + 30 unchanged - 1 fixed = 30 total (was 31) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 26s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
41s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 13s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 8m 23s {color}
| {color:red} hadoop-yarn-client in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 28s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.yarn.client.api.impl.TestYarnClient |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12820549/YARN-5440.1.patch |
| JIRA Issue | YARN-5440 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux f0fa7c32b47a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 54fe17a |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| unit |
https://builds.apache.org/job/PreCommit-YARN-Build/12527/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
|
| unit test logs |
https://builds.apache.org/job/PreCommit-YARN-Build/12527/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/12527/testReport/ |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/12527/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.o
