[jira] [Commented] (YARN-5572) HBaseTimelineWriterImpl appears to reference a bad property name
[
https://issues.apache.org/jira/browse/YARN-5572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15733257#comment-15733257
]
Sangjin Lee commented on YARN-5572:
---
I also committed this to YARN-5355-branch-2. Any trunk changes for timeline
service v.2 needs to be committed to YARN-5355-branch-2 as they are not picked
up by rebase.
> HBaseTimelineWriterImpl appears to reference a bad property name
>
>
> Key: YARN-5572
> URL: https://issues.apache.org/jira/browse/YARN-5572
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Daniel Templeton
>Assignee: Varun Saxena
> Fix For: 3.0.0-alpha2
>
> Attachments: YARN-5572.01.patch
>
>
> This constructor:
> {code}
> public HBaseTimelineWriterImpl(Configuration conf) throws IOException {
> super(conf.get("yarn.application.id",
> HBaseTimelineWriterImpl.class.getName()));
> }
> {code}
> references "yarn.application.id", which is the only reference to this
> property I could find.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5572) HBaseTimelineWriterImpl appears to reference a bad property name
[
https://issues.apache.org/jira/browse/YARN-5572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15700102#comment-15700102
]
Hudson commented on YARN-5572:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10895 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/10895/])
YARN-5572. HBaseTimelineWriterImpl appears to reference a bad property
(naganarasimha_gr: rev c06114d6a360dddeb66c2dd9ad4fa5dae0cfbfb1)
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/DataGeneratorForTest.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/flow/TestHBaseStorageFlowRunCompaction.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesHBaseStorage.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/flow/TestHBaseStorageFlowRun.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/storage/HBaseTimelineWriterImpl.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/flow/TestHBaseStorageFlowActivity.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/TestHBaseTimelineStorageEntities.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/storage/TestHBaseTimelineStorageApps.java
> HBaseTimelineWriterImpl appears to reference a bad property name
>
>
> Key: YARN-5572
> URL: https://issues.apache.org/jira/browse/YARN-5572
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Daniel Templeton
>Assignee: Varun Saxena
> Attachments: YARN-5572.01.patch
>
>
> This constructor:
> {code}
> public HBaseTimelineWriterImpl(Configuration conf) throws IOException {
> super(conf.get("yarn.application.id",
> HBaseTimelineWriterImpl.class.getName()));
> }
> {code}
> references "yarn.application.id", which is the only reference to this
> property I could find.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5572) HBaseTimelineWriterImpl appears to reference a bad property name
[
https://issues.apache.org/jira/browse/YARN-5572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15699409#comment-15699409
]
Naganarasimha G R commented on YARN-5572:
-
Thanks [~varun_saxena], for working on the patch, *HBaseTimelineWriterImpl* is
created through reflection and initialized by the configuration object later
{code}
public void serviceInit(Configuration conf) throws Exception {
writer = ReflectionUtils.newInstance(conf.getClass(
YarnConfiguration.TIMELINE_SERVICE_WRITER_CLASS,
HBaseTimelineWriterImpl.class,
TimelineWriter.class), conf);
writer.init(conf);
...
}
{code}
hence i do not see the need for the constructor. Will commit the patch shortly.
> HBaseTimelineWriterImpl appears to reference a bad property name
>
>
> Key: YARN-5572
> URL: https://issues.apache.org/jira/browse/YARN-5572
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Daniel Templeton
>Assignee: Varun Saxena
> Attachments: YARN-5572.01.patch
>
>
> This constructor:
> {code}
> public HBaseTimelineWriterImpl(Configuration conf) throws IOException {
> super(conf.get("yarn.application.id",
> HBaseTimelineWriterImpl.class.getName()));
> }
> {code}
> references "yarn.application.id", which is the only reference to this
> property I could find.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5572) HBaseTimelineWriterImpl appears to reference a bad property name
[
https://issues.apache.org/jira/browse/YARN-5572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15692363#comment-15692363
]
Akira Ajisaka commented on YARN-5572:
-
LGTM, +1.
> HBaseTimelineWriterImpl appears to reference a bad property name
>
>
> Key: YARN-5572
> URL: https://issues.apache.org/jira/browse/YARN-5572
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Daniel Templeton
>Assignee: Varun Saxena
> Attachments: YARN-5572.01.patch
>
>
> This constructor:
> {code}
> public HBaseTimelineWriterImpl(Configuration conf) throws IOException {
> super(conf.get("yarn.application.id",
> HBaseTimelineWriterImpl.class.getName()));
> }
> {code}
> references "yarn.application.id", which is the only reference to this
> property I could find.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5572) HBaseTimelineWriterImpl appears to reference a bad property name
[
https://issues.apache.org/jira/browse/YARN-5572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690956#comment-15690956
]
Hadoop QA commented on YARN-5572:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 7 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
56s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
43s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
46s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
45s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
58s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
48s{color} | {color:green} hadoop-yarn-server-timelineservice in the patch
passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m
45s{color} | {color:green} hadoop-yarn-server-timelineservice-hbase-tests in
the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 30m 24s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | YARN-5572 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12840099/YARN-5572.01.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 7ffd7418aad9 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28
20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 005850b |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/14063/testReport/ |
| modules | C:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests
U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/14063/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was
[jira] [Commented] (YARN-5572) HBaseTimelineWriterImpl appears to reference a bad property name
[
https://issues.apache.org/jira/browse/YARN-5572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15687752#comment-15687752
]
Varun Saxena commented on YARN-5572:
This constructor is unnecessary. Removed it.
> HBaseTimelineWriterImpl appears to reference a bad property name
>
>
> Key: YARN-5572
> URL: https://issues.apache.org/jira/browse/YARN-5572
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Daniel Templeton
>Assignee: Varun Saxena
> Attachments: YARN-5572.01.patch
>
>
> This constructor:
> {code}
> public HBaseTimelineWriterImpl(Configuration conf) throws IOException {
> super(conf.get("yarn.application.id",
> HBaseTimelineWriterImpl.class.getName()));
> }
> {code}
> references "yarn.application.id", which is the only reference to this
> property I could find.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
