[jira] [Commented] (YARN-5710) Fix inconsistent naming in class ResourceRequest

2016-10-27 Thread Yufei Gu (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612399#comment-15612399
 ] 

Yufei Gu commented on YARN-5710:


Thanks [~sunilg] and [~varun_saxena] for the review and commit. Thanks [~kasha] 
for the offline review.

> Fix inconsistent naming in class ResourceRequest
> 
>
> Key: YARN-5710
> URL: https://issues.apache.org/jira/browse/YARN-5710
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: yarn
>Reporter: Yufei Gu
>Assignee: Yufei Gu
>Priority: Trivial
> Fix For: 2.9.0, 3.0.0-alpha2
>
> Attachments: YARN-5710.001.patch, YARN-5710.002.patch
>
>
>  "node", "machine" and "host" are the same thing with different name in this 
> context. Consolidate them to "node". 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-5710) Fix inconsistent naming in class ResourceRequest

2016-10-27 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611192#comment-15611192
 ] 

Hudson commented on YARN-5710:
--

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10699 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/10699/])
YARN-5710. Fix inconsistent naming in class ResourceRequest (Yufei Gu 
(varunsaxena: rev 6cc7c438661f07cddb5fbe36338a380117eba663)
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceRequest.java


> Fix inconsistent naming in class ResourceRequest
> 
>
> Key: YARN-5710
> URL: https://issues.apache.org/jira/browse/YARN-5710
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: yarn
>Reporter: Yufei Gu
>Assignee: Yufei Gu
>Priority: Trivial
> Fix For: 2.9.0, 3.0.0-alpha2
>
> Attachments: YARN-5710.001.patch, YARN-5710.002.patch
>
>
>  "node", "machine" and "host" are the same thing with different name in this 
> context. Consolidate them to "node". 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-5710) Fix inconsistent naming in class ResourceRequest

2016-10-27 Thread Varun Saxena (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611159#comment-15611159
 ] 

Varun Saxena commented on YARN-5710:


Committed to trunk, branch-2.
Thanks [~yufeigu] for your contribution.

> Fix inconsistent naming in class ResourceRequest
> 
>
> Key: YARN-5710
> URL: https://issues.apache.org/jira/browse/YARN-5710
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: yarn
>Reporter: Yufei Gu
>Assignee: Yufei Gu
>Priority: Trivial
> Fix For: 2.9.0, 3.0.0-alpha2
>
> Attachments: YARN-5710.001.patch, YARN-5710.002.patch
>
>
>  "node", "machine" and "host" are the same thing with different name in this 
> context. Consolidate them to "node". 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-5710) Fix inconsistent naming in class ResourceRequest

2016-10-27 Thread Sunil G (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611152#comment-15611152
 ] 

Sunil G commented on YARN-5710:
---

Looks fine for me. cc/[~rohithsharma]

> Fix inconsistent naming in class ResourceRequest
> 
>
> Key: YARN-5710
> URL: https://issues.apache.org/jira/browse/YARN-5710
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: yarn
>Reporter: Yufei Gu
>Assignee: Yufei Gu
>Priority: Trivial
> Attachments: YARN-5710.001.patch, YARN-5710.002.patch
>
>
>  "node", "machine" and "host" are the same thing with different name in this 
> context. Consolidate them to "node". 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-5710) Fix inconsistent naming in class ResourceRequest

2016-10-04 Thread Yufei Gu (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547079#comment-15547079
 ] 

Yufei Gu commented on YARN-5710:


No need to add unit test.

> Fix inconsistent naming in class ResourceRequest
> 
>
> Key: YARN-5710
> URL: https://issues.apache.org/jira/browse/YARN-5710
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: yarn
>Reporter: Yufei Gu
>Assignee: Yufei Gu
>Priority: Trivial
> Attachments: YARN-5710.001.patch, YARN-5710.002.patch
>
>
>  "node", "machine" and "host" are the same thing with different name in this 
> context. Consolidate them to "node". 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-5710) Fix inconsistent naming in class ResourceRequest

2016-10-04 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547063#comment-15547063
 ] 

Hadoop QA commented on YARN-5710:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s 
{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 
44s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s 
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 
13s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 26s 
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
12s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 2s 
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s 
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 
22s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 20s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 
10s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 24s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
9s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 5s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 14s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 21s 
{color} | {color:green} hadoop-yarn-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
15s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 30s {color} 
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:9560f25 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12831645/YARN-5710.002.patch |
| JIRA Issue | YARN-5710 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux a0811dff0277 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 
17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / 44f48ee |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/13283/testReport/ |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api U: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/13283/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Fix inconsistent naming in class ResourceRequest
> 
>
> Key: YARN-5710
> URL: https://issues.apache.org/jira/browse/YARN-5710
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: yarn
>Reporter: Yufei Gu
>Assignee: Yufei Gu
>Priority: Trivial
> Attachments: YARN-5710.001.patch, YARN-5710.002.patch
>
>
>  "node", "machine" and "host" are the same

[jira] [Commented] (YARN-5710) Fix inconsistent naming in class ResourceRequest

2016-10-04 Thread Yufei Gu (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547003#comment-15547003
 ] 

Yufei Gu commented on YARN-5710:


Since "host" is used in many place, we think "host" should be fine, and change 
"machine" to "host" in patch 002. 

> Fix inconsistent naming in class ResourceRequest
> 
>
> Key: YARN-5710
> URL: https://issues.apache.org/jira/browse/YARN-5710
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: yarn
>Reporter: Yufei Gu
>Assignee: Yufei Gu
>Priority: Trivial
> Attachments: YARN-5710.001.patch, YARN-5710.002.patch
>
>
>  "node", "machine" and "host" are the same thing with different name in this 
> context. Consolidate them to "node". 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-5710) Fix inconsistent naming in class ResourceRequest

2016-10-04 Thread Yufei Gu (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546956#comment-15546956
 ] 

Yufei Gu commented on YARN-5710:


It is OK to leave the style issue alone and not add any unit test since the 
patch doesn't change any logic. 

> Fix inconsistent naming in class ResourceRequest
> 
>
> Key: YARN-5710
> URL: https://issues.apache.org/jira/browse/YARN-5710
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: yarn
>Reporter: Yufei Gu
>Assignee: Yufei Gu
>Priority: Trivial
> Attachments: YARN-5710.001.patch
>
>
>  "node", "machine" and "host" are the same thing with different name in this 
> context. Consolidate them to "node". 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-5710) Fix inconsistent naming in class ResourceRequest

2016-10-04 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546907#comment-15546907
 ] 

Hadoop QA commented on YARN-5710:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s 
{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 
35s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 29s 
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 
17s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 32s 
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
14s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 
12s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 22s 
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 
32s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 27s 
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s 
{color} | {color:red} hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api: The 
patch generated 1 new + 16 unchanged - 1 fixed = 17 total (was 17) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 31s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
12s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 
21s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 28s 
{color} | {color:green} hadoop-yarn-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
18s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 17m 3s {color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:9560f25 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12831629/YARN-5710.001.patch |
| JIRA Issue | YARN-5710 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux bb90a2f1f490 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 
17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / 44f48ee |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-YARN-Build/13282/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/13282/testReport/ |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api U: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/13282/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Fix inconsistent naming in class ResourceRequest
> 
>
> Key: YARN-5710
> URL: https://issues.apache.org/jira/browse/YARN-5710
> Project: Hadoop