[jira] [Commented] (YARN-5800) Delete LinuxContainerExecutor comment from yarn-default.xml
[ https://issues.apache.org/jira/browse/YARN-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15639187#comment-15639187 ] ASF GitHub Bot commented on YARN-5800: -- Github user HorizonNet commented on the issue: https://github.com/apache/hadoop/pull/149 This one was already applied to trunk via [this commit](https://github.com/apache/hadoop/commit/773c60bd7bd00651dc3016799b424b9bd2233eb3). > Delete LinuxContainerExecutor comment from yarn-default.xml > --- > > Key: YARN-5800 > URL: https://issues.apache.org/jira/browse/YARN-5800 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn >Reporter: Daniel Templeton >Assignee: Jan Hentschel >Priority: Trivial > Labels: newbie > Fix For: 3.0.0-alpha2 > > Attachments: YARN-5800.001.patch > > > In {{yarn-default.xml}} there's an extraneous comment line in the > {{yarn.nodemanager.container-executor.class}} property. Since admins > shouldn't typically be modifying this file, this comment isn't useful. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5800) Delete LinuxContainerExecutor comment from yarn-default.xml
[ https://issues.apache.org/jira/browse/YARN-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15639186#comment-15639186 ] ASF GitHub Bot commented on YARN-5800: -- Github user HorizonNet closed the pull request at: https://github.com/apache/hadoop/pull/149 > Delete LinuxContainerExecutor comment from yarn-default.xml > --- > > Key: YARN-5800 > URL: https://issues.apache.org/jira/browse/YARN-5800 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn >Reporter: Daniel Templeton >Assignee: Jan Hentschel >Priority: Trivial > Labels: newbie > Fix For: 3.0.0-alpha2 > > Attachments: YARN-5800.001.patch > > > In {{yarn-default.xml}} there's an extraneous comment line in the > {{yarn.nodemanager.container-executor.class}} property. Since admins > shouldn't typically be modifying this file, this comment isn't useful. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5800) Delete LinuxContainerExecutor comment from yarn-default.xml
[ https://issues.apache.org/jira/browse/YARN-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15623597#comment-15623597 ] Hudson commented on YARN-5800: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10736 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10736/]) YARN-5800. Delete LinuxContainerExecutor comment from yarn-default.xml (templedf: rev 773c60bd7bd00651dc3016799b424b9bd2233eb3) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml > Delete LinuxContainerExecutor comment from yarn-default.xml > --- > > Key: YARN-5800 > URL: https://issues.apache.org/jira/browse/YARN-5800 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn >Reporter: Daniel Templeton >Assignee: Jan Hentschel >Priority: Trivial > Labels: newbie > Fix For: 3.0.0-alpha2 > > Attachments: YARN-5800.001.patch > > > In {{yarn-default.xml}} there's an extraneous comment line in the > {{yarn.nodemanager.container-executor.class}} property. Since admins > shouldn't typically be modifying this file, this comment isn't useful. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5800) Delete LinuxContainerExecutor comment from yarn-default.xml
[ https://issues.apache.org/jira/browse/YARN-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15623566#comment-15623566 ] Jan Hentschel commented on YARN-5800: - [~templedf] Thanks. Should I close the pull request? > Delete LinuxContainerExecutor comment from yarn-default.xml > --- > > Key: YARN-5800 > URL: https://issues.apache.org/jira/browse/YARN-5800 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn >Reporter: Daniel Templeton >Assignee: Jan Hentschel >Priority: Trivial > Labels: newbie > Fix For: 3.0.0-alpha2 > > Attachments: YARN-5800.001.patch > > > In {{yarn-default.xml}} there's an extraneous comment line in the > {{yarn.nodemanager.container-executor.class}} property. Since admins > shouldn't typically be modifying this file, this comment isn't useful. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5800) Delete LinuxContainerExecutor comment from yarn-default.xml
[ https://issues.apache.org/jira/browse/YARN-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15623382#comment-15623382 ] Hadoop QA commented on YARN-5800: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 4m 48s{color} | {color:red} root in trunk failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 28s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 35s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 11s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 30s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 34s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 54s{color} | {color:red} hadoop-yarn-common in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 17s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 12m 0s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.yarn.util.TestFSDownload | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:9560f25 | | JIRA Issue | YARN-5800 | | GITHUB PR | https://github.com/apache/hadoop/pull/149 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit xml | | uname | Linux 6096e3596e6f 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 2528bea | | Default Java | 1.8.0_101 | | mvninstall | https://builds.apache.org/job/PreCommit-YARN-Build/13703/artifact/patchprocess/branch-mvninstall-root.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/13703/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/13703/testReport/ | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/13703/console | | Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Delete LinuxContainerExecutor comment from yarn-default.xml > --- > > Key: YARN-5800 > URL: https://issues.apache.org/jira/browse/YARN-5800 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn >Reporter: Daniel Templeton >Priority: Trivial > Labels: newbie > Attachments: YARN-5800.001.patch > > > In {{yarn-default.xml}} there's an extraneous comment line in the >
[jira] [Commented] (YARN-5800) Delete LinuxContainerExecutor comment from yarn-default.xml
[ https://issues.apache.org/jira/browse/YARN-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15623358#comment-15623358 ] Varun Saxena commented on YARN-5800: Actually I was under the impression that PR will be automatically picked up by Jenkins. Not sure why build wasn't invoked. Maybe I am mistaken.:) > Delete LinuxContainerExecutor comment from yarn-default.xml > --- > > Key: YARN-5800 > URL: https://issues.apache.org/jira/browse/YARN-5800 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn >Reporter: Daniel Templeton >Priority: Trivial > Labels: newbie > Attachments: YARN-5800.001.patch > > > In {{yarn-default.xml}} there's an extraneous comment line in the > {{yarn.nodemanager.container-executor.class}} property. Since admins > shouldn't typically be modifying this file, this comment isn't useful. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5800) Delete LinuxContainerExecutor comment from yarn-default.xml
[ https://issues.apache.org/jira/browse/YARN-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15623300#comment-15623300 ] Hadoop QA commented on YARN-5800: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 22s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 8s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 30s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 2s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 15s{color} | {color:green} hadoop-yarn-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 14m 9s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:9560f25 | | JIRA Issue | YARN-5800 | | GITHUB PR | https://github.com/apache/hadoop/pull/149 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit xml | | uname | Linux ec0d39dd5f21 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / a9d68d2 | | Default Java | 1.8.0_101 | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/13702/testReport/ | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/13702/console | | Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Delete LinuxContainerExecutor comment from yarn-default.xml > --- > > Key: YARN-5800 > URL: https://issues.apache.org/jira/browse/YARN-5800 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn >Reporter: Daniel Templeton >Priority: Trivial > Labels: newbie > Attachments: YARN-5800.001.patch > > > In {{yarn-default.xml}} there's an extraneous comment line in the > {{yarn.nodemanager.container-executor.class}} property. Since admins > shouldn't typically be modifying this file, this comment isn't useful. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail:
[jira] [Commented] (YARN-5800) Delete LinuxContainerExecutor comment from yarn-default.xml
[ https://issues.apache.org/jira/browse/YARN-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15620573#comment-15620573 ] Varun Saxena commented on YARN-5800: [~Jan Hentschel], pull request should be fine. What Naga meant was that we did not invoke Jenkins for this by submitting patch. But looking at the changes, its probably not even required. I have anyways submitted the patch though. > Delete LinuxContainerExecutor comment from yarn-default.xml > --- > > Key: YARN-5800 > URL: https://issues.apache.org/jira/browse/YARN-5800 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn >Reporter: Daniel Templeton >Priority: Trivial > Labels: newbie > > In {{yarn-default.xml}} there's an extraneous comment line in the > {{yarn.nodemanager.container-executor.class}} property. Since admins > shouldn't typically be modifying this file, this comment isn't useful. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5800) Delete LinuxContainerExecutor comment from yarn-default.xml
[ https://issues.apache.org/jira/browse/YARN-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15620568#comment-15620568 ] Jan Hentschel commented on YARN-5800: - I opened the pull request. Wasn't sure about the whole process. If you like I can also attach a patch to this issue. > Delete LinuxContainerExecutor comment from yarn-default.xml > --- > > Key: YARN-5800 > URL: https://issues.apache.org/jira/browse/YARN-5800 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn >Reporter: Daniel Templeton >Priority: Trivial > Labels: newbie > > In {{yarn-default.xml}} there's an extraneous comment line in the > {{yarn.nodemanager.container-executor.class}} property. Since admins > shouldn't typically be modifying this file, this comment isn't useful. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5800) Delete LinuxContainerExecutor comment from yarn-default.xml
[ https://issues.apache.org/jira/browse/YARN-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15620250#comment-15620250 ] Daniel Templeton commented on YARN-5800: The PR is a little confusing for such a small patch, but I don't have an issue with it. The patch is from [~Jan Hentschel] as [https://github.com/HorizonNet]. > Delete LinuxContainerExecutor comment from yarn-default.xml > --- > > Key: YARN-5800 > URL: https://issues.apache.org/jira/browse/YARN-5800 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn >Reporter: Daniel Templeton >Priority: Trivial > Labels: newbie > > In {{yarn-default.xml}} there's an extraneous comment line in the > {{yarn.nodemanager.container-executor.class}} property. Since admins > shouldn't typically be modifying this file, this comment isn't useful. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5800) Delete LinuxContainerExecutor comment from yarn-default.xml
[ https://issues.apache.org/jira/browse/YARN-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15620239#comment-15620239 ] Naganarasimha G R commented on YARN-5800: - Patch looks fine but who submitted it and why not submit the patch ? > Delete LinuxContainerExecutor comment from yarn-default.xml > --- > > Key: YARN-5800 > URL: https://issues.apache.org/jira/browse/YARN-5800 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn >Reporter: Daniel Templeton >Priority: Trivial > Labels: newbie > > In {{yarn-default.xml}} there's an extraneous comment line in the > {{yarn.nodemanager.container-executor.class}} property. Since admins > shouldn't typically be modifying this file, this comment isn't useful. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5800) Delete LinuxContainerExecutor comment from yarn-default.xml
[ https://issues.apache.org/jira/browse/YARN-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15620172#comment-15620172 ] Daniel Templeton commented on YARN-5800: LGTM +1 I'll commit on Monday if no one objects. > Delete LinuxContainerExecutor comment from yarn-default.xml > --- > > Key: YARN-5800 > URL: https://issues.apache.org/jira/browse/YARN-5800 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn >Reporter: Daniel Templeton >Priority: Trivial > Labels: newbie > > In {{yarn-default.xml}} there's an extraneous comment line in the > {{yarn.nodemanager.container-executor.class}} property. Since admins > shouldn't typically be modifying this file, this comment isn't useful. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5800) Delete LinuxContainerExecutor comment from yarn-default.xml
[ https://issues.apache.org/jira/browse/YARN-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15619540#comment-15619540 ] ASF GitHub Bot commented on YARN-5800: -- GitHub user HorizonNet opened a pull request: https://github.com/apache/hadoop/pull/149 YARN-5800: Deleted LinuxContainerExecutor comment from yarn-default.xml https://issues.apache.org/jira/browse/YARN-5800 - Removed the comment about LinuxContainerExecutor from the yarn-default.xml file You can merge this pull request into a Git repository by running: $ git pull https://github.com/ultratendency/hadoop YARN-5800 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/149.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #149 commit a329d9d674d8bfacd60bb17474ca37de8111541a Author: Jan HentschelDate: 2016-10-30T08:07:28Z YARN-5800: Deleted LinuxContainerExecutor comment from yarn-default.xml - Removed the comment about LinuxContainerExecutor from the yarn-default.xml file > Delete LinuxContainerExecutor comment from yarn-default.xml > --- > > Key: YARN-5800 > URL: https://issues.apache.org/jira/browse/YARN-5800 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn >Reporter: Daniel Templeton >Priority: Trivial > Labels: newbie > > In {{yarn-default.xml}} there's an extraneous comment line in the > {{yarn.nodemanager.container-executor.class}} property. Since admins > shouldn't typically be modifying this file, this comment isn't useful. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org