[jira] [Commented] (YARN-610) ClientToken should not be set in the environment
[ https://issues.apache.org/jira/browse/YARN-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13685005#comment-13685005 ] Omkar Vinit Joshi commented on YARN-610: bq. Seems like the patch has gone stale, can you rebase? rebased.. bq. File a MR ticket too as a followup tracking MR changes. MAPREDUCE-5328 bq. TestClientTokens should also be renamed to TestClientToAMTokens renamed bq. CustomNM is no longer needed? its just implementing an interface..keeping it as it is. bq. There is commented out code that should be removed. fixed. ClientToken should not be set in the environment Key: YARN-610 URL: https://issues.apache.org/jira/browse/YARN-610 Project: Hadoop YARN Issue Type: Sub-task Reporter: Siddharth Seth Assignee: Omkar Vinit Joshi Attachments: YARN-610-20130614.patch Similar to YARN-579, this can be set via ContainerTokens -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-610) ClientToken should not be set in the environment
[ https://issues.apache.org/jira/browse/YARN-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684533#comment-13684533 ] Omkar Vinit Joshi commented on YARN-610: patch submitted should be applied on top of YARN-693 which also involves AMRMProtocol changes. ClientToken should not be set in the environment Key: YARN-610 URL: https://issues.apache.org/jira/browse/YARN-610 Project: Hadoop YARN Issue Type: Sub-task Reporter: Siddharth Seth Assignee: Omkar Vinit Joshi Attachments: YARN-610-20130614.patch Similar to YARN-579, this can be set via ContainerTokens -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-610) ClientToken should not be set in the environment
[ https://issues.apache.org/jira/browse/YARN-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684562#comment-13684562 ] Vinod Kumar Vavilapalli commented on YARN-610: -- bq. Now instead of sharing it here in environment we should send it on AMRMProtocol as a part of AMRegistration. Thereby AM will get secret key after am registration and will be able to authenticate thereafter. any thoughts? That is reasonable. Seems like the patch has gone stale, can you rebase? File a MR ticket too as a followup tracking MR changes. Patch looks mostly good. W.r.t TestClientTokens - TestClientTokens should also be renamed to TestClientToAMTokens - CustomNM is no longer needed? - There is commented out code that should be removed. ClientToken should not be set in the environment Key: YARN-610 URL: https://issues.apache.org/jira/browse/YARN-610 Project: Hadoop YARN Issue Type: Sub-task Reporter: Siddharth Seth Assignee: Omkar Vinit Joshi Attachments: YARN-610-20130614.patch Similar to YARN-579, this can be set via ContainerTokens -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-610) ClientToken should not be set in the environment
[ https://issues.apache.org/jira/browse/YARN-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683611#comment-13683611 ] Omkar Vinit Joshi commented on YARN-610: Here we will be making sure that AM has the secret key for authenticating client requests(tokens). Now problem is that we can't share it in environment as this people might be able to read it (windows). Now instead of sharing it here in environment we should send it on AMRMProtocol as a part of AMRegistration. Thereby AM will get secret key after am registration and will be able to authenticate thereafter. any thoughts? ClientToken should not be set in the environment Key: YARN-610 URL: https://issues.apache.org/jira/browse/YARN-610 Project: Hadoop YARN Issue Type: Sub-task Reporter: Siddharth Seth Assignee: Omkar Vinit Joshi Similar to YARN-579, this can be set via ContainerTokens -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-610) ClientToken should not be set in the environment
[ https://issues.apache.org/jira/browse/YARN-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683625#comment-13683625 ] Omkar Vinit Joshi commented on YARN-610: also we can't send it via credentials as a token because we are sharing secret key. Renaming name to ClientToAMToken in protocols too. ClientToken should not be set in the environment Key: YARN-610 URL: https://issues.apache.org/jira/browse/YARN-610 Project: Hadoop YARN Issue Type: Sub-task Reporter: Siddharth Seth Assignee: Omkar Vinit Joshi Similar to YARN-579, this can be set via ContainerTokens -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
