[jira] [Commented] (YARN-6297) TestAppLogAggregatorImp.verifyFilesUploaded() should check # of filed uploaded with that of files expected

2017-03-08 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901771#comment-15901771
 ] 

Hudson commented on YARN-6297:
--

FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #11373 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/11373/])
YARN-6297. TestAppLogAggregatorImp.verifyFilesUploaded() should check # 
(rkanter: rev 287ba4ffa66212c02e1b1edc8fca53f6368a9efc)
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/TestAppLogAggregatorImpl.java


> TestAppLogAggregatorImp.verifyFilesUploaded() should check # of filed 
> uploaded with that of files expected
> --
>
> Key: YARN-6297
> URL: https://issues.apache.org/jira/browse/YARN-6297
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Haibo Chen
>Assignee: Haibo Chen
>  Labels: test
> Fix For: 2.9.0, 3.0.0-alpha3
>
> Attachments: YARN-6297.01.patch
>
>
> Per YARN-6252
> {code:java}
>   private static void verifyFilesUploaded(Set filesUploaded,
>   Set filesExpected) {
> final String errMsgPrefix = "The set of files uploaded are not the same " 
> +
> "as expected";
> if(filesUploaded.size() != filesUploaded.size()) {
>   fail(errMsgPrefix + ": actual size: " + filesUploaded.size() + " vs " +
>   "expected size: " + filesExpected.size());
> }
> for(String file: filesExpected) {
>   if(!filesUploaded.contains(file)) {
> fail(errMsgPrefix + ": expecting " + file);
>   }
> }
>   }
> {code}
> should check the number of files uploaded against the number of files 
> expected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6297) TestAppLogAggregatorImp.verifyFilesUploaded() should check # of filed uploaded with that of files expected

2017-03-08 Thread Robert Kanter (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901740#comment-15901740
 ] 

Robert Kanter commented on YARN-6297:
-

+1

> TestAppLogAggregatorImp.verifyFilesUploaded() should check # of filed 
> uploaded with that of files expected
> --
>
> Key: YARN-6297
> URL: https://issues.apache.org/jira/browse/YARN-6297
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Haibo Chen
>Assignee: Haibo Chen
>  Labels: test
> Attachments: YARN-6297.01.patch
>
>
> Per YARN-6252
> {code:java}
>   private static void verifyFilesUploaded(Set filesUploaded,
>   Set filesExpected) {
> final String errMsgPrefix = "The set of files uploaded are not the same " 
> +
> "as expected";
> if(filesUploaded.size() != filesUploaded.size()) {
>   fail(errMsgPrefix + ": actual size: " + filesUploaded.size() + " vs " +
>   "expected size: " + filesExpected.size());
> }
> for(String file: filesExpected) {
>   if(!filesUploaded.contains(file)) {
> fail(errMsgPrefix + ": expecting " + file);
>   }
> }
>   }
> {code}
> should check the number of files uploaded against the number of files 
> expected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6297) TestAppLogAggregatorImp.verifyFilesUploaded() should check # of filed uploaded with that of files expected

2017-03-07 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900370#comment-15900370
 ] 

Hadoop QA commented on YARN-6297:
-

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
26s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 14m 
41s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
19s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
14s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
48s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
20s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 14m 
31s{color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed. 
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
20s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 36m 44s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | YARN-6297 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12856692/YARN-6297.01.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux 095947b0ad54 3.13.0-108-generic #155-Ubuntu SMP Wed Jan 11 
16:58:52 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / 1598fd3 |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/15198/testReport/ |
| modules | C: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 U: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/15198/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> TestAppLogAggregatorImp.verifyFilesUploaded() should check # of filed 
> uploaded with that of files expected
> --
>
> Key: YARN-6297
> URL: https://issues.apache.org/jira/browse/YARN-6297
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Haibo Chen
>Assignee: Haibo Chen
>  Labels: test
> Attachments: YARN-6

[jira] [Commented] (YARN-6297) TestAppLogAggregatorImp.verifyFilesUploaded() should check # of filed uploaded with that of files expected

2017-03-07 Thread Haibo Chen (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900299#comment-15900299
 ] 

Haibo Chen commented on YARN-6297:
--

[~rkanter] Can you help review it please?

> TestAppLogAggregatorImp.verifyFilesUploaded() should check # of filed 
> uploaded with that of files expected
> --
>
> Key: YARN-6297
> URL: https://issues.apache.org/jira/browse/YARN-6297
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Haibo Chen
>Assignee: Haibo Chen
>  Labels: test
> Attachments: YARN-6297.01.patch
>
>
> Per YARN-6252
> {code:java}
>   private static void verifyFilesUploaded(Set filesUploaded,
>   Set filesExpected) {
> final String errMsgPrefix = "The set of files uploaded are not the same " 
> +
> "as expected";
> if(filesUploaded.size() != filesUploaded.size()) {
>   fail(errMsgPrefix + ": actual size: " + filesUploaded.size() + " vs " +
>   "expected size: " + filesExpected.size());
> }
> for(String file: filesExpected) {
>   if(!filesUploaded.contains(file)) {
> fail(errMsgPrefix + ": expecting " + file);
>   }
> }
>   }
> {code}
> should check the number of files uploaded against the number of files 
> expected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org