[jira] [Commented] (YARN-6372) Add default value for NM disk validator

2017-04-17 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971212#comment-15971212
 ] 

Hudson commented on YARN-6372:
--

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11591 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/11591/])
YARN-6372. Add default value for NM disk validator (Contributed by Yufei 
(templedf: rev e9ac61cc0e55d1a0b132c795047e959c761dc3be)
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DirectoryCollection.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ContainerLocalizer.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java


> Add default value for NM disk validator
> ---
>
> Key: YARN-6372
> URL: https://issues.apache.org/jira/browse/YARN-6372
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: nodemanager
>Affects Versions: 2.7.3, 3.0.0-alpha2
>Reporter: Yufei Gu
>Assignee: Yufei Gu
> Fix For: 2.9.0, 3.0.0-alpha3
>
> Attachments: YARN-6372.001.patch, YARN-6372.002.patch
>
>
> YARN-5137 make DiskChecker pluggable in NodeManager. We should give a default 
> value in case NM does't provide the configuration item.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6372) Add default value for NM disk validator

2017-04-10 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963577#comment-15963577
 ] 

Hudson commented on YARN-6372:
--

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11563 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/11563/])
YARN-6372. Add default value for NM disk validator (Contributed by Yufei 
(templedf: rev e9ac61cc0e55d1a0b132c795047e959c761dc3be)
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DirectoryCollection.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ContainerLocalizer.java


> Add default value for NM disk validator
> ---
>
> Key: YARN-6372
> URL: https://issues.apache.org/jira/browse/YARN-6372
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: nodemanager
>Affects Versions: 2.7.3, 3.0.0-alpha2
>Reporter: Yufei Gu
>Assignee: Yufei Gu
> Fix For: 2.9.0, 3.0.0-alpha3
>
> Attachments: YARN-6372.001.patch, YARN-6372.002.patch
>
>
> YARN-5137 make DiskChecker pluggable in NodeManager. We should give a default 
> value in case NM does't provide the configuration item.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6372) Add default value for NM disk validator

2017-04-10 Thread Yufei Gu (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963568#comment-15963568
 ] 

Yufei Gu commented on YARN-6372:


Thanks [~templedf] for the review and commit. Thanks 
[~miklos.szeg...@cloudera.com] for the review. 

> Add default value for NM disk validator
> ---
>
> Key: YARN-6372
> URL: https://issues.apache.org/jira/browse/YARN-6372
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: nodemanager
>Affects Versions: 2.7.3, 3.0.0-alpha2
>Reporter: Yufei Gu
>Assignee: Yufei Gu
> Fix For: 2.9.0, 3.0.0-alpha3
>
> Attachments: YARN-6372.001.patch, YARN-6372.002.patch
>
>
> YARN-5137 make DiskChecker pluggable in NodeManager. We should give a default 
> value in case NM does't provide the configuration item.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6372) Add default value for NM disk validator

2017-03-30 Thread Daniel Templeton (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949682#comment-15949682
 ] 

Daniel Templeton commented on YARN-6372:


Works for me.  +1  I'll commit soon.

> Add default value for NM disk validator
> ---
>
> Key: YARN-6372
> URL: https://issues.apache.org/jira/browse/YARN-6372
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: nodemanager
>Affects Versions: 2.7.3, 3.0.0-alpha2
>Reporter: Yufei Gu
>Assignee: Yufei Gu
> Attachments: YARN-6372.001.patch, YARN-6372.002.patch
>
>
> YARN-5137 make DiskChecker pluggable in NodeManager. We should give a default 
> value in case NM does't provide the configuration item.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6372) Add default value for NM disk validator

2017-03-24 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941366#comment-15941366
 ] 

Hadoop QA commented on YARN-6372:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
11s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 16m 
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 11m 
14s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
55s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m  
3s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
38s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
56s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
49s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  
9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  9m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  9m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m  
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
34s{color} | {color:green} hadoop-yarn-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 13m 
33s{color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed. 
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
30s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 72m 31s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | YARN-6372 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12860470/YARN-6372.002.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux a1b43c143d1c 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 
09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / 1f66524 |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/15384/testReport/ |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 U: hadoop-yarn-project/hadoop-yarn |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/15384/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT   http://yetus.apache.org |


This message

[jira] [Commented] (YARN-6372) Add default value for NM disk validator

2017-03-24 Thread Miklos Szegedi (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941355#comment-15941355
 ] 

Miklos Szegedi commented on YARN-6372:
--

+1 (non-binding) Thank you, [~yufeigu] for fixing this.

> Add default value for NM disk validator
> ---
>
> Key: YARN-6372
> URL: https://issues.apache.org/jira/browse/YARN-6372
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: nodemanager
>Affects Versions: 2.7.3, 3.0.0-alpha2
>Reporter: Yufei Gu
>Assignee: Yufei Gu
> Attachments: YARN-6372.001.patch, YARN-6372.002.patch
>
>
> YARN-5137 make DiskChecker pluggable in NodeManager. We should give a default 
> value in case NM does't provide the configuration item.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6372) Add default value for NM disk validator

2017-03-23 Thread Yufei Gu (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15939766#comment-15939766
 ] 

Yufei Gu commented on YARN-6372:


Good catch! I'll update patch soon.

> Add default value for NM disk validator
> ---
>
> Key: YARN-6372
> URL: https://issues.apache.org/jira/browse/YARN-6372
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: nodemanager
>Affects Versions: 2.7.3, 3.0.0-alpha2
>Reporter: Yufei Gu
>Assignee: Yufei Gu
> Attachments: YARN-6372.001.patch
>
>
> YARN-5137 make DiskChecker pluggable in NodeManager. We should give a default 
> value in case NM does't provide the configuration item.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6372) Add default value for NM disk validator

2017-03-23 Thread Miklos Szegedi (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15939502#comment-15939502
 ] 

Miklos Szegedi commented on YARN-6372:
--

Thank you for the patch [~yufeigu]. It is not related to the patch, but now 
that you use it, should not the default be set using the predefined constant 
BasicDiskValidator.NAME like below?
{code}
public static final String DEFAULT_DISK_VALIDATOR = BasicDiskValidator.NAME;
{code}

> Add default value for NM disk validator
> ---
>
> Key: YARN-6372
> URL: https://issues.apache.org/jira/browse/YARN-6372
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: nodemanager
>Affects Versions: 2.7.3, 3.0.0-alpha2
>Reporter: Yufei Gu
>Assignee: Yufei Gu
> Attachments: YARN-6372.001.patch
>
>
> YARN-5137 make DiskChecker pluggable in NodeManager. We should give a default 
> value in case NM does't provide the configuration item.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6372) Add default value for NM disk validator

2017-03-21 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935506#comment-15935506
 ] 

Hadoop QA commented on YARN-6372:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
30s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m 
 0s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
35s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
19s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
33s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
16s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
46s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
20s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 13m  
7s{color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed. 
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
16s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 33m 59s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | YARN-6372 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12859798/YARN-6372.001.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux 8ee0afb94e31 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 
15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / cc938e9 |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/15350/testReport/ |
| modules | C: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 U: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
 |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/15350/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Add default value for NM disk validator
> ---
>
> Key: YARN-6372
> URL: https://issues.apache.org/jira/browse/YARN-6372
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: nodemanager
>Affects Versions: 2.7.3, 3.0.0-alpha2
>Reporter: Yufei Gu
>Assignee: Yufei Gu
>