[jira] [Commented] (YARN-7205) Log improvements for the ResourceUtils
[ https://issues.apache.org/jira/browse/YARN-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201193#comment-16201193 ] Hudson commented on YARN-7205: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13076 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/13076/]) YARN-7205. Log improvements for the ResourceUtils. (Sunil G via wangda) (wangda: rev 8bcc49e6771ca75f012211e27870a421b19233e7) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/util/resource/ResourceUtils.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceTypeInfo.java > Log improvements for the ResourceUtils > -- > > Key: YARN-7205 > URL: https://issues.apache.org/jira/browse/YARN-7205 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager, resourcemanager >Reporter: Jian He >Assignee: Sunil G > Fix For: 3.1.0 > > Attachments: YARN-7205.001.patch, YARN-7205.002.patch, > YARN-7205.003.patch, YARN-7205.004.patch > > > I've seen below logs printed at the service client console after the merge, > can this be moved to debug level log ? cc [~sunilg], [~leftnoteasy] > {code} > 17/09/15 10:26:32 INFO conf.Configuration: resource-types.xml not found > 17/09/15 10:26:32 INFO resource.ResourceUtils: Unable to find > 'resource-types.xml'. Falling back to memory and vcores as resources. > 17/09/15 10:26:32 INFO resource.ResourceUtils: Adding resource type - name = > memory-mb, units = Mi, type = COUNTABLE > 17/09/15 10:26:32 INFO resource.ResourceUtils: Adding resource type - name = > vcores, units = , type = COUNTABLE > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7205) Log improvements for the ResourceUtils
[ https://issues.apache.org/jira/browse/YARN-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200479#comment-16200479 ] Wangda Tan commented on YARN-7205: -- +1, will commit shortly > Log improvements for the ResourceUtils > -- > > Key: YARN-7205 > URL: https://issues.apache.org/jira/browse/YARN-7205 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager, resourcemanager >Reporter: Jian He >Assignee: Sunil G > Attachments: YARN-7205.001.patch, YARN-7205.002.patch, > YARN-7205.003.patch, YARN-7205.004.patch > > > I've seen below logs printed at the service client console after the merge, > can this be moved to debug level log ? cc [~sunilg], [~leftnoteasy] > {code} > 17/09/15 10:26:32 INFO conf.Configuration: resource-types.xml not found > 17/09/15 10:26:32 INFO resource.ResourceUtils: Unable to find > 'resource-types.xml'. Falling back to memory and vcores as resources. > 17/09/15 10:26:32 INFO resource.ResourceUtils: Adding resource type - name = > memory-mb, units = Mi, type = COUNTABLE > 17/09/15 10:26:32 INFO resource.ResourceUtils: Adding resource type - name = > vcores, units = , type = COUNTABLE > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7205) Log improvements for the ResourceUtils
[ https://issues.apache.org/jira/browse/YARN-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198256#comment-16198256 ] Hadoop QA commented on YARN-7205: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m 37s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 26s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 15s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 28s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 9m 27s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 3s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api: The patch generated 0 new + 7 unchanged - 2 fixed = 7 total (was 9) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 10m 3s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 28s{color} | {color:green} hadoop-yarn-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 40m 8s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:71bbb86 | | JIRA Issue | YARN-7205 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12891211/YARN-7205.004.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 4e30d2f8af8f 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 5cfbad6 | | Default Java | 1.8.0_144 | | findbugs | v3.1.0-RC1 | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/17839/testReport/ | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/17839/console | | Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Log improvements for the ResourceUtils >
[jira] [Commented] (YARN-7205) Log improvements for the ResourceUtils
[ https://issues.apache.org/jira/browse/YARN-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196864#comment-16196864 ] Daniel Templeton commented on YARN-7205: One last, tiny complaint:{code}LOG.debug("Couldn't find node resources file:" + YarnConfiguration.NODE_RESOURCES_CONFIGURATION_FILE);{code} needs a space in the string after the colon. > Log improvements for the ResourceUtils > -- > > Key: YARN-7205 > URL: https://issues.apache.org/jira/browse/YARN-7205 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager, resourcemanager >Reporter: Jian He >Assignee: Sunil G > Attachments: YARN-7205.001.patch, YARN-7205.002.patch, > YARN-7205.003.patch > > > I've seen below logs printed at the service client console after the merge, > can this be moved to debug level log ? cc [~sunilg], [~leftnoteasy] > {code} > 17/09/15 10:26:32 INFO conf.Configuration: resource-types.xml not found > 17/09/15 10:26:32 INFO resource.ResourceUtils: Unable to find > 'resource-types.xml'. Falling back to memory and vcores as resources. > 17/09/15 10:26:32 INFO resource.ResourceUtils: Adding resource type - name = > memory-mb, units = Mi, type = COUNTABLE > 17/09/15 10:26:32 INFO resource.ResourceUtils: Adding resource type - name = > vcores, units = , type = COUNTABLE > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7205) Log improvements for the ResourceUtils
[ https://issues.apache.org/jira/browse/YARN-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196800#comment-16196800 ] Hadoop QA commented on YARN-7205: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m 34s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 15s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 29s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 9m 29s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 3s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api: The patch generated 0 new + 7 unchanged - 2 fixed = 7 total (was 9) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 10m 2s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 28s{color} | {color:green} hadoop-yarn-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 17s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 40m 4s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:71bbb86 | | JIRA Issue | YARN-7205 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12891026/YARN-7205.003.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux d6ef8e647498 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 8137254 | | Default Java | 1.8.0_144 | | findbugs | v3.1.0-RC1 | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/17821/testReport/ | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/17821/console | | Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Log improvements for the ResourceUtils >
[jira] [Commented] (YARN-7205) Log improvements for the ResourceUtils
[ https://issues.apache.org/jira/browse/YARN-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187993#comment-16187993 ] Sunil G commented on YARN-7205: --- {{17/09/15 10:26:32 INFO conf.Configuration: resource-types.xml not found}} this log is coming when we try to load *resource-types.xml* and conf object complaints its not there. This cant be debug as its a common information message used Confguration class. Other than that all other logs are pushed to debug. > Log improvements for the ResourceUtils > -- > > Key: YARN-7205 > URL: https://issues.apache.org/jira/browse/YARN-7205 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager, resourcemanager >Reporter: Jian He >Assignee: Sunil G > Attachments: YARN-7205.001.patch, YARN-7205.002.patch > > > I've seen below logs printed at the service client console after the merge, > can this be moved to debug level log ? cc [~sunilg], [~leftnoteasy] > {code} > 17/09/15 10:26:32 INFO conf.Configuration: resource-types.xml not found > 17/09/15 10:26:32 INFO resource.ResourceUtils: Unable to find > 'resource-types.xml'. Falling back to memory and vcores as resources. > 17/09/15 10:26:32 INFO resource.ResourceUtils: Adding resource type - name = > memory-mb, units = Mi, type = COUNTABLE > 17/09/15 10:26:32 INFO resource.ResourceUtils: Adding resource type - name = > vcores, units = , type = COUNTABLE > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7205) Log improvements for the ResourceUtils
[ https://issues.apache.org/jira/browse/YARN-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187792#comment-16187792 ] Daniel Templeton commented on YARN-7205: I hear ya, but given that resource types can't actually be turned off, I don't see the point in trying to make it look like it can. As you said, the admin can choose to configure additional resources or not. I don't think it helps to add yet another config property to control whether that config file is read. Since these logs are all at debug level now, I don't think it's a big issue in any case. > Log improvements for the ResourceUtils > -- > > Key: YARN-7205 > URL: https://issues.apache.org/jira/browse/YARN-7205 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager, resourcemanager >Reporter: Jian He >Assignee: Sunil G > Attachments: YARN-7205.001.patch, YARN-7205.002.patch > > > I've seen below logs printed at the service client console after the merge, > can this be moved to debug level log ? cc [~sunilg], [~leftnoteasy] > {code} > 17/09/15 10:26:32 INFO conf.Configuration: resource-types.xml not found > 17/09/15 10:26:32 INFO resource.ResourceUtils: Unable to find > 'resource-types.xml'. Falling back to memory and vcores as resources. > 17/09/15 10:26:32 INFO resource.ResourceUtils: Adding resource type - name = > memory-mb, units = Mi, type = COUNTABLE > 17/09/15 10:26:32 INFO resource.ResourceUtils: Adding resource type - name = > vcores, units = , type = COUNTABLE > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7205) Log improvements for the ResourceUtils
[ https://issues.apache.org/jira/browse/YARN-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187765#comment-16187765 ] Sunil G commented on YARN-7205: --- bq.Resource types and resource profiles are distinct features--each makes sense without the other. Yes. Thats correct. However i could see that resource type file will be loaded by default by RM w/o any toggle OFF option. I am also in line with making this default ON as admin has to place resource-types.xml manually. But there are many loggings etc will come additionally. If everyone is fine with that, i think its fine to have this as default ON. Or we need to think of introducing a new config to switch on supporting more resource types. other comments are fine, i ll take care in next patch. > Log improvements for the ResourceUtils > -- > > Key: YARN-7205 > URL: https://issues.apache.org/jira/browse/YARN-7205 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager, resourcemanager >Reporter: Jian He >Assignee: Sunil G > Attachments: YARN-7205.001.patch, YARN-7205.002.patch > > > I've seen below logs printed at the service client console after the merge, > can this be moved to debug level log ? cc [~sunilg], [~leftnoteasy] > {code} > 17/09/15 10:26:32 INFO conf.Configuration: resource-types.xml not found > 17/09/15 10:26:32 INFO resource.ResourceUtils: Unable to find > 'resource-types.xml'. Falling back to memory and vcores as resources. > 17/09/15 10:26:32 INFO resource.ResourceUtils: Adding resource type - name = > memory-mb, units = Mi, type = COUNTABLE > 17/09/15 10:26:32 INFO resource.ResourceUtils: Adding resource type - name = > vcores, units = , type = COUNTABLE > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7205) Log improvements for the ResourceUtils
[ https://issues.apache.org/jira/browse/YARN-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187724#comment-16187724 ] Daniel Templeton commented on YARN-7205: I don't see why it makes sense to only load the resource types config files if resource profiles is enabled. Resource types and resource profiles are distinct features--each makes sense without the other. Also, the additional log message after {{addResourcesFileToConf()}} is redundant. For this message: "Couldn't find node resources file named:resource-types.xml", can we make it "Couldn't find node resources file: resource-types.xml" > Log improvements for the ResourceUtils > -- > > Key: YARN-7205 > URL: https://issues.apache.org/jira/browse/YARN-7205 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager, resourcemanager >Reporter: Jian He >Assignee: Sunil G > Attachments: YARN-7205.001.patch, YARN-7205.002.patch > > > I've seen below logs printed at the service client console after the merge, > can this be moved to debug level log ? cc [~sunilg], [~leftnoteasy] > {code} > 17/09/15 10:26:32 INFO conf.Configuration: resource-types.xml not found > 17/09/15 10:26:32 INFO resource.ResourceUtils: Unable to find > 'resource-types.xml'. Falling back to memory and vcores as resources. > 17/09/15 10:26:32 INFO resource.ResourceUtils: Adding resource type - name = > memory-mb, units = Mi, type = COUNTABLE > 17/09/15 10:26:32 INFO resource.ResourceUtils: Adding resource type - name = > vcores, units = , type = COUNTABLE > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7205) Log improvements for the ResourceUtils
[ https://issues.apache.org/jira/browse/YARN-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187313#comment-16187313 ] Hadoop QA commented on YARN-7205: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 21s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m 13s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 26s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 28s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 9m 16s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 3s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api: The patch generated 0 new + 7 unchanged - 2 fixed = 7 total (was 9) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 10m 16s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 28s{color} | {color:green} hadoop-yarn-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 39m 50s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:71bbb86 | | JIRA Issue | YARN-7205 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12889877/YARN-7205.002.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux d1fc1a4d3148 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 06df6ab | | Default Java | 1.8.0_144 | | findbugs | v3.1.0-RC1 | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/17725/testReport/ | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/17725/console | | Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Log improvements for the ResourceUtils >
[jira] [Commented] (YARN-7205) Log improvements for the ResourceUtils
[ https://issues.apache.org/jira/browse/YARN-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187306#comment-16187306 ] Sunil G commented on YARN-7205: --- # Improved logs to debug so that it wont show in console any more. # {{memory-mb (unit=Mi), vcores}}. Made UI more cleaner for *Scheduling Resource Type* columns as mentioned by Jian # Also resource-types.xml were loaded in case where profiles were not enabled. I made an improvement to check this also. Looping [~leftnoteasy] [~dan...@cloudera.com] I know we had this talk a while back, but may be we could put this boolean check. Thoughts? Attaching patch v2 for reference. > Log improvements for the ResourceUtils > -- > > Key: YARN-7205 > URL: https://issues.apache.org/jira/browse/YARN-7205 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager, resourcemanager >Reporter: Jian He >Assignee: Sunil G > Attachments: YARN-7205.001.patch > > > I've seen below logs printed at the service client console after the merge, > can this be moved to debug level log ? cc [~sunilg], [~leftnoteasy] > {code} > 17/09/15 10:26:32 INFO conf.Configuration: resource-types.xml not found > 17/09/15 10:26:32 INFO resource.ResourceUtils: Unable to find > 'resource-types.xml'. Falling back to memory and vcores as resources. > 17/09/15 10:26:32 INFO resource.ResourceUtils: Adding resource type - name = > memory-mb, units = Mi, type = COUNTABLE > 17/09/15 10:26:32 INFO resource.ResourceUtils: Adding resource type - name = > vcores, units = , type = COUNTABLE > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7205) Log improvements for the ResourceUtils
[ https://issues.apache.org/jira/browse/YARN-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186955#comment-16186955 ] Hadoop QA commented on YARN-7205: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 21s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 14m 17s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 14s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 36s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 9m 45s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 3s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api: The patch generated 0 new + 7 unchanged - 2 fixed = 7 total (was 9) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 10m 10s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 29s{color} | {color:green} hadoop-yarn-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 19s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 41m 25s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:71bbb86 | | JIRA Issue | YARN-7205 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12889832/YARN-7205.001.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 7bfc59a6bb27 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 06df6ab | | Default Java | 1.8.0_144 | | findbugs | v3.1.0-RC1 | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/17722/testReport/ | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/17722/console | | Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Log improvements for the ResourceUtils >
[jira] [Commented] (YARN-7205) Log improvements for the ResourceUtils
[ https://issues.apache.org/jira/browse/YARN-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168296#comment-16168296 ] Jian He commented on YARN-7205: --- another thing notices on the UI is: {code}