[jira] [Commented] (YARN-7240) Add more states and transitions to stabilize the NM Container state machine
[ https://issues.apache.org/jira/browse/YARN-7240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227662#comment-16227662 ] Andrew Wang commented on YARN-7240: --- Woops, my bad. I had the wrong base revision in my versions script, and it picked this up as a false positive. Thanks for the double check! > Add more states and transitions to stabilize the NM Container state machine > --- > > Key: YARN-7240 > URL: https://issues.apache.org/jira/browse/YARN-7240 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Arun Suresh >Assignee: kartheek muthyala > Fix For: 2.9.0, 3.0.0 > > Attachments: YARN-7240.001.patch, YARN-7240.002.patch, > YARN-7240.002.patch > > > There seem to be a few intermediate states that can be added to improve the > stability of the NM container state machine. > For. eg: > * The REINITIALIZING should probably be split into REINITIALIZING and > REINITIALIZING_AWAITING_KILL. > * Container updates are currently handled in the ContainerScheduler, but it > would probably be better to have it plumbed through the container state > machine as a new state, say UPDATING and a new container event. > The plan is to add some extra tests too to try and test every transition. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7240) Add more states and transitions to stabilize the NM Container state machine
[ https://issues.apache.org/jira/browse/YARN-7240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227648#comment-16227648 ] Arun Suresh commented on YARN-7240: --- [~andrew.wang], looks like I had already cherry-picked this into branch-3.0 > Add more states and transitions to stabilize the NM Container state machine > --- > > Key: YARN-7240 > URL: https://issues.apache.org/jira/browse/YARN-7240 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Arun Suresh >Assignee: kartheek muthyala > Fix For: 2.9.0, 3.0.0 > > Attachments: YARN-7240.001.patch, YARN-7240.002.patch, > YARN-7240.002.patch > > > There seem to be a few intermediate states that can be added to improve the > stability of the NM container state machine. > For. eg: > * The REINITIALIZING should probably be split into REINITIALIZING and > REINITIALIZING_AWAITING_KILL. > * Container updates are currently handled in the ContainerScheduler, but it > would probably be better to have it plumbed through the container state > machine as a new state, say UPDATING and a new container event. > The plan is to add some extra tests too to try and test every transition. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7240) Add more states and transitions to stabilize the NM Container state machine
[ https://issues.apache.org/jira/browse/YARN-7240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227383#comment-16227383 ] Arun Suresh commented on YARN-7240: --- Yup, I was waiting for 3.0.0-beta1 to be cut before pushing this in. Will cherry-pick shortly. > Add more states and transitions to stabilize the NM Container state machine > --- > > Key: YARN-7240 > URL: https://issues.apache.org/jira/browse/YARN-7240 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Arun Suresh >Assignee: kartheek muthyala > Fix For: 2.9.0, 3.0.0 > > Attachments: YARN-7240.001.patch, YARN-7240.002.patch, > YARN-7240.002.patch > > > There seem to be a few intermediate states that can be added to improve the > stability of the NM container state machine. > For. eg: > * The REINITIALIZING should probably be split into REINITIALIZING and > REINITIALIZING_AWAITING_KILL. > * Container updates are currently handled in the ContainerScheduler, but it > would probably be better to have it plumbed through the container state > machine as a new state, say UPDATING and a new container event. > The plan is to add some extra tests too to try and test every transition. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7240) Add more states and transitions to stabilize the NM Container state machine
[ https://issues.apache.org/jira/browse/YARN-7240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227379#comment-16227379 ] Andrew Wang commented on YARN-7240: --- Hi Arun, did you mean for this to go into branch-3.0 also? > Add more states and transitions to stabilize the NM Container state machine > --- > > Key: YARN-7240 > URL: https://issues.apache.org/jira/browse/YARN-7240 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Arun Suresh >Assignee: kartheek muthyala > Fix For: 2.9.0, 3.0.0 > > Attachments: YARN-7240.001.patch, YARN-7240.002.patch, > YARN-7240.002.patch > > > There seem to be a few intermediate states that can be added to improve the > stability of the NM container state machine. > For. eg: > * The REINITIALIZING should probably be split into REINITIALIZING and > REINITIALIZING_AWAITING_KILL. > * Container updates are currently handled in the ContainerScheduler, but it > would probably be better to have it plumbed through the container state > machine as a new state, say UPDATING and a new container event. > The plan is to add some extra tests too to try and test every transition. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7240) Add more states and transitions to stabilize the NM Container state machine
[ https://issues.apache.org/jira/browse/YARN-7240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180198#comment-16180198 ] kartheek muthyala commented on YARN-7240: - Thank you for [~asuresh], for rebasing and the checkstyle fixes in the patch. > Add more states and transitions to stabilize the NM Container state machine > --- > > Key: YARN-7240 > URL: https://issues.apache.org/jira/browse/YARN-7240 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Arun Suresh >Assignee: kartheek muthyala > Fix For: 2.9.0, 3.1.0 > > Attachments: YARN-7240.001.patch, YARN-7240.002.patch, > YARN-7240.002.patch > > > There seem to be a few intermediate states that can be added to improve the > stability of the NM container state machine. > For. eg: > * The REINITIALIZING should probably be split into REINITIALIZING and > REINITIALIZING_AWAITING_KILL. > * Container updates are currently handled in the ContainerScheduler, but it > would probably be better to have it plumbed through the container state > machine as a new state, say UPDATING and a new container event. > The plan is to add some extra tests too to try and test every transition. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7240) Add more states and transitions to stabilize the NM Container state machine
[ https://issues.apache.org/jira/browse/YARN-7240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179953#comment-16179953 ] Hudson commented on YARN-7240: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12973 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/12973/]) YARN-7240. Add more states and transitions to stabilize the NM Container (arun suresh: rev df800f6cf3ea663daf4081ebe784808b08d9366d) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerEventType.java * (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/UpdateContainerTokenEvent.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/scheduler/ContainerScheduler.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestContainerManager.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/scheduler/UpdateContainerSchedulerEvent.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerState.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/scheduler/TestContainerSchedulerQueuing.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java > Add more states and transitions to stabilize the NM Container state machine > --- > > Key: YARN-7240 > URL: https://issues.apache.org/jira/browse/YARN-7240 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Arun Suresh >Assignee: kartheek muthyala > Attachments: YARN-7240.001.patch, YARN-7240.002.patch, > YARN-7240.002.patch > > > There seem to be a few intermediate states that can be added to improve the > stability of the NM container state machine. > For. eg: > * The REINITIALIZING should probably be split into REINITIALIZING and > REINITIALIZING_AWAITING_KILL. > * Container updates are currently handled in the ContainerScheduler, but it > would probably be better to have it plumbed through the container state > machine as a new state, say UPDATING and a new container event. > The plan is to add some extra tests too to try and test every transition. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7240) Add more states and transitions to stabilize the NM Container state machine
[ https://issues.apache.org/jira/browse/YARN-7240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179904#comment-16179904 ] Arun Suresh commented on YARN-7240: --- +1. The latest patch looks good. (I will take care of the unused imports while committing) > Add more states and transitions to stabilize the NM Container state machine > --- > > Key: YARN-7240 > URL: https://issues.apache.org/jira/browse/YARN-7240 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Arun Suresh >Assignee: kartheek muthyala > Attachments: YARN-7240.001.patch, YARN-7240.002.patch, > YARN-7240.002.patch > > > There seem to be a few intermediate states that can be added to improve the > stability of the NM container state machine. > For. eg: > * The REINITIALIZING should probably be split into REINITIALIZING and > REINITIALIZING_AWAITING_KILL. > * Container updates are currently handled in the ContainerScheduler, but it > would probably be better to have it plumbed through the container state > machine as a new state, say UPDATING and a new container event. > The plan is to add some extra tests too to try and test every transition. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7240) Add more states and transitions to stabilize the NM Container state machine
[
https://issues.apache.org/jira/browse/YARN-7240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179851#comment-16179851
]
Hadoop QA commented on YARN-7240:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
28s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
45s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 18s{color} | {color:orange}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager:
The patch generated 44 new + 288 unchanged - 8 fixed = 332 total (was 296)
{color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 14m
46s{color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 34m 30s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:71bbb86 |
| JIRA Issue | YARN-7240 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12888954/YARN-7240.002.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 1970297a95d8 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 0889e5a |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
https://builds.apache.org/job/PreCommit-YARN-Build/17629/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/17629/testReport/ |
| modules | C:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
U:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
|
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/17629/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Add more states and transitions to stabilize the NM Container state machine
> ---
>
> Key: YARN-7240
> URL: https:
[jira] [Commented] (YARN-7240) Add more states and transitions to stabilize the NM Container state machine
[ https://issues.apache.org/jira/browse/YARN-7240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179806#comment-16179806 ] Arun Suresh commented on YARN-7240: --- bq. Requeing the containers to the front of the queuedGuaranteed or queuedOpprotunistic queues would require to change the datastructures or we have to put use some temporary auxiliary queues to move this element. Yeah, this should be fine for now. Lets tackle this in a separate JIRA if really required. > Add more states and transitions to stabilize the NM Container state machine > --- > > Key: YARN-7240 > URL: https://issues.apache.org/jira/browse/YARN-7240 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Arun Suresh >Assignee: kartheek muthyala > Attachments: YARN-7240.001.patch, YARN-7240.002.patch, > YARN-7240.002.patch > > > There seem to be a few intermediate states that can be added to improve the > stability of the NM container state machine. > For. eg: > * The REINITIALIZING should probably be split into REINITIALIZING and > REINITIALIZING_AWAITING_KILL. > * Container updates are currently handled in the ContainerScheduler, but it > would probably be better to have it plumbed through the container state > machine as a new state, say UPDATING and a new container event. > The plan is to add some extra tests too to try and test every transition. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7240) Add more states and transitions to stabilize the NM Container state machine
[
https://issues.apache.org/jira/browse/YARN-7240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179550#comment-16179550
]
Hadoop QA commented on YARN-7240:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
3s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m
42s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
36s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
50s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
17s{color} | {color:red} hadoop-yarn-server-nodemanager in the patch failed.
{color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
19s{color} | {color:red} hadoop-yarn-server-nodemanager in the patch failed.
{color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 19s{color}
| {color:red} hadoop-yarn-server-nodemanager in the patch failed. {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 22s{color} | {color:orange}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager:
The patch generated 43 new + 288 unchanged - 8 fixed = 331 total (was 296)
{color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
19s{color} | {color:red} hadoop-yarn-server-nodemanager in the patch failed.
{color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
16s{color} | {color:red} hadoop-yarn-server-nodemanager in the patch failed.
{color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
19s{color} | {color:red}
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager
generated 4 new + 103 unchanged - 0 fixed = 107 total (was 103) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 19s{color}
| {color:red} hadoop-yarn-server-nodemanager in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 30s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:71bbb86 |
| JIRA Issue | YARN-7240 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12888922/YARN-7240.002.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux e2d3ccb54916 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26
18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / e928ee5 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC1 |
| mvninstall |
https://builds.apache.org/job/PreCommit-YARN-Build/17624/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
|
| compile |
https://builds.apache.org/job/PreCommit-YARN-Build/17624/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
|
| javac |
https://builds.apache.org/job/PreCommit-YARN-Build/17624/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-YARN
[jira] [Commented] (YARN-7240) Add more states and transitions to stabilize the NM Container state machine
[
https://issues.apache.org/jira/browse/YARN-7240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178482#comment-16178482
]
Arun Suresh commented on YARN-7240:
---
Thanks for the patch [~kartheek]. The patch looks mostly good.
Some Comments:
* When we re-queue paused containers (lines 276 - 285 of the
ContainerScheduler) see if we can push the container to the head of the queue
* Remove the "TODO: fix transition" comments from the ContainerImpl
* Since we are introducing a new state "REINITIALIZING_AWAITING_KILL", we need
to update the ContainerImpl::getCurrentState() to map it to RUNNING state.
* Existing tests in {{TestContainerManager}} should be able to verify that the
new "REINITIALIZING_AWAITING_KILL" state works fine, but we should add a test
case to {{TestContainer}}
> Add more states and transitions to stabilize the NM Container state machine
> ---
>
> Key: YARN-7240
> URL: https://issues.apache.org/jira/browse/YARN-7240
> Project: Hadoop YARN
> Issue Type: Improvement
>Reporter: Arun Suresh
>Assignee: kartheek muthyala
> Attachments: YARN-7240.001.patch
>
>
> There seem to be a few intermediate states that can be added to improve the
> stability of the NM container state machine.
> For. eg:
> * The REINITIALIZING should probably be split into REINITIALIZING and
> REINITIALIZING_AWAITING_KILL.
> * Container updates are currently handled in the ContainerScheduler, but it
> would probably be better to have it plumbed through the container state
> machine as a new state, say UPDATING and a new container event.
> The plan is to add some extra tests too to try and test every transition.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7240) Add more states and transitions to stabilize the NM Container state machine
[
https://issues.apache.org/jira/browse/YARN-7240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178282#comment-16178282
]
Hadoop QA commented on YARN-7240:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
22s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 16m
57s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
38s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
54s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 24s{color} | {color:orange}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager:
The patch generated 33 new + 255 unchanged - 8 fixed = 288 total (was 263)
{color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 15m
7s{color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 41m 38s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:71bbb86 |
| JIRA Issue | YARN-7240 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12888748/YARN-7240.001.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 721880b0ad64 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 415e5a1 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
https://builds.apache.org/job/PreCommit-YARN-Build/17614/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/17614/testReport/ |
| modules | C:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
U:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
|
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/17614/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Add more states and transitions to stabilize the NM Container state machine
> ---
>
> Key: YARN-7240
> URL: htt
