[jira] [Commented] (YARN-7389) Make TestResourceManager Scheduler agnostic
[
https://issues.apache.org/jira/browse/YARN-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235041#comment-16235041
]
Subru Krishnan commented on YARN-7389:
--
Thanks [~rkanter] for the backport.
> Make TestResourceManager Scheduler agnostic
> ---
>
> Key: YARN-7389
> URL: https://issues.apache.org/jira/browse/YARN-7389
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: test
>Affects Versions: 3.0.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
>Priority: Major
> Fix For: 2.9.0, 3.0.0
>
> Attachments: YARN-7389.001.patch
>
>
> Many of the tests in {{TestResourceManager}} override the scheduler to always
> be {{CapacityScheduler}}. However, these tests should be made scheduler
> agnostic (they are testing the RM, not the scheduler).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7389) Make TestResourceManager Scheduler agnostic
[
https://issues.apache.org/jira/browse/YARN-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227524#comment-16227524
]
Haibo Chen commented on YARN-7389:
--
Thanks for doing that!
> Make TestResourceManager Scheduler agnostic
> ---
>
> Key: YARN-7389
> URL: https://issues.apache.org/jira/browse/YARN-7389
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: test
>Affects Versions: 3.0.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Fix For: 3.0.0
>
> Attachments: YARN-7389.001.patch
>
>
> Many of the tests in {{TestResourceManager}} override the scheduler to always
> be {{CapacityScheduler}}. However, these tests should be made scheduler
> agnostic (they are testing the RM, not the scheduler).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7389) Make TestResourceManager Scheduler agnostic
[
https://issues.apache.org/jira/browse/YARN-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227500#comment-16227500
]
Andrew Wang commented on YARN-7389:
---
Great, I backported it to branch-3.0.
> Make TestResourceManager Scheduler agnostic
> ---
>
> Key: YARN-7389
> URL: https://issues.apache.org/jira/browse/YARN-7389
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: test
>Affects Versions: 3.0.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Fix For: 3.0.0
>
> Attachments: YARN-7389.001.patch
>
>
> Many of the tests in {{TestResourceManager}} override the scheduler to always
> be {{CapacityScheduler}}. However, these tests should be made scheduler
> agnostic (they are testing the RM, not the scheduler).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7389) Make TestResourceManager Scheduler agnostic
[
https://issues.apache.org/jira/browse/YARN-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227429#comment-16227429
]
Haibo Chen commented on YARN-7389:
--
Yes. Forgot to cherry-pick into branch-3.0.
> Make TestResourceManager Scheduler agnostic
> ---
>
> Key: YARN-7389
> URL: https://issues.apache.org/jira/browse/YARN-7389
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: test
>Affects Versions: 3.0.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Fix For: 3.0.0
>
> Attachments: YARN-7389.001.patch
>
>
> Many of the tests in {{TestResourceManager}} override the scheduler to always
> be {{CapacityScheduler}}. However, these tests should be made scheduler
> agnostic (they are testing the RM, not the scheduler).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7389) Make TestResourceManager Scheduler agnostic
[
https://issues.apache.org/jira/browse/YARN-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227378#comment-16227378
]
Andrew Wang commented on YARN-7389:
---
Hey Haibo, did you mean for this to go into branch-3.0 too?
> Make TestResourceManager Scheduler agnostic
> ---
>
> Key: YARN-7389
> URL: https://issues.apache.org/jira/browse/YARN-7389
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: test
>Affects Versions: 3.0.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Fix For: 3.0.0
>
> Attachments: YARN-7389.001.patch
>
>
> Many of the tests in {{TestResourceManager}} override the scheduler to always
> be {{CapacityScheduler}}. However, these tests should be made scheduler
> agnostic (they are testing the RM, not the scheduler).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7389) Make TestResourceManager Scheduler agnostic
[
https://issues.apache.org/jira/browse/YARN-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221318#comment-16221318
]
Subru Krishnan commented on YARN-7389:
--
Thanks [~rkanter] for doing this, appreciated.
> Make TestResourceManager Scheduler agnostic
> ---
>
> Key: YARN-7389
> URL: https://issues.apache.org/jira/browse/YARN-7389
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: test
>Affects Versions: 3.0.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Fix For: 3.0.0
>
> Attachments: YARN-7389.001.patch
>
>
> Many of the tests in {{TestResourceManager}} override the scheduler to always
> be {{CapacityScheduler}}. However, these tests should be made scheduler
> agnostic (they are testing the RM, not the scheduler).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7389) Make TestResourceManager Scheduler agnostic
[
https://issues.apache.org/jira/browse/YARN-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221182#comment-16221182
]
Robert Kanter commented on YARN-7389:
-
I just uploaded a branch-2 version of YARN-7146 there. Once that's in, I'll
backport YARN-7389 to branch-2.
> Make TestResourceManager Scheduler agnostic
> ---
>
> Key: YARN-7389
> URL: https://issues.apache.org/jira/browse/YARN-7389
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: test
>Affects Versions: 3.0.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Fix For: 3.0.0
>
> Attachments: YARN-7389.001.patch
>
>
> Many of the tests in {{TestResourceManager}} override the scheduler to always
> be {{CapacityScheduler}}. However, these tests should be made scheduler
> agnostic (they are testing the RM, not the scheduler).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7389) Make TestResourceManager Scheduler agnostic
[
https://issues.apache.org/jira/browse/YARN-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221057#comment-16221057
]
Robert Kanter commented on YARN-7389:
-
Unfortunately, it looks like YARN-7146 doesn't apply cleanly to branch-2. I
think that's why we didn't bother with it before.
> Make TestResourceManager Scheduler agnostic
> ---
>
> Key: YARN-7389
> URL: https://issues.apache.org/jira/browse/YARN-7389
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: test
>Affects Versions: 3.0.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Fix For: 3.0.0
>
> Attachments: YARN-7389.001.patch
>
>
> Many of the tests in {{TestResourceManager}} override the scheduler to always
> be {{CapacityScheduler}}. However, these tests should be made scheduler
> agnostic (they are testing the RM, not the scheduler).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7389) Make TestResourceManager Scheduler agnostic
[
https://issues.apache.org/jira/browse/YARN-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220933#comment-16220933
]
Subru Krishnan commented on YARN-7389:
--
Thanks [~rkanter] for the clarification. YARN-7146 looks relevant for branch-2
as well, so it'll be good if you can backport both.
> Make TestResourceManager Scheduler agnostic
> ---
>
> Key: YARN-7389
> URL: https://issues.apache.org/jira/browse/YARN-7389
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: test
>Affects Versions: 3.0.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Fix For: 3.0.0
>
> Attachments: YARN-7389.001.patch
>
>
> Many of the tests in {{TestResourceManager}} override the scheduler to always
> be {{CapacityScheduler}}. However, these tests should be made scheduler
> agnostic (they are testing the RM, not the scheduler).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7389) Make TestResourceManager Scheduler agnostic
[
https://issues.apache.org/jira/browse/YARN-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219753#comment-16219753
]
Robert Kanter commented on YARN-7389:
-
[~subru], yes. However, it won't work because it relies on some changes
introduced by YARN-7146, which isn't in branch-2. Though I guess we could
backport YARN-7146 to branch-2 as well.
> Make TestResourceManager Scheduler agnostic
> ---
>
> Key: YARN-7389
> URL: https://issues.apache.org/jira/browse/YARN-7389
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: test
>Affects Versions: 3.0.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Fix For: 3.0.0
>
> Attachments: YARN-7389.001.patch
>
>
> Many of the tests in {{TestResourceManager}} override the scheduler to always
> be {{CapacityScheduler}}. However, these tests should be made scheduler
> agnostic (they are testing the RM, not the scheduler).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7389) Make TestResourceManager Scheduler agnostic
[
https://issues.apache.org/jira/browse/YARN-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219435#comment-16219435
]
Subru Krishnan commented on YARN-7389:
--
[~rkanter]/[~haibo.chen], does it make sense to include this in branch-2 as
well?
> Make TestResourceManager Scheduler agnostic
> ---
>
> Key: YARN-7389
> URL: https://issues.apache.org/jira/browse/YARN-7389
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: test
>Affects Versions: 3.0.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Fix For: 3.0.0
>
> Attachments: YARN-7389.001.patch
>
>
> Many of the tests in {{TestResourceManager}} override the scheduler to always
> be {{CapacityScheduler}}. However, these tests should be made scheduler
> agnostic (they are testing the RM, not the scheduler).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7389) Make TestResourceManager Scheduler agnostic
[
https://issues.apache.org/jira/browse/YARN-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218151#comment-16218151
]
Hudson commented on YARN-7389:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13132 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/13132/])
YARN-7389. Make TestResourceManager Scheduler agnostic. (Robert Kanter
(haibochen: rev d7f3737f3b3236fbf8c25fdd4656251ed63a2be9)
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceManager.java
> Make TestResourceManager Scheduler agnostic
> ---
>
> Key: YARN-7389
> URL: https://issues.apache.org/jira/browse/YARN-7389
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: test
>Affects Versions: 3.0.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Fix For: 3.0.0
>
> Attachments: YARN-7389.001.patch
>
>
> Many of the tests in {{TestResourceManager}} override the scheduler to always
> be {{CapacityScheduler}}. However, these tests should be made scheduler
> agnostic (they are testing the RM, not the scheduler).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7389) Make TestResourceManager Scheduler agnostic
[
https://issues.apache.org/jira/browse/YARN-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218108#comment-16218108
]
Haibo Chen commented on YARN-7389:
--
TestFSAppStarvation.testPreemptionEnabled is tracked at YARN-6747. +1 on the
patch. Will check it in shortly
> Make TestResourceManager Scheduler agnostic
> ---
>
> Key: YARN-7389
> URL: https://issues.apache.org/jira/browse/YARN-7389
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: test
>Affects Versions: 3.0.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Attachments: YARN-7389.001.patch
>
>
> Many of the tests in {{TestResourceManager}} override the scheduler to always
> be {{CapacityScheduler}}. However, these tests should be made scheduler
> agnostic (they are testing the RM, not the scheduler).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7389) Make TestResourceManager Scheduler agnostic
[
https://issues.apache.org/jira/browse/YARN-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217940#comment-16217940
]
Hadoop QA commented on YARN-7389:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m
1s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
35s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
9m 1s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
57s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
The patch generated 0 new + 15 unchanged - 2 fixed = 15 total (was 17) {color}
|
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
8m 57s{color} | {color:green} patch has no errors when building and testing our
client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 45m 45s{color}
| {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 83m 12s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:ca8ddc6 |
| JIRA Issue | YARN-7389 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12893832/YARN-7389.001.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux a9b94009d799 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 17cd8d0 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC1 |
| unit |
https://builds.apache.org/job/PreCommit-YARN-Build/18123/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/18123/testReport/ |
| modules | C:
