[jira] [Commented] (YARN-7932) [atsv2 read acls] Add TimelineDomain to entity
[ https://issues.apache.org/jira/browse/YARN-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379831#comment-16379831 ] Rohith Sharma K S commented on YARN-7932: - As discussed offline with [~vrushalic], exposing TimelineV2Client API is the last step of ACLs story. So we shall keep this to end of ACLs story. Lets start with YARN-7933 which does server side implementation first and related back end jira. > [atsv2 read acls] Add TimelineDomain to entity > -- > > Key: YARN-7932 > URL: https://issues.apache.org/jira/browse/YARN-7932 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Vrushali C >Assignee: Rohith Sharma K S >Priority: Major > Attachments: YARN-7932.001.patch > > > > Need to have a TimelineDomain class in atsv2 that can contain the acls info > for entities. TimelineEntity will contain TimelineDomain as a member -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7932) [atsv2 read acls] Add TimelineDomain to entity
[ https://issues.apache.org/jira/browse/YARN-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379795#comment-16379795 ] Vrushali C commented on YARN-7932: -- One more thing. If we are adding the API, shall we also update the documentation? Else if a release happens, the documentation will not match the code. > [atsv2 read acls] Add TimelineDomain to entity > -- > > Key: YARN-7932 > URL: https://issues.apache.org/jira/browse/YARN-7932 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Vrushali C >Assignee: Rohith Sharma K S >Priority: Major > Attachments: YARN-7932.001.patch > > > > Need to have a TimelineDomain class in atsv2 that can contain the acls info > for entities. TimelineEntity will contain TimelineDomain as a member -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7932) [atsv2 read acls] Add TimelineDomain to entity
[ https://issues.apache.org/jira/browse/YARN-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379792#comment-16379792 ] Vrushali C commented on YARN-7932: -- Hi Rohith! Thanks for the patch! I looked at it. Apart from the whitespace and checkstyle mentions from jenkins, I had a couple of questions. * do we need writers as a member of class TimelineDomain? We have only the collector writing. * do we want to mark putDomain as "@Evolving" ? * small question, shall we have "domain" as a constant somewhere? I see it used at L180 in TimelineV2ClientImpl.java and am wondering if we would need it in the collector etc, maybe not. * Tiny nit: the spacing at a couple of places between commas on L180 is incorrect. thanks Vrushali > [atsv2 read acls] Add TimelineDomain to entity > -- > > Key: YARN-7932 > URL: https://issues.apache.org/jira/browse/YARN-7932 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Vrushali C >Assignee: Rohith Sharma K S >Priority: Major > Attachments: YARN-7932.001.patch > > > > Need to have a TimelineDomain class in atsv2 that can contain the acls info > for entities. TimelineEntity will contain TimelineDomain as a member -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7932) [atsv2 read acls] Add TimelineDomain to entity
[
https://issues.apache.org/jira/browse/YARN-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371397#comment-16371397
]
genericqa commented on YARN-7932:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
24s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m
46s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
42s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
57s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
26s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 15s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
6s{color} | {color:red} hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api in
trunk has 1 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
5s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m
41s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 58s{color} | {color:orange} hadoop-yarn-project/hadoop-yarn: The patch
generated 17 new + 3 unchanged - 0 fixed = 20 total (was 3) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
22s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 16 line(s) that end in whitespace. Use
git apply --whitespace=fix <>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 41s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
39s{color} | {color:green} hadoop-yarn-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
8s{color} | {color:green} hadoop-yarn-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
25s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 70m 23s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 |
| JIRA Issue | YARN-7932 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12911375/YARN-7932.001.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux f16a6c993c42 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20
11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 004b722 |
| maven | version: Apache Maven
[jira] [Commented] (YARN-7932) [atsv2 read acls] Add TimelineDomain to entity
[ https://issues.apache.org/jira/browse/YARN-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371299#comment-16371299 ] Rohith Sharma K S commented on YARN-7932: - Updated the patch to incorporate TimelineDomain into TimelineEntity. And also added new API i.e putDomain(TimelineDomain domain) to publish domain information. This is a blocking call. cc:/ [~vrushalic] > [atsv2 read acls] Add TimelineDomain to entity > -- > > Key: YARN-7932 > URL: https://issues.apache.org/jira/browse/YARN-7932 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Vrushali C >Assignee: Rohith Sharma K S >Priority: Major > Attachments: YARN-7932.001.patch > > > > Need to have a TimelineDomain class in atsv2 that can contain the acls info > for entities. TimelineEntity will contain TimelineDomain as a member -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
