[jira] [Commented] (YARN-8084) Yarn native service classes renaming for easier development?
[ https://issues.apache.org/jira/browse/YARN-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419903#comment-16419903 ] Gour Saha commented on YARN-8084: - [~eyang], I agree with you. I would also prefer if existing classes in api.records remain as is, primarily because it is end-user/consumer friendly. By consumers, I primarily refer to the REST API or programmatic client-side API users who would use the swagger definition to generate client-side stubs in a language of their choice. The duplication of class name is definitely inconvenient for developers, but I prefer developers taking the hit rather than consumers. Nevertheless, if we rename the non-(api.records) classes we will solve the dev issue as well. > Yarn native service classes renaming for easier development? > - > > Key: YARN-8084 > URL: https://issues.apache.org/jira/browse/YARN-8084 > Project: Hadoop YARN > Issue Type: Task >Reporter: Wangda Tan >Priority: Major > > There're a couple of classes with same name exists in YARN native service. > Such as: > 1) ...service.component.Component and api.records.Component. > This makes harder when development in IDE since clash of class name forces to > use full qualified class name. > Similarly in API definition: > ...service.api.records: > Container/ContainerState/Resource/ResourceInformation. How about rename them > to: > ServiceContainer/ServiceContainerState/ServiceResource/ServiceResourceInformation? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-8084) Yarn native service classes renaming for easier development?
[ https://issues.apache.org/jira/browse/YARN-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418268#comment-16418268 ] Eric Yang commented on YARN-8084: - [~leftnoteasy], I agree with Gour Saha that service.component.Component can be renamed to ComponentManager for clarity. I am unsure about prefix Service in service.api.records. The existing form is easier to read in my opinion. This is the same as List class can come from many packages, and user can hover over to see their origin in IDE. > Yarn native service classes renaming for easier development? > - > > Key: YARN-8084 > URL: https://issues.apache.org/jira/browse/YARN-8084 > Project: Hadoop YARN > Issue Type: Task >Reporter: Wangda Tan >Priority: Major > > There're a couple of classes with same name exists in YARN native service. > Such as: > 1) ...service.component.Component and api.records.Component. > This makes harder when development in IDE since clash of class name forces to > use full qualified class name. > Similarly in API definition: > ...service.api.records: > Container/ContainerState/Resource/ResourceInformation. How about rename them > to: > ServiceContainer/ServiceContainerState/ServiceResource/ServiceResourceInformation? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-8084) Yarn native service classes renaming for easier development?
[ https://issues.apache.org/jira/browse/YARN-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418156#comment-16418156 ] Wangda Tan commented on YARN-8084: -- Thanks [~gsaha] for the input, let me think more about this, will post proposal once I get a clear idea. This is not a blocker anyway. > Yarn native service classes renaming for easier development? > - > > Key: YARN-8084 > URL: https://issues.apache.org/jira/browse/YARN-8084 > Project: Hadoop YARN > Issue Type: Task >Reporter: Wangda Tan >Priority: Major > > There're a couple of classes with same name exists in YARN native service. > Such as: > 1) ...service.component.Component and api.records.Component. > This makes harder when development in IDE since clash of class name forces to > use full qualified class name. > Similarly in API definition: > ...service.api.records: > Container/ContainerState/Resource/ResourceInformation. How about rename them > to: > ServiceContainer/ServiceContainerState/ServiceResource/ServiceResourceInformation? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-8084) Yarn native service classes renaming for easier development?
[ https://issues.apache.org/jira/browse/YARN-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418113#comment-16418113 ] Gour Saha commented on YARN-8084: - [~leftnoteasy] are you referring to changing api.records.Component to ServiceComponent or service.component.Component? I am fine with prefixing the classes (with name collision) under api.records with "Service". If we stick to this style then renaming service.component.Component is not required since there won't be name collision anymore. > Yarn native service classes renaming for easier development? > - > > Key: YARN-8084 > URL: https://issues.apache.org/jira/browse/YARN-8084 > Project: Hadoop YARN > Issue Type: Task >Reporter: Wangda Tan >Priority: Major > > There're a couple of classes with same name exists in YARN native service. > Such as: > 1) ...service.component.Component and api.records.Component. > This makes harder when development in IDE since clash of class name forces to > use full qualified class name. > Similarly in API definition: > ...service.api.records: > Container/ContainerState/Resource/ResourceInformation. How about rename them > to: > ServiceContainer/ServiceContainerState/ServiceResource/ServiceResourceInformation? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-8084) Yarn native service classes renaming for easier development?
[ https://issues.apache.org/jira/browse/YARN-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418059#comment-16418059 ] Wangda Tan commented on YARN-8084: -- [~gsaha], ComponentManager sounds like a manager of a bunch of components, if you don't like "ServiceComponent", how about call it "RuntimeComponent"? > Yarn native service classes renaming for easier development? > - > > Key: YARN-8084 > URL: https://issues.apache.org/jira/browse/YARN-8084 > Project: Hadoop YARN > Issue Type: Task >Reporter: Wangda Tan >Priority: Major > > There're a couple of classes with same name exists in YARN native service. > Such as: > 1) ...service.component.Component and api.records.Component. > This makes harder when development in IDE since clash of class name forces to > use full qualified class name. > Similarly in API definition: > ...service.api.records: > Container/ContainerState/Resource/ResourceInformation. How about rename them > to: > ServiceContainer/ServiceContainerState/ServiceResource/ServiceResourceInformation? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-8084) Yarn native service classes renaming for easier development?
[ https://issues.apache.org/jira/browse/YARN-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417965#comment-16417965 ] Gour Saha commented on YARN-8084: - For the service.component.Component I suggest to rename it to ComponentManager (similar to ServiceManager). > Yarn native service classes renaming for easier development? > - > > Key: YARN-8084 > URL: https://issues.apache.org/jira/browse/YARN-8084 > Project: Hadoop YARN > Issue Type: Task >Reporter: Wangda Tan >Priority: Major > > There're a couple of classes with same name exists in YARN native service. > Such as: > 1) ...service.component.Component and api.records.Component. > This makes harder when development in IDE since clash of class name forces to > use full qualified class name. > Similarly in API definition: > ...service.api.records: > Container/ContainerState/Resource/ResourceInformation. How about rename them > to: > ServiceContainer/ServiceContainerState/ServiceResource/ServiceResourceInformation? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
