[jira] [Commented] (YARN-8235) "RM Home" link in AM may point to an inactive RM in an HA setup

2018-04-28 Thread tartarus (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-8235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457636#comment-16457636
 ] 

tartarus commented on YARN-8235:


+1,LGTM

> "RM Home" link in AM may point to an inactive RM in an HA setup
> ---
>
> Key: YARN-8235
> URL: https://issues.apache.org/jira/browse/YARN-8235
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: resourcemanager, webapp
>Affects Versions: 2.7.1
>Reporter: Jianchao Jia
>Priority: Major
> Attachments: YARN-8235.001.patch, YARN-8235.002.patch
>
>
> YARN-2713 has fixed one issue about the wrong RM_HOME,but I think it is not 
> incomplete.
> If the first rm in RM_HA_IDS is inactive ,the RM_HOME  points to the wrong 
> URL.
> Instead ,point to the active rm will be better.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-8235) "RM Home" link in AM may point to an inactive RM in an HA setup

2018-04-28 Thread genericqa (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-8235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457574#comment-16457574
 ] 

genericqa commented on YARN-8235:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 16m 
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 23m 
 6s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
36s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
38s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
10m 23s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m  
5s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
34s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}  
9m 52s{color} | {color:green} patch has no errors when building and testing our 
client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  3m 11s{color} 
| {color:red} hadoop-yarn-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
22s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 70m 22s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.yarn.webapp.util.TestWebAppUtils |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | YARN-8235 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12921141/YARN-8235.002.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux c728ae245eb2 4.4.0-89-generic #112-Ubuntu SMP Mon Jul 31 
19:38:41 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 2c95eb8 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC1 |
| unit | 
https://builds.apache.org/job/PreCommit-YARN-Build/20525/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/20525/testReport/ |
| Max. process+thread count | 407 (vs. ulimit of 1) |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: 

[jira] [Commented] (YARN-8235) "RM Home" link in AM may point to an inactive RM in an HA setup

2018-04-28 Thread liuhongtong (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-8235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457524#comment-16457524
 ] 

liuhongtong commented on YARN-8235:
---

Reasonable. Good catch.

> "RM Home" link in AM may point to an inactive RM in an HA setup
> ---
>
> Key: YARN-8235
> URL: https://issues.apache.org/jira/browse/YARN-8235
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: resourcemanager, webapp
>Affects Versions: 2.7.1
>Reporter: Jianchao Jia
>Priority: Major
> Attachments: YARN-8235.001.patch
>
>
> YARN-2713 has fixed one issue about the wrong RM_HOME,but I think it is not 
> incomplete.
> If the first rm in RM_HA_IDS is inactive ,the RM_HOME  points to the wrong 
> URL.
> Instead ,point to the active rm will be better.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-8235) "RM Home" link in AM may point to an inactive RM in an HA setup

2018-04-28 Thread genericqa (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-8235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457521#comment-16457521
 ] 

genericqa commented on YARN-8235:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  6s{color} 
| {color:red} YARN-8235 does not apply to trunk. Rebase required? Wrong Branch? 
See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | YARN-8235 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12921137/YARN-8235.001.patch |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/20521/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> "RM Home" link in AM may point to an inactive RM in an HA setup
> ---
>
> Key: YARN-8235
> URL: https://issues.apache.org/jira/browse/YARN-8235
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: resourcemanager, webapp
>Affects Versions: 2.7.1
>Reporter: Jianchao Jia
>Priority: Major
> Attachments: YARN-8235.001.patch
>
>
> YARN-2713 has fixed one issue about the wrong RM_HOME,but I think it is not 
> incomplete.
> If the first rm in RM_HA_IDS is inactive ,the RM_HOME  points to the wrong 
> URL.
> Instead ,point to the active rm will be better.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org