[jira] [Commented] (YARN-8475) Should check the resource of assignment is greater than Resources.none() before submitResourceCommitRequest
[
https://issues.apache.org/jira/browse/YARN-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632176#comment-16632176
]
Zoltan Siegl commented on YARN-8475:
I am not really sure about the context either, however about the code:
Couldn't we avoid having two early returns so close to each other in a simple
method like this?
About the tests:
{quote}{{289 //This assignment of a none resource should not fail}}
{{290 TestUtils.applyResourceCommitRequest(null,}}
{{291 new CSAssignment(Resources.none(), null), null, null);}}
{quote}
This assignment does not test the early return, as it is not less then None.
Additionally it would not even fail without the patch. Therefore it seems that
effectively we are not really testing anything here...
> Should check the resource of assignment is greater than Resources.none()
> before submitResourceCommitRequest
> ---
>
> Key: YARN-8475
> URL: https://issues.apache.org/jira/browse/YARN-8475
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
>Reporter: JackZhou
>Assignee: Tanuj Nayak
>Priority: Blocker
> Attachments: YARN-8475.v1.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-8475) Should check the resource of assignment is greater than Resources.none() before submitResourceCommitRequest
[
https://issues.apache.org/jira/browse/YARN-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568842#comment-16568842
]
genericqa commented on YARN-8475:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
32s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 26m
36s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
46s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 8s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
11s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 17s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 71m 43s{color}
| {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
32s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}131m 21s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart |
| | hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue |
| |
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation |
| |
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerResizing |
| |
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation
|
| |
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestQueueManagementDynamicEditPolicy
|
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:ba1ab08 |
| JIRA Issue | YARN-8475 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12934309/YARN-8475.v1.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux ae249fb97062 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 2b18bb4 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC1 |
| unit |
[jira] [Commented] (YARN-8475) Should check the resource of assignment is greater than Resources.none() before submitResourceCommitRequest
[ https://issues.apache.org/jira/browse/YARN-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568712#comment-16568712 ] Wangda Tan commented on YARN-8475: -- [~zhouyunfan], could u add more details to the bug? In what scenario we could have <0 CSAssignment? > Should check the resource of assignment is greater than Resources.none() > before submitResourceCommitRequest > --- > > Key: YARN-8475 > URL: https://issues.apache.org/jira/browse/YARN-8475 > Project: Hadoop YARN > Issue Type: Bug > Components: scheduler >Reporter: JackZhou >Assignee: Tanuj Nayak >Priority: Blocker > Attachments: YARN-8475.v1.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
