[jira] [Commented] (YARN-8484) Fix NPE during ServiceStop in Router classes

2018-07-09 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/YARN-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537803#comment-16537803
 ] 

Íñigo Goiri commented on YARN-8484:
---

{quote}
At the end of one of the tests, I saw a bunch of NPE when the test kills the 
Router process. With YARN-8484.v1.patch I don't see them anymore and the Router 
dies gratefully.

It is just to make clean the logging for the tests' execution.

I am not sure if I can add a test for this fix.
{quote}

This means you were able to repro this and trigger the NPE.
You just need to add a check for that.
Probably you will need to simplify the test.

> Fix NPE during ServiceStop in Router classes
> 
>
> Key: YARN-8484
> URL: https://issues.apache.org/jira/browse/YARN-8484
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 2.9.0
>Reporter: Giovanni Matteo Fumarola
>Assignee: Giovanni Matteo Fumarola
>Priority: Minor
> Attachments: YARN-8484.v1.patch
>
>
> Fix NPE during ServiceStop in Router classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8484) Fix NPE during ServiceStop in Router classes

2018-07-09 Thread Subru Krishnan (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537794#comment-16537794
 ] 

Subru Krishnan commented on YARN-8484:
--

Thanks [~giovanni.fumarola] for the clarification, +1 from my side.

> Fix NPE during ServiceStop in Router classes
> 
>
> Key: YARN-8484
> URL: https://issues.apache.org/jira/browse/YARN-8484
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 2.9.0
>Reporter: Giovanni Matteo Fumarola
>Assignee: Giovanni Matteo Fumarola
>Priority: Minor
> Attachments: YARN-8484.v1.patch
>
>
> Fix NPE during ServiceStop in Router classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8484) Fix NPE during ServiceStop in Router classes

2018-07-09 Thread Giovanni Matteo Fumarola (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537561#comment-16537561
 ] 

Giovanni Matteo Fumarola commented on YARN-8484:


Thanks [~subru] . I found this bug while I was coding YARN-7898's tests.

I am not sure if I can add a test for this fix.

 

> Fix NPE during ServiceStop in Router classes
> 
>
> Key: YARN-8484
> URL: https://issues.apache.org/jira/browse/YARN-8484
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 2.9.0
>Reporter: Giovanni Matteo Fumarola
>Assignee: Giovanni Matteo Fumarola
>Priority: Minor
> Attachments: YARN-8484.v1.patch
>
>
> Fix NPE during ServiceStop in Router classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8484) Fix NPE during ServiceStop in Router classes

2018-07-09 Thread Subru Krishnan (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537385#comment-16537385
 ] 

Subru Krishnan commented on YARN-8484:
--

Thanks [~giovanni.fumarola] for the quick fix. How did you validate it? Can you 
add a test?

> Fix NPE during ServiceStop in Router classes
> 
>
> Key: YARN-8484
> URL: https://issues.apache.org/jira/browse/YARN-8484
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 2.9.0
>Reporter: Giovanni Matteo Fumarola
>Assignee: Giovanni Matteo Fumarola
>Priority: Minor
> Attachments: YARN-8484.v1.patch
>
>
> Fix NPE during ServiceStop in Router classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8484) Fix NPE during ServiceStop in Router classes

2018-06-29 Thread genericqa (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16528486#comment-16528486
 ] 

genericqa commented on YARN-8484:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 23m 
37s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
10s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
24s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
10m  0s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
15s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
10m 38s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 
16s{color} | {color:green} hadoop-yarn-server-router in the patch passed. 
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
19s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 50m 12s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | YARN-8484 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12929797/YARN-8484.v1.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux 59f1a1536407 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 
11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / cdb0844 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC1 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/21155/testReport/ |
| Max. process+thread count | 790 (vs. ulimit of 1) |
| modules | C: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/21155/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |