[jira] [Commented] (YARN-8812) Containers fail during creating a symlink which started with hyphen for a resource file
[
https://issues.apache.org/jira/browse/YARN-8812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701959#comment-16701959
]
Jason Lowe commented on YARN-8812:
--
Thanks for the patch! +1 lgtm. Committing this.
> Containers fail during creating a symlink which started with hyphen for a
> resource file
> ---
>
> Key: YARN-8812
> URL: https://issues.apache.org/jira/browse/YARN-8812
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Oleksandr Shevchenko
>Assignee: Oleksandr Shevchenko
>Priority: Minor
> Attachments: YARN-8812.001.patch
>
>
> When we run some job and add a file with alias started with hyphen then a
> container fails during creating a symlink for a resource file:
> {noformat}
> yarn jar hadoop-mapreduce-examples.jar pi -files testfile#-symlink 1 1
> {noformat}
> or add a file to distributed cache in MR job by "job.addCacheFile"
> Containers fail if resource file has a symlink started with hyphen with the
> following error:
> {noformat}
> Stack trace: ExitCodeException exitCode=1:
> /tmp/hadoop-yarn/nm-local-dir/usercache/yarn/appcache/application_1537449069809_0022/container_e01_1537449069809_0022_02_01/launch_container.sh
> ln: invalid option -- 'y'
> Try 'ln --help' for more information.
> at org.apache.hadoop.util.Shell.runCommand(Shell.java:572)
> at org.apache.hadoop.util.Shell.run(Shell.java:466)
> at org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:768)
> at
> org.apache.hadoop.yarn.server.nodemanager.LinuxContainerExecutor.launchContainer(LinuxContainerExecutor.java:306)
> {noformat}
> The main cause of the problem is "launch_container.sh" script whitch contain
> the following command for creating a symlink:
> {noformat}
> ln -sf "/tmp/hadoop-yarn/nm-local-dir/usercache/yarn/filecache/49/testfile"
> "-symlink"
> {noformat}
> As the result "-symlink" parse as "-s" flag but not as a symlink name.
> The same job successfully passed when running on MRv1 but not on YARN since
> symlinks create in different ways. Unix systems support names which start
> with the hyphen.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-8812) Containers fail during creating a symlink which started with hyphen for a resource file
[
https://issues.apache.org/jira/browse/YARN-8812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701988#comment-16701988
]
Hudson commented on YARN-8812:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15516 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/15516/])
YARN-8812. Containers fail during creating a symlink which started with (jlowe:
rev 3ce99e32f7d7887412cae8337cd4ebeb3b2ee308)
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/TestContainerLaunch.java
> Containers fail during creating a symlink which started with hyphen for a
> resource file
> ---
>
> Key: YARN-8812
> URL: https://issues.apache.org/jira/browse/YARN-8812
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Oleksandr Shevchenko
>Assignee: Oleksandr Shevchenko
>Priority: Minor
> Fix For: 3.0.4, 3.1.2, 3.3.0, 3.2.1
>
> Attachments: YARN-8812.001.patch
>
>
> When we run some job and add a file with alias started with hyphen then a
> container fails during creating a symlink for a resource file:
> {noformat}
> yarn jar hadoop-mapreduce-examples.jar pi -files testfile#-symlink 1 1
> {noformat}
> or add a file to distributed cache in MR job by "job.addCacheFile"
> Containers fail if resource file has a symlink started with hyphen with the
> following error:
> {noformat}
> Stack trace: ExitCodeException exitCode=1:
> /tmp/hadoop-yarn/nm-local-dir/usercache/yarn/appcache/application_1537449069809_0022/container_e01_1537449069809_0022_02_01/launch_container.sh
> ln: invalid option -- 'y'
> Try 'ln --help' for more information.
> at org.apache.hadoop.util.Shell.runCommand(Shell.java:572)
> at org.apache.hadoop.util.Shell.run(Shell.java:466)
> at org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:768)
> at
> org.apache.hadoop.yarn.server.nodemanager.LinuxContainerExecutor.launchContainer(LinuxContainerExecutor.java:306)
> {noformat}
> The main cause of the problem is "launch_container.sh" script whitch contain
> the following command for creating a symlink:
> {noformat}
> ln -sf "/tmp/hadoop-yarn/nm-local-dir/usercache/yarn/filecache/49/testfile"
> "-symlink"
> {noformat}
> As the result "-symlink" parse as "-s" flag but not as a symlink name.
> The same job successfully passed when running on MRv1 but not on YARN since
> symlinks create in different ways. Unix systems support names which start
> with the hyphen.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-8812) Containers fail during creating a symlink which started with hyphen for a resource file
[
https://issues.apache.org/jira/browse/YARN-8812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701978#comment-16701978
]
Oleksandr Shevchenko commented on YARN-8812:
Thank you [~jlowe] for the review and committing the path!
Appreciate your help!
> Containers fail during creating a symlink which started with hyphen for a
> resource file
> ---
>
> Key: YARN-8812
> URL: https://issues.apache.org/jira/browse/YARN-8812
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Oleksandr Shevchenko
>Assignee: Oleksandr Shevchenko
>Priority: Minor
> Fix For: 3.0.4, 3.1.2, 3.3.0, 3.2.1
>
> Attachments: YARN-8812.001.patch
>
>
> When we run some job and add a file with alias started with hyphen then a
> container fails during creating a symlink for a resource file:
> {noformat}
> yarn jar hadoop-mapreduce-examples.jar pi -files testfile#-symlink 1 1
> {noformat}
> or add a file to distributed cache in MR job by "job.addCacheFile"
> Containers fail if resource file has a symlink started with hyphen with the
> following error:
> {noformat}
> Stack trace: ExitCodeException exitCode=1:
> /tmp/hadoop-yarn/nm-local-dir/usercache/yarn/appcache/application_1537449069809_0022/container_e01_1537449069809_0022_02_01/launch_container.sh
> ln: invalid option -- 'y'
> Try 'ln --help' for more information.
> at org.apache.hadoop.util.Shell.runCommand(Shell.java:572)
> at org.apache.hadoop.util.Shell.run(Shell.java:466)
> at org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:768)
> at
> org.apache.hadoop.yarn.server.nodemanager.LinuxContainerExecutor.launchContainer(LinuxContainerExecutor.java:306)
> {noformat}
> The main cause of the problem is "launch_container.sh" script whitch contain
> the following command for creating a symlink:
> {noformat}
> ln -sf "/tmp/hadoop-yarn/nm-local-dir/usercache/yarn/filecache/49/testfile"
> "-symlink"
> {noformat}
> As the result "-symlink" parse as "-s" flag but not as a symlink name.
> The same job successfully passed when running on MRv1 but not on YARN since
> symlinks create in different ways. Unix systems support names which start
> with the hyphen.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-8812) Containers fail during creating a symlink which started with hyphen for a resource file
[
https://issues.apache.org/jira/browse/YARN-8812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691904#comment-16691904
]
Oleksandr Shevchenko commented on YARN-8812:
Could someone kindly review the patch?
Thanks!
> Containers fail during creating a symlink which started with hyphen for a
> resource file
> ---
>
> Key: YARN-8812
> URL: https://issues.apache.org/jira/browse/YARN-8812
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Oleksandr Shevchenko
>Assignee: Oleksandr Shevchenko
>Priority: Minor
> Attachments: YARN-8812.001.patch
>
>
> When we run some job and add a file with alias started with hyphen then a
> container fails during creating a symlink for a resource file:
> {noformat}
> yarn jar hadoop-mapreduce-examples.jar pi -files testfile#-symlink 1 1
> {noformat}
> or add a file to distributed cache in MR job by "job.addCacheFile"
> Containers fail if resource file has a symlink started with hyphen with the
> following error:
> {noformat}
> Stack trace: ExitCodeException exitCode=1:
> /tmp/hadoop-yarn/nm-local-dir/usercache/yarn/appcache/application_1537449069809_0022/container_e01_1537449069809_0022_02_01/launch_container.sh
> ln: invalid option -- 'y'
> Try 'ln --help' for more information.
> at org.apache.hadoop.util.Shell.runCommand(Shell.java:572)
> at org.apache.hadoop.util.Shell.run(Shell.java:466)
> at org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:768)
> at
> org.apache.hadoop.yarn.server.nodemanager.LinuxContainerExecutor.launchContainer(LinuxContainerExecutor.java:306)
> {noformat}
> The main cause of the problem is "launch_container.sh" script whitch contain
> the following command for creating a symlink:
> {noformat}
> ln -sf "/tmp/hadoop-yarn/nm-local-dir/usercache/yarn/filecache/49/testfile"
> "-symlink"
> {noformat}
> As the result "-symlink" parse as "-s" flag but not as a symlink name.
> The same job successfully passed when running on MRv1 but not on YARN since
> symlinks create in different ways. Unix systems support names which start
> with the hyphen.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-8812) Containers fail during creating a symlink which started with hyphen for a resource file
[
https://issues.apache.org/jira/browse/YARN-8812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623439#comment-16623439
]
Oleksandr Shevchenko commented on YARN-8812:
Test Proxy#testNMProxyRPCRetry failed by a different cause. This test failed in
trunk without the patch.
> Containers fail during creating a symlink which started with hyphen for a
> resource file
> ---
>
> Key: YARN-8812
> URL: https://issues.apache.org/jira/browse/YARN-8812
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Oleksandr Shevchenko
>Assignee: Oleksandr Shevchenko
>Priority: Minor
> Attachments: YARN-8812.001.patch
>
>
> When we run some job and add a file with alias started with hyphen then a
> container fails during creating a symlink for a resource file:
> {noformat}
> yarn jar hadoop-mapreduce-examples.jar pi -files testfile#-symlink 1 1
> {noformat}
> or add a file to distributed cache in MR job by "job.addCacheFile"
> Containers fail if resource file has a symlink started with hyphen with the
> following error:
> {noformat}
> Stack trace: ExitCodeException exitCode=1:
> /tmp/hadoop-yarn/nm-local-dir/usercache/yarn/appcache/application_1537449069809_0022/container_e01_1537449069809_0022_02_01/launch_container.sh
> ln: invalid option -- 'y'
> Try 'ln --help' for more information.
> at org.apache.hadoop.util.Shell.runCommand(Shell.java:572)
> at org.apache.hadoop.util.Shell.run(Shell.java:466)
> at org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:768)
> at
> org.apache.hadoop.yarn.server.nodemanager.LinuxContainerExecutor.launchContainer(LinuxContainerExecutor.java:306)
> {noformat}
> The main cause of the problem is "launch_container.sh" script whitch contain
> the following command for creating a symlink:
> {noformat}
> ln -sf "/tmp/hadoop-yarn/nm-local-dir/usercache/yarn/filecache/49/testfile"
> "-symlink"
> {noformat}
> As the result "-symlink" parse as "-s" flag but not as a symlink name.
> The same job successfully passed when running on MRv1 but not on YARN since
> symlinks create in different ways. Unix systems support names which start
> with the hyphen.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-8812) Containers fail during creating a symlink which started with hyphen for a resource file
[
https://issues.apache.org/jira/browse/YARN-8812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623412#comment-16623412
]
Hadoop QA commented on YARN-8812:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m
34s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
38s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 58s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
6s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 29s{color} | {color:orange}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager:
The patch generated 2 new + 143 unchanged - 1 fixed = 145 total (was 144)
{color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 40s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 19m 25s{color}
| {color:red} hadoop-yarn-server-nodemanager in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
30s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 74m 48s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.yarn.server.nodemanager.containermanager.TestNMProxy |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1 |
| JIRA Issue | YARN-8812 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12940754/YARN-8812.001.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 4d4e4f1d146a 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 524f7cd |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
https://builds.apache.org/job/PreCommit-YARN-Build/21925/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
|
| unit |
[jira] [Commented] (YARN-8812) Containers fail during creating a symlink which started with hyphen for a resource file
[
https://issues.apache.org/jira/browse/YARN-8812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623324#comment-16623324
]
Oleksandr Shevchenko commented on YARN-8812:
Changed generating symlink creating command by adding "--" flag to separate
flags of the command and path parameters.
The command looks like now:
{code}
ln -sf -- "/tmp/hadoop-yarn/nm-local-dir/usercache/yarn/filecache/49/testfile"
"-symlink"
{code}
Could someone review the patch?
Thanks!
> Containers fail during creating a symlink which started with hyphen for a
> resource file
> ---
>
> Key: YARN-8812
> URL: https://issues.apache.org/jira/browse/YARN-8812
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Oleksandr Shevchenko
>Assignee: Oleksandr Shevchenko
>Priority: Minor
> Attachments: YARN-8812.001.patch
>
>
> When we run some job and add a file with alias started with hyphen then a
> container fails during creating a symlink for a resource file:
> {noformat}
> yarn jar hadoop-mapreduce-examples.jar pi -files testfile#-symlink 1 1
> {noformat}
> or add a file to distributed cache in MR job by "job.addCacheFile"
> Containers fail if resource file has a symlink started with hyphen with the
> following error:
> {noformat}
> Stack trace: ExitCodeException exitCode=1:
> /tmp/hadoop-yarn/nm-local-dir/usercache/yarn/appcache/application_1537449069809_0022/container_e01_1537449069809_0022_02_01/launch_container.sh
> ln: invalid option -- 'y'
> Try 'ln --help' for more information.
> at org.apache.hadoop.util.Shell.runCommand(Shell.java:572)
> at org.apache.hadoop.util.Shell.run(Shell.java:466)
> at org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:768)
> at
> org.apache.hadoop.yarn.server.nodemanager.LinuxContainerExecutor.launchContainer(LinuxContainerExecutor.java:306)
> {noformat}
> The main cause of the problem is "launch_container.sh" script whitch contain
> the following command for creating a symlink:
> {noformat}
> ln -sf "/tmp/hadoop-yarn/nm-local-dir/usercache/yarn/filecache/49/testfile"
> "-symlink"
> {noformat}
> As the result "-symlink" parse as "-s" flag but not as a symlink name.
> The same job successfully passed when running on MRv1 but not on YARN since
> symlinks create in different ways. Unix systems support names which start
> with the hyphen.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
