[jira] [Commented] (YARN-9054) Fix FederationStateStoreFacade#buildGetSubClustersCacheRequest

2018-11-27 Thread Bibin A Chundatt (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700118#comment-16700118
 ] 

Bibin A Chundatt commented on YARN-9054:


Yes.. we should add to branch-2 as well. 

> Fix FederationStateStoreFacade#buildGetSubClustersCacheRequest
> --
>
> Key: YARN-9054
> URL: https://issues.apache.org/jira/browse/YARN-9054
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: federation
>Reporter: Bibin A Chundatt
>Assignee: Bibin A Chundatt
>Priority: Major
> Fix For: 3.3.0
>
> Attachments: YARN-9054.001.patch, YARN-9054.002.patch
>
>
> Currently cache  key is create with null argument.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-9054) Fix FederationStateStoreFacade#buildGetSubClustersCacheRequest

2018-11-26 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699466#comment-16699466
 ] 

Hudson commented on YARN-9054:
--

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15504 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/15504/])
YARN-9054. Fix (gifuma: rev 0d8406135f8b8ac427fd7f49f5faf20064ace121)
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreTestUtil.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/utils/TestFederationStateStoreFacade.java


> Fix FederationStateStoreFacade#buildGetSubClustersCacheRequest
> --
>
> Key: YARN-9054
> URL: https://issues.apache.org/jira/browse/YARN-9054
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: federation
>Reporter: Bibin A Chundatt
>Assignee: Bibin A Chundatt
>Priority: Major
> Fix For: 3.3.0
>
> Attachments: YARN-9054.001.patch, YARN-9054.002.patch
>
>
> Currently cache  key is create with null argument.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-9054) Fix FederationStateStoreFacade#buildGetSubClustersCacheRequest

2018-11-26 Thread Giovanni Matteo Fumarola (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699437#comment-16699437
 ] 

Giovanni Matteo Fumarola commented on YARN-9054:


Thanks [~bibinchundatt] for fixing it.
+1.

> Fix FederationStateStoreFacade#buildGetSubClustersCacheRequest
> --
>
> Key: YARN-9054
> URL: https://issues.apache.org/jira/browse/YARN-9054
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: federation
>Reporter: Bibin A Chundatt
>Assignee: Bibin A Chundatt
>Priority: Major
> Attachments: YARN-9054.001.patch, YARN-9054.002.patch
>
>
> Currently cache  key is create with null argument.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-9054) Fix FederationStateStoreFacade#buildGetSubClustersCacheRequest

2018-11-26 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699364#comment-16699364
 ] 

Hadoop QA commented on YARN-9054:
-

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 21m 
28s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
50s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
22s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
36s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
15m 24s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
25s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
25s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
20m 22s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
11s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  5m  
4s{color} | {color:green} hadoop-yarn-server-common in the patch passed. 
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  1m 
11s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 81m 16s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | YARN-9054 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12949515/YARN-9054.002.patch |
| Optional Tests |  dupname  asflicense  compile  javac  javadoc  mvninstall  
mvnsite  unit  shadedclient  findbugs  checkstyle  |
| uname | Linux e531524e46a4 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / b098281 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC1 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/22708/testReport/ |
| Max. process+thread count | 328 (vs. ulimit of 1) |
| modules | C: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/22708/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> Fix FederationStateStoreFacade#buildGetSubClustersCacheRequest
>

[jira] [Commented] (YARN-9054) Fix FederationStateStoreFacade#buildGetSubClustersCacheRequest

2018-11-26 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699055#comment-16699055
 ] 

Hadoop QA commented on YARN-9054:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m 
10s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
17s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
31s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 50s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
53s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
25s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 14s{color} | {color:orange} 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: 
The patch generated 1 new + 13 unchanged - 1 fixed = 14 total (was 14) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 40s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
57s{color} | {color:red} 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common 
generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
20s{color} | {color:green} hadoop-yarn-server-common in the patch passed. 
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
24s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 52m 15s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | 
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
 |
|  |  
org.apache.hadoop.yarn.server.federation.utils.FederationStateStoreFacade.buildGetSubClustersCacheRequest(boolean)
 invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead  At 
FederationStateStoreFacade.java:use Boolean.valueOf(...) instead  At 
FederationStateStoreFacade.java:[line 467] |
|  |  Primitive boxed just to call toString in 
org.apache.hadoop.yarn.server.federation.utils.FederationStateStoreFacade.buildGetSubClustersCacheRequest(boolean)
  At FederationStateStoreFacade.java:toString in 
org.apache.hadoop.yarn.server.federation.utils.FederationStateStoreFacade.buildGetSubClustersCacheRequest(boolean)
  At FederationStateStoreFacade.java:[line 468] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | YARN-9054 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12949499/YARN-9054.001.patch |
| Optional

[jira] [Commented] (YARN-9054) Fix FederationStateStoreFacade#buildGetSubClustersCacheRequest

2018-11-26 Thread Bibin A Chundatt (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698968#comment-16698968
 ] 

Bibin A Chundatt commented on YARN-9054:


cc: [~botong]

> Fix FederationStateStoreFacade#buildGetSubClustersCacheRequest
> --
>
> Key: YARN-9054
> URL: https://issues.apache.org/jira/browse/YARN-9054
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: federation
>Reporter: Bibin A Chundatt
>Assignee: Bibin A Chundatt
>Priority: Major
> Attachments: YARN-9054.001.patch
>
>
> Currently cache  key is create with null argument.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org