[jira] [Commented] (YARN-9085) Guaranteed and MaxCapacity CSQueueMetrics
[ https://issues.apache.org/jira/browse/YARN-9085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713165#comment-16713165 ] Zhe Zhang commented on YARN-9085: - +1 (binding) Thanks [~jhung]! Latest patch LGTM; I like the {{updateConfiguredCapacityMetrics}} structure. > Guaranteed and MaxCapacity CSQueueMetrics > - > > Key: YARN-9085 > URL: https://issues.apache.org/jira/browse/YARN-9085 > Project: Hadoop YARN > Issue Type: Improvement >Affects Versions: 2.9.3 >Reporter: Jonathan Hung >Assignee: Jonathan Hung >Priority: Major > Attachments: YARN-9085.001.patch, YARN-9085.002.patch > > > Would be useful to have Absolute Capacity/Absolute Max Capacity for queues to > compare against allocated/pending/etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9085) Guaranteed and MaxCapacity CSQueueMetrics
[ https://issues.apache.org/jira/browse/YARN-9085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713148#comment-16713148 ] Jonathan Hung commented on YARN-9085: - Thx Anthony, currently we can't backport it to branch 2.x because it relies on resource types which is not in branch 2.x yet. > Guaranteed and MaxCapacity CSQueueMetrics > - > > Key: YARN-9085 > URL: https://issues.apache.org/jira/browse/YARN-9085 > Project: Hadoop YARN > Issue Type: Improvement >Affects Versions: 2.9.3 >Reporter: Jonathan Hung >Assignee: Jonathan Hung >Priority: Major > Attachments: YARN-9085.001.patch, YARN-9085.002.patch > > > Would be useful to have Absolute Capacity/Absolute Max Capacity for queues to > compare against allocated/pending/etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9085) Guaranteed and MaxCapacity CSQueueMetrics
[ https://issues.apache.org/jira/browse/YARN-9085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713098#comment-16713098 ] Anthony Hsu commented on YARN-9085: --- Latest patch looks good to me. +1 (non-binding) > Guaranteed and MaxCapacity CSQueueMetrics > - > > Key: YARN-9085 > URL: https://issues.apache.org/jira/browse/YARN-9085 > Project: Hadoop YARN > Issue Type: Improvement >Affects Versions: 2.9.3 >Reporter: Jonathan Hung >Assignee: Jonathan Hung >Priority: Major > Attachments: YARN-9085.001.patch, YARN-9085.002.patch > > > Would be useful to have Absolute Capacity/Absolute Max Capacity for queues to > compare against allocated/pending/etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9085) Guaranteed and MaxCapacity CSQueueMetrics
[ https://issues.apache.org/jira/browse/YARN-9085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713094#comment-16713094 ] Anthony Hsu commented on YARN-9085: --- {quote}GPU metrics should be addressable in YARN-8842 (but this is currently only in 3.3.0) {quote} Can we backport this to branch 2.x? GPU metrics are important for those doing deep learning on GPUs. > Guaranteed and MaxCapacity CSQueueMetrics > - > > Key: YARN-9085 > URL: https://issues.apache.org/jira/browse/YARN-9085 > Project: Hadoop YARN > Issue Type: Improvement >Affects Versions: 2.9.3 >Reporter: Jonathan Hung >Assignee: Jonathan Hung >Priority: Major > Attachments: YARN-9085.001.patch, YARN-9085.002.patch > > > Would be useful to have Absolute Capacity/Absolute Max Capacity for queues to > compare against allocated/pending/etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9085) Guaranteed and MaxCapacity CSQueueMetrics
[ https://issues.apache.org/jira/browse/YARN-9085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712163#comment-16712163 ] Hadoop QA commented on YARN-9085: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m 24s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 46s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 41s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 48s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 13m 27s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 17s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 43s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 38s{color} | {color:orange} hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 29 new + 297 unchanged - 0 fixed = 326 total (was 297) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 45s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 13m 19s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 93m 11s{color} | {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 24s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}149m 24s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f | | JIRA Issue | YARN-9085 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12950894/YARN-9085.002.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 17e5cc7c8ef0 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 8d882c3 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/22793/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt | | whitespace |
[jira] [Commented] (YARN-9085) Guaranteed and MaxCapacity CSQueueMetrics
[ https://issues.apache.org/jira/browse/YARN-9085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712055#comment-16712055 ] Jonathan Hung commented on YARN-9085: - Thanks folks. Upon reviewing your comments I feel this logic is better handled in updateClusterResource (the original patch would update guaranteed/max-capacity every time a container is allocated which is excessive). Uploaded 002 to address this. {{[~zhz], setGuaranteedResources}} takes a partition to match the behavior of other metrics, so once multiple partition metrics is supported this code all be changed at once. [~erwaman], non-default partition metrics should be addressed in YARN-6492 (but not yet committed). GPU metrics should be addressable in YARN-8842 (but this is currently only in 3.3.0) For the other comments, I took this logic out of CSQueueUtils#updateQueueStatistics and put it in ParentQueue/LeafQueue, if we support multi-partition metrics we can update this part to loop through all of that queue's partitions (but for now we can just pass in default partition directly). > Guaranteed and MaxCapacity CSQueueMetrics > - > > Key: YARN-9085 > URL: https://issues.apache.org/jira/browse/YARN-9085 > Project: Hadoop YARN > Issue Type: Improvement >Affects Versions: 2.9.3 >Reporter: Jonathan Hung >Assignee: Jonathan Hung >Priority: Major > Attachments: YARN-9085.001.patch, YARN-9085.002.patch > > > Would be useful to have Absolute Capacity/Absolute Max Capacity for queues to > compare against allocated/pending/etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9085) Guaranteed and MaxCapacity CSQueueMetrics
[ https://issues.apache.org/jira/browse/YARN-9085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711709#comment-16711709 ] Anthony Hsu commented on YARN-9085: --- Looks good overall. A few questions/comments: * In CSQueueMetrics.java, I see the comment {code:java} //Metrics updated only for "default" partition{code} How come metrics are not updated for non-default partitions? Are any metrics available for non-default partitions? * What about GPU metrics? Can CSQueueMetrics collect those, too? * Regarding {noformat} if (nodePartition == null) { for (String partition : Sets.union(queueCapacities.getNodePartitionsSet(), queueResourceUsage.getNodePartitionsSet())) { -updateUsedCapacity(rc, nlm.getResourceByLabel(partition, cluster), -partition, childQueue); +updateUsedCapacity(rc, partitionResource, partition, childQueue); } + updateConfiguredCapacities(rc, partitionResource, childQueue); } else { - updateUsedCapacity(rc, nlm.getResourceByLabel(nodePartition, cluster), - nodePartition, childQueue); + updateUsedCapacity(rc, partitionResource, nodePartition, childQueue); } {noformat} Seems to me the *updateConfiguredCapacities* call you added should be inside the for loop and should also take in a *partition* parameter like the *updateUsedCapacity* call does. In the future, metrics may be collected for non-default partitions as well. Also, I think the *else* block should also have a *updateConfiguredCapacities* call (in case in the future, we collect non-default partition metrics, too. > Guaranteed and MaxCapacity CSQueueMetrics > - > > Key: YARN-9085 > URL: https://issues.apache.org/jira/browse/YARN-9085 > Project: Hadoop YARN > Issue Type: Improvement >Affects Versions: 2.9.3 >Reporter: Jonathan Hung >Assignee: Jonathan Hung >Priority: Major > Attachments: YARN-9085.001.patch > > > Would be useful to have Absolute Capacity/Absolute Max Capacity for queues to > compare against allocated/pending/etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9085) Guaranteed and MaxCapacity CSQueueMetrics
[ https://issues.apache.org/jira/browse/YARN-9085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711044#comment-16711044 ] Zhe Zhang commented on YARN-9085: - Thanks [~jhung]! This is a useful metric. Patch LGTM overall. +1 pending the following couple of nits: # Why does {{setGuaranteedResources}} take a {{partition}} argument if it's always supposed to be null? # Since you are updating configured capacities now, should update the comment as well: {code} * When nodePartition is null, all partition of * used-capacity/absolute-used-capacity will be updated {code} > Guaranteed and MaxCapacity CSQueueMetrics > - > > Key: YARN-9085 > URL: https://issues.apache.org/jira/browse/YARN-9085 > Project: Hadoop YARN > Issue Type: Improvement >Affects Versions: 2.9.3 >Reporter: Jonathan Hung >Assignee: Jonathan Hung >Priority: Major > Attachments: YARN-9085.001.patch > > > Would be useful to have Absolute Capacity/Absolute Max Capacity for queues to > compare against allocated/pending/etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9085) Guaranteed and MaxCapacity CSQueueMetrics
[ https://issues.apache.org/jira/browse/YARN-9085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710980#comment-16710980 ] Keqiu Hu commented on YARN-9085: +1, this makes life easier to collect configured queue information/used queue information together. > Guaranteed and MaxCapacity CSQueueMetrics > - > > Key: YARN-9085 > URL: https://issues.apache.org/jira/browse/YARN-9085 > Project: Hadoop YARN > Issue Type: Improvement >Affects Versions: 2.9.3 >Reporter: Jonathan Hung >Assignee: Jonathan Hung >Priority: Major > Attachments: YARN-9085.001.patch > > > Would be useful to have Absolute Capacity/Absolute Max Capacity for queues to > compare against allocated/pending/etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9085) Guaranteed and MaxCapacity CSQueueMetrics
[ https://issues.apache.org/jira/browse/YARN-9085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710967#comment-16710967 ] Hadoop QA commented on YARN-9085: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 21s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 21m 1s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 42s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 54s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 13m 48s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 21s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 43s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 37s{color} | {color:orange} hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 23 new + 231 unchanged - 0 fixed = 254 total (was 231) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 44s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 13m 23s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 92m 15s{color} | {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 27s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}149m 51s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f | | JIRA Issue | YARN-9085 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12950780/YARN-9085.001.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux fe84d446ca27 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 5d4a432 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/22785/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/22785/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt | | Test Results |
[jira] [Commented] (YARN-9085) Guaranteed and MaxCapacity CSQueueMetrics
[ https://issues.apache.org/jira/browse/YARN-9085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710879#comment-16710879 ] Jonathan Hung commented on YARN-9085: - Attached 001 patch which adds [Guaranteed|MaxCapacity][MB|VCores] to CSQueueMetrics. > Guaranteed and MaxCapacity CSQueueMetrics > - > > Key: YARN-9085 > URL: https://issues.apache.org/jira/browse/YARN-9085 > Project: Hadoop YARN > Issue Type: Improvement >Affects Versions: 2.9.3 >Reporter: Jonathan Hung >Assignee: Jonathan Hung >Priority: Major > Attachments: YARN-9085.001.patch > > > Would be useful to have Absolute Capacity/Absolute Max Capacity for queues to > compare against allocated/pending/etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org