[jira] [Commented] (YARN-9175) Null resources check in ResourceInfo for branch-3.0
[
https://issues.apache.org/jira/browse/YARN-9175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733859#comment-16733859
]
Sunil Govindan commented on YARN-9175:
--
Thanks [~jhung]
> Null resources check in ResourceInfo for branch-3.0
> ---
>
> Key: YARN-9175
> URL: https://issues.apache.org/jira/browse/YARN-9175
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Jonathan Hung
>Assignee: Jonathan Hung
>Priority: Major
> Fix For: 3.0.4
>
> Attachments: YARN-9175-branch-3.0.001.patch
>
>
> Check for null {{resources}} in ResourceInfo class to avoid NPE when
> rendering RM UI.
> This was fixed as part of YARN-7934 which didn't make it to 3.0 and below.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9175) Null resources check in ResourceInfo for branch-3.0
[
https://issues.apache.org/jira/browse/YARN-9175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733505#comment-16733505
]
Zhe Zhang commented on YARN-9175:
-
+1. Thanks [~jhung] for the fix.
> Null resources check in ResourceInfo for branch-3.0
> ---
>
> Key: YARN-9175
> URL: https://issues.apache.org/jira/browse/YARN-9175
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Jonathan Hung
>Assignee: Jonathan Hung
>Priority: Major
> Attachments: YARN-9175-branch-3.0.001.patch
>
>
> Check for null {{resources}} in ResourceInfo class to avoid NPE when
> rendering RM UI.
> This was fixed as part of YARN-7934 which didn't make it to 3.0 and below.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9175) Null resources check in ResourceInfo for branch-3.0
[
https://issues.apache.org/jira/browse/YARN-9175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733455#comment-16733455
]
Jonathan Hung commented on YARN-9175:
-
thx [~oliverhuh...@gmail.com], if you're referring to branch-3.0, there's no
GPU support there, but it will be added as part of YARN-8200
as far as the unit test, seems it's a known issue: YARN-9006
> Null resources check in ResourceInfo for branch-3.0
> ---
>
> Key: YARN-9175
> URL: https://issues.apache.org/jira/browse/YARN-9175
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Jonathan Hung
>Assignee: Jonathan Hung
>Priority: Major
> Attachments: YARN-9175-branch-3.0.001.patch
>
>
> Check for null {{resources}} in ResourceInfo class to avoid NPE when
> rendering RM UI.
> This was fixed as part of YARN-7934 which didn't make it to 3.0 and below.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9175) Null resources check in ResourceInfo for branch-3.0
[
https://issues.apache.org/jira/browse/YARN-9175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733429#comment-16733429
]
Hadoop QA commented on YARN-9175:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 16m
6s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-3.0 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 22m
28s{color} | {color:green} branch-3.0 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} branch-3.0 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} branch-3.0 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
44s{color} | {color:green} branch-3.0 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 22s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
11s{color} | {color:green} branch-3.0 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} branch-3.0 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 27s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 62m 32s{color}
| {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}133m 53s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation
|
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:e402791 |
| JIRA Issue | YARN-9175 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12953660/YARN-9175-branch-3.0.001.patch
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux e0f41ee2c6fb 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct
5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | branch-3.0 / f17ef6f |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| findbugs | v3.1.0-RC1 |
| unit |
https://builds.apache.org/job/PreCommit-YARN-Build/22982/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/22982/testReport/ |
[jira] [Commented] (YARN-9175) Null resources check in ResourceInfo for branch-3.0
[
https://issues.apache.org/jira/browse/YARN-9175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733420#comment-16733420
]
Keqiu Hu commented on YARN-9175:
Beyond the fix, is ResourceInfo class supposed to include GPU? I code searched
the whole dao/ folder and there is 0 mention of GPU.
> Null resources check in ResourceInfo for branch-3.0
> ---
>
> Key: YARN-9175
> URL: https://issues.apache.org/jira/browse/YARN-9175
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Jonathan Hung
>Assignee: Jonathan Hung
>Priority: Major
> Attachments: YARN-9175-branch-3.0.001.patch
>
>
> Check for null {{resources}} in ResourceInfo class to avoid NPE when
> rendering RM UI.
> This was fixed as part of YARN-7934 which didn't make it to 3.0 and below.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-9175) Null resources check in ResourceInfo for branch-3.0
[
https://issues.apache.org/jira/browse/YARN-9175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733414#comment-16733414
]
Keqiu Hu commented on YARN-9175:
+1 thanks for fixing this.
> Null resources check in ResourceInfo for branch-3.0
> ---
>
> Key: YARN-9175
> URL: https://issues.apache.org/jira/browse/YARN-9175
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Jonathan Hung
>Assignee: Jonathan Hung
>Priority: Major
> Attachments: YARN-9175-branch-3.0.001.patch
>
>
> Check for null {{resources}} in ResourceInfo class to avoid NPE when
> rendering RM UI.
> This was fixed as part of YARN-7934 which didn't make it to 3.0 and below.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
